From 00d600138536a4978f40b25233c2f37c0fc426d4 Mon Sep 17 00:00:00 2001
From: Wilco Dijkstra <wdijkstr@arm.com>
Date: Thu, 18 May 2017 15:58:33 +0000
Subject: [PATCH] Add an assert to leaf_function_p to ensure it is not called
from a prolog or...
Add an assert to leaf_function_p to ensure it is not called from a
prolog or epilog sequence (which would incorrectly return true in a
non-leaf function). There are several targets which still call
leaf_function_p, and while most appear safe or appear aware of the
issue, it is likely not all such calls are safe. This check enables
any such latent bugs to be found.
gcc/
* final.c (leaf_function_p): Check we are not in a sequence.
From-SVN: r248240
---
gcc/ChangeLog | 4 ++++
gcc/final.c | 3 +++
2 files changed, 7 insertions(+)
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index f2762580970f..a9a861eb5e8c 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,7 @@
+2017-05-18 Wilco Dijkstra <wdijkstr@arm.com>
+
+ * final.c (leaf_function_p): Check we are not in a sequence.
+
2017-05-18 Martin Liska <mliska@suse.cz>
* cfgrtl.c (rtl_verify_edges): Remove usage of TDF_RTL.
diff --git a/gcc/final.c b/gcc/final.c
index 820162b2d28d..e61b78b0a915 100644
--- a/gcc/final.c
+++ b/gcc/final.c
@@ -4309,6 +4309,9 @@ leaf_function_p (void)
{
rtx_insn *insn;
+ /* Ensure we walk the entire function body. */
+ gcc_assert (!in_sequence_p ());
+
/* Some back-ends (e.g. s390) want leaf functions to stay leaf
functions even if they call mcount. */
if (crtl->profile && !targetm.keep_leaf_when_profiled ())
--
GitLab