diff --git a/gcc/analyzer/region-model.cc b/gcc/analyzer/region-model.cc index f844b519f6131e28fea2ea21bf2f8409bf40f9e5..2187aecbe9127fc6d29dab78f91ffb8a16b573e7 100644 --- a/gcc/analyzer/region-model.cc +++ b/gcc/analyzer/region-model.cc @@ -1477,8 +1477,6 @@ region_model::on_call_pre (const gcall *call, region_model_context *ctxt) { call_details cd (call, this, ctxt); - bool unknown_side_effects = false; - /* Special-case for IFN_DEFERRED_INIT. We want to report uninitialized variables with -fanalyzer (treating -ftrivial-auto-var-init= as purely a mitigation feature). @@ -1487,7 +1485,7 @@ region_model::on_call_pre (const gcall *call, region_model_context *ctxt) view of the analyzer. */ if (gimple_call_internal_p (call) && gimple_call_internal_fn (call) == IFN_DEFERRED_INIT) - return false; + return false; /* No side effects. */ /* Get svalues for all of the arguments at the callsite, to ensure that we complain about any uninitialized arguments. This might lead to @@ -1532,33 +1530,29 @@ region_model::on_call_pre (const gcall *call, region_model_context *ctxt) = get_known_function (gimple_call_internal_fn (call))) { kf->impl_call_pre (cd); - return false; + return false; /* No further side effects. */ } - if (callee_fndecl) - { - int callee_fndecl_flags = flags_from_decl_or_type (callee_fndecl); + if (!callee_fndecl) + return true; /* Unknown side effects. */ - if (const known_function *kf = get_known_function (callee_fndecl, cd)) - { - kf->impl_call_pre (cd); - return false; - } - else if (fndecl_built_in_p (callee_fndecl, BUILT_IN_NORMAL) - && gimple_builtin_call_types_compatible_p (call, callee_fndecl)) - { - if (!(callee_fndecl_flags & (ECF_CONST | ECF_PURE))) - unknown_side_effects = true; - } - else if (!fndecl_has_gimple_body_p (callee_fndecl) - && (!(callee_fndecl_flags & (ECF_CONST | ECF_PURE))) - && !fndecl_built_in_p (callee_fndecl)) - unknown_side_effects = true; + if (const known_function *kf = get_known_function (callee_fndecl, cd)) + { + kf->impl_call_pre (cd); + return false; /* No further side effects. */ } - else - unknown_side_effects = true; - return unknown_side_effects; + const int callee_fndecl_flags = flags_from_decl_or_type (callee_fndecl); + if (callee_fndecl_flags & (ECF_CONST | ECF_PURE)) + return false; /* No side effects. */ + + if (fndecl_built_in_p (callee_fndecl)) + return true; /* Unknown side effects. */ + + if (!fndecl_has_gimple_body_p (callee_fndecl)) + return true; /* Unknown side effects. */ + + return false; /* No side effects. */ } /* Update this model for the CALL stmt, using CTXT to report any diff --git a/gcc/testsuite/gcc.dg/analyzer/builtins-pr107565.c b/gcc/testsuite/gcc.dg/analyzer/builtins-pr107565.c new file mode 100644 index 0000000000000000000000000000000000000000..fb340aa5981bde2ae7be39c0f96f5fc16a101a87 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/builtins-pr107565.c @@ -0,0 +1,29 @@ +/* { dg-do compile { target { x86_64-*-* && lp64 } } } */ +/* { dg-additional-options "-mrdrnd" } */ + +unsigned short +hardware_rand16 (void) +{ + unsigned short x; + while (! __builtin_ia32_rdrand16_step (&x)) + continue; + return x; /* { dg-bogus "uninit" } */ +} + +unsigned int +hardware_rand32 (void) +{ + unsigned int x; + while (! __builtin_ia32_rdrand32_step (&x)) + continue; + return x; /* { dg-bogus "uninit" } */ +} + +unsigned long long +hardware_rand64 (void) +{ + unsigned long long int x; + while (! __builtin_ia32_rdrand64_step (&x)) + continue; + return x; /* { dg-bogus "uninit" } */ +} diff --git a/gcc/testsuite/gcc.dg/analyzer/pr99716-1.c b/gcc/testsuite/gcc.dg/analyzer/pr99716-1.c index 2ccdcc73a5c29a34977a3cc629596d43b21a24cc..4fae368f3210ee4b0c1bedcd2394c3f939ac6dee 100644 --- a/gcc/testsuite/gcc.dg/analyzer/pr99716-1.c +++ b/gcc/testsuite/gcc.dg/analyzer/pr99716-1.c @@ -27,7 +27,11 @@ test_2 (void) FILE *fp = fopen ("/tmp/test", "w"); fprintf (fp, "hello"); } -} /* { dg-warning "leak of FILE 'fp'" } */ +} /* { dg-warning "leak of FILE 'fp'" "" { xfail *-*-* } } */ +/* TODO: fails on some targets due to fprintf call being optimized to + __builtin_fwrite with a size argument (idx 2) that fails + gimple_builtin_call_types_compatible_p, and thus the known_function + for __builtin_fwrite not being used (PR middle-end/108988). */ FILE *fp3;