diff --git a/gcc/config/xtensa/xtensa-protos.h b/gcc/config/xtensa/xtensa-protos.h index ecd0f0c8d108b5ccd042c40ec919a2fa53b01f42..c81cf94323ac8b27858a4280c9c816b1d60a81e9 100644 --- a/gcc/config/xtensa/xtensa-protos.h +++ b/gcc/config/xtensa/xtensa-protos.h @@ -53,7 +53,7 @@ extern void xtensa_expand_atomic (enum rtx_code, rtx, rtx, rtx, bool); extern void xtensa_emit_loop_end (rtx_insn *, rtx *); extern char *xtensa_emit_branch (bool, rtx *); extern char *xtensa_emit_movcc (bool, bool, bool, rtx *); -extern void xtensa_prepare_expand_call (int, rtx *); +extern void xtensa_expand_call (int, rtx *); extern char *xtensa_emit_call (int, rtx *); extern char *xtensa_emit_sibcall (int, rtx *); extern bool xtensa_tls_referenced_p (rtx); diff --git a/gcc/config/xtensa/xtensa.cc b/gcc/config/xtensa/xtensa.cc index e52fba0825509a606048707c927e52aa812d8c47..5044bc25c2fef46fd4f9b234dc65582aa381ee7c 100644 --- a/gcc/config/xtensa/xtensa.cc +++ b/gcc/config/xtensa/xtensa.cc @@ -2183,8 +2183,10 @@ xtensa_emit_movcc (bool inverted, bool isfp, bool isbool, rtx *operands) void -xtensa_prepare_expand_call (int callop, rtx *operands) +xtensa_expand_call (int callop, rtx *operands) { + rtx call; + rtx_insn *call_insn; rtx addr = XEXP (operands[callop], 0); if (flag_pic && SYMBOL_REF_P (addr) @@ -2202,6 +2204,27 @@ xtensa_prepare_expand_call (int callop, rtx *operands) Pmode); XEXP (operands[callop], 0) = reg; } + + call = gen_rtx_CALL (VOIDmode, operands[callop], operands[callop + 1]); + + if (callop) + call = gen_rtx_SET (operands[0], call); + + call_insn = emit_call_insn (call); + + if (TARGET_WINDOWED_ABI) + { + /* + * Windowed xtensa ABI specifies that static chain pointer is passed + * in memory below the caller's stack pointer, which means that the + * callee may clobber it if it's a non-leaf function. + * Add the clobber expression for the static chain to the function call + * expression list so that it is not assumed to be live across the call. + */ + rtx clob = gen_rtx_CLOBBER (Pmode, xtensa_static_chain (NULL, false)); + CALL_INSN_FUNCTION_USAGE (call_insn) = + gen_rtx_EXPR_LIST (Pmode, clob, CALL_INSN_FUNCTION_USAGE (call_insn)); + } } diff --git a/gcc/config/xtensa/xtensa.md b/gcc/config/xtensa/xtensa.md index cf25beb83d54a9d4c2371c29c5d2154ef3c0946a..b60dec2447f319b6e238dc11d367b680c6619226 100644 --- a/gcc/config/xtensa/xtensa.md +++ b/gcc/config/xtensa/xtensa.md @@ -2333,7 +2333,8 @@ (match_operand 1 "" ""))] "" { - xtensa_prepare_expand_call (0, operands); + xtensa_expand_call (0, operands); + DONE; }) (define_insn "call_internal" @@ -2353,7 +2354,8 @@ (match_operand 2 "" "")))] "" { - xtensa_prepare_expand_call (1, operands); + xtensa_expand_call (1, operands); + DONE; }) (define_insn "call_value_internal" @@ -2373,7 +2375,8 @@ (match_operand 1 "" ""))] "!TARGET_WINDOWED_ABI" { - xtensa_prepare_expand_call (0, operands); + xtensa_expand_call (0, operands); + DONE; }) (define_insn "sibcall_internal" @@ -2393,7 +2396,8 @@ (match_operand 2 "" "")))] "!TARGET_WINDOWED_ABI" { - xtensa_prepare_expand_call (1, operands); + xtensa_expand_call (1, operands); + DONE; }) (define_insn "sibcall_value_internal" diff --git a/gcc/testsuite/gcc.target/xtensa/pr108919.c b/gcc/testsuite/gcc.target/xtensa/pr108919.c new file mode 100644 index 0000000000000000000000000000000000000000..300b6fd10a9923addaccdc4074258274390b4c0a --- /dev/null +++ b/gcc/testsuite/gcc.target/xtensa/pr108919.c @@ -0,0 +1,46 @@ +/* { dg-do run } */ +/* { dg-options "-O2" } */ + + +#ifdef __XTENSA_CALL0_ABI__ +void __xtensa_libgcc_window_spill (void) +{ +} +#else +void __xtensa_libgcc_window_spill (void); +#endif + +__attribute__((noinline)) void h (void) +{ + __xtensa_libgcc_window_spill (); +} + +int f (int u, int v) +{ + int a = u; + int s; + + __attribute__((noinline,pure)) int nested1 (int b) + { + h(); + return a + b; + } + + __attribute__((noinline,pure)) int nested2 (int b) + { + h(); + return a - b; + } + + s = nested1 (v); + s += nested2 (v); + return s; +} + +int main (void) +{ + int u = 0x12345678; + int v = 1; + + return f (u, v) == 2 * u ? 0 : 1; +}