From 49de156a6adb50e0624479f22c20141cadef812d Mon Sep 17 00:00:00 2001
From: Jakub Jelinek <jakub@redhat.com>
Date: Thu, 10 Nov 2022 11:46:52 +0100
Subject: [PATCH] i386: Fix up ix86_expand_int_sse_cmp [PR107585]
The following patch fixes ICE on the testcase. I've used GEN_INT
incorrectly thinking the code punts on the problematic boundaries.
It does, but only for LE and GE, i.e. signed comparisons, for unsigned
the boundaries are 0 and unsigned maximum, so when say unsigned char
adds one to 127 or subtracts one from 128 we need to canonicalize it.
2022-11-10 Jakub Jelinek <jakub@redhat.com>
PR target/107585
PR target/107546
* config/i386/i386-expand.cc (ix86_expand_int_sse_cmp): Use
gen_int_mode rather than GEN_INT.
* gcc.dg/pr107585.c: New test.
---
gcc/config/i386/i386-expand.cc | 6 ++++--
gcc/testsuite/gcc.dg/pr107585.c | 13 +++++++++++++
2 files changed, 17 insertions(+), 2 deletions(-)
create mode 100644 gcc/testsuite/gcc.dg/pr107585.c
diff --git a/gcc/config/i386/i386-expand.cc b/gcc/config/i386/i386-expand.cc
index 9c92b07d5cd8..acf9e00d4906 100644
--- a/gcc/config/i386/i386-expand.cc
+++ b/gcc/config/i386/i386-expand.cc
@@ -4540,7 +4540,8 @@ ix86_expand_int_sse_cmp (rtx dest, enum rtx_code code, rtx cop0, rtx cop1,
rtvec v = rtvec_alloc (n_elts);
for (i = 0; i < n_elts; ++i)
RTVEC_ELT (v, i)
- = GEN_INT (INTVAL (CONST_VECTOR_ELT (cop1, i)) + 1);
+ = gen_int_mode (INTVAL (CONST_VECTOR_ELT (cop1, i)) + 1,
+ eltmode);
cop1 = gen_rtx_CONST_VECTOR (mode, v);
std::swap (cop0, cop1);
code = code == LE ? GT : GTU;
@@ -4584,7 +4585,8 @@ ix86_expand_int_sse_cmp (rtx dest, enum rtx_code code, rtx cop0, rtx cop1,
rtvec v = rtvec_alloc (n_elts);
for (i = 0; i < n_elts; ++i)
RTVEC_ELT (v, i)
- = GEN_INT (INTVAL (CONST_VECTOR_ELT (cop1, i)) - 1);
+ = gen_int_mode (INTVAL (CONST_VECTOR_ELT (cop1, i)) - 1,
+ eltmode);
cop1 = gen_rtx_CONST_VECTOR (mode, v);
code = code == GE ? GT : GTU;
break;
diff --git a/gcc/testsuite/gcc.dg/pr107585.c b/gcc/testsuite/gcc.dg/pr107585.c
new file mode 100644
index 000000000000..820e04b6537c
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr107585.c
@@ -0,0 +1,13 @@
+/* PR target/107585 */
+/* { dg-do compile } */
+/* { dg-options "-O2" } */
+
+typedef unsigned char __attribute__((__vector_size__ (16))) V;
+char c;
+void bar (int);
+
+void
+foo (void)
+{
+ bar (((V) (c <= (V){127}))[2]);
+}
--
GitLab