diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index 2c1ffd21598adf54d63fc3df73b34d6b3dc469cf..dc96107a1f9bd5896305a7bfaae2dfa7895e5201 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,3 +1,16 @@ +2013-02-04 François Dumont <fdumont@gcc.gnu.org> + + * include/bits/functional_hash.h (std::__is_fast_hash<>): New. + * include/bits/basic_string.h: Specialize previous to mark + std::hash for string types as slow. + * include/bits/hashtable.h (__cache_default): Replace is_integral + with __is_fast_hash. + * src/c++11/hash_c++0x.cc: Add type_traits include. + * testsuite/23_containers/unordered_set/instantiation_neg.cc: + Adapt dg-error line number. + * testsuite/23_containers/unordered_set/ + not_default_constructible_hash_neg.cc: Likewise. + 2013-02-04 Manuel López-Ibáñez <manu@gcc.gnu.org> Paolo Carlini <paolo.carlini@oracle.com> diff --git a/libstdc++-v3/include/bits/basic_string.h b/libstdc++-v3/include/bits/basic_string.h index b5d2526c9079464092ab4e6b6b00e585d251b4b6..aa188f53a6891a522fc5597c3319cf37af4a3b25 100644 --- a/libstdc++-v3/include/bits/basic_string.h +++ b/libstdc++-v3/include/bits/basic_string.h @@ -3051,6 +3051,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION { return std::_Hash_impl::hash(__s.data(), __s.length()); } }; + template<> + struct __is_fast_hash<hash<string>> : std::false_type + { }; + #ifdef _GLIBCXX_USE_WCHAR_T /// std::hash specialization for wstring. template<> @@ -3062,6 +3066,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION { return std::_Hash_impl::hash(__s.data(), __s.length() * sizeof(wchar_t)); } }; + + template<> + struct __is_fast_hash<hash<wstring>> : std::false_type + { }; #endif #endif /* _GLIBCXX_COMPATIBILITY_CXX0X */ @@ -3077,6 +3085,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __s.length() * sizeof(char16_t)); } }; + template<> + struct __is_fast_hash<hash<u16string>> : std::false_type + { }; + /// std::hash specialization for u32string. template<> struct hash<u32string> @@ -3087,6 +3099,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION { return std::_Hash_impl::hash(__s.data(), __s.length() * sizeof(char32_t)); } }; + + template<> + struct __is_fast_hash<hash<u32string>> : std::false_type + { }; #endif _GLIBCXX_END_NAMESPACE_VERSION diff --git a/libstdc++-v3/include/bits/functional_hash.h b/libstdc++-v3/include/bits/functional_hash.h index 5a99c5414950d1fade70d80dc12b246d7d7142f0..bc29235cf1411bd89fcf77a65ceb92c197e14197 100644 --- a/libstdc++-v3/include/bits/functional_hash.h +++ b/libstdc++-v3/include/bits/functional_hash.h @@ -194,6 +194,18 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION // @} group hashes + // Hint about performance of hash functor. If not fast the hash based + // containers will cache the hash code. + // Default behavior is to consider that hasher are fast unless specified + // otherwise. + template<typename _Hash> + struct __is_fast_hash : public std::true_type + { }; + + template<> + struct __is_fast_hash<hash<long double>> : public std::false_type + { }; + _GLIBCXX_END_NAMESPACE_VERSION } // namespace diff --git a/libstdc++-v3/include/bits/hashtable.h b/libstdc++-v3/include/bits/hashtable.h index d899fa728ebac1503c7aa5edae19744bbc616552..6515b71eef9f397a48735b7578b0d19c794bbecb 100644 --- a/libstdc++-v3/include/bits/hashtable.h +++ b/libstdc++-v3/include/bits/hashtable.h @@ -40,9 +40,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION template<typename _Tp, typename _Hash> using __cache_default - = __not_<__and_<// Do not cache for builtin integral types having trivial - // hasher. - is_integral<_Tp>, + = __not_<__and_<// Do not cache for fast hasher. + __is_fast_hash<_Hash>, // Mandatory to make local_iterator default // constructible. is_default_constructible<_Hash>, diff --git a/libstdc++-v3/src/c++11/hash_c++0x.cc b/libstdc++-v3/src/c++11/hash_c++0x.cc index 29549ea21735dfdf8a82986d41421ad9430fb02d..fc5295ad2083633091577532949f4cc044035124 100644 --- a/libstdc++-v3/src/c++11/hash_c++0x.cc +++ b/libstdc++-v3/src/c++11/hash_c++0x.cc @@ -26,6 +26,7 @@ # error "hash_c++0x.cc must be compiled with -std=gnu++0x" #endif +#include <type_traits> #include <bits/functional_hash.h> namespace std _GLIBCXX_VISIBILITY(default) diff --git a/libstdc++-v3/testsuite/23_containers/unordered_set/instantiation_neg.cc b/libstdc++-v3/testsuite/23_containers/unordered_set/instantiation_neg.cc index 6712d626231e9664d011b04886708fa51ed1d55a..827691f2ce042704d35c8c211a254dcafbeaeddb 100644 --- a/libstdc++-v3/testsuite/23_containers/unordered_set/instantiation_neg.cc +++ b/libstdc++-v3/testsuite/23_containers/unordered_set/instantiation_neg.cc @@ -19,7 +19,7 @@ // with this library; see the file COPYING3. If not see // <http://www.gnu.org/licenses/>. -// { dg-error "with noexcept" "" { target *-*-* } 252 } +// { dg-error "with noexcept" "" { target *-*-* } 251 } #include <unordered_set> diff --git a/libstdc++-v3/testsuite/23_containers/unordered_set/not_default_constructible_hash_neg.cc b/libstdc++-v3/testsuite/23_containers/unordered_set/not_default_constructible_hash_neg.cc index 53a25bc65b8961dabc224a076aaf84a80d4e55ef..bd62a0808c70dee11c2c02ac5c7b24e39ffd0f22 100644 --- a/libstdc++-v3/testsuite/23_containers/unordered_set/not_default_constructible_hash_neg.cc +++ b/libstdc++-v3/testsuite/23_containers/unordered_set/not_default_constructible_hash_neg.cc @@ -19,7 +19,7 @@ // with this library; see the file COPYING3. If not see // <http://www.gnu.org/licenses/>. -// { dg-error "default constructible" "" { target *-*-* } 268 } +// { dg-error "default constructible" "" { target *-*-* } 267 } #include <unordered_set>