From b713de1ce50e603d1559d1d4838318e245ef6706 Mon Sep 17 00:00:00 2001 From: Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org> Date: Wed, 12 Apr 2023 14:35:39 +0000 Subject: [PATCH] [contrib] validate_failures.py: Support expiry attributes in manifests contrib/ChangeLog: * testsuite-management/validate_failures.py (ParseManifestWorker): Support expiry attributes in manifests. (ParseSummary): Add a comment. --- contrib/testsuite-management/validate_failures.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/contrib/testsuite-management/validate_failures.py b/contrib/testsuite-management/validate_failures.py index 94ba2e58b51f..7351ba120b73 100755 --- a/contrib/testsuite-management/validate_failures.py +++ b/contrib/testsuite-management/validate_failures.py @@ -338,7 +338,13 @@ def ParseManifestWorker(result_set, manifest_path): elif IsInclude(line): ParseManifestWorker(result_set, GetIncludeFile(line, manifest_path)) elif IsInterestingResult(line): - result_set.add(result_set.MakeTestResult(line)) + result = result_set.MakeTestResult(line) + if result.HasExpired(): + # Ignore expired manifest entries. + if _OPTIONS.verbosity >= 4: + print('WARNING: Expected failure "%s" has expired.' % line.strip()) + continue + result_set.add(result) elif IsExpLine(orig_line): result_set.current_exp = _EXP_LINE_REX.match(orig_line).groups()[0] elif IsToolLine(orig_line): @@ -369,6 +375,8 @@ def ParseSummary(sum_fname): result = result_set.MakeTestResult(line, ordinal) ordinal += 1 if result.HasExpired(): + # ??? What is the use-case for this? How "expiry" annotations are + # ??? supposed to be added to .sum results? # Tests that have expired are not added to the set of expected # results. If they are still present in the set of actual results, # they will cause an error to be reported. -- GitLab