From c356dfdd6fb75553d010852b0a801c9e780290e8 Mon Sep 17 00:00:00 2001
From: Piotr Trojanek <trojanek@adacore.com>
Date: Tue, 22 Dec 2020 01:06:31 +0100
Subject: [PATCH] [Ada] Reject formals of mode IN appearing as global outputs
gcc/ada/
* sem_prag.adb (Check_Mode_Restriction_In_Enclosing_Context):
Apply the rule even with no explicit Global contract (and remove
a dead condition for Refined_Global).
---
gcc/ada/sem_prag.adb | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/gcc/ada/sem_prag.adb b/gcc/ada/sem_prag.adb
index b13894c2e90b..86a97541378e 100644
--- a/gcc/ada/sem_prag.adb
+++ b/gcc/ada/sem_prag.adb
@@ -2634,13 +2634,9 @@ package body Sem_Prag is
Context := Anonymous_Object (Context);
end if;
- if (Is_Subprogram_Or_Entry (Context)
- or else Ekind (Context) = E_Task_Type
- or else Is_Single_Task_Object (Context))
- and then
- (Present (Get_Pragma (Context, Pragma_Global))
- or else
- Present (Get_Pragma (Context, Pragma_Refined_Global)))
+ if Is_Subprogram_Or_Entry (Context)
+ or else Ekind (Context) = E_Task_Type
+ or else Is_Single_Task_Object (Context)
then
Collect_Subprogram_Inputs_Outputs
(Subp_Id => Context,
@@ -2649,8 +2645,8 @@ package body Sem_Prag is
Global_Seen => Dummy);
-- The item is classified as In_Out or Output but appears as
- -- an Input in an enclosing subprogram or task unit (SPARK
- -- RM 6.1.4(13)).
+ -- an Input or a formal parameter of mode IN in an enclosing
+ -- subprogram or task unit (SPARK RM 6.1.4(13)).
if Appears_In (Inputs, Item_Id)
and then not Appears_In (Outputs, Item_Id)
--
GitLab