Skip to content
Snippets Groups Projects
  • Jakub Jelinek's avatar
    ff060ef0
    contrib: Fix up git-descr.sh regression [PR102664] · ff060ef0
    Jakub Jelinek authored
    On Wed, Mar 09, 2022 at 12:40:24PM -0500, Patrick Palka via Gcc-patches wrote:
    > On Wed, Mar 9, 2022 at 8:54 AM Mikael Morin <morin-mikael@orange.fr> wrote:
    > > Le 08/03/2022 à 18:58, Jonathan Wakely via Gcc-patches a écrit :
    > > > Replace \([0-9]\+\) with \([0-9][0-9]*\) or with \([1-9][0-9]*\) in release branch numbers, where
    > > > a leading zero does not occur.
    > > >
    > > Note that you also changed some gcc-[0-9]* to gcc-[1-9]*, which is a
    > > typo/thinko I guess?  It looks like it wouldn’t match gcc-10 any more
    > > for example…
    >
    > Perhaps related to this, I noticed the following
    >   git gcc-descr ea1ce0d1
    > now fails with
    >   fatal: No tags can describe 'ea1ce0d1'.
    > instead of outputting
    >   r0-52309-gea1ce0d163ea1d
    
    That is because of those [0-9] to [1-9] changes which prevent
    basepoints/gcc-0 from working.  While basepoints/gcc-005 etc. are certainly
    unexpected, basepoints/gcc-0 needs to work.
    
    2022-03-10  Jakub Jelinek  <jakub@redhat.com>
    
    	PR other/102664
    	* git-descr.sh: Replace all [1-9] occurrences with [0-9].
    	* git-undescr.sh: Likewise.
    ff060ef0
    History
    contrib: Fix up git-descr.sh regression [PR102664]
    Jakub Jelinek authored
    On Wed, Mar 09, 2022 at 12:40:24PM -0500, Patrick Palka via Gcc-patches wrote:
    > On Wed, Mar 9, 2022 at 8:54 AM Mikael Morin <morin-mikael@orange.fr> wrote:
    > > Le 08/03/2022 à 18:58, Jonathan Wakely via Gcc-patches a écrit :
    > > > Replace \([0-9]\+\) with \([0-9][0-9]*\) or with \([1-9][0-9]*\) in release branch numbers, where
    > > > a leading zero does not occur.
    > > >
    > > Note that you also changed some gcc-[0-9]* to gcc-[1-9]*, which is a
    > > typo/thinko I guess?  It looks like it wouldn’t match gcc-10 any more
    > > for example…
    >
    > Perhaps related to this, I noticed the following
    >   git gcc-descr ea1ce0d1
    > now fails with
    >   fatal: No tags can describe 'ea1ce0d1'.
    > instead of outputting
    >   r0-52309-gea1ce0d163ea1d
    
    That is because of those [0-9] to [1-9] changes which prevent
    basepoints/gcc-0 from working.  While basepoints/gcc-005 etc. are certainly
    unexpected, basepoints/gcc-0 needs to work.
    
    2022-03-10  Jakub Jelinek  <jakub@redhat.com>
    
    	PR other/102664
    	* git-descr.sh: Replace all [1-9] occurrences with [0-9].
    	* git-undescr.sh: Likewise.