Skip to content
Snippets Groups Projects
  • Jakub Jelinek's avatar
    1eff4872
    openmp: Call dlopen with "libmemkind.so.0" rather than "libmemkind.so" · 1eff4872
    Jakub Jelinek authored
    On Thu, Jun 09, 2022 at 12:11:28PM +0200, Thomas Schwinge wrote:
    > > This patch adds support for dlopening libmemkind.so
    >
    > Instead of 'dlopen'ing literally 'libmemkind.so':
    > ..., shouldn't this instead 'dlopen' 'libmemkind.so.0'?  At least for
    > Debian/Ubuntu, the latter ('libmemkind.so.0') is shipped in the "library"
    > package:
    
    I agree and I've actually noticed it too right before committing, but I thought
    I'll investigate and tweak incrementally because "libmemkind.so"
    is what I've actually tested (it is what llvm libomp uses).
    
    Here is the now tested incremental fix.
    
    2022-06-10  Jakub Jelinek  <jakub@redhat.com>
    
    	* allocator.c (gomp_init_memkind): Call dlopen with "libmemkind.so.0"
    	rather than "libmemkind.so".
    1eff4872
    History
    openmp: Call dlopen with "libmemkind.so.0" rather than "libmemkind.so"
    Jakub Jelinek authored
    On Thu, Jun 09, 2022 at 12:11:28PM +0200, Thomas Schwinge wrote:
    > > This patch adds support for dlopening libmemkind.so
    >
    > Instead of 'dlopen'ing literally 'libmemkind.so':
    > ..., shouldn't this instead 'dlopen' 'libmemkind.so.0'?  At least for
    > Debian/Ubuntu, the latter ('libmemkind.so.0') is shipped in the "library"
    > package:
    
    I agree and I've actually noticed it too right before committing, but I thought
    I'll investigate and tweak incrementally because "libmemkind.so"
    is what I've actually tested (it is what llvm libomp uses).
    
    Here is the now tested incremental fix.
    
    2022-06-10  Jakub Jelinek  <jakub@redhat.com>
    
    	* allocator.c (gomp_init_memkind): Call dlopen with "libmemkind.so.0"
    	rather than "libmemkind.so".