Skip to content
Snippets Groups Projects
  • Joseph Myers's avatar
    667b3ec1
    Update libquadmath fmaq from glibc, fix nanq issues. · 667b3ec1
    Joseph Myers authored
    This patch extends update-quadmath.py to update fmaq from glibc.
    
    The issue in that function was that quadmath-imp.h had a struct in a
    union with mant_high and mant_low fields (up to 64-bit) whereas glibc
    has mantissa0, mantissa1, mantissa2 and mantissa3 (up to 32-bit).  The
    patch changes those fields to be the same as in glibc, moving printf /
    strtod code that also uses those fields back to closer to the glibc
    form.  This allows fmaq to be updated automatically from glibc (which
    brings in at least one bug fix from glibc from 2015).
    
    nanq was also using the mant_high field name, and had other issues: it
    only partly initialized the union from which a value was returned, and
    setting mant_high to 1 meant a signaling NaN would be returned rather
    than a quiet NaN.  This patch fixes those issues as part of updating
    it to use the changed interfaces (but does not fix the issue of not
    using the argument).
    
    Bootstrapped with no regressions on x86_64-pc-linux-gnu.
    
    	* quadmath-imp.h (ieee854_float128): Use mantissa0, mantissa1,
    	mantissa2 and mantissa3 fields instead of mant_high and mant_low.
    	Change nan field to ieee_nan.
    	* update-quadmath.py (update_sources): Also update fmaq.c.
    	* math/nanq.c (nanq): Use ieee_nan field of union.
    	Zero-initialize f.  Set quiet_nan field.
    	* printf/flt1282mpn.c, printf/printf_fphex.c, strtod/mpn2flt128.c,
    	strtod/strtoflt128.c: Use mantissa0, mantissa1, mantissa2 and
    	mantissa3 fields.  Use ieee_nan and quiet_nan field.
    	* math/fmaq.c: Regenerate from glibc sources with
    	update-quadmath.py.
    
    From-SVN: r265874
    667b3ec1
    History
    Update libquadmath fmaq from glibc, fix nanq issues.
    Joseph Myers authored
    This patch extends update-quadmath.py to update fmaq from glibc.
    
    The issue in that function was that quadmath-imp.h had a struct in a
    union with mant_high and mant_low fields (up to 64-bit) whereas glibc
    has mantissa0, mantissa1, mantissa2 and mantissa3 (up to 32-bit).  The
    patch changes those fields to be the same as in glibc, moving printf /
    strtod code that also uses those fields back to closer to the glibc
    form.  This allows fmaq to be updated automatically from glibc (which
    brings in at least one bug fix from glibc from 2015).
    
    nanq was also using the mant_high field name, and had other issues: it
    only partly initialized the union from which a value was returned, and
    setting mant_high to 1 meant a signaling NaN would be returned rather
    than a quiet NaN.  This patch fixes those issues as part of updating
    it to use the changed interfaces (but does not fix the issue of not
    using the argument).
    
    Bootstrapped with no regressions on x86_64-pc-linux-gnu.
    
    	* quadmath-imp.h (ieee854_float128): Use mantissa0, mantissa1,
    	mantissa2 and mantissa3 fields instead of mant_high and mant_low.
    	Change nan field to ieee_nan.
    	* update-quadmath.py (update_sources): Also update fmaq.c.
    	* math/nanq.c (nanq): Use ieee_nan field of union.
    	Zero-initialize f.  Set quiet_nan field.
    	* printf/flt1282mpn.c, printf/printf_fphex.c, strtod/mpn2flt128.c,
    	strtod/strtoflt128.c: Use mantissa0, mantissa1, mantissa2 and
    	mantissa3 fields.  Use ieee_nan and quiet_nan field.
    	* math/fmaq.c: Regenerate from glibc sources with
    	update-quadmath.py.
    
    From-SVN: r265874