Skip to content
Snippets Groups Projects
  • Richard Guenther's avatar
    a406865a
    re PR c/40401 (ICE: verify_gimple failed) · a406865a
    Richard Guenther authored
    2009-07-17  Richard Guenther  <rguenther@suse.de>
    
    	PR c/40401
    	* tree-pass.h (pass_diagnose_omp_blocks): Declare.
    	(pass_warn_unused_result): Likewise.
    	(TODO_set_props): Remove.
    	* omp-low.c (diagnose_omp_structured_block_errors): Change to
    	run as a pass.
    	(pass_diagnose_omp_blocks): Define.
    	* c-decl.c (pop_file_scope): Do not finalize the CU here.
    	(c_gimple_diagnostics_recursively): Remove.
    	(finish_function): Do not call it.
    	(c_write_global_declarations): Continue after errors.
    	Finalize the CU here.
    	* c-gimplify.c (c_genericize): Do not gimplify here.
    	* c-common.c (c_warn_unused_result): Move ...
    	* tree-cfg.c (do_warn_unused_result): ... here.
    	(run_warn_unused_result): New function.
    	(gate_warn_unused_result): New function.
    	(pass_warn_unused_result): New pass.
    	* c-common.h (c_warn_unused_result): Remove.
    	* flags.h (flag_warn_unused_result): Declare.
    	* c-opts.c (c_common_init_options): Enable flag_warn_unused_result.
    	* opts.c (flag_warn_unused_result): Initialize to false.
    
    	* toplev.c (compile_file): Add comment.
    	* omp-low.c (create_omp_child_function): Do not register
    	the function with the frontend.
    	(diagnose_omp_structured_block_errors): Prepare to be
    	called as optimization pass.
    	(gate_diagnose_omp_blocks): New function.
    	(pass_diagnose_omp_blocks): New pass.
    	* cgraph.h (cgraph_optimize): Remove.
    	(cgraph_analyze_function): Likewise.
    	* cgraph.c (cgraph_add_new_function): Gimplify C++ thunks.
    	* cgraphunit.c (cgraph_lower_function): Lower nested functions
    	before their parents here.
    	(cgraph_finalize_function): Not here.
    	(cgraph_analyze_function): Gimplify functions here.
    	(cgraph_finalize_compilation_unit): Continue after errors.
    	Optimize the callgraph from here.
    	(cgraph_optimize): Make static.
    	* langhooks.c (write_global_declarations): Finalize the CU.
    	* gimplify.c (gimplify_asm_expr): Do not emit ASMs with errors.
    	(gimplify_function_tree): Assert we gimplify only once.
    	Set PROP_gimple_any property.
    	* tree-nested.c (gimplify_all_functions): New function.
    	(lower_nested_functions): Gimplify all nested functions.
    	* gimple.h (diagnose_omp_structured_block_errors): Remove.
    	* passes.c (init_optimization_passes): Add pass_warn_unused_result
    	and pass_diagnose_omp_blocks after gimplification.  Do not
    	set TODO_set_props on all_lowering_passes.
    	(execute_one_pass): Do not handle TODO_set_props.
    	* Makefile.in (cgraphunit.o): Add $(TREE_DUMP_H) dependency.
    	(gimplify.o): Add tree-pass.h dependency.
    	* tree-inline.c (copy_statement_list): Properly copy STATEMENT_LIST.
    	(copy_tree_body_r): Properly handle TARGET_EXPR like SAVE_EXPR.
    	(unsave_r): Likewise.
    	* c-omp.c (c_finish_omp_atomic): Set DECL_CONTEXT on the
    	temporary variable.
    
    	cp/
    	* decl.c (finish_function): Do not emit unused result warnings
    	from here.
    	* cp-objcp-common.h (LANG_HOOKS_POST_GIMPLIFY_PASS): Use
    	c_warn_unused_result_pass.
    	* semantics.c (expand_or_defer_fn): Adjust assertion about IL status.
    	* optimize.c (clone_body): Clone in GENERIC.
    	(maybe_clone_body): Do not clear DECL_SAVED_TREE.
    	* decl2.c (cp_write_global_declarations): Fix body test.
    	Do not call cgraph_optimize.
    	* Make-lang.in (optimize.o): Add tree-iterator.h dependency.
    	* method.c (use_thunk): Register thunk with
    	cgraph_finalize_function.
    	* error.c (function_category): Guard access of DECL_LANG_SPECIFIC.
    
    	java/
    	* java-gimplify.c (java_genericize): Do not gimplify here.
    	But replace all local references.
    	(java_gimplify_expr): Do not replace local references here.
    	(java_gimplify_modify_expr): Likewise.
    	* jcf-parse.c (java_parse_file): Do not finalize the CU or
    	optimize the cgraph here.
    	* decl.c (java_replace_reference): Make static.
    	(java_replace_references): New function.
    	(end_java_method): Clear base_decl_map.
    	* java-tree.h (java_replace_references): Declare.
    	(java_replace_reference): Remove.
    
    	ada/
    	* utils.c (end_subprog_body): Revert to pre-tuples state.  Remove
    	unused parameter.
    	(gnat_gimplify_function): Do not gimplify here.
    	Fold into its only caller and remove.
    	(gnat_builtin_function): Adjust for end_subprog_body signature change.
    	(gnat_write_global_declarations): Also finalize the CU.
    	* misc.c (gnat_parse_file): Do not finalize the CU here.
    	* trans.c (gigi): Revert to pre-tuples state.
    	(Subprogram_Body_to_gnu): Adjust for end_subprog_body signature
    	change.
    	* gigi.h (end_subprog_body): Remove unused parameter.
    
    	fortran/
    	* f95-lang.c (gfc_be_parse_file): Do not finalize the CU here.
    	* trans-decl.c (gfc_gimplify_function): Remove.
    	(build_entry_thunks): Do not gimplify here.
    	(create_main_function): Likewise.
    	(gfc_generate_function_code): Likewise.
    
    	* g++.dg/rtti/crash4.C: New testcase.
    	* g++.dg/torture/20090706-1.C: Likewise.
    	* gcc.dg/redecl-17.c: Likewise.
    
    	* gfortran.dg/missing_optional_dummy_5.f90: Adjust pattern.
    	* gcc.dg/declspec-9.c: Expect extra error.
    	* gcc.dg/declspec-10.c: Likewise.
    	* gcc.dg/declspec-11.c: Likewise.
    	* gcc.dg/redecl-10.c: Expect extra warnings.
    	* gcc.target/i386/pr39082-1.c: Adjust diagnostic location.
    	* gcc.target/i386/pr39545-1.c: Likewise.
    	* g++.dg/ext/asm3.C: Expect more errors.
    	* g++.dg/gomp/block-1.C: Likewise.
    	* g++.dg/gomp/block-2.C: Likewise.
    	* g++.dg/gomp/block-3.C: Likewise.
    	* g++.dg/gomp/block-5.C: Likewise.
    	* g++.old-deja/g++.jason/report.C: Expect extra warnings.
    	* g++.dg/warn/unused-result1.C: XFAIL.
    
    From-SVN: r149750
    a406865a
    History
    re PR c/40401 (ICE: verify_gimple failed)
    Richard Guenther authored
    2009-07-17  Richard Guenther  <rguenther@suse.de>
    
    	PR c/40401
    	* tree-pass.h (pass_diagnose_omp_blocks): Declare.
    	(pass_warn_unused_result): Likewise.
    	(TODO_set_props): Remove.
    	* omp-low.c (diagnose_omp_structured_block_errors): Change to
    	run as a pass.
    	(pass_diagnose_omp_blocks): Define.
    	* c-decl.c (pop_file_scope): Do not finalize the CU here.
    	(c_gimple_diagnostics_recursively): Remove.
    	(finish_function): Do not call it.
    	(c_write_global_declarations): Continue after errors.
    	Finalize the CU here.
    	* c-gimplify.c (c_genericize): Do not gimplify here.
    	* c-common.c (c_warn_unused_result): Move ...
    	* tree-cfg.c (do_warn_unused_result): ... here.
    	(run_warn_unused_result): New function.
    	(gate_warn_unused_result): New function.
    	(pass_warn_unused_result): New pass.
    	* c-common.h (c_warn_unused_result): Remove.
    	* flags.h (flag_warn_unused_result): Declare.
    	* c-opts.c (c_common_init_options): Enable flag_warn_unused_result.
    	* opts.c (flag_warn_unused_result): Initialize to false.
    
    	* toplev.c (compile_file): Add comment.
    	* omp-low.c (create_omp_child_function): Do not register
    	the function with the frontend.
    	(diagnose_omp_structured_block_errors): Prepare to be
    	called as optimization pass.
    	(gate_diagnose_omp_blocks): New function.
    	(pass_diagnose_omp_blocks): New pass.
    	* cgraph.h (cgraph_optimize): Remove.
    	(cgraph_analyze_function): Likewise.
    	* cgraph.c (cgraph_add_new_function): Gimplify C++ thunks.
    	* cgraphunit.c (cgraph_lower_function): Lower nested functions
    	before their parents here.
    	(cgraph_finalize_function): Not here.
    	(cgraph_analyze_function): Gimplify functions here.
    	(cgraph_finalize_compilation_unit): Continue after errors.
    	Optimize the callgraph from here.
    	(cgraph_optimize): Make static.
    	* langhooks.c (write_global_declarations): Finalize the CU.
    	* gimplify.c (gimplify_asm_expr): Do not emit ASMs with errors.
    	(gimplify_function_tree): Assert we gimplify only once.
    	Set PROP_gimple_any property.
    	* tree-nested.c (gimplify_all_functions): New function.
    	(lower_nested_functions): Gimplify all nested functions.
    	* gimple.h (diagnose_omp_structured_block_errors): Remove.
    	* passes.c (init_optimization_passes): Add pass_warn_unused_result
    	and pass_diagnose_omp_blocks after gimplification.  Do not
    	set TODO_set_props on all_lowering_passes.
    	(execute_one_pass): Do not handle TODO_set_props.
    	* Makefile.in (cgraphunit.o): Add $(TREE_DUMP_H) dependency.
    	(gimplify.o): Add tree-pass.h dependency.
    	* tree-inline.c (copy_statement_list): Properly copy STATEMENT_LIST.
    	(copy_tree_body_r): Properly handle TARGET_EXPR like SAVE_EXPR.
    	(unsave_r): Likewise.
    	* c-omp.c (c_finish_omp_atomic): Set DECL_CONTEXT on the
    	temporary variable.
    
    	cp/
    	* decl.c (finish_function): Do not emit unused result warnings
    	from here.
    	* cp-objcp-common.h (LANG_HOOKS_POST_GIMPLIFY_PASS): Use
    	c_warn_unused_result_pass.
    	* semantics.c (expand_or_defer_fn): Adjust assertion about IL status.
    	* optimize.c (clone_body): Clone in GENERIC.
    	(maybe_clone_body): Do not clear DECL_SAVED_TREE.
    	* decl2.c (cp_write_global_declarations): Fix body test.
    	Do not call cgraph_optimize.
    	* Make-lang.in (optimize.o): Add tree-iterator.h dependency.
    	* method.c (use_thunk): Register thunk with
    	cgraph_finalize_function.
    	* error.c (function_category): Guard access of DECL_LANG_SPECIFIC.
    
    	java/
    	* java-gimplify.c (java_genericize): Do not gimplify here.
    	But replace all local references.
    	(java_gimplify_expr): Do not replace local references here.
    	(java_gimplify_modify_expr): Likewise.
    	* jcf-parse.c (java_parse_file): Do not finalize the CU or
    	optimize the cgraph here.
    	* decl.c (java_replace_reference): Make static.
    	(java_replace_references): New function.
    	(end_java_method): Clear base_decl_map.
    	* java-tree.h (java_replace_references): Declare.
    	(java_replace_reference): Remove.
    
    	ada/
    	* utils.c (end_subprog_body): Revert to pre-tuples state.  Remove
    	unused parameter.
    	(gnat_gimplify_function): Do not gimplify here.
    	Fold into its only caller and remove.
    	(gnat_builtin_function): Adjust for end_subprog_body signature change.
    	(gnat_write_global_declarations): Also finalize the CU.
    	* misc.c (gnat_parse_file): Do not finalize the CU here.
    	* trans.c (gigi): Revert to pre-tuples state.
    	(Subprogram_Body_to_gnu): Adjust for end_subprog_body signature
    	change.
    	* gigi.h (end_subprog_body): Remove unused parameter.
    
    	fortran/
    	* f95-lang.c (gfc_be_parse_file): Do not finalize the CU here.
    	* trans-decl.c (gfc_gimplify_function): Remove.
    	(build_entry_thunks): Do not gimplify here.
    	(create_main_function): Likewise.
    	(gfc_generate_function_code): Likewise.
    
    	* g++.dg/rtti/crash4.C: New testcase.
    	* g++.dg/torture/20090706-1.C: Likewise.
    	* gcc.dg/redecl-17.c: Likewise.
    
    	* gfortran.dg/missing_optional_dummy_5.f90: Adjust pattern.
    	* gcc.dg/declspec-9.c: Expect extra error.
    	* gcc.dg/declspec-10.c: Likewise.
    	* gcc.dg/declspec-11.c: Likewise.
    	* gcc.dg/redecl-10.c: Expect extra warnings.
    	* gcc.target/i386/pr39082-1.c: Adjust diagnostic location.
    	* gcc.target/i386/pr39545-1.c: Likewise.
    	* g++.dg/ext/asm3.C: Expect more errors.
    	* g++.dg/gomp/block-1.C: Likewise.
    	* g++.dg/gomp/block-2.C: Likewise.
    	* g++.dg/gomp/block-3.C: Likewise.
    	* g++.dg/gomp/block-5.C: Likewise.
    	* g++.old-deja/g++.jason/report.C: Expect extra warnings.
    	* g++.dg/warn/unused-result1.C: XFAIL.
    
    From-SVN: r149750