Skip to content
Snippets Groups Projects
  • Jakub Jelinek's avatar
    dea9ac2a
    libgomp: Use void (*) (void *) rather than void (*)() for host_fn type [PR114216] · dea9ac2a
    Jakub Jelinek authored
    For the type of the target callbacks we use elsehwere void (*) (void *) and
    IMHO should use that for the reverse offload fallback as well (where the actual
    callback is emitted using the same code as for host fallback or device kernel
    entry routines), even when it is also ok to use void (*) () before C23 and
    we aren't building libgomp with C23 yet.  On some arches perhaps void (*) ()
    could result in worse code generation because calls in that case like casts
    to unprototyped functions need to sometimes pass argument in two different spots
    etc. so that it deals with both passing it through ... and as a named argument.
    
    2024-03-04  Jakub Jelinek  <jakub@redhat.com>
    
    	PR libgomp/114216
    	* target.c (gomp_target_rev): Change host_fn type and corresponding
    	cast from void (*)() to void (*) (void *).
    dea9ac2a
    History
    libgomp: Use void (*) (void *) rather than void (*)() for host_fn type [PR114216]
    Jakub Jelinek authored
    For the type of the target callbacks we use elsehwere void (*) (void *) and
    IMHO should use that for the reverse offload fallback as well (where the actual
    callback is emitted using the same code as for host fallback or device kernel
    entry routines), even when it is also ok to use void (*) () before C23 and
    we aren't building libgomp with C23 yet.  On some arches perhaps void (*) ()
    could result in worse code generation because calls in that case like casts
    to unprototyped functions need to sometimes pass argument in two different spots
    etc. so that it deals with both passing it through ... and as a named argument.
    
    2024-03-04  Jakub Jelinek  <jakub@redhat.com>
    
    	PR libgomp/114216
    	* target.c (gomp_target_rev): Change host_fn type and corresponding
    	cast from void (*)() to void (*) (void *).