libstdc++: Fix views::transform(move_only_fn{}) forwarding [PR118413]
The range adaptor perfect forwarding simplification mechanism is currently
only enabled for trivially copyable bound arguments, to prevent undesirable
copies of complex objects. But "trivially copyable" is the wrong property
to check for here, since a move-only type with a trivial move constructor
is considered trivially copyable, and after P2492R2 we can't assume copy
constructibility of the bound arguments. This patch makes the mechanism
more specifically check for trivial copy constructibility instead so
that it's properly disabled for move-only bound arguments.
PR libstdc++/118413
libstdc++-v3/ChangeLog:
* include/std/ranges (views::__adaptor::_Partial): Adjust
constraints on the "simple" partial specializations to require
is_trivially_copy_constructible_v instead of
is_trivially_copyable_v.
* testsuite/std/ranges/adaptors/adjacent_transform/1.cc (test04):
Extend P2494R2 test.
* testsuite/std/ranges/adaptors/transform.cc (test09): Likewise.
Reviewed-by:
Jonathan Wakely <jwakely@redhat.com>
Showing
- libstdc++-v3/include/std/ranges 2 additions, 2 deletionslibstdc++-v3/include/std/ranges
- libstdc++-v3/testsuite/std/ranges/adaptors/adjacent_transform/1.cc 1 addition, 0 deletions...-v3/testsuite/std/ranges/adaptors/adjacent_transform/1.cc
- libstdc++-v3/testsuite/std/ranges/adaptors/transform.cc 2 additions, 0 deletionslibstdc++-v3/testsuite/std/ranges/adaptors/transform.cc
Loading
Please register or sign in to comment