c++: non-dependent assignment checking [PR63198, PR18474]
This patch makes us recognize and check non-dependent simple assigments ahead of time, like we already do for compound assignments. This means the templated representation of such assignments will now usually have an implicit INDIRECT_REF (due to the reference return type), which the -Wparentheses code needs to handle. As a drive-by improvement, this patch also makes maybe_convert_cond issue -Wparentheses warnings ahead of time, and removes a seemingly unnecessary suppress_warning call in build_x_modify_expr. On the libstdc++ side, some tests were attempting to modify a data member from a uninstantiated const member function, which this patch minimally fixes by making the data member mutable. PR c++/63198 PR c++/18474 gcc/cp/ChangeLog: * semantics.cc (maybe_convert_cond): Look through implicit INDIRECT_REF when deciding whether to issue a -Wparentheses warning, and consider templated assignment expressions as well. (finish_parenthesized_expr): Look through implicit INDIRECT_REF when suppressing -Wparentheses warning. * typeck.cc (build_x_modify_expr): Check simple assignments ahead time too, not just compound assignments. Give the second operand of MODOP_EXPR a non-null type so that it's not considered always instantiation-dependent. Don't call suppress_warning. gcc/testsuite/ChangeLog: * g++.dg/cpp0x/static_assert15.C: Expect diagnostic for non-constant static_assert condition. * g++.dg/expr/unary2.C: Remove xfails. * g++.dg/template/init7.C: Make initializer type-dependent to preserve intent of test. * g++.dg/template/recurse3.C: Likewise for the erroneous statement. * g++.dg/template/non-dependent26.C: New test. * g++.dg/warn/Wparentheses-32.C: New test. libstdc++-v3/ChangeLog: * testsuite/26_numerics/random/discard_block_engine/cons/seed_seq2.cc: Make data member seed_seq::called mutable. * testsuite/26_numerics/random/independent_bits_engine/cons/seed_seq2.cc: Likewise. * testsuite/26_numerics/random/linear_congruential_engine/cons/seed_seq2.cc: Likewise. * testsuite/26_numerics/random/mersenne_twister_engine/cons/seed_seq2.cc: Likewise. * testsuite/26_numerics/random/shuffle_order_engine/cons/seed_seq2.cc: Likewise. * testsuite/26_numerics/random/subtract_with_carry_engine/cons/seed_seq2.cc: Likewise. * testsuite/ext/random/simd_fast_mersenne_twister_engine/cons/seed_seq2.cc: Likewise.
Showing
- gcc/cp/semantics.cc 13 additions, 6 deletionsgcc/cp/semantics.cc
- gcc/cp/typeck.cc 18 additions, 23 deletionsgcc/cp/typeck.cc
- gcc/testsuite/g++.dg/cpp0x/static_assert15.C 1 addition, 1 deletiongcc/testsuite/g++.dg/cpp0x/static_assert15.C
- gcc/testsuite/g++.dg/expr/unary2.C 3 additions, 5 deletionsgcc/testsuite/g++.dg/expr/unary2.C
- gcc/testsuite/g++.dg/template/init7.C 1 addition, 1 deletiongcc/testsuite/g++.dg/template/init7.C
- gcc/testsuite/g++.dg/template/non-dependent26.C 25 additions, 0 deletionsgcc/testsuite/g++.dg/template/non-dependent26.C
- gcc/testsuite/g++.dg/template/recurse3.C 4 additions, 4 deletionsgcc/testsuite/g++.dg/template/recurse3.C
- gcc/testsuite/g++.dg/warn/Wparentheses-32.C 28 additions, 0 deletionsgcc/testsuite/g++.dg/warn/Wparentheses-32.C
- libstdc++-v3/testsuite/26_numerics/random/discard_block_engine/cons/seed_seq2.cc 1 addition, 1 deletion...26_numerics/random/discard_block_engine/cons/seed_seq2.cc
- libstdc++-v3/testsuite/26_numerics/random/independent_bits_engine/cons/seed_seq2.cc 1 addition, 1 deletion...numerics/random/independent_bits_engine/cons/seed_seq2.cc
- libstdc++-v3/testsuite/26_numerics/random/linear_congruential_engine/cons/seed_seq2.cc 1 addition, 1 deletion...erics/random/linear_congruential_engine/cons/seed_seq2.cc
- libstdc++-v3/testsuite/26_numerics/random/mersenne_twister_engine/cons/seed_seq2.cc 1 addition, 1 deletion...numerics/random/mersenne_twister_engine/cons/seed_seq2.cc
- libstdc++-v3/testsuite/26_numerics/random/shuffle_order_engine/cons/seed_seq2.cc 1 addition, 1 deletion...26_numerics/random/shuffle_order_engine/cons/seed_seq2.cc
- libstdc++-v3/testsuite/26_numerics/random/subtract_with_carry_engine/cons/seed_seq2.cc 1 addition, 1 deletion...erics/random/subtract_with_carry_engine/cons/seed_seq2.cc
- libstdc++-v3/testsuite/ext/random/simd_fast_mersenne_twister_engine/cons/seed_seq2.cc 1 addition, 1 deletion...andom/simd_fast_mersenne_twister_engine/cons/seed_seq2.cc
Loading
Please register or sign in to comment