-
- Downloads
c-family: -Wleading-whitespace= argument spelling
On Thu, Oct 24, 2024 at 03:33:25PM -0400, Eric Gallager wrote: > On Thu, Oct 24, 2024 at 4:17 AM Jakub Jelinek <jakub@redhat.com> wrote: > > I've tried to build stage3 with > > -Wleading-whitespace=blanks -Wtrailing-whitespace=blank -Wno-error=leading-whitespace=blanks -Wno-error=trailing-whitespace=blank > > So wait, it's "blanks" (plural) when it's leading, but "blank" > (singular) when it's trailing? That inconsistency bothers me... I've mentioned it already in https://gcc.gnu.org/pipermail/gcc-patches/2024-October/664664.html Citing that here: Not sure about the kinds for the option, given -Wleading-whitespace= uses plural and this option singular and -Wleading-whitespace= spaces means literally just ' ' characters, while space in -Wtrailing-whitespace= was ' ', '\t', '\v' and '\f'; so category; perhaps just use any and blanks? Other preferences? Here is a patch to do the blank->blanks and space->any changes. 2024-10-27 Jakub Jelinek <jakub@redhat.com> gcc/ * doc/invoke.texi (Wtrailing-whitespace=): Change blank argument to blanks and space argument to any. gcc/c-family/ * c.opt (warn_trailing_whitespace_kind): Change blank to blanks and space to any. gcc/testsuite/ * c-c++-common/cpp/Wtrailing-whitespace-2.c: Use -Wtrailing-whitespace=blanks rather than -Wtrailing-whitespace=blank. * c-c++-common/cpp/Wtrailing-whitespace-3.c: Use -Wtrailing-whitespace=any rather than -Wtrailing-whitespace=space. * c-c++-common/cpp/Wtrailing-whitespace-7.c: Use -Wtrailing-whitespace=blanks rather than -Wtrailing-whitespace=blank. * c-c++-common/cpp/Wtrailing-whitespace-8.c: Use -Wtrailing-whitespace=any rather than -Wtrailing-whitespace=space.
Showing
- gcc/c-family/c.opt 4 additions, 4 deletionsgcc/c-family/c.opt
- gcc/doc/invoke.texi 2 additions, 2 deletionsgcc/doc/invoke.texi
- gcc/testsuite/c-c++-common/cpp/Wtrailing-whitespace-2.c 1 addition, 1 deletiongcc/testsuite/c-c++-common/cpp/Wtrailing-whitespace-2.c
- gcc/testsuite/c-c++-common/cpp/Wtrailing-whitespace-3.c 1 addition, 1 deletiongcc/testsuite/c-c++-common/cpp/Wtrailing-whitespace-3.c
- gcc/testsuite/c-c++-common/cpp/Wtrailing-whitespace-7.c 1 addition, 1 deletiongcc/testsuite/c-c++-common/cpp/Wtrailing-whitespace-7.c
- gcc/testsuite/c-c++-common/cpp/Wtrailing-whitespace-8.c 1 addition, 1 deletiongcc/testsuite/c-c++-common/cpp/Wtrailing-whitespace-8.c
Loading
Please register or sign in to comment