Skip to content
Snippets Groups Projects
Commit b4c9ba20 authored by Viljar Indus's avatar Viljar Indus Committed by Marc Poulhiès
Browse files

ada: Remove level attribute from Rules in the SARIF report

A Rule object in the SARIF report does not have a level
attribute. Result objects are the elements in the SARIF
reprot that have a level attribute that ultimately determines
the level of each diagnostic object.

Rules can have a defaultConfiguration attribute which has a level
attribute that can be overridden in multiple ways. This can make
the overall report more complex than it needs to be. It is simpler
to remove the attribute from rules where it does not really matter
and add it back in under the defaultConfiguration when there is an
explicit need for it.

gcc/ada/ChangeLog:

	* diagnostics-sarif_emitter.adb (Print_Rule): Remove printing
	of the level attribute since it does not match the SARIF schema.
parent 92d50b9d
No related branches found
No related tags found
No related merge requests found
......@@ -229,12 +229,10 @@ package body Diagnostics.SARIF_Emitter is
procedure Print_Rule (Diag : Diagnostic_Type);
-- Print a rule node that consists of the following attributes:
-- * ruleId
-- * level
-- * name
--
-- {
-- "id": <Diag.Id>,
-- "level": <Diag.Kind>,
-- "name": <Human_Id(Diag)>
-- },
......@@ -1006,10 +1004,6 @@ package body Diagnostics.SARIF_Emitter is
Write_Char (',');
NL_And_Indent;
Write_String_Attribute ("level", Kind_To_String (Diag));
Write_Char (',');
NL_And_Indent;
if Human_Id = null then
Write_String_Attribute ("name", "Uncategorized_Diagnostic");
else
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment