Skip to content
Snippets Groups Projects
  1. Nov 23, 2024
    • Lewis Hyatt's avatar
      libcpp: Fix ICE lexing invalid raw string in a deferred pragma [PR117118] · 18cace46
      Lewis Hyatt authored
      The PR shows that we ICE after lexing an invalid unterminated raw string,
      because lex_raw_string() pops the main buffer unexpectedly. Resolve by
      handling this case the same way as for other directives.
      
      libcpp/ChangeLog:
      	PR preprocessor/117118
      	* lex.cc (lex_raw_string): Treat an unterminated raw string the same
      	way for a deferred pragma as is done for other directives.
      
      gcc/testsuite/ChangeLog:
      	PR preprocessor/117118
      	* c-c++-common/raw-string-directive-3.c: New test.
      	* c-c++-common/raw-string-directive-4.c: New test.
      18cace46
    • Lewis Hyatt's avatar
      libcpp: Fix potential unaligned access in cpp_buffer · c93eb81c
      Lewis Hyatt authored
      libcpp makes use of the cpp_buffer pfile->a_buff to store things while it is
      handling macros. It uses it to store pointers (cpp_hashnode*, for macro
      arguments) and cpp_macro objects. This works fine because a cpp_hashnode*
      and a cpp_macro have the same alignment requirement on either 32-bit or
      64-bit systems (namely, the same alignment as a pointer.)
      
      When 64-bit location_t is enabled on a 32-bit sytem, the alignment
      requirement may cease to be the same, because the alignment requirement of a
      cpp_macro object changes to that of a uint64_t, which be larger than that of
      a pointer. It's not the case for x86 32-bit, but for example, on sparc, a
      pointer has 4-byte alignment while a uint64_t has 8. In that case,
      intermixing the two within the same cpp_buffer leads to a misaligned
      access. The code path that triggers this is the one in _cpp_commit_buff in
      which a hash table with its own allocator (i.e. ggc) is not being used, so
      it doesn't happen within the compiler itself, but it happens in the other
      libcpp clients, such as genmatch.
      
      Fix that up by ensuring _cpp_commit_buff commits a fully aligned chunk of the
      buffer, so it's ready for anything it may be used for next.
      
      Also modify CPP_ALIGN so that it guarantees to return an alignment at least
      the size of location_t. Currently it returns the max of a pointer and a
      double. I am not aware of any platform where a double may have smaller
      alignment than a uint64_t, but it does not hurt to add location_t here to be
      sure.
      
      libcpp/ChangeLog:
      
      	* lex.cc (_cpp_commit_buff): Make sure that the buffer is properly
      	aligned for the next allocation.
      	* internal.h (struct dummy): Make sure alignment is large enough for
      	a location_t, just in case.
      c93eb81c
  2. Nov 01, 2024
    • Jakub Jelinek's avatar
      c++: Attempt to implement C++26 P3034R1 - Module Declarations Shouldn't be Macros [PR114461] · 1ae24f7e
      Jakub Jelinek authored
      This is an attempt to implement the https://wg21.link/p3034r1 paper,
      but I'm afraid the wording in the paper is bad for multiple reasons.
      I think I understand the intent, that the module name and partition
      if any shouldn't come from macros so that they can be scanned for
      without preprocessing, but on the other side doesn't want to disable
      macro expansion in pp-module altogether, because e.g. the optional
      attribute in module-declaration would be nice to come from macros
      as which exact attribute is needed might need to be decided based on
      preprocessor checks.
      The paper added https://eel.is/c++draft/cpp.module#2
      which uses partly the wording from https://eel.is/c++draft/cpp.module#1
      
      The first issue I see is that using that "defined as an object-like macro"
      from there means IMHO something very different in those 2 paragraphs.
      As per https://eel.is/c++draft/cpp.pre#7.sentence-1 preprocessing tokens
      in preprocessing directives aren't subject to macro expansion unless
      otherwise stated, and so the export and module tokens aren't expanded
      and so the requirement that they aren't defined as an object-like macro
      makes perfect sense.  The problem with the new paragraph is that
      https://eel.is/c++draft/cpp.module#3.sentence-1 says that the rest of
      the tokens are macro expanded and after macro expansion none of the
      tokens can be defined as an object-like macro, if they would be, they'd
      be expanded to that.  So, I think either the wording needs to change
      such that not all preprocessing tokens after module are macro expanded,
      only those which are after the pp-module-name and if any pp-module-partition
      tokens, or all tokens after module are macro expanded but none of the tokens in
      pp-module-name and pp-module-partition if any must come from macro
      expansion.  The patch below implements it as if the former would be
      specified (but see later), so essentially scans the preprocessing tokens
      after module without expansion, if the first one is an identifier, it
      disables expansion for it and then if followed by . or : expects another
      such identifier (again with disabled expansion), but stops after second
      : is seen.
      
      Second issue is that while the global-module-fragment start is fine, matches
      the syntax of the new paragraph where the pp-tokens[opt] aren't present,
      there is also private-module-fragment in the syntax where module is
      followed by : private ; and in that case the colon doesn't match the
      pp-module-name grammar and appears now to be invalid.  I think the
      https://eel.is/c++draft/cpp.module#2
      paragraph needs to change so that it allows also that pp-tokens of
      a pp-module may also be : pp-tokens[opt] (and in that case, I think
      the colon shouldn't come from a macro and private and/or ; can).
      
      Third issue is that there are too many pp-tokens in
      https://eel.is/c++draft/cpp.module , one is all the tokens between
      module keyword and the semicolon and one is the optional extra tokens
      after pp-module-partition (if any, if missing, after pp-module).
      Perhaps introducing some other non-terminal would help talking about it?
      So in "where the pp-tokens (if any) shall not begin with a ( preprocessing
      token" it isn't obvious which pp-tokens it is talking about (my assumption
      is the latter) and also whether ( can't appear there just before macro
      expansion or also after expansion.  The patch expects only before expansion,
      so
       #define F ();
       export module foo F
      would be valid during preprocessing but obviously invalid during
      compilation, but
       #define foo(n) n;
       export module foo (3)
      would be invalid already during preprocessing.
      
      The last issue applies only if the first issue is resolved to allow
      expansion of tokens after : if first token, or after pp-module-partition
      if present or after pp-module-name if present.  When non-preprocessing
      scanner sees
       export module foo.bar:baz.qux;
      it knows nothing can come from preprocessing macros and is ok, but if it
      sees
       export module foo.bar:baz qux
      then it can't know whether it will be
       export module foo.bar:baz;
      or
       export module foo.bar:baz [[]];
      or
       export module foo.bar:baz.freddy.garply;
      because qux could be validly a macro, which expands to ; or [[]];
      or .freddy.garply; etc.  So, either the non-preprocessing scanner would
      need to note it as possible export of foo.bar:baz* module partitions
      and preprocess if it needs to know the details or just compile, or if that
      is not ok, the wording would need to rule out that the expansion of (the
      second) pp-tokens if any can't start with . or : (colon would be only
      problematic if it isn't present in the tokens before it already).
      So, if e.g. defining qux above to . whatever is invalid, then the scanner
      can rely it sees the whole module name and partition.
      
      The patch below implements what is above described as the first variant
      of the first issue resolution, i.e. disables expansion of as many tokens
      as could be in the valid module name and module partition syntax, but
      as soon as it e.g. sees two adjacent identifiers, the second one can be
      macro expanded.  If it is macro expanded though, the expansion can't
      start with . or :, and if it expands to nothing, tokens after it (whether
      they come from macro expansion or not) can't start with . or :.
      So, effectively:
       #define SEMI ;
       export module SEMI
      used to be valid and isn't anymore,
       #define FOO bar
       export module FOO;
      isn't valid,
       #define COLON :
       export module COLON private;
      isn't valid,
       #define BAR baz
       export module foo.bar:baz.qux.BAR;
      isn't valid,
       #define BAZ .qux
       export module foo BAZ;
      isn't valid,
       #define FREDDY :garply
       export module foo FREDDY;
      isn't valid,
      while
       #define QUX [[]]
       export module foo QUX;
      or
       #define GARPLY private
       module : GARPLY;
      etc. is.
      
      2024-11-01  Jakub Jelinek  <jakub@redhat.com>
      
      	PR c++/114461
      libcpp/
      	* include/cpplib.h: Implement C++26 P3034R1
      	- Module Declarations Shouldn’t be Macros (or more precisely
      	its expected intent).
      	(NO_DOT_COLON): Define.
      	* internal.h (struct cpp_reader): Add diagnose_dot_colon_from_macro_p
      	member.
      	* lex.cc (cpp_maybe_module_directive): For pp-module, if
      	module keyword is followed by CPP_NAME, ensure all CPP_NAME
      	tokens possibly matching module name and module partition
      	syntax aren't expanded and aren't defined as object-like macros.
      	Verify first token after that doesn't start with open paren.
      	If the next token after module name/partition is CPP_NAME defined
      	as macro, set NO_DOT_COLON flag on it.
      	* macro.cc (cpp_get_token_1): Set
      	pfile->diagnose_dot_colon_from_macro_p if token to be expanded has
      	NO_DOT_COLON bit set in flags.  Before returning, if
      	pfile->diagnose_dot_colon_from_macro_p is true and not returning
      	CPP_PADDING or CPP_COMMENT and not during macro expansion preparation,
      	set pfile->diagnose_dot_colon_from_macro_p to false and diagnose
      	if returning CPP_DOT or CPP_COLON.
      gcc/testsuite/
      	* g++.dg/modules/cpp-7.C: New test.
      	* g++.dg/modules/cpp-8.C: New test.
      	* g++.dg/modules/cpp-9.C: New test.
      	* g++.dg/modules/cpp-10.C: New test.
      	* g++.dg/modules/cpp-11.C: New test.
      	* g++.dg/modules/cpp-12.C: New test.
      	* g++.dg/modules/cpp-13.C: New test.
      	* g++.dg/modules/cpp-14.C: New test.
      	* g++.dg/modules/cpp-15.C: New test.
      	* g++.dg/modules/cpp-16.C: New test.
      	* g++.dg/modules/cpp-17.C: New test.
      	* g++.dg/modules/cpp-18.C: New test.
      	* g++.dg/modules/cpp-19.C: New test.
      	* g++.dg/modules/cpp-20.C: New test.
      	* g++.dg/modules/pmp-4.C: New test.
      	* g++.dg/modules/pmp-5.C: New test.
      	* g++.dg/modules/pmp-6.C: New test.
      	* g++.dg/modules/token-6.C: New test.
      	* g++.dg/modules/token-7.C: New test.
      	* g++.dg/modules/token-8.C: New test.
      	* g++.dg/modules/token-9.C: New test.
      	* g++.dg/modules/token-10.C: New test.
      	* g++.dg/modules/token-11.C: New test.
      	* g++.dg/modules/token-12.C: New test.
      	* g++.dg/modules/token-13.C: New test.
      	* g++.dg/modules/token-14.C: New test.
      	* g++.dg/modules/token-15.C: New test.
      	* g++.dg/modules/token-16.C: New test.
      	* g++.dg/modules/dir-only-3.C: Expect an error.
      	* g++.dg/modules/dir-only-4.C: Expect an error.
      	* g++.dg/modules/dir-only-5.C: New test.
      	* g++.dg/modules/atom-preamble-2_a.C: In export module malcolm;
      	replace malcolm with kevin.  Don't define malcolm macro.
      	* g++.dg/modules/atom-preamble-4.C: Expect an error.
      	* g++.dg/modules/atom-preamble-5.C: New test.
      1ae24f7e
  3. Oct 25, 2024
    • Jakub Jelinek's avatar
      non-gcc: Remove trailing whitespace · 45ab93d9
      Jakub Jelinek authored
      I've tried to build stage3 with
      -Wleading-whitespace=blanks -Wtrailing-whitespace=blank -Wno-error=leading-whitespace=blanks -Wno-error=trailing-whitespace=blank
      added to STRICT_WARN and that expectably resulted in about
      2744 unique trailing whitespace warnings and 124837 leading whitespace
      warnings when excluding *.md files (which obviously is in big part a
      generator issue).  Others from that are generator related, I think those
      need to be solved later.
      
      The following patch just fixes up the easy case (trailing whitespace),
      which could be easily automated:
      for i in `find . -name \*.h -o -name \*.cc -o -name \*.c | xargs grep -l '[ 	]$' | grep -v testsuite/`; do sed -i -e 's/[ 	]*$//' $i; done
      I've excluded files which I knew are obviously generated or go FE.
      
      Is there anything else we'd want to avoid the changes?
      
      Due to patch size, I've split it between gcc/ part
      and rest (include/, libiberty/, libgcc/, libcpp/, libstdc++-v3/;
      this part).
      
      2024-10-24  Jakub Jelinek  <jakub@redhat.com>
      
      include/
      	* dyn-string.h: Remove trailing whitespace.
      	* libiberty.h: Likewise.
      	* xregex.h: Likewise.
      	* splay-tree.h: Likewise.
      	* partition.h: Likewise.
      	* plugin-api.h: Likewise.
      	* demangle.h: Likewise.
      	* vtv-change-permission.h: Likewise.
      	* fibheap.h: Likewise.
      	* hsa_ext_image.h: Likewise.
      	* hashtab.h: Likewise.
      	* libcollector.h: Likewise.
      	* sort.h: Likewise.
      	* symcat.h: Likewise.
      	* hsa_ext_amd.h: Likewise.
      libcpp/
      	* directives.cc: Remove trailing whitespace.
      	* mkdeps.cc: Likewise.
      	* line-map.cc: Likewise.
      	* internal.h: Likewise.
      	* files.cc: Likewise.
      	* init.cc: Likewise.
      	* makeucnid.cc: Likewise.
      	* system.h: Likewise.
      	* include/line-map.h: Likewise.
      	* include/symtab.h: Likewise.
      	* include/cpplib.h: Likewise.
      	* expr.cc: Likewise.
      	* charset.cc: Likewise.
      	* macro.cc: Likewise.
      	* errors.cc: Likewise.
      	* lex.cc: Likewise.
      	* traditional.cc: Likewise.
      libgcc/
      	* crtstuff.c: Remove trailing whitespace.
      	* libgcov.h: Likewise.
      	* config/alpha/crtfastmath.c: Likewise.
      	* config/alpha/vms-gcc_shell_handler.c: Likewise.
      	* config/alpha/vms-unwind.h: Likewise.
      	* config/pa/linux-atomic.c: Likewise.
      	* config/pa/linux-unwind.h: Likewise.
      	* config/pa/quadlib.c: Likewise.
      	* config/pa/fptr.c: Likewise.
      	* config/s390/32/_fixsfdi.c: Likewise.
      	* config/s390/32/_fixunssfdi.c: Likewise.
      	* config/s390/32/_fixunsdfdi.c: Likewise.
      	* config/c6x/pr-support.c: Likewise.
      	* config/lm32/_udivsi3.c: Likewise.
      	* config/lm32/libgcc_lm32.h: Likewise.
      	* config/lm32/_udivmodsi4.c: Likewise.
      	* config/lm32/_mulsi3.c: Likewise.
      	* config/lm32/_modsi3.c: Likewise.
      	* config/lm32/_umodsi3.c: Likewise.
      	* config/lm32/_divsi3.c: Likewise.
      	* config/darwin-crt3.c: Likewise.
      	* config/msp430/mpy.c: Likewise.
      	* config/ia64/tf-signs.c: Likewise.
      	* config/ia64/fde-vms.c: Likewise.
      	* config/ia64/unwind-ia64.c: Likewise.
      	* config/ia64/vms-unwind.h: Likewise.
      	* config/ia64/sfp-exceptions.c: Likewise.
      	* config/ia64/quadlib.c: Likewise.
      	* config/ia64/unwind-ia64.h: Likewise.
      	* config/rl78/vregs.h: Likewise.
      	* config/arm/bpabi.c: Likewise.
      	* config/arm/unwind-arm.c: Likewise.
      	* config/arm/pr-support.c: Likewise.
      	* config/arm/linux-atomic.c: Likewise.
      	* config/arm/bpabi-lib.h: Likewise.
      	* config/frv/frvend.c: Likewise.
      	* config/frv/cmovw.c: Likewise.
      	* config/frv/frvbegin.c: Likewise.
      	* config/frv/cmovd.c: Likewise.
      	* config/frv/cmovh.c: Likewise.
      	* config/aarch64/cpuinfo.c: Likewise.
      	* config/i386/crtfastmath.c: Likewise.
      	* config/i386/cygming-crtend.c: Likewise.
      	* config/i386/32/tf-signs.c: Likewise.
      	* config/i386/crtprec.c: Likewise.
      	* config/i386/sfp-exceptions.c: Likewise.
      	* config/i386/w32-unwind.h: Likewise.
      	* config/m32r/initfini.c: Likewise.
      	* config/sparc/crtfastmath.c: Likewise.
      	* config/gcn/amdgcn_veclib.h: Likewise.
      	* config/nios2/linux-atomic.c: Likewise.
      	* config/nios2/linux-unwind.h: Likewise.
      	* config/nios2/lib2-mul.c: Likewise.
      	* config/nios2/lib2-nios2.h: Likewise.
      	* config/xtensa/unwind-dw2-xtensa.c: Likewise.
      	* config/rs6000/darwin-fallback.c: Likewise.
      	* config/rs6000/ibm-ldouble.c: Likewise.
      	* config/rs6000/sfp-machine.h: Likewise.
      	* config/rs6000/darwin-asm.h: Likewise.
      	* config/rs6000/darwin-crt2.c: Likewise.
      	* config/rs6000/aix-unwind.h: Likewise.
      	* config/rs6000/sfp-exceptions.c: Likewise.
      	* config/gthr-vxworks.c: Likewise.
      	* config/riscv/atomic.c: Likewise.
      	* config/visium/memcpy.c: Likewise.
      	* config/darwin-crt-tm.c: Likewise.
      	* config/stormy16/lib2funcs.c: Likewise.
      	* config/arc/ieee-754/divtab-arc-sf.c: Likewise.
      	* config/arc/ieee-754/divtab-arc-df.c: Likewise.
      	* config/arc/initfini.c: Likewise.
      	* config/sol2/gmon.c: Likewise.
      	* config/microblaze/divsi3_table.c: Likewise.
      	* config/m68k/fpgnulib.c: Likewise.
      	* libgcov-driver.c: Likewise.
      	* unwind-dw2.c: Likewise.
      	* fp-bit.c: Likewise.
      	* dfp-bit.h: Likewise.
      	* dfp-bit.c: Likewise.
      	* libgcov-driver-system.c: Likewise.
      libgcc/config/libbid/
      	* _le_td.c: Remove trailing whitespace.
      	* bid128_compare.c: Likewise.
      	* bid_div_macros.h: Likewise.
      	* bid64_to_bid128.c: Likewise.
      	* bid64_to_uint32.c: Likewise.
      	* bid128_to_uint64.c: Likewise.
      	* bid64_div.c: Likewise.
      	* bid128_round_integral.c: Likewise.
      	* bid_binarydecimal.c: Likewise.
      	* bid128_string.c: Likewise.
      	* bid_flag_operations.c: Likewise.
      	* bid128_to_int64.c: Likewise.
      	* _mul_sd.c: Likewise.
      	* bid64_mul.c: Likewise.
      	* bid128_noncomp.c: Likewise.
      	* _gt_dd.c: Likewise.
      	* bid64_add.c: Likewise.
      	* bid64_string.c: Likewise.
      	* bid_from_int.c: Likewise.
      	* bid128.c: Likewise.
      	* _ge_dd.c: Likewise.
      	* _ne_sd.c: Likewise.
      	* _dd_to_td.c: Likewise.
      	* _unord_sd.c: Likewise.
      	* bid64_to_uint64.c: Likewise.
      	* _gt_sd.c: Likewise.
      	* _sd_to_td.c: Likewise.
      	* _addsub_td.c: Likewise.
      	* _ne_td.c: Likewise.
      	* bid_dpd.c: Likewise.
      	* bid128_add.c: Likewise.
      	* bid128_next.c: Likewise.
      	* _lt_sd.c: Likewise.
      	* bid64_next.c: Likewise.
      	* bid128_mul.c: Likewise.
      	* _lt_dd.c: Likewise.
      	* _ge_td.c: Likewise.
      	* _unord_dd.c: Likewise.
      	* bid64_sqrt.c: Likewise.
      	* bid_sqrt_macros.h: Likewise.
      	* bid64_fma.c: Likewise.
      	* _sd_to_dd.c: Likewise.
      	* bid_conf.h: Likewise.
      	* bid64_noncomp.c: Likewise.
      	* bid_gcc_intrinsics.h: Likewise.
      	* _gt_td.c: Likewise.
      	* _ge_sd.c: Likewise.
      	* bid128_minmax.c: Likewise.
      	* bid128_quantize.c: Likewise.
      	* bid32_to_bid64.c: Likewise.
      	* bid_round.c: Likewise.
      	* _td_to_sd.c: Likewise.
      	* bid_inline_add.h: Likewise.
      	* bid128_fma.c: Likewise.
      	* _eq_td.c: Likewise.
      	* bid32_to_bid128.c: Likewise.
      	* bid64_rem.c: Likewise.
      	* bid128_2_str_tables.c: Likewise.
      	* _mul_dd.c: Likewise.
      	* _dd_to_sd.c: Likewise.
      	* bid128_div.c: Likewise.
      	* _lt_td.c: Likewise.
      	* bid64_compare.c: Likewise.
      	* bid64_to_int32.c: Likewise.
      	* _unord_td.c: Likewise.
      	* bid128_rem.c: Likewise.
      	* bid_internal.h: Likewise.
      	* bid64_to_int64.c: Likewise.
      	* _eq_dd.c: Likewise.
      	* _td_to_dd.c: Likewise.
      	* bid128_to_int32.c: Likewise.
      	* bid128_to_uint32.c: Likewise.
      	* _ne_dd.c: Likewise.
      	* bid64_quantize.c: Likewise.
      	* _le_dd.c: Likewise.
      	* bid64_round_integral.c: Likewise.
      	* _le_sd.c: Likewise.
      	* bid64_minmax.c: Likewise.
      libgcc/config/avr/libf7/
      	* f7-renames.h: Remove trailing whitespace.
      libstdc++-v3/
      	* include/debug/debug.h: Remove trailing whitespace.
      	* include/parallel/base.h: Likewise.
      	* include/parallel/types.h: Likewise.
      	* include/parallel/settings.h: Likewise.
      	* include/parallel/multiseq_selection.h: Likewise.
      	* include/parallel/partition.h: Likewise.
      	* include/parallel/random_number.h: Likewise.
      	* include/parallel/find_selectors.h: Likewise.
      	* include/parallel/partial_sum.h: Likewise.
      	* include/parallel/list_partition.h: Likewise.
      	* include/parallel/search.h: Likewise.
      	* include/parallel/algorithmfwd.h: Likewise.
      	* include/parallel/random_shuffle.h: Likewise.
      	* include/parallel/multiway_mergesort.h: Likewise.
      	* include/parallel/sort.h: Likewise.
      	* include/parallel/algobase.h: Likewise.
      	* include/parallel/numericfwd.h: Likewise.
      	* include/parallel/multiway_merge.h: Likewise.
      	* include/parallel/losertree.h: Likewise.
      	* include/bits/basic_ios.h: Likewise.
      	* include/bits/stringfwd.h: Likewise.
      	* include/bits/ostream_insert.h: Likewise.
      	* include/bits/stl_heap.h: Likewise.
      	* include/bits/unordered_map.h: Likewise.
      	* include/bits/hashtable_policy.h: Likewise.
      	* include/bits/stl_iterator_base_funcs.h: Likewise.
      	* include/bits/valarray_before.h: Likewise.
      	* include/bits/regex.h: Likewise.
      	* include/bits/postypes.h: Likewise.
      	* include/bits/stl_iterator.h: Likewise.
      	* include/bits/localefwd.h: Likewise.
      	* include/bits/stl_algo.h: Likewise.
      	* include/bits/ios_base.h: Likewise.
      	* include/bits/stl_function.h: Likewise.
      	* include/bits/basic_string.h: Likewise.
      	* include/bits/hashtable.h: Likewise.
      	* include/bits/valarray_after.h: Likewise.
      	* include/bits/char_traits.h: Likewise.
      	* include/bits/gslice.h: Likewise.
      	* include/bits/locale_facets_nonio.h: Likewise.
      	* include/bits/mask_array.h: Likewise.
      	* include/bits/specfun.h: Likewise.
      	* include/bits/random.h: Likewise.
      	* include/bits/slice_array.h: Likewise.
      	* include/bits/valarray_array.h: Likewise.
      	* include/tr1/float.h: Likewise.
      	* include/tr1/functional_hash.h: Likewise.
      	* include/tr1/math.h: Likewise.
      	* include/tr1/hashtable_policy.h: Likewise.
      	* include/tr1/stdio.h: Likewise.
      	* include/tr1/complex.h: Likewise.
      	* include/tr1/stdbool.h: Likewise.
      	* include/tr1/stdarg.h: Likewise.
      	* include/tr1/inttypes.h: Likewise.
      	* include/tr1/fenv.h: Likewise.
      	* include/tr1/stdlib.h: Likewise.
      	* include/tr1/wchar.h: Likewise.
      	* include/tr1/tgmath.h: Likewise.
      	* include/tr1/limits.h: Likewise.
      	* include/tr1/wctype.h: Likewise.
      	* include/tr1/stdint.h: Likewise.
      	* include/tr1/ctype.h: Likewise.
      	* include/tr1/random.h: Likewise.
      	* include/tr1/shared_ptr.h: Likewise.
      	* include/ext/mt_allocator.h: Likewise.
      	* include/ext/sso_string_base.h: Likewise.
      	* include/ext/debug_allocator.h: Likewise.
      	* include/ext/vstring_fwd.h: Likewise.
      	* include/ext/pointer.h: Likewise.
      	* include/ext/pod_char_traits.h: Likewise.
      	* include/ext/malloc_allocator.h: Likewise.
      	* include/ext/vstring.h: Likewise.
      	* include/ext/bitmap_allocator.h: Likewise.
      	* include/ext/pool_allocator.h: Likewise.
      	* include/ext/type_traits.h: Likewise.
      	* include/ext/ropeimpl.h: Likewise.
      	* include/ext/codecvt_specializations.h: Likewise.
      	* include/ext/throw_allocator.h: Likewise.
      	* include/ext/extptr_allocator.h: Likewise.
      	* include/ext/atomicity.h: Likewise.
      	* include/ext/concurrence.h: Likewise.
      	* include/c_compatibility/wchar.h: Likewise.
      	* include/c_compatibility/stdint.h: Likewise.
      	* include/backward/hash_fun.h: Likewise.
      	* include/backward/binders.h: Likewise.
      	* include/backward/hashtable.h: Likewise.
      	* include/backward/auto_ptr.h: Likewise.
      	* libsupc++/eh_arm.cc: Likewise.
      	* libsupc++/unwind-cxx.h: Likewise.
      	* libsupc++/si_class_type_info.cc: Likewise.
      	* libsupc++/vec.cc: Likewise.
      	* libsupc++/class_type_info.cc: Likewise.
      	* libsupc++/vmi_class_type_info.cc: Likewise.
      	* libsupc++/guard_error.cc: Likewise.
      	* libsupc++/bad_typeid.cc: Likewise.
      	* libsupc++/eh_personality.cc: Likewise.
      	* libsupc++/atexit_arm.cc: Likewise.
      	* libsupc++/pmem_type_info.cc: Likewise.
      	* libsupc++/vterminate.cc: Likewise.
      	* libsupc++/eh_terminate.cc: Likewise.
      	* libsupc++/bad_cast.cc: Likewise.
      	* libsupc++/exception_ptr.h: Likewise.
      	* libsupc++/eh_throw.cc: Likewise.
      	* libsupc++/bad_alloc.cc: Likewise.
      	* libsupc++/nested_exception.cc: Likewise.
      	* libsupc++/pointer_type_info.cc: Likewise.
      	* libsupc++/pbase_type_info.cc: Likewise.
      	* libsupc++/bad_array_new.cc: Likewise.
      	* libsupc++/pure.cc: Likewise.
      	* libsupc++/eh_exception.cc: Likewise.
      	* libsupc++/bad_array_length.cc: Likewise.
      	* libsupc++/cxxabi.h: Likewise.
      	* libsupc++/guard.cc: Likewise.
      	* libsupc++/eh_catch.cc: Likewise.
      	* libsupc++/cxxabi_forced.h: Likewise.
      	* libsupc++/tinfo.h: Likewise.
      45ab93d9
  4. Oct 23, 2024
    • Jakub Jelinek's avatar
      libcpp: Add -Wleading-whitespace= warning · d4499a23
      Jakub Jelinek authored
      The following patch on top of the r15-4346 patch adds
      -Wleading-whitespace= warning option.
      This warning doesn't care how much one actually indents which line
      in the source (that is something that can't be easily done in the
      preprocessor without doing syntactic analysis), but just simple checks
      on what kind of whitespace is used in the indentation.
      I think it is still useful to get warnings about such issues early,
      while git diagnoses some of it in patches (e.g. the tab after space
      case), getting the warnings earlier might help avoiding such issues
      sooner.
      
      There are projects which ban use of tabs and require just spaces,
      others which require indentation just with horizontal tabs, and finally
      projects which want indentation with tabs for multiples of tabstop size
      followed by spaces (fewer than tabstop size), like GCC.
      For all 3 kinds the warning diagnoses indentation with '\v' or '\f'
      characters (unless line contains just whitespace), and for the last one
      also cases where a space in the indentation is followed by horizontal
      tab or where there are N or more consecutive spaces in the indentation
      (for -ftabstop=N).
      
      BTW, for additional testing I've enabled the warnings (without -Werror
      for them) in stage3.  There are many warnings (both trailing and leading
      whitespace), some of them something that can be easily fixed in the headers
      or source files, but others with whitespace issues in generated sources,
      so if we enable the warnings, either we'd need to adjust the generators
      or disable the warnings in (some of the) generated files.
      
      2024-10-23  Jakub Jelinek  <jakub@redhat.com>
      
      libcpp/
      	* include/cpplib.h (struct cpp_options): Add
      	cpp_warn_leading_whitespace and cpp_tabstop members.
      	(enum cpp_warning_reason): Add CPP_W_LEADING_WHITESPACE.
      	* internal.h (struct _cpp_line_note): Document new
      	line note kinds.
      	* init.cc (cpp_create_reader): Set cpp_tabstop to 8.
      	* lex.cc (find_leading_whitespace_issues): New function.
      	(_cpp_clean_line): Use it.
      	(_cpp_process_line_notes): Handle 'L', 'S' and 'T' line notes.
      	(lex_raw_string): Clear type on 'L', 'S' and 'T' line notes
      	inside of raw string literals.
      gcc/
      	* doc/invoke.texi (Wleading-whitespace=): Document.
      gcc/c-family/
      	* c.opt (Wleading-whitespace=): New option.
      	* c-opts.cc (c_common_post_options): Set cpp_opts->cpp_tabstop
      	to global_dc->m_tabstop.
      gcc/testsuite/
      	* c-c++-common/cpp/Wleading-whitespace-1.c: New test.
      	* c-c++-common/cpp/Wleading-whitespace-2.c: New test.
      	* c-c++-common/cpp/Wleading-whitespace-3.c: New test.
      	* c-c++-common/cpp/Wleading-whitespace-4.c: New test.
      d4499a23
  5. Oct 15, 2024
    • Jakub Jelinek's avatar
      libcpp: Add -Wtrailing-blanks warning · ac615e10
      Jakub Jelinek authored
      Trailing blanks is something even git diff diagnoses; while it is a coding
      style issue, if it is so common that git diff diagnoses it, I think it could
      be useful to various projects to check that at compile time.
      
      Dunno if it should be included in -Wextra, currently it isn't, and due to
      tons of trailing whitespace in our sources, haven't enabled it for when
      building gcc itself either.
      
      Note, git diff also diagnoses indentation with tab following space, wonder
      if we couldn't have trivial warning options where one would simply ask for
      checking of indentation with no tabs, just spaces vs. indentation with
      tabs followed by spaces (but never tab width or more spaces in the
      indentation).  I think that would be easy to do also on the libcpp side.
      Checking how much something should be exactly indented requires syntax
      analysis (at least some limited one) and can consider columns of first token
      on line, but what the exact indentation blanks were is something only libcpp
      knows.
      
      On Thu, Sep 19, 2024 at 08:17:24AM +0200, Richard Biener wrote:
      > Generally I like diagnosing this early.  For the above I'd say -Wtrailing-whitespace=
      > with a set of things to diagnose (and a sane default - just spaces and tabs - for
      > -Wtrailiing-whitespace) would be nice.  As for naming possibly follow the
      > is{space,blank,cntrl} character classifications?  If those are a good
      > fit, that is.
      
      The patch currently allows blank (' ' '\t') and space (' ' '\t' '\f' '\v'),
      cntrl not yet added, not anything non-ASCII, but in theory could
      be added later (though, non-ASCII would be just for inside of comments,
      say non-breaking space etc. in the source is otherwise an error).
      
      2024-10-15  Jakub Jelinek  <jakub@redhat.com>
      
      libcpp/
      	* include/cpplib.h (struct cpp_options): Add
      	cpp_warn_trailing_whitespace member.
      	(enum cpp_warning_reason): Add CPP_W_TRAILING_WHITESPACE.
      	* internal.h (struct _cpp_line_note): Document 'W' line note.
      	* lex.cc (_cpp_clean_line): Add 'W' line note for trailing whitespace
      	except for trailing whitespace after backslash.  Formatting fix.
      	(_cpp_process_line_notes): Emit -Wtrailing-whitespace diagnostics.
      	Formatting fixes.
      	(lex_raw_string): Clear type on 'W' notes.
      gcc/
      	* doc/invoke.texi (Wtrailing-whitespace): Document.
      gcc/c-family/
      	* c.opt (Wtrailing-whitespace=): New option.
      	(Wtrailing-whitespace): New alias.
      	* c.opt.urls: Regenerate.
      gcc/testsuite/
      	* c-c++-common/cpp/Wtrailing-whitespace-1.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-2.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-3.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-4.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-5.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-6.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-7.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-8.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-9.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-10.c: New test.
      ac615e10
  6. Oct 14, 2024
    • Jason Merrill's avatar
      libcpp: avoid extra spaces in module preprocessing · 2c08ddd3
      Jason Merrill authored
      Within the compiler, module keywords "import", "module", and "export" that
      are recognized as part of module directives gain an extra trailing space to
      distinguish them from other non-keyword uses of those words in the code.
      But when dumping preprocessed output, printing those spaces creates a
      gratuitous inconsistency with non-modules preprocessing, as revealed by
      several of the g++.dg/modules/cpp* tests if modules are enabled by default
      in C++20 mode.
      
      libcpp/ChangeLog:
      
      	* lex.cc (cpp_output_token): Omit terminal space from name.
      
      gcc/testsuite/ChangeLog:
      
      	* g++.dg/modules/cpp-2_c.C: Expect only one space after import.
      	* g++.dg/modules/cpp-5_c.C
      	* g++.dg/modules/dep-2.C
      	* g++.dg/modules/dir-only-2_b.C
      	* g++.dg/modules/pr99050_b.C
      	* g++.dg/modules/inc-xlate-1_b.H
      	* g++.dg/modules/legacy-3_b.H
      	* g++.dg/modules/legacy-3_c.H: Likewise.
      2c08ddd3
    • Lewis Hyatt's avatar
      libcpp: Support extended characters for #pragma {push,pop}_macro [PR109704] · 998eb2a1
      Lewis Hyatt authored
      The implementation of #pragma push_macro and #pragma pop_macro has to date
      made use of an ad-hoc function, _cpp_lex_identifier(), which lexes an
      identifier out of a string. When support was added for extended characters
      in identifiers ($, UCNs, or UTF-8), that support was added only for the
      "normal" way of lexing identifiers out of a cpp_buffer (_cpp_lex_direct) and
      not for the ad-hoc way. Consequently, extended identifiers are not usable
      with these pragmas.
      
      The logic for lexing identifiers has become more complicated than it was
      when _cpp_lex_identifier() was written -- it now handles things like \N{}
      escapes in C++, for instance -- and it no longer seems practical to maintain
      a redundant code path for lexing identifiers. Address the issue by changing
      the implementation of #pragma {push,pop}_macro to lex identifiers in the
      expected way, i.e. by pushing a cpp_buffer and lexing the identifier from
      there.
      
      The existing implementation has some quirks because of the ad-hoc parsing
      logic. For example:
      
       #pragma push_macro("X ")
       ...
       #pragma pop_macro("X")
      
      will not restore macro X (note the extra space in the first string). However:
      
       #pragma push_macro("X ")
       ...
       #pragma pop_macro("X ")
      
      actually does sucessfully restore "X". This is because the key for looking
      up the saved macro on the push stack is the original string passed, so the
      string passed to pop_macro needs to match it exactly. It is not that easy to
      reproduce this logic in the world of extended characters, given that for
      example it should be valid to pass a UCN to push_macro, and the
      corresponding UTF-8 to pop_macro. Given that this aspect of the existing
      behavior seems unintentional and has no tests (and does not match other
      implementations), I opted to make the new logic more straightforward. The
      string passed needs to lex to one token, which must be a valid identifier,
      or else no action is taken and no error is generated. Any diagnostics
      encountered during lexing (e.g., due to a UTF-8 character not permitted to
      appear in an identifier) are also suppressed.
      
      It could be nice (for GCC 15) to also add a warning if a pop_macro does not
      match a previous push_macro.
      
      libcpp/ChangeLog:
      
      	PR preprocessor/109704
      	* include/cpplib.h (class cpp_auto_suppress_diagnostics): New class.
      	* errors.cc
      	(cpp_auto_suppress_diagnostics::cpp_auto_suppress_diagnostics): New
      	function.
      	(cpp_auto_suppress_diagnostics::~cpp_auto_suppress_diagnostics): New
      	function.
      	* charset.cc (noop_diagnostic_cb): Remove.
      	(cpp_interpret_string_ranges): Refactor diagnostic suppression logic
      	into new class cpp_auto_suppress_diagnostics.
      	(count_source_chars): Likewise.
      	* directives.cc (cpp_pop_definition): Add cpp_hashnode argument.
      	(lex_identifier_from_string): New static helper function.
      	(push_pop_macro_common): Refactor common logic from
      	do_pragma_push_macro and do_pragma_pop_macro; use
      	lex_identifier_from_string instead of _cpp_lex_identifier.
      	(do_pragma_push_macro): Reimplement using push_pop_macro_common.
      	(do_pragma_pop_macro): Likewise.
      	* internal.h (_cpp_lex_identifier): Remove.
      	* lex.cc (lex_identifier_intern): Remove.
      	(_cpp_lex_identifier): Remove.
      
      gcc/testsuite/ChangeLog:
      
      	PR preprocessor/109704
      	* c-c++-common/cpp/pragma-push-pop-utf8.c: New test.
      	* g++.dg/pch/pushpop-2.C: New test.
      	* g++.dg/pch/pushpop-2.Hs: New test.
      	* gcc.dg/pch/pushpop-2.c: New test.
      	* gcc.dg/pch/pushpop-2.hs: New test.
      998eb2a1
  7. Oct 12, 2024
    • Jakub Jelinek's avatar
      libcpp, genmatch: Use gcc_diag instead of printf for libcpp diagnostics · c397a8c1
      Jakub Jelinek authored
      When working on #embed support, or -Wheader-guard or other recent libcpp
      changes, I've been annoyed by the libcpp diagnostics being visually
      different from normal gcc diagnostics, especially in the area of quoting
      stuff in the diagnostic messages.
      Normall GCC diagnostics is gcc_diag/gcc_tdiag, one can use
      %</%>, %qs etc. in there, while libcpp diagnostics was marked as printf
      and in libcpp we've been very creative with quoting stuff, either
      no quotes at all, or "something" quoting, or 'something' quoting, or
      `something' quoting (but in none of the cases it used colors consistently
      with the rest of the compiler).
      
      Now, libcpp diagnostics is always emitted using a callback,
      pfile->cb.diagnostic.  On the gcc/ side, this callback is initialized with
      genmatch.cc:  cb->diagnostic = diagnostic_cb;
      c-family/c-opts.cc:  cb->diagnostic = c_cpp_diagnostic;
      fortran/cpp.cc:  cb->diagnostic = cb_cpp_diagnostic;
      where the latter two just use diagnostic_report_diagnostic, so actually
      support all the gcc_diag stuff, only the genmatch.cc case didn't.
      
      So, the following patch changes genmatch.cc to use pp_format* instead
      of vfprintf so that it supports the gcc_diag formatting (pretty-print.o
      unfortunately has various dependencies, so had to link genmatch with
      libcommon.a libbacktrace.a and tweak Makefile.in so that there are no
      circular dependencies) and marks the libcpp diagnostic routines as
      gcc_diag rather than printf.  That change resulted in hundreds of
      -Wformat-diag new warnings (most of them useful and resulting IMHO in
      better diagnostics), so the rest of the patch is changing the format
      strings to make -Wformat-diag happy and adjusting the testsuite for
      the differences in how is the diagnostic reformatted.
      
      Dunno if some out of GCC tree projects use libcpp, that case would
      make it harder because one couldn't use vfprintf in the diagnostic
      callback anymore, but there is always David's libdiagnostic which could
      be used for that purpose IMHO.
      
      2024-10-12  Jakub Jelinek  <jakub@redhat.com>
      
      libcpp/
      	* include/cpplib.h (ATTRIBUTE_CPP_PPDIAG): Define.
      	(struct cpp_callbacks): Use ATTRIBUTE_CPP_PPDIAG instead of
      	ATTRIBUTE_FPTR_PRINTF on diagnostic callback.
      	(cpp_error, cpp_warning, cpp_pedwarning, cpp_warning_syshdr): Use
      	ATTRIBUTE_CPP_PPDIAG (3, 4) instead of ATTRIBUTE_PRINTF_3.
      	(cpp_warning_at, cpp_pedwarning_at): Use ATTRIBUTE_CPP_PPDIAG (4, 5)
      	instead of ATTRIBUTE_PRINTF_4.
      	(cpp_error_with_line, cpp_warning_with_line, cpp_pedwarning_with_line,
      	cpp_warning_with_line_syshdr): Use ATTRIBUTE_CPP_PPDIAG (5, 6)
      	instead of ATTRIBUTE_PRINTF_5.
      	(cpp_error_at): Use ATTRIBUTE_CPP_PPDIAG (4, 5) instead of
      	ATTRIBUTE_PRINTF_4.
      	* Makefile.in (po/$(PACKAGE).pot): Use --language=GCC-source rather
      	than --language=c.
      	* errors.cc (cpp_diagnostic_at, cpp_diagnostic,
      	cpp_diagnostic_with_line): Use ATTRIBUTE_CPP_PPDIAG instead of
      	-ATTRIBUTE_FPTR_PRINTF.
      	* charset.cc (cpp_host_to_exec_charset, _cpp_valid_ucn, convert_hex,
      	convert_oct, convert_escape): Fix up -Wformat-diag warnings.
      	(cpp_interpret_string_ranges, count_source_chars): Use
      	ATTRIBUTE_CPP_PPDIAG instead of ATTRIBUTE_FPTR_PRINTF.
      	(narrow_str_to_charconst): Fix up -Wformat-diag warnings.
      	* directives.cc (check_eol_1, directive_diagnostics, lex_macro_node,
      	do_undef, glue_header_name, parse_include, do_include_common,
      	do_include_next, _cpp_parse_embed_params, do_embed, read_flag,
      	do_line, do_linemarker, register_pragma_1, do_pragma_once,
      	do_pragma_push_macro, do_pragma_pop_macro, do_pragma_poison,
      	do_pragma_system_header, do_pragma_warning_or_error, _cpp_do__Pragma,
      	do_else, do_elif, do_endif, parse_answer, do_assert,
      	cpp_define_unused): Likewise.
      	* expr.cc (cpp_classify_number, parse_defined, eval_token,
      	_cpp_parse_expr, reduce, check_promotion): Likewise.
      	* files.cc (_cpp_find_file, finish_base64_embed,
      	_cpp_pop_file_buffer): Likewise.
      	* init.cc (sanity_checks): Likewise.
      	* lex.cc (_cpp_process_line_notes, maybe_warn_bidi_on_char,
      	_cpp_warn_invalid_utf8, _cpp_skip_block_comment,
      	warn_about_normalization, forms_identifier_p, maybe_va_opt_error,
      	identifier_diagnostics_on_lex, cpp_maybe_module_directive): Likewise.
      	* macro.cc (class vaopt_state, builtin_has_include_1,
      	builtin_has_include, builtin_has_embed, _cpp_warn_if_unused_macro,
      	_cpp_builtin_macro_text, builtin_macro, stringify_arg,
      	_cpp_arguments_ok, collect_args, enter_macro_context,
      	_cpp_save_parameter, parse_params, create_iso_definition,
      	_cpp_create_definition, check_trad_stringification): Likewise.
      	* pch.cc (cpp_valid_state): Likewise.
      	* traditional.cc (_cpp_scan_out_logical_line, recursive_macro):
      	Likewise.
      gcc/
      	* Makefile.in (generated_files): Remove {gimple,generic}-match*.
      	(generated_match_files): New variable.  Add a dependency of
      	$(filter-out $(OBJS-libcommon),$(ALL_HOST_OBJS)) files on those.
      	(build/genmatch$(build_exeext)): Depend on and link against
      	libcommon.a and $(LIBBACKTRACE).
      	* genmatch.cc: Include pretty-print.h and input.h.
      	(ggc_internal_cleared_alloc, ggc_free): Remove.
      	(fatal): New function.
      	(line_table): Remove.
      	(linemap_client_expand_location_to_spelling_point): Remove.
      	(diagnostic_cb): Use gcc_diag rather than printf format.  Use
      	pp_format_verbatim on a temporary pretty_printer instead of
      	vfprintf.
      	(fatal_at, warning_at): Use gcc_diag rather than printf format.
      	(output_line_directive): Rename location_hash to loc_hash.
      	(parser::eat_ident, parser::parse_operation, parser::parse_expr,
      	parser::parse_pattern, parser::finish_match_operand): Fix up
      	-Wformat-diag warnings.
      gcc/c-family/
      	* c-lex.cc (c_common_has_attribute,
      	c_common_lex_availability_macro): Fix up -Wformat-diag warnings.
      gcc/testsuite/
      	* c-c++-common/cpp/counter-2.c: Adjust expected diagnostics for
      	libcpp diagnostic formatting changes.
      	* c-c++-common/cpp/embed-3.c: Likewise.
      	* c-c++-common/cpp/embed-4.c: Likewise.
      	* c-c++-common/cpp/embed-16.c: Likewise.
      	* c-c++-common/cpp/embed-18.c: Likewise.
      	* c-c++-common/cpp/eof-2.c: Likewise.
      	* c-c++-common/cpp/eof-3.c: Likewise.
      	* c-c++-common/cpp/fmax-include-depth.c: Likewise.
      	* c-c++-common/cpp/has-builtin.c: Likewise.
      	* c-c++-common/cpp/line-2.c: Likewise.
      	* c-c++-common/cpp/line-3.c: Likewise.
      	* c-c++-common/cpp/macro-arg-count-1.c: Likewise.
      	* c-c++-common/cpp/macro-arg-count-2.c: Likewise.
      	* c-c++-common/cpp/macro-ranges.c: Likewise.
      	* c-c++-common/cpp/named-universal-char-escape-4.c: Likewise.
      	* c-c++-common/cpp/named-universal-char-escape-5.c: Likewise.
      	* c-c++-common/cpp/pr88974.c: Likewise.
      	* c-c++-common/cpp/va-opt-error.c: Likewise.
      	* c-c++-common/cpp/va-opt-pedantic.c: Likewise.
      	* c-c++-common/cpp/Wheader-guard-2.c: Likewise.
      	* c-c++-common/cpp/Wheader-guard-3.c: Likewise.
      	* c-c++-common/cpp/Winvalid-utf8-1.c: Likewise.
      	* c-c++-common/cpp/Winvalid-utf8-2.c: Likewise.
      	* c-c++-common/cpp/Winvalid-utf8-3.c: Likewise.
      	* c-c++-common/diagnostic-format-sarif-file-bad-utf8-pr109098-1.c:
      	Likewise.
      	* c-c++-common/diagnostic-format-sarif-file-bad-utf8-pr109098-3.c:
      	Likewise.
      	* c-c++-common/pr68833-3.c: Likewise.
      	* c-c++-common/raw-string-directive-1.c: Likewise.
      	* gcc.dg/analyzer/named-constants-Wunused-macros.c: Likewise.
      	* gcc.dg/binary-constants-4.c: Likewise.
      	* gcc.dg/builtin-redefine.c: Likewise.
      	* gcc.dg/cpp/19951025-1.c: Likewise.
      	* gcc.dg/cpp/c11-warning-1.c: Likewise.
      	* gcc.dg/cpp/c11-warning-2.c: Likewise.
      	* gcc.dg/cpp/c11-warning-3.c: Likewise.
      	* gcc.dg/cpp/c23-elifdef-2.c: Likewise.
      	* gcc.dg/cpp/c23-warning-2.c: Likewise.
      	* gcc.dg/cpp/embed-2.c: Likewise.
      	* gcc.dg/cpp/embed-3.c: Likewise.
      	* gcc.dg/cpp/embed-4.c: Likewise.
      	* gcc.dg/cpp/expr.c: Likewise.
      	* gcc.dg/cpp/gnu11-elifdef-2.c: Likewise.
      	* gcc.dg/cpp/gnu11-elifdef-3.c: Likewise.
      	* gcc.dg/cpp/gnu11-elifdef-4.c: Likewise.
      	* gcc.dg/cpp/gnu11-warning-1.c: Likewise.
      	* gcc.dg/cpp/gnu11-warning-2.c: Likewise.
      	* gcc.dg/cpp/gnu11-warning-3.c: Likewise.
      	* gcc.dg/cpp/gnu23-warning-2.c: Likewise.
      	* gcc.dg/cpp/include6.c: Likewise.
      	* gcc.dg/cpp/pr35322.c: Likewise.
      	* gcc.dg/cpp/tr-warn6.c: Likewise.
      	* gcc.dg/cpp/undef2.c: Likewise.
      	* gcc.dg/cpp/warn-comments.c: Likewise.
      	* gcc.dg/cpp/warn-comments-2.c: Likewise.
      	* gcc.dg/cpp/warn-comments-3.c: Likewise.
      	* gcc.dg/cpp/warn-cxx-compat.c: Likewise.
      	* gcc.dg/cpp/warn-cxx-compat-2.c: Likewise.
      	* gcc.dg/cpp/warn-deprecated.c: Likewise.
      	* gcc.dg/cpp/warn-deprecated-2.c: Likewise.
      	* gcc.dg/cpp/warn-long-long.c: Likewise.
      	* gcc.dg/cpp/warn-long-long-2.c: Likewise.
      	* gcc.dg/cpp/warn-normalized-1.c: Likewise.
      	* gcc.dg/cpp/warn-normalized-2.c: Likewise.
      	* gcc.dg/cpp/warn-normalized-3.c: Likewise.
      	* gcc.dg/cpp/warn-normalized-4-bytes.c: Likewise.
      	* gcc.dg/cpp/warn-normalized-4-unicode.c: Likewise.
      	* gcc.dg/cpp/warn-redefined.c: Likewise.
      	* gcc.dg/cpp/warn-redefined-2.c: Likewise.
      	* gcc.dg/cpp/warn-traditional.c: Likewise.
      	* gcc.dg/cpp/warn-traditional-2.c: Likewise.
      	* gcc.dg/cpp/warn-trigraphs-1.c: Likewise.
      	* gcc.dg/cpp/warn-trigraphs-2.c: Likewise.
      	* gcc.dg/cpp/warn-trigraphs-3.c: Likewise.
      	* gcc.dg/cpp/warn-trigraphs-4.c: Likewise.
      	* gcc.dg/cpp/warn-undef.c: Likewise.
      	* gcc.dg/cpp/warn-undef-2.c: Likewise.
      	* gcc.dg/cpp/warn-unused-macros.c: Likewise.
      	* gcc.dg/cpp/warn-unused-macros-2.c: Likewise.
      	* gcc.dg/pch/counter-2.c: Likewise.
      	* g++.dg/cpp0x/udlit-error1.C: Likewise.
      	* g++.dg/cpp23/named-universal-char-escape1.C: Likewise.
      	* g++.dg/cpp23/named-universal-char-escape2.C: Likewise.
      	* g++.dg/cpp23/Winvalid-utf8-1.C: Likewise.
      	* g++.dg/cpp23/Winvalid-utf8-2.C: Likewise.
      	* g++.dg/cpp23/Winvalid-utf8-3.C: Likewise.
      	* g++.dg/cpp23/Winvalid-utf8-4.C: Likewise.
      	* g++.dg/cpp23/Winvalid-utf8-5.C: Likewise.
      	* g++.dg/cpp23/Winvalid-utf8-6.C: Likewise.
      	* g++.dg/cpp23/Winvalid-utf8-7.C: Likewise.
      	* g++.dg/cpp23/Winvalid-utf8-8.C: Likewise.
      	* g++.dg/cpp23/Winvalid-utf8-9.C: Likewise.
      	* g++.dg/cpp23/Winvalid-utf8-10.C: Likewise.
      	* g++.dg/cpp23/Winvalid-utf8-11.C: Likewise.
      	* g++.dg/cpp23/Winvalid-utf8-12.C: Likewise.
      	* g++.dg/cpp/elifdef-3.C: Likewise.
      	* g++.dg/cpp/elifdef-5.C: Likewise.
      	* g++.dg/cpp/elifdef-6.C: Likewise.
      	* g++.dg/cpp/elifdef-7.C: Likewise.
      	* g++.dg/cpp/embed-1.C: Likewise.
      	* g++.dg/cpp/embed-2.C: Likewise.
      	* g++.dg/cpp/pedantic-errors.C: Likewise.
      	* g++.dg/cpp/warning-1.C: Likewise.
      	* g++.dg/cpp/warning-2.C: Likewise.
      	* g++.dg/ext/bitint1.C: Likewise.
      	* g++.dg/ext/bitint2.C: Likewise.
      c397a8c1
  8. Sep 12, 2024
    • Jason Merrill's avatar
      libcpp: adjust pedwarn handling · c5009eb8
      Jason Merrill authored
      Using cpp_pedwarning (CPP_W_PEDANTIC instead of if (CPP_PEDANTIC cpp_error
      lets users suppress these diagnostics with
       #pragma GCC diagnostic ignored "-Wpedantic".
      
      This patch changes all instances of the cpp_error (CPP_DL_PEDWARN to
      cpp_pedwarning.  In cases where the extension appears in a later C++
      revision, we now condition the warning on the relevant -Wc++??-extensions
      flag instead of -Wpedantic; in such cases often the if (CPP_PEDANTIC) check
      is retained to preserve the default non-warning behavior.
      
      I didn't attempt to adjust the warning flags for the C compiler, since it
      seems to follow a different system than C++.
      
      The CPP_PEDANTIC check is also kept in _cpp_lex_direct to avoid an ICE in
      the self-tests from cb.diagnostics not being initialized.
      
      While working on testcases for these changes I noticed that the c-c++-common
      tests are not run with -pedantic-errors by default like the gcc.dg and
      g++.dg directories are.  And if I specify -pedantic-errors with dg-options,
      the default -std= changes from c++?? to gnu++??, which interferes with some
      other pedwarns.  So two of the tests are C++-only.
      
      libcpp/ChangeLog:
      
      	* include/cpplib.h (enum cpp_warning_reason): Add
      	CPP_W_CXX{14,17,20,23}_EXTENSIONS.
      	* charset.cc (_cpp_valid_ucn, convert_hex, convert_oct)
      	(convert_escape, narrow_str_to_charconst): Use cpp_pedwarning
      	instead of cpp_error for pedwarns.
      	* directives.cc (directive_diagnostics, _cpp_handle_directive)
      	(do_line, do_elif): Likewise.
      	* expr.cc (cpp_classify_number, eval_token): Likewise.
      	* lex.cc (skip_whitespace, maybe_va_opt_error)
      	(_cpp_lex_direct): Likewise.
      	* macro.cc (_cpp_arguments_ok): Likewise.
      	(replace_args): Use -Wvariadic-macros for pedwarn about
      	empty macro arguments.
      
      gcc/c-family/ChangeLog:
      
      	* c.opt: Add CppReason for Wc++{14,17,20,23}-extensions.
      	* c-pragma.cc (handle_pragma_diagnostic_impl): Don't check
      	OPT_Wc__23_extensions.
      
      gcc/testsuite/ChangeLog:
      
      	* c-c++-common/pragma-diag-17.c: New test.
      	* g++.dg/cpp0x/va-opt1.C: New test.
      	* g++.dg/cpp23/named-universal-char-escape3.C: New test.
      c5009eb8
    • Jakub Jelinek's avatar
      libcpp, c-family: Add (dumb) C23 N3017 #embed support [PR105863] · eba6d2aa
      Jakub Jelinek authored
      The following patch implements the C23 N3017 "#embed - a scannable,
      tooling-friendly binary resource inclusion mechanism" paper.
      
      The implementation is intentionally dumb, in that it doesn't significantly
      speed up compilation of larger initializers and doesn't make it possible
      to use huge #embeds (like several gigabytes large, that is compile time
      and memory still infeasible).
      There are 2 reasons for this.  One is that I think like it is implemented
      now in the patch is how we should use it for the smaller #embed sizes,
      dunno with which boundary, whether 32 bytes or 64 or something like that,
      certainly handling the single byte cases which is something that can appear
      anywhere in the source where constant integer literal can appear is
      desirable and I think for a few bytes it isn't worth it to come up with
      something smarter and users would like to e.g. see it in -E readably as
      well (perhaps the slow vs. fast boundary should be determined by command
      line option).  And the other one is to be able to more easily find
      regressions in behavior caused by the optimizations, so we have something
      to get back in git to compare against.
      I'm definitely willing to work on the optimizations (likely introduce a new
      CPP_* token type to refer to a range of libcpp owned memory (start + size)
      and similarly some tree which can do the same, and can be at any time e.g.
      split into 2 subparts + say INTEGER_CST in between if needed say for
      const unsigned char d[] = {
       #embed "2GB.dat" prefix (0, 0, ) suffix (, [0x40000000] = 42)
      }; still without having to copy around huge amounts of data; STRING_CST
      owns the memory it points to and can be only 2GB in size), but would
      like to do that incrementally.
      And would like to first include some extensions also not included in
      this patch, like gnu::offset (off) parameter to allow to skip certain
      constant amount of bytes at the start of the files, plus
      gnu::base64 ("base64_encoded_data") parameter to add something which can
      store more efficiently large amounts of the #embed data in preprocessed
      source.
      
      I've been cross-checking all the tests also against the LLVM implementation
      https://github.com/llvm/llvm-project/pull/68620
      which has been for a few hours even committed to LLVM trunk but reverted
      afterwards.  LLVM now has the support committed and I admit I haven't
      rechecked whether the behavior on the below mentioned spots have been fixed
      in it already or not yet.
      
      The patch uses --embed-dir= option that clang plans to add above and doesn't
      use other variants on the search directories yet, plus there are no
      default directories at least for the time being where to search for embed
      files.  So, #embed "..." works if it is found in the same directory (or
      relative to the current file's directory) and #embed "/..." or #embed </...>
      work always, but relative #embed <...> doesn't unless at least one
      --embed-dir= is specified.  There is no reason to differentiate between
      system and non-system directories, so we don't need -isystem like
      counterpart, perhaps -iquote like counterpart could be useful in the future,
      dunno what else.  It has --embed-directory=dir and --embed-directory dir
      as aliases.
      
      There are some differences beyond clang ICEs, so I'd like to point them out
      to make sure there is agreement on the choices in the patch.  They are also
      mentioned in the comments of the llvm pull request.
      
      The most important is that the GCC patch (as well as the original thephd.dev
      LLVM branch on godbolt) expands #embed (or acts as if it is expanded) into
      a mere sequence of numbers like 123,2,35,26 rather then what clang
      effectively treats as (unsigned char)123,(unsigned char)2,(unsigned
      char)35,(unsigned char)26 but only does that when using integrated
      preprocessor, not when using -save-temps where it acts as GCC.
      JeanHeyd as the original author agrees that is how it is currently worded in
      C23.
      
      Another difference (not tested in the testsuite, not sure how to check for
      effective target /dev/urandom nor am sure it is desirable to check that
      during testsuite) is how to treat character devices, named pipes etc.
      (block devices are errored on).  The original paper uses /dev/urandom
      in various examples and seems to assume that unlike regular files the
      devices aren't really cached, so
       #embed </dev/urandom> limit(1) prefix(int a = ) suffix(;)
       #embed </dev/urandom> limit(1) prefix(int b = ) suffix(;)
      usually results in a != b.  That is what the godbolt thephd.dev branch
      implements too and what this patch does as well, but clang actually seems
      to just go from st.st_size == 0, ergo it must be zero-sized resource and
      so just copies over if_empty if present.  It is really questionable
      what to do about the character devices/named pipes with __has_embed, for
      regular files the patch doesn't read anything from them, relies on
      st.st_size + limit for whether it is empty or non-empty.  But I don't know
      of a way to check if read on say a character device would read anything
      or not (the </dev/null> limit (1) vs. </dev/zero> limit (1) cases), and
      if we read something, that would be better cached for later because
       #embed later if it reads again could read no further data even when it
      first read something.  So, the patch currently for __has_embed just
      always returns 2 on the non-regular files, like the thephd.dev
      branch does as well and like the clang pull request as well.
      A question is also what to do for gnu::offset on the non-regular files
      even for #embed, those aren't seekable and do we want to just read and throw
      away the offset bytes each time we see it used?
      
      clang also chokes on the
       #if __has_embed (__FILE__ __limit__ (1) __prefix__ () suffix (1 / 0) \
       __if_empty__ ((({{[0[0{0{0(0(0)1)1}1}]]}})))) != __STDC_EMBED_FOUND__
       #error "__has_embed fail"
       #endif
      in embed-1.c, but thephd.dev branch accepts it and I don't see why
      it shouldn't, (({{[0[0{0{0(0(0)1)1}1}]]}}))) is a balanced token
      sequence and the file isn't empty, so it should just be parsed and
      discarded.
      
      clang also IMHO mishandles
       const unsigned char w[] = {
       #embed __FILE__ prefix([0] = 42, [15] =) limit(32)
       };
      but again only without -save-temps, seems like it
      treats it as
      [0] = 42, [15] = (99,111,110,115,116,32,117,110,115,105,103,110,101,100,
      32,99,104,97,114,32,119,91,93,32,61,32,123,10,35,101,109,98)
      rather than
      [0] = 42, [15] = 99,111,110,115,116,32,117,110,115,105,103,110,101,100,
      32,99,104,97,114,32,119,91,93,32,61,32,123,10,35,101,109,98
      and warns on it for -Wunused-value and just compiles it as
      [0] = 42, [15] = 98
      
      And also
       void foo (int, int, int, int);
       void bar (void) { foo (
       #embed __FILE__ limit (4) prefix (172 + ) suffix (+ 2)
       ); }
      is treated as
      172 + (118, 111, 105, 100) + 2
      rather than
      172 + 118, 111, 105, 100 + 2
      which clang -save-temps or GCC treats it like, so results
      in just one argument passed rather than 4.
      
      if (!strstr ((const char *) magna_carta, "imprisonétur")) abort ();
      in the testcase fails as well, but in that case calling it in gdb succeeds:
      p ((char *(*)(char *, char *))__strstr_sse2) (magna_carta, "imprisonétur")
      $2 = 0x555555558d3c <magna_carta+11564> "imprisonétur aut disseisiátur"...
      so I guess they are just trying to constant evaluate strstr and do it
      incorrectly.
      
      They started with making the optimizations together in the initial patch
      set, so they don't have the luxury to compare if it is just because of
      the optimization they are trying to do or because that is how the
      feature works for them.  At least unless they use -save-temps for now.
      
      There is also different behavior between clang and gcc on -M or other
      dependency generating options.  Seems clang includes the __has_embed
      searched files in dependencies, while my patch doesn't.  But so does
      clang for __has_include and GCC doesn't.  Emitting a hard dependency
      on some header just because there was __has_include/__has_embed for it
      seems wrong to me, because (at least when properly written) the source
      likely doesn't mind if the file is missing, it will do something else,
      so a hard error from make because of it doesn't seem right.  Does
      make have some weaker dependencies, such that if some file can be remade
      it is but if it doesn't exist, it isn't fatal?
      
      I wonder whether #embed <non-existent-file> really needs to be fatal
      or whether we could simply after diagnosing it pretend the file exists
      and is empty.  For #include I think fatal errors make tons of sense,
      but perhaps for #embed which is more localized we'd get better error
      reporting if we didn't bail out immediately.  Note, both GCC and clang
      currently treat those as fatal errors.
      
      clang also added -dE option which with -E instead of preprocessing
      the #embed directives keeps them as is, but the preprocessed source
      then isn't self-contained.  That option looks more harmful than useful to
      me.
      
      Also, it isn't clear to me from C23 whether it is possible to have
      __has_include/__has_c_attribute/__has_embed expressions inside of
      the limit #embed/__has_embed argument.
      6.10.3.2/2 says that defined should not appear there (and the patch
      diagnoses it and testsuite tests), but for __has_include/__has_embed
      etc. 6.10.1/11 says:
      "The identifiers __has_include, __has_embed, and __has_c_attribute
      shall not appear in any context not mentioned in this subclause."
      If that subclause in that case means 6.10.1, then it presumably shouldn't
      appear in #embed in 6.10.3, but __has_embed is in 6.10.1...
      But 6.10.3.2/3 says that it should be parsed according to the 6.10.1
      rules.  Haven't included tests like
       #if __has_embed (__FILE__ limit (__has_embed (__FILE__ limit (1))))
      or
       #embed __FILE__ limit (__has_include (__FILE__))
      into the testsuite because of the doubts but I think the patch should
      handle those right now.
      
      The reason I've used Magna Carta text in some of the testcases is that
      I hope it shouldn't be copyrighted after the centuries and I'd strongly
      prefer not to have binary blobs in git after the xz backdoor lesson
      and wanted something larger which doesn't change all the time.
      
      Oh, BTW, I see in C23 draft 6.10.3.2 in Example 4
      if (f_source == NULL);
        return 1;
      (note the spurious semicolon after closing paren), has that been fixed
      already?
      
      Like the thephd.dev and clang implementations, the patch always macro
      expands the whole #embed and __has_embed directives except for the
      embed keyword.  That is most likely not what C23 says, my limited
      understanding right now is that in #embed one needs to parse the whole
      directive line with macro expansion disabled and check if it satisfies the
      grammar, if not, the whole directive is macro expanded, if yes, only
      the limit parameter argument is macro expanded and the prefix/suffix/if_empty
      arguments are maybe macro expanded when actually used (and not at all if
      unused).  And I think __has_embed macro expansion has conflicting rules.
      
      2024-09-12  Jakub Jelinek  <jakub@redhat.com>
      
      	PR c/105863
      libcpp/
      	* include/cpplib.h: Implement C23 N3017 #embed - a scannable,
      	tooling-friendly binary resource inclusion mechanism paper.
      	(struct cpp_options): Add embed member.
      	(enum cpp_builtin_type): Add BT_HAS_EMBED.
      	(cpp_set_include_chains): Add another cpp_dir * argument to
      	the declaration.
      	* internal.h (enum include_type): Add IT_EMBED.
      	(struct cpp_reader): Add embed_include member.
      	(struct cpp_embed_params_tokens): New type.
      	(struct cpp_embed_params): New type.
      	(_cpp_get_token_no_padding): Declare.
      	(enum _cpp_find_file_kind): Add _cpp_FFK_EMBED and _cpp_FFK_HAS_EMBED.
      	(_cpp_stack_embed): Declare.
      	(_cpp_parse_expr): Change return type to cpp_num_part instead of
      	bool, change second argument from bool to const char * and add third
      	argument.
      	(_cpp_parse_embed_params): Declare.
      	* directives.cc (DIRECTIVE_TABLE): Add embed entry.
      	(end_directive): Don't call skip_rest_of_line for T_EMBED directive.
      	(_cpp_handle_directive): Return 2 rather than 1 for T_EMBED in
      	directives-only mode.
      	(parse_include): Don't Call check_eol for T_EMBED directive.
      	(skip_balanced_token_seq): New function.
      	(EMBED_PARAMS): Define.
      	(enum embed_param_kind): New type.
      	(embed_params): New variable.
      	(_cpp_parse_embed_params): New function.
      	(do_embed): New function.
      	(do_if): Adjust _cpp_parse_expr caller.
      	(do_elif): Likewise.
      	* expr.cc (parse_defined): Diagnose defined in #embed or __has_embed
      	parameters.
      	(_cpp_parse_expr): Change return type to cpp_num_part instead of
      	bool, change second argument from bool to const char * and add third
      	argument.  Adjust function comment.  For #embed/__has_embed parameters
      	add an artificial CPP_OPEN_PAREN.  Use the second argument DIR
      	directly instead of string literals conditional on IS_IF.
      	For #embed/__has_embed parameter, stop on reaching CPP_CLOSE_PAREN
      	matching the artificial one.  Diagnose negative or too large embed
      	parameter operands.
      	(num_binary_op): Use #embed instead of #if for diagnostics if inside
      	#embed/__has_embed parameter.
      	(num_div_op): Likewise.
      	* files.cc (struct _cpp_file): Add limit member and embed bitfield.
      	(search_cache): Add IS_EMBED argument, formatting fix.  Skip over
      	files with different file->embed from the argument.
      	(find_file_in_dir): Don't call pch_open_file if file->embed.
      	(_cpp_find_file): Handle _cpp_FFK_EMBED and _cpp_FFK_HAS_EMBED.
      	(read_file_guts): Formatting fix.
      	(has_unique_contents): Ignore file->embed files.
      	(search_path_head): Handle IT_EMBED type.
      	(_cpp_stack_embed): New function.
      	(_cpp_get_file_stat): Formatting fix.
      	(cpp_set_include_chains): Add embed argument, save it to
      	pfile->embed_include and compute lens for the chain.
      	* init.cc (struct lang_flags): Add embed member.
      	(lang_defaults): Add embed initializers.
      	(cpp_set_lang): Initialize CPP_OPTION (pfile, embed).
      	(builtin_array): Add __has_embed entry.
      	(cpp_init_builtins): Predefine __STDC_EMBED_NOT_FOUND__,
      	__STDC_EMBED_FOUND__ and __STDC_EMBED_EMPTY__.
      	* lex.cc (cpp_directive_only_process): Handle #embed.
      	* macro.cc (cpp_get_token_no_padding): Rename to ...
      	(_cpp_get_token_no_padding): ... this.  No longer static.
      	(builtin_has_include_1): New function.
      	(builtin_has_include): Use it.  Use _cpp_get_token_no_padding
      	instead of cpp_get_token_no_padding.
      	(builtin_has_embed): New function.
      	(_cpp_builtin_macro_text): Handle BT_HAS_EMBED.
      gcc/
      	* doc/cppdiropts.texi (--embed-dir=): Document.
      	* doc/cpp.texi (Binary Resource Inclusion): New chapter.
      	(__has_embed): Document.
      	* doc/invoke.texi (Directory Options): Mention --embed-dir=.
      	* gcc.cc (cpp_unique_options): Add %{-embed*}.
      	* genmatch.cc (main): Adjust cpp_set_include_chains caller.
      	* incpath.h (enum incpath_kind): Add INC_EMBED.
      	* incpath.cc (merge_include_chains): Handle INC_EMBED.
      	(register_include_chains): Adjust cpp_set_include_chains caller.
      gcc/c-family/
      	* c.opt (-embed-dir=): New option.
      	(-embed-directory): New alias.
      	(-embed-directory=): New alias.
      	* c-opts.cc (c_common_handle_option): Handle OPT__embed_dir_.
      gcc/testsuite/
      	* c-c++-common/cpp/embed-1.c: New test.
      	* c-c++-common/cpp/embed-2.c: New test.
      	* c-c++-common/cpp/embed-3.c: New test.
      	* c-c++-common/cpp/embed-4.c: New test.
      	* c-c++-common/cpp/embed-5.c: New test.
      	* c-c++-common/cpp/embed-6.c: New test.
      	* c-c++-common/cpp/embed-7.c: New test.
      	* c-c++-common/cpp/embed-8.c: New test.
      	* c-c++-common/cpp/embed-9.c: New test.
      	* c-c++-common/cpp/embed-10.c: New test.
      	* c-c++-common/cpp/embed-11.c: New test.
      	* c-c++-common/cpp/embed-12.c: New test.
      	* c-c++-common/cpp/embed-13.c: New test.
      	* c-c++-common/cpp/embed-14.c: New test.
      	* c-c++-common/cpp/embed-25.c: New test.
      	* c-c++-common/cpp/embed-26.c: New test.
      	* c-c++-common/cpp/embed-dir/embed-1.inc: New test.
      	* c-c++-common/cpp/embed-dir/embed-3.c: New test.
      	* c-c++-common/cpp/embed-dir/embed-4.c: New test.
      	* c-c++-common/cpp/embed-dir/magna-carta.txt: New test.
      	* gcc.dg/cpp/embed-1.c: New test.
      	* gcc.dg/cpp/embed-2.c: New test.
      	* gcc.dg/cpp/embed-3.c: New test.
      	* gcc.dg/cpp/embed-4.c: New test.
      	* g++.dg/cpp/embed-1.C: New test.
      	* g++.dg/cpp/embed-2.C: New test.
      	* g++.dg/cpp/embed-3.C: New test.
      eba6d2aa
  9. Aug 26, 2024
    • Alexander Monakov's avatar
      libcpp: deduplicate definition of padding size · a8260ebe
      Alexander Monakov authored
      Tie together the two functions that ensure tail padding with
      search_line_ssse3 via CPP_BUFFER_PADDING macro.
      
      libcpp/ChangeLog:
      
      	* internal.h (CPP_BUFFER_PADDING): New macro; use it ...
      	* charset.cc (_cpp_convert_input): ...here, and ...
      	* files.cc (read_file_guts): ...here, and ...
      	* lex.cc (search_line_ssse3): here.
      a8260ebe
  10. Aug 22, 2024
  11. Aug 20, 2024
    • Alexander Monakov's avatar
      libcpp: replace SSE4.2 helper with an SSSE3 one · 20a5b482
      Alexander Monakov authored
      Since the characters we are searching for (CR, LF, '\', '?') all have
      distinct ASCII codes mod 16, PSHUFB can help match them all at once.
      
      Directly use the new helper if __SSSE3__ is defined. It makes the other
      helpers unused, so mark them inline to prevent warnings.
      
      Rewrite and simplify init_vectorized_lexer.
      
      libcpp/ChangeLog:
      
      	* config.in: Regenerate.
      	* configure: Regenerate.
      	* configure.ac: Check for SSSE3 instead of SSE4.2.
      	* files.cc (read_file_guts): Bump padding to 64 if HAVE_SSSE3.
      	* lex.cc (search_line_acc_char): Mark inline, not "unused".
      	(search_line_sse2): Mark inline.
      	(search_line_sse42): Replace with...
      	(search_line_ssse3): ... this new function.  Adjust the use...
      	(init_vectorized_lexer): ... here.  Simplify.
      20a5b482
  12. Aug 06, 2024
    • Andi Kleen's avatar
      Remove MMX code path in lexer · eac63be1
      Andi Kleen authored
      Host systems with only MMX and no SSE2 should be really rare now.
      Let's remove the MMX code path to keep the number of custom
      implementations the same.
      
      The SSE2 code path is also somewhat dubious now (nearly everything
      should have SSE4 4.2 which is >15 years old now), but the SSE2
      code path is used as fallback for others and also apparently
      Solaris uses it due to tool chain deficiencies.
      
      libcpp/ChangeLog:
      
      	* lex.cc (search_line_mmx): Remove function.
      	(init_vectorized_lexer): Remove search_line_mmx.
      eac63be1
  13. Jul 25, 2024
    • Jakub Jelinek's avatar
      c++: Implement C++26 P2558R2 - Add @, $, and ` to the basic character set [PR110343] · 29341f21
      Jakub Jelinek authored
      The following patch implements the easy parts of the paper.
      When @$` are added to the basic character set, it means that
      R"@$`()@$`" should now be valid (here I've noticed most of the
      raw string tests were tested solely with -std=c++11 or -std=gnu++11
      and I've tried to change that), and on the other side even if
      by extension $ is allowed in identifiers, \u0024 or \U00000024
      or \u{24} should not be, similarly how \u0041 is not allowed.
      
      The paper in 3.1 claims though that
       #include <stdio.h>
      
       #define STR(x) #x
      
      int main()
      {
        printf("%s", STR(\u0060)); // U+0060 is ` GRAVE ACCENT
      }
      should have been accepted before this paper (and rejected after it),
      but g++ rejects it.
      
      I've tried to understand it, but am confused on what is the right
      behavior and why.
      
      Consider
       #define STR(x) #x
      const char *a = "\u00b7";
      const char *b = STR(\u00b7);
      const char *c = "\u0041";
      const char *d = STR(\u0041);
      const char *e = STR(a\u00b7);
      const char *f = STR(a\u0041);
      const char *g = STR(a \u00b7);
      const char *h = STR(a \u0041);
      const char *i = "\u066d";
      const char *j = STR(\u066d);
      const char *k = "\u0040";
      const char *l = STR(\u0040);
      const char *m = STR(a\u066d);
      const char *n = STR(a\u0040);
      const char *o = STR(a \u066d);
      const char *p = STR(a \u0040);
      
      Neither clang nor gcc emit any diagnostics on the a, c, i and k
      initializers, those are certainly valid (c is invalid in C23 though).  g++
      emits with -pedantic-errors errors on all the others, while clang++ on the
      ones with STR involving \u0041, \u0040 and a\u0066d.  The chosen values are
      \u0040 '@' as something being changed by this paper, \u0041 'A' as basic
      character set char valid in identifiers before/after, \u00b7 as an example
      of character which is pedantically valid in identifiers if not at the start
      and \u066d s something pedantically not valid in identifiers.
      
      Now, https://eel.is/c++draft/lex.charset#6 says that UCN used outside of a
      string/character literal which corresponds to basic character set character
      (or control character) is ill-formed, that would make d, f, h cases invalid
      for C++ and l, n, p cases invalid for C++26.
      
      https://eel.is/c++draft/lex.name states which characters can appear at the
      start of the identifier and which can appear after the start.  And
      https://eel.is/c++draft/lex.pptoken states that preprocessing-token is
      either identifier, or tons of other things, or "each non-whitespace
      character that cannot be one of the above"
      
      Then https://eel.is/c++draft/lex.pptoken#1 says that this last category is
      invalid if the preprocessing token is being converted into token.
      
      And https://eel.is/c++draft/lex.pptoken#2 includes "If any character not in
      the basic character set matches the last category, the program is
      ill-formed."
      
      Now, e.g.  for the C++23 STR(\u0040) case, \u0040 is there not in the basic
      character set, so valid outside of the literals (not the case anymore in
      C++26), but it isn't nondigit and doesn't have XID_Start property, so it
      isn't IMHO an identifier and so must be the "each non-whitespace character
      that cannot be one of the above" case.  Why doesn't the above mentioned
      https://eel.is/c++draft/lex.pptoken#2 sentence make that invalid?  Ignoring
      that, I'd say it would be then stringized and that feels like it is what
      clang++ is doing.  Now, e.g.  for the STR(a\u066d) case, I wonder why that
      isn't lexed as a identifier followed by \u066d "each non-whitespace
      character that cannot be one of the above" token and stringified similarly,
      clang++ rejects that.
      
      What GCC libcpp seems to be doing is that if that forms_identifier_p calls
      _cpp_valid_utf8 or _cpp_valid_ucn with an argument which tells it is first
      or second+ in identifier, and e.g.  _cpp_valid_ucn then for UCNs valid in
      string literals calls
        else if (identifier_pos)
          {
            int validity = ucn_valid_in_identifier (pfile, result, nst);
      
            if (validity == 0)
              cpp_error (pfile, CPP_DL_ERROR,
                         "universal character %.*s is not valid in an identifier",
                         (int) (str - base), base);
            else if (validity == 2 && identifier_pos == 1)
              cpp_error (pfile, CPP_DL_ERROR,
         "universal character %.*s is not valid at the start of an identifier",
                         (int) (str - base), base);
          }
      so basically all those invalid in identifiers cases emit an error and
      pretend to be valid in identifiers, rather than what e.g.  _cpp_valid_utf8
      does for C but not for C++ and only for the chars completely invalid in
      identifiers rather than just valid in identifiers but not at the start:
                /* In C++, this is an error for invalid character in an identifier
                   because logically, the UTF-8 was converted to a UCN during
                   translation phase 1 (even though we don't physically do it that
                   way).  In C, this byte rather becomes grammatically a separate
                   token.  */
      
                if (CPP_OPTION (pfile, cplusplus))
                  cpp_error (pfile, CPP_DL_ERROR,
                             "extended character %.*s is not valid in an identifier",
                             (int) (*pstr - base), base);
                else
                  {
                    *pstr = base;
                    return false;
                  }
      The comment doesn't really match what is done in recent C++ versions because
      there UCNs are translated to characters and not the other way around.
      
      2024-07-25  Jakub Jelinek  <jakub@redhat.com>
      
      	PR c++/110343
      libcpp/
      	* lex.cc: C++26 P2558R2 - Add @, $, and ` to the basic character set.
      	(lex_raw_string): For C++26 allow $@` characters in prefix.
      	* charset.cc (_cpp_valid_ucn): For C++26 reject \u0024 in identifiers.
      gcc/testsuite/
      	* c-c++-common/raw-string-1.c: Use { c || c++11 } effective target,
      	remove c++ specific dg-options.
      	* c-c++-common/raw-string-2.c: Likewise.
      	* c-c++-common/raw-string-4.c: Likewise.
      	* c-c++-common/raw-string-5.c: Likewise.  Expect some diagnostics
      	only for non-c++26, for c++26 expect different.
      	* c-c++-common/raw-string-6.c: Use { c || c++11 } effective target,
      	remove c++ specific dg-options.
      	* c-c++-common/raw-string-11.c: Likewise.
      	* c-c++-common/raw-string-13.c: Likewise.
      	* c-c++-common/raw-string-14.c: Likewise.
      	* c-c++-common/raw-string-15.c: Use { c || c++11 } effective target,
      	change c++ specific dg-options to just -Wtrigraphs.
      	* c-c++-common/raw-string-16.c: Likewise.
      	* c-c++-common/raw-string-17.c: Use { c || c++11 } effective target,
      	remove c++ specific dg-options.
      	* c-c++-common/raw-string-18.c: Use { c || c++11 } effective target,
      	remove -std=c++11 from c++ specific dg-options.
      	* c-c++-common/raw-string-19.c: Likewise.
      	* g++.dg/cpp26/raw-string1.C: New test.
      	* g++.dg/cpp26/raw-string2.C: New test.
      29341f21
  14. May 26, 2024
  15. Feb 22, 2024
    • Jakub Jelinek's avatar
      c: Handle scoped attributes in __has*attribute and scoped attribute parsing... · 37127ed9
      Jakub Jelinek authored
      c: Handle scoped attributes in __has*attribute and scoped attribute parsing changes in -std=c11 etc. modes [PR114007]
      
      We aren't able to parse __has_attribute (vendor::attr) (and __has_c_attribute
      and __has_cpp_attribute) in strict C < C23 modes.  While in -std=gnu* modes
      or in -std=c23 there is CPP_SCOPE token, in -std=c* (except for -std=c23)
      there are is just a pair of CPP_COLON tokens.
      The c-lex.cc hunk adds support for that.
      
      That leads to a question if we should return 1 or 0 from
      __has_attribute (gnu::unused) or not, because while
      [[gnu::unused]] is parsed fine in -std=gnu*/-std=c23 modes (sure, with
      pedwarn for < C23), we do not parse it at all in -std=c* (except for
      -std=c23), we only parse [[__extension__ gnu::unused]] there.  While
      the __extension__ in there helps to avoid the pedwarn, I think it is
      better to be consistent between GNU and strict C < C23 modes and
      parse [[gnu::unused]] too; on the other side, I think parsing
      [[__extension__ gnu : : unused]] is too weird and undesirable.
      
      So, the following patch adds a flag during preprocessing at the point
      where we normally create CPP_SCOPE tokens out of 2 consecutive colons
      on the first CPP_COLON to mark the consecutive case (as we are tight
      on the bits, I've reused the PURE_ZERO flag, which is used just by the
      C++ FE and only ever set (both C and C++) on CPP_NUMBER tokens, this
      new flag has the same value and is only ever used on CPP_COLON tokens)
      and instead of checking loose_scope_p argument (i.e. whether it is
      [[__extension__ ...]] or not), it just parses CPP_SCOPE or CPP_COLON
      with CLONE_SCOPE flag followed by another CPP_COLON the same.
      The latter will never appear in >= C23 or -std=gnu* modes, though
      guarding its use say with flag_iso && !flag_isoc23 && doesn't really
      work because the __extension__ case temporarily clears flag_iso flag.
      
      This makes the -std=c11 etc. behavior more similar to -std=gnu11 or
      -std=c23, the only difference I'm aware of are the
       #define JOIN2(A, B) A##B
       [[vendor JOIN2(:,:) attr]]
       [[__extension__ vendor JOIN2(:,:) attr]]
      cases, which are accepted in the latter modes, but results in error
      in -std=c11; but the error is during preprocessing that :: doesn't
      form a valid preprocessing token, which is true, so just don't do that if
      you try to have __STRICT_ANSI__ && __STDC_VERSION__ <= 201710L
      compatibility.
      
      2024-02-22  Jakub Jelinek  <jakub@redhat.com>
      
      	PR c/114007
      gcc/
      	* doc/extend.texi: (__extension__): Remove comments about scope
      	tokens vs. two colons.
      gcc/c-family/
      	* c-lex.cc (c_common_has_attribute): Parse 2 CPP_COLONs with
      	the first one with COLON_SCOPE flag the same as CPP_SCOPE.
      gcc/c/
      	* c-parser.cc (c_parser_std_attribute): Remove loose_scope_p argument.
      	Instead of checking it, parse 2 CPP_COLONs with the first one with
      	COLON_SCOPE flag the same as CPP_SCOPE.
      	(c_parser_std_attribute_list): Remove loose_scope_p argument, don't
      	pass it to c_parser_std_attribute.
      	(c_parser_std_attribute_specifier): Adjust c_parser_std_attribute_list
      	caller.
      gcc/testsuite/
      	* gcc.dg/c23-attr-syntax-6.c: Adjust testcase for :: being valid
      	even in -std=c11 even without __extension__ and : : etc. not being
      	valid anymore even with __extension__.
      	* gcc.dg/c23-attr-syntax-7.c: Likewise.
      	* gcc.dg/c23-attr-syntax-8.c: New test.
      libcpp/
      	* include/cpplib.h (COLON_SCOPE): Define to PURE_ZERO.
      	* lex.cc (_cpp_lex_direct): When lexing CPP_COLON with another
      	colon after it, if !CPP_OPTION (pfile, scope) set COLON_SCOPE
      	flag on the first CPP_COLON token.
      37127ed9
  16. Jan 03, 2024
  17. Dec 13, 2023
    • Jakub Jelinek's avatar
      libcpp: Fix valgrind errors on pr88974.c [PR112956] · 819bc4f6
      Jakub Jelinek authored
      On the c-c++-common/cpp/pr88974.c testcase I'm seeing
      ==600549== Conditional jump or move depends on uninitialised value(s)
      ==600549==    at 0x1DD3A05: cpp_get_token_1(cpp_reader*, unsigned int*) (macro.cc:3050)
      ==600549==    by 0x1DBFC7F: _cpp_parse_expr (expr.cc:1392)
      ==600549==    by 0x1DB9471: do_if(cpp_reader*) (directives.cc:2087)
      ==600549==    by 0x1DBB4D8: _cpp_handle_directive (directives.cc:572)
      ==600549==    by 0x1DCD488: _cpp_lex_token (lex.cc:3682)
      ==600549==    by 0x1DD3A97: cpp_get_token_1(cpp_reader*, unsigned int*) (macro.cc:2936)
      ==600549==    by 0x7F7EE4: scan_translation_unit (c-ppoutput.cc:350)
      ==600549==    by 0x7F7EE4: preprocess_file(cpp_reader*) (c-ppoutput.cc:106)
      ==600549==    by 0x7F6235: c_common_init() (c-opts.cc:1280)
      ==600549==    by 0x704C8B: lang_dependent_init (toplev.cc:1837)
      ==600549==    by 0x704C8B: do_compile (toplev.cc:2135)
      ==600549==    by 0x704C8B: toplev::main(int, char**) (toplev.cc:2306)
      ==600549==    by 0x7064BA: main (main.cc:39)
      error.  The problem is that _cpp_lex_direct can leave result->src_loc
      uninitialized in some cases and later on we use that location_t.
      
      _cpp_lex_direct essentially does:
        cppchar_t c;
      ...
        cpp_token *result = pfile->cur_token++;
      
       fresh_line:
        result->flags = 0;
      ...
        if (buffer->need_line)
          {
            if (pfile->state.in_deferred_pragma)
              {
                result->type = CPP_PRAGMA_EOL;
                ... // keeps result->src_loc uninitialized;
                return result;
              }
            if (!_cpp_get_fresh_line (pfile))
              {
                result->type = CPP_EOF;
                if (!pfile->state.in_directive && !pfile->state.parsing_args)
                  {
                    result->src_loc = pfile->line_table->highest_line;
                    ...
                  }
                ... // otherwise result->src_loc is sometimes uninitialized here
                return result;
              }
            ...
          }
      ...
        result->src_loc = pfile->line_table->highest_line;
      ...
        c = *buffer->cur++;
        switch (c)
          {
      ...
          case '\n':
      ...
            buffer->need_line = true;
            if (pfile->state.in_deferred_pragma)
              {
                result->type = CPP_PRAGMA_EOL;
      ...
                return result;
              }
            goto fresh_line;
      ...
          }
      ...
      So, if _cpp_lex_direct is called without buffer->need_line initially set,
      result->src_loc is always initialized (and actually hundreds of tests rely
      on that exact value it has), even when c == '\n' and we set that flag later
      on and goto fresh_line.  For CPP_PRAGMA_EOL case we have in that case
      separate handling and don't goto.
      But if _cpp_lex_direct is called with buffer->need_line initially set and
      either decide to return a CPP_PRAGMA_EOL token or if getting a new line fails
      for some reason and we return an CPP_ERROR token and we are in directive
      or parsing args state, it is kept uninitialized and can be whatever the
      allocation left it there as.
      
      The following patch attempts to keep the status quo, use value that was
      returned previously if it was initialized (i.e. we went through the
      goto fresh_line; statement in c == '\n' handling) and only initialize
      result->src_loc if it was uninitialized before.
      
      2023-12-13  Jakub Jelinek  <jakub@redhat.com>
      
      	PR preprocessor/112956
      	* lex.cc (_cpp_lex_direct): Initialize c to 0.
      	For CPP_PRAGMA_EOL tokens and if c == 0 also for CPP_EOF
      	set result->src_loc to highest locus.
      819bc4f6
  18. Nov 24, 2023
    • Alexander Monakov's avatar
      libcpp: configure: drop unused Valgrind detection · ab78426a
      Alexander Monakov authored
      When top-level configure has either --enable-checking=valgrind or
      --enable-valgrind-annotations, we want to activate a couple of workarounds
      in libcpp. They do not use anything from the Valgrind API, so just
      delete all detection.
      
      libcpp/ChangeLog:
      
      	* config.in: Regenerate.
      	* configure: Regenerate.
      	* configure.ac (ENABLE_VALGRIND_CHECKING): Delete.
      	(ENABLE_VALGRIND_ANNOTATIONS): Rename to
      	ENABLE_VALGRIND_WORKAROUNDS.  Delete Valgrind header checks.
      	* lex.cc (new_buff): Adjust for renaming.
      	(_cpp_free_buff): Ditto.
      ab78426a
  19. Nov 07, 2023
    • Joseph Myers's avatar
      c: Refer more consistently to C23 not C2X · 094a609c
      Joseph Myers authored
      Continuing the move to refer to C23 in place of C2X throughout the
      source tree, update documentation, diagnostics, comments, variable and
      function names, etc., to use the C23 name.
      
      Testsuite updates are left for a future patch, except for testcases
      that test diagnostics that previously mentioned C2X (but in those
      testcases, sometimes other comments are updated, not just the
      diagnostic expectations).
      
      Bootstrapped with no regressions for x86_64-pc-linux-gnu.
      
      gcc/
      	* builtins.def (DEF_C2X_BUILTIN): Rename to DEF_C23_BUILTIN and
      	use flag_isoc23 and function_c23_misc.
      	* config/rl78/rl78.cc (rl78_option_override): Compare
      	lang_hooks.name with "GNU C23" not "GNU C2X".
      	* coretypes.h (function_c2x_misc): Rename to function_c23_misc.
      	* doc/cpp.texi (@code{__has_attribute}): Refer to C23 instead of
      	C2x.
      	* doc/extend.texi: Likewise.
      	* doc/invoke.texi: Likewise.
      	* dwarf2out.cc (highest_c_language, gen_compile_unit_die): Compare
      	against and return "GNU C23" language string instead of "GNU C2X".
      	* ginclude/float.h: Refer to C23 instead of C2X in comments.
      	* ginclude/stdint-gcc.h: Likewise.
      	* glimits.h: Likewise.
      	* tree.h: Likewise.
      
      gcc/ada/
      	* gcc-interface/utils.cc (flag_isoc2x): Rename to flag_isoc23.
      
      gcc/c-family/
      	* c-common.cc (flag_isoc2x): Rename to flag_isoc23.
      	(c_common_reswords): Use D_C23 instead of D_C2X.
      	* c-common.h: Refer throughout to C23 instead of C2X in comments.
      	(D_C2X): Rename to D_C23.
      	(flag_isoc2x): Rename to flag_isoc23.
      	* c-cppbuiltin.cc (builtin_define_float_constants): Use
      	flag_isoc23 instead of flag_isoc2x.  Refer to C23 instead of C2x
      	in comments.
      	* c-format.cc: Use STD_C23 instead of STD_C2X and flag_isoc23
      	instead of flag_isoc2x.  Refer to C23 instead of C2X in comments.
      	* c-format.h: Use STD_C23 instead of STD_C2X.
      	* c-lex.cc: Use warn_c11_c23_compat instead of warn_c11_c2x_compat
      	and flag_isoc23 instead of flag_isoc2x.  Refer to C23 instead of
      	C2X in diagnostics.
      	* c-opts.cc: Use flag_isoc23 instead of flag_isoc2x.  Refer to C23
      	instead of C2X in comments.
      	(set_std_c2x): Rename to set_std_c23.
      	* c.opt (Wc11-c23-compat): Use CPP(cpp_warn_c11_c23_compat)
      	CppReason(CPP_W_C11_C23_COMPAT) Var(warn_c11_c23_compat) instead
      	of CPP(cpp_warn_c11_c2x_compat) CppReason(CPP_W_C11_C2X_COMPAT)
      	Var(warn_c11_c2x_compat).
      
      gcc/c/
      	* c-decl.cc: Use flag_isoc23 instead of flag_isoc2x and c23_auto_p
      	instead of c2x_auto_p.  Refer to C23 instead of C2X in diagnostics
      	and comments.
      	* c-errors.cc: Use flag_isoc23 instead of flag_isoc2x and
      	warn_c11_c23_compat instead of warn_c11_c2x_compat.  Refer to C23
      	instead of C2X in comments.
      	* c-parser.cc: Use flag_isoc23 instead of flag_isoc2x,
      	warn_c11_c23_compat instead of warn_c11_c2x_compat, c23_auto_p
      	instead of c2x_auto_p and D_C23 instead of D_C2X.  Refer to C23
      	instead of C2X in diagnostics and comments.
      	* c-tree.h: Refer to C23 instead of C2X in comments.
      	(struct c_declspecs): Rename c2x_auto_p to c23_auto_p.
      	* c-typeck.cc: Use flag_isoc23 instead of flag_isoc2x and
      	warn_c11_c23_compat instead of warn_c11_c2x_compat.  Refer to C23
      	instead of C2X in diagnostics and comments.
      
      gcc/fortran/
      	* gfortran.h (gfc_real_info): Refer to C23 instead of C2X in
      	comment.
      
      gcc/lto/
      	* lto-lang.cc (flag_isoc2x): Rename to flag_isoc23.
      
      gcc/testsuite/
      	* gcc.dg/binary-constants-2.c: Refer to C23 instead of C2X.
      	* gcc.dg/binary-constants-3.c: Likewise.
      	* gcc.dg/bitint-23.c: Likewise.
      	* gcc.dg/bitint-26.c: Likewise.
      	* gcc.dg/bitint-27.c: Likewise.
      	* gcc.dg/c11-attr-syntax-1.c: Likewise.
      	* gcc.dg/c11-attr-syntax-2.c: Likewise.
      	* gcc.dg/c11-floatn-1.c: Likewise.
      	* gcc.dg/c11-floatn-2.c: Likewise.
      	* gcc.dg/c11-floatn-3.c: Likewise.
      	* gcc.dg/c11-floatn-4.c: Likewise.
      	* gcc.dg/c11-floatn-5.c: Likewise.
      	* gcc.dg/c11-floatn-6.c: Likewise.
      	* gcc.dg/c11-floatn-7.c: Likewise.
      	* gcc.dg/c11-floatn-8.c: Likewise.
      	* gcc.dg/c2x-attr-syntax-4.c: Likewise.
      	* gcc.dg/c2x-attr-syntax-6.c: Likewise.
      	* gcc.dg/c2x-attr-syntax-7.c: Likewise.
      	* gcc.dg/c2x-binary-constants-2.c: Likewise.
      	* gcc.dg/c2x-floatn-5.c: Likewise.
      	* gcc.dg/c2x-floatn-6.c: Likewise.
      	* gcc.dg/c2x-floatn-7.c: Likewise.
      	* gcc.dg/c2x-floatn-8.c: Likewise.
      	* gcc.dg/c2x-nullptr-4.c: Likewise.
      	* gcc.dg/c2x-qual-2.c: Likewise.
      	* gcc.dg/c2x-qual-3.c: Likewise.
      	* gcc.dg/c2x-qual-6.c: Likewise.
      	* gcc.dg/cpp/c11-warning-1.c: Likewise.
      	* gcc.dg/cpp/c11-warning-2.c: Likewise.
      	* gcc.dg/cpp/c11-warning-3.c: Likewise.
      	* gcc.dg/cpp/c2x-warning-2.c: Likewise.
      	* gcc.dg/cpp/gnu11-elifdef-3.c: Likewise.
      	* gcc.dg/cpp/gnu11-elifdef-4.c: Likewise.
      	* gcc.dg/cpp/gnu11-warning-1.c: Likewise.
      	* gcc.dg/cpp/gnu11-warning-2.c: Likewise.
      	* gcc.dg/cpp/gnu11-warning-3.c: Likewise.
      	* gcc.dg/cpp/gnu2x-warning-2.c: Likewise.
      	* gcc.dg/dfp/c11-constants-1.c: Likewise.
      	* gcc.dg/dfp/c11-constants-2.c: Likewise.
      	* gcc.dg/dfp/c2x-constants-2.c: Likewise.
      	* gcc.dg/dfp/constants-pedantic.c: Likewise.
      	* gcc.dg/pr30260.c: Likewise.
      	* gcc.dg/system-binary-constants-1.c: Likewise.
      
      libcpp/
      	* directives.cc: Refer to C23 instead of C2X in diagnostics and
      	comments.
      	(STDC2X): Rename to STDC23.
      	* expr.cc: Use cpp_warn_c11_c23_compat instead of
      	cpp_warn_c11_c2x_compat and CPP_W_C11_C23_COMPAT instead of
      	CPP_W_C11_C2X_COMPAT.  Refer to C23 instead of C2X in diagnostics
      	and comments.
      	* include/cpplib.h: Refer to C23 instead of C2X in diagnostics and
      	comments.
      	(CLK_GNUC2X): Rename to CLK_GNUC23.
      	(CLK_STDC2X): Rename to CLK_STDC23.
      	(CPP_W_C11_C2X_COMPAT): Rename to CPP_W_C11_C23_COMPAT.
      	* init.cc: Use GNUC23 instead of GNUC2X, STDC23 instead of STDC2X
      	and cpp_warn_c11_c23_compat instead of cpp_warn_c11_c2x_compat.
      	* lex.cc (maybe_va_opt_error): Refer to C23 instead of C2X in
      	diagnostic.
      	* macro.cc (_cpp_arguments_ok): Refer to C23 instead of C2X in
      	comment.
      094a609c
  20. Oct 23, 2023
    • Lewis Hyatt's avatar
      libcpp: Improve the diagnostic for poisoned identifiers [PR36887] · cb05acdc
      Lewis Hyatt authored
      The PR requests an enhancement to the diagnostic issued for the use of a
      poisoned identifier. Currently, we show the location of the usage, but not
      the location which requested the poisoning, which would be helpful for the
      user if the decision to poison an identifier was made externally, such as
      in a library header.
      
      In order to output this information, we need to remember a location_t for
      each identifier that has been poisoned, and that data needs to be preserved
      as well in a PCH. One option would be to add a field to struct cpp_hashnode,
      but there is no convenient place to add it without increasing the size of
      the struct for all identifiers. Given this facility will be needed rarely,
      it seemed better to add a second hash map, which is handled PCH-wise the
      same as the current one in gcc/stringpool.cc. This hash map associates a new
      struct cpp_hashnode_extra with each identifier that needs one. Currently
      that struct only contains the new location_t, but it could be extended in
      the future if there is other ancillary data that may be convenient to put
      there for other purposes.
      
      libcpp/ChangeLog:
      
      	PR preprocessor/36887
      	* directives.cc (do_pragma_poison): Store in the extra hash map the
      	location from which an identifier has been poisoned.
      	* lex.cc (identifier_diagnostics_on_lex): When issuing a diagnostic
      	for the use of a poisoned identifier, also add a note indicating the
      	location from which it was poisoned.
      	* identifiers.cc (alloc_node): Convert to template function.
      	(_cpp_init_hashtable): Handle the new extra hash map.
      	(_cpp_destroy_hashtable): Likewise.
      	* include/cpplib.h (struct cpp_hashnode_extra): New struct.
      	(cpp_create_reader): Update prototype to...
      	* init.cc (cpp_create_reader): ...accept an argument for the extra
      	hash table and pass it to _cpp_init_hashtable.
      	* include/symtab.h (ht_lookup): New overload for convenience.
      	* internal.h (struct cpp_reader): Add EXTRA_HASH_TABLE member.
      	(_cpp_init_hashtable): Adjust prototype.
      
      gcc/c-family/ChangeLog:
      
      	PR preprocessor/36887
      	* c-opts.cc (c_common_init_options): Pass new extra hash map
      	argument to cpp_create_reader().
      
      gcc/ChangeLog:
      
      	PR preprocessor/36887
      	* toplev.h (ident_hash_extra): Declare...
      	* stringpool.cc (ident_hash_extra): ...this new global variable.
      	(init_stringpool): Handle ident_hash_extra as well as ident_hash.
      	(ggc_mark_stringpool): Likewise.
      	(ggc_purge_stringpool): Likewise.
      	(struct string_pool_data_extra): New struct.
      	(spd2): New GC root variable.
      	(gt_pch_save_stringpool): Use spd2 to handle ident_hash_extra,
      	analogous to how spd is used to handle ident_hash.
      	(gt_pch_restore_stringpool): Likewise.
      
      gcc/testsuite/ChangeLog:
      
      	PR preprocessor/36887
      	* c-c++-common/cpp/diagnostic-poison.c: New test.
      	* g++.dg/pch/pr36887.C: New test.
      	* g++.dg/pch/pr36887.Hs: New test.
      cb05acdc
  21. Oct 08, 2023
    • David Malcolm's avatar
      libcpp: eliminate COMBINE_LOCATION_DATA · 1f68a3e8
      David Malcolm authored
      
      This patch eliminates the function "COMBINE_LOCATION_DATA" (which hasn't
      been a macro since r6-739-g0501dbd932a7e9) and the function
      "get_combined_adhoc_loc" in favor of a new
      line_maps::get_or_create_combined_loc member function.
      
      No functional change intended.
      
      gcc/cp/ChangeLog:
      	* module.cc (module_state::read_location): Update for renaming of
      	get_combined_adhoc_loc.
      
      gcc/ChangeLog:
      	* genmatch.cc (main): Update for "m_" prefix of some fields of
      	line_maps.
      	* input.cc (make_location): Update for removal of
      	COMBINE_LOCATION_DATA.
      	(dump_line_table_statistics): Update for "m_" prefix of some
      	fields of line_maps.
      	(location_with_discriminator): Update for removal of
      	COMBINE_LOCATION_DATA.
      	(line_table_test::line_table_test): Update for "m_" prefix of some
      	fields of line_maps.
      	* toplev.cc (general_init): Likewise.
      	* tree.cc (set_block): Update for removal of
      	COMBINE_LOCATION_DATA.
      	(set_source_range): Likewise.
      
      libcpp/ChangeLog:
      	* include/line-map.h (line_maps::reallocator): Rename to...
      	(line_maps::m_reallocator): ...this.
      	(line_maps::round_alloc_size): Rename to...
      	(line_maps::m_round_alloc_size): ...this.
      	(line_maps::location_adhoc_data_map): Rename to...
      	(line_maps::m_location_adhoc_data_map): ...this.
      	(line_maps::num_optimized_ranges): Rename to...
      	(line_maps::m_num_optimized_ranges): ..this.
      	(line_maps::num_unoptimized_ranges): Rename to...
      	(line_maps::m_num_unoptimized_ranges): ...this.
      	(get_combined_adhoc_loc): Delete decl.
      	(COMBINE_LOCATION_DATA): Delete.
      	* lex.cc (get_location_for_byte_range_in_cur_line): Update for
      	removal of COMBINE_LOCATION_DATA.
      	(warn_about_normalization): Likewise.
      	(_cpp_lex_direct): Likewise.
      	* line-map.cc (line_maps::~line_maps): Update for "m_" prefix of
      	some fields of line_maps.
      	(rebuild_location_adhoc_htab): Likewise.
      	(can_be_stored_compactly_p): Convert to...
      	(line_maps::can_be_stored_compactly_p): ...this private member
      	function.
      	(get_combined_adhoc_loc): Convert to...
      	(line_maps::get_or_create_combined_loc): ...this public member
      	function.
      	(line_maps::make_location): Update for removal of
      	COMBINE_LOCATION_DATA.
      	(get_data_from_adhoc_loc): Update for "m_" prefix of some fields
      	of line_maps.
      	(get_discriminator_from_adhoc_loc): Likewise.
      	(get_location_from_adhoc_loc): Likewise.
      	(get_range_from_adhoc_loc): Convert to...
      	(line_maps::get_range_from_adhoc_loc): ...this private member
      	function.
      	(line_maps::get_range_from_loc): Update for conversion of
      	get_range_from_adhoc_loc to a member function.
      	(linemap_init): Update for "m_" prefix of some fields of
      	line_maps.
      	(line_map_new_raw): Likewise.
      	(linemap_enter_macro): Likewise.
      	(linemap_get_statistics): Likewise.
      
      Signed-off-by: default avatarDavid Malcolm <dmalcolm@redhat.com>
      1f68a3e8
  22. Jul 19, 2023
    • Lewis Hyatt's avatar
      libcpp: Handle extended characters in user-defined literal suffix [PR103902] · 1d3e4f4e
      Lewis Hyatt authored
      The PR complains that we do not handle UTF-8 in the suffix for a user-defined
      literal, such as:
      
      bool operator ""_π (unsigned long long);
      
      In fact we don't handle any extended identifier characters there, whether
      UTF-8, UCNs, or the $ sign. We do handle it fine if the optional space after
      the "" tokens is included, since then the identifier is lexed in the
      "normal" way as its own token. But when it is lexed as part of the string
      token, this is handled in lex_string() with a one-off loop that is not aware
      of extended characters.
      
      This patch fixes it by adding a new function scan_cur_identifier() that can
      be used to lex an identifier while in the middle of lexing another token.
      
      BTW, the other place that has been mis-lexing identifiers is
      lex_identifier_intern(), which is used to implement #pragma push_macro
      and #pragma pop_macro. This does not support extended characters either.
      I will add that in a subsequent patch, because it can't directly reuse the
      new function, but rather needs to lex from a string instead of a cpp_buffer.
      
      With scan_cur_identifier(), we do also correctly warn about bidi and
      normalization issues in the extended identifiers comprising the suffix.
      
      libcpp/ChangeLog:
      
      	PR preprocessor/103902
      	* lex.cc (identifier_diagnostics_on_lex): New function refactoring
      	some common code.
      	(lex_identifier_intern): Use the new function.
      	(lex_identifier): Don't run identifier diagnostics here, rather let
      	the call site do it when needed.
      	(_cpp_lex_direct): Adjust the call sites of lex_identifier ()
      	acccordingly.
      	(struct scan_id_result): New struct.
      	(scan_cur_identifier): New function.
      	(create_literal2): New function.
      	(lit_accum::create_literal2): New function.
      	(is_macro): Folded into new function...
      	(maybe_ignore_udl_macro_suffix): ...here.
      	(is_macro_not_literal_suffix): Folded likewise.
      	(lex_raw_string): Handle UTF-8 in UDL suffix via
      	scan_cur_identifier ().
      	(lex_string): Likewise.
      
      gcc/testsuite/ChangeLog:
      
      	PR preprocessor/103902
      	* g++.dg/cpp0x/udlit-extended-id-1.C: New test.
      	* g++.dg/cpp0x/udlit-extended-id-2.C: New test.
      	* g++.dg/cpp0x/udlit-extended-id-3.C: New test.
      	* g++.dg/cpp0x/udlit-extended-id-4.C: New test.
      1d3e4f4e
  23. Jan 16, 2023
  24. Dec 07, 2022
    • Joseph Myers's avatar
      preprocessor: Enable __VA_OPT__ for C2x · ce53cf7b
      Joseph Myers authored
      C2x supports __VA_OPT__, so adjust libcpp not to pedwarn for uses of
      it (or of not passing any variable arguments to a variable-arguments
      macro) in standard C2x mode.
      
      I didn't try to duplicate existing tests for the details of the
      feature, just verified -pedantic-errors handling is as expected.  And
      there's a reasonable argument (bug 98859) that __VA_OPT__ shouldn't be
      diagnosed in older standard modes at all (as opposed to not passing
      any variable arguments to a variable-arguments macro, for which older
      versions of the C standard require a diagnostic as a constraint
      violation); that argument applies to C as much as to C++, but I
      haven't made any changes in that regard.
      
      Bootstrapped with no regressions for x86_64-pc-linux-gnu.
      
      libcpp/
      	* init.cc (lang_defaults): Enable va_opt for STDC2X.
      	* lex.cc (maybe_va_opt_error): Adjust diagnostic message for C.
      	* macro.cc (_cpp_arguments_ok): Update comment.
      
      gcc/testsuite/
      	* gcc.dg/cpp/c11-vararg-1.c, gcc.dg/cpp/c2x-va-opt-1.c: New tests.
      ce53cf7b
  25. Nov 05, 2022
    • Lewis Hyatt's avatar
      c++: libcpp: Support raw strings with newlines in directives [PR55971] · 3ad2167b
      Lewis Hyatt authored
      It's not currently possible to use a C++11 raw string containing a newline as
      part of the definition of a macro, or in any other preprocessing directive,
      such as:
      
       #define X R"(two
      lines)"
      
       #error R"(this error has
      two lines)"
      
      Add support for that by relaxing the conditions under which
      _cpp_get_fresh_line() refuses to get a new line. For the case of lexing a raw
      string, it's OK to do so as long as there is another line within the current
      buffer. The code in cpp_get_fresh_line() was refactored into a new function
      get_fresh_line_impl(), so that the new logic is applied only when processing a
      raw string and not any other times.
      
      libcpp/ChangeLog:
      
      	PR preprocessor/55971
      	* lex.cc (get_fresh_line_impl): New function refactoring the code
      	from...
      	(_cpp_get_fresh_line): ...here.
      	(lex_raw_string): Use the new version of get_fresh_line_impl() to
      	support raw strings containing new lines when processing a directive.
      
      gcc/testsuite/ChangeLog:
      
      	PR preprocessor/55971
      	* c-c++-common/raw-string-directive-1.c: New test.
      	* c-c++-common/raw-string-directive-2.c: New test.
      
      gcc/c-family/ChangeLog:
      
      	PR preprocessor/55971
      	* c-ppoutput.cc (adjust_for_newlines): Update comment.
      3ad2167b
  26. Oct 14, 2022
    • Joseph Myers's avatar
      preprocessor: C2x identifier rules · 36d20fa4
      Joseph Myers authored
      C2x has, like C++, adopted rules for identifiers based directly on an
      unversioned normative reference to Unicode.  Make libcpp follow those
      rules for c2x / gnu2x standards (this involves bringing back a flag
      separate from the C++ one for whether to use these identifier rules,
      but this time enabled for all C++ language versions since that was the
      conclusion adopted for C++ identifier handling).
      
      There is one change here that affects C++.  I believe the new
      normative requirement for NFC only applies to identifiers, not to the
      use of identifier-continue characters in pp-numbers, where there is no
      such requirement and so the diagnostic ought to be a warning not a
      pedwarn in pp-numbers, and that this is the case for both C and C++.
      
      Bootstrapped with no regressions for x86_64-pc-linux-gnu.
      
      libcpp/
      	* charset.cc (ucn_valid_in_identifier): Check xid_identifiers not
      	cplusplus to determine whether to use CXX23 and NXX23 flags.
      	* include/cpplib.h (struct cpp_options): Add xid_identifiers.
      	* init.cc (struct lang_flags, lang_defaults): Add xid_identifiers.
      	(cpp_set_lang): Set xid_identifiers.
      	* lex.cc (warn_about_normalization): Add parameter identifier.
      	Only pedwarn about non-NFC for identifiers, not pp-numbers.
      	(_cpp_lex_direct): Update calls to warn_about_normalization.
      
      gcc/testsuite/
      	* gcc.dg/cpp/c2x-ucnid-1-utf8.c, gcc.dg/cpp/c2x-ucnid-1.c: New
      	tests.
      36d20fa4
  27. Sep 28, 2022
    • Eugene Rozenfeld's avatar
      Add instruction level discriminator support. · f1adf45b
      Eugene Rozenfeld authored
      This is the first in a series of patches to enable discriminator support
      in AutoFDO.
      
      This patch switches to tracking discriminators per statement/instruction
      instead of per basic block. Tracking per basic block was problematic since
      not all statements in a basic block needed a discriminator and, also, later
      optimizations could move statements between basic blocks making correlation
      during AutoFDO compilation unreliable. Tracking per statement also allows
      us to assign different discriminators to multiple function calls in the same
      basic block. A subsequent patch will add that support.
      
      The idea of this patch is based on commit 4c311d95cf6d9519c3c20f641cc77af7df491fdf
      by Dehao Chen in vendors/google/heads/gcc-4_8 but uses a slightly different
      approach. In Dehao's work special (normally unused) location ids and side tables
      were used to keep track of locations with discriminators. Things have changed
      since then and I don't think we have unused location ids anymore. Instead,
      I made discriminators a part of ad-hoc locations.
      
      The difference from Dehao's work also includes support for discriminator
      reading/writing in lto streaming and in modules.
      
      Tested on x86_64-pc-linux-gnu.
      
      gcc/ChangeLog:
      
      	* basic-block.h: Remove discriminator from basic blocks.
      	* cfghooks.cc (split_block_1): Remove discriminator from basic blocks.
      	* final.cc (final_start_function_1): Switch from per-bb to per statement
      	discriminator.
      	(final_scan_insn_1): Don't keep track of basic block discriminators.
      	(compute_discriminator): Switch from basic block discriminators to
      	instruction discriminators.
      	(insn_discriminator): New function to return instruction discriminator.
      	(notice_source_line): Use insn_discriminator.
      	* gimple-pretty-print.cc (dump_gimple_bb_header): Remove dumping of
      	basic block discriminators.
      	* gimple-streamer-in.cc (input_bb): Remove reading of basic block
      	discriminators.
      	* gimple-streamer-out.cc (output_bb): Remove writing of basic block
      	discriminators.
      	* input.cc (make_location): Pass 0 discriminator to COMBINE_LOCATION_DATA.
      	(location_with_discriminator): New function to combine locus with
      	a discriminator.
      	(has_discriminator): New function to check if a location has a discriminator.
      	(get_discriminator_from_loc): New function to get the discriminator
      	from a location.
      	* input.h: Declarations of new functions.
      	* lto-streamer-in.cc (cmp_loc): Use discriminators in location comparison.
      	(apply_location_cache): Keep track of current discriminator.
      	(input_location_and_block): Read discriminator from stream.
      	* lto-streamer-out.cc (clear_line_info): Set current discriminator to
      	UINT_MAX.
      	(lto_output_location_1): Write discriminator to stream.
      	* lto-streamer.h: Add discriminator to cached_location.
      	Add current_discr to lto_location_cache.
      	Add current_discr to output_block.
      	* print-rtl.cc (print_rtx_operand_code_i): Print discriminator.
      	* rtl.h: Add extern declaration of insn_discriminator.
      	* tree-cfg.cc (assign_discriminator): New function to assign a unique
      	discriminator value to all statements in a basic block that have the given
      	line number.
      	(assign_discriminators): Assign discriminators to statement locations.
      	* tree-pretty-print.cc (dump_location): Dump discriminators.
      	* tree.cc (set_block): Preserve discriminator when setting block.
      	(set_source_range): Preserve discriminator when setting source range.
      
      gcc/cp/ChangeLog:
      	* module.cc (write_location): Write discriminator.
      	(read_location): Read discriminator.
      
      libcpp/ChangeLog:
      
      	* include/line-map.h: Add discriminator to location_adhoc_data.
      	(get_combined_adhoc_loc): Add discriminator parameter.
      	(get_discriminator_from_adhoc_loc): Add external declaration.
      	(get_discriminator_from_loc): Add external declaration.
      	(COMBINE_LOCATION_DATA): Add discriminator parameter.
      	* lex.cc (get_location_for_byte_range_in_cur_line) Pass 0 discriminator
      	in a call to COMBINE_LOCATION_DATA.
      	(warn_about_normalization): Pass 0 discriminator in a call to
      	COMBINE_LOCATION_DATA.
      	(_cpp_lex_direct): Pass 0 discriminator in a call to
      	COMBINE_LOCATION_DATA.
      	* line-map.cc (location_adhoc_data_hash): Use discriminator compute
      	location_adhoc_data hash.
      	(location_adhoc_data_eq): Use discriminator when comparing
      	location_adhoc_data.
      	(can_be_stored_compactly_p): Check discriminator to determine
      	compact storage.
      	(get_combined_adhoc_loc): Add discriminator parameter.
      	(get_discriminator_from_adhoc_loc): New function to get the discriminator
      	from an ad-hoc location.
      	(get_discriminator_from_loc): New function to get the discriminator
      	from a location.
      
      gcc/testsuite/ChangeLog:
      
      	* c-c++-common/ubsan/pr85213.c: Pass -gno-statement-frontiers.
      f1adf45b
  28. Sep 01, 2022
    • Jakub Jelinek's avatar
      libcpp: Add -Winvalid-utf8 warning [PR106655] · 0b8c57ed
      Jakub Jelinek authored
      The following patch introduces a new warning - -Winvalid-utf8 similarly
      to what clang now has - to diagnose invalid UTF-8 byte sequences in
      comments, but not just in those, but also in string/character literals
      and outside of them.
      
      The warning is on by default when explicit -finput-charset=UTF-8 is
      used and C++23 compilation is requested and if -{,W}pedantic or
      -pedantic-errors it is actually a pedwarn.
      
      The reason it is on by default only for -finput-charset=UTF-8 is
      that the sources often are UTF-8, but sometimes could be some ASCII
      compatible single byte encoding where non-ASCII characters only
      appear in comments.  So having the warning off by default
      is IMO desirable.  The C++23 pedantic mode for when the source code
      is UTF-8 is -std=c++23 -pedantic-errors -finput-charset=UTF-8.
      
      2022-09-01  Jakub Jelinek  <jakub@redhat.com>
      
      	PR c++/106655
      libcpp/
      	* include/cpplib.h (struct cpp_options): Implement C++23
      	P2295R6 - Support for UTF-8 as a portable source file encoding.
      	Add cpp_warn_invalid_utf8 and cpp_input_charset_explicit fields.
      	(enum cpp_warning_reason): Add CPP_W_INVALID_UTF8 enumerator.
      	* init.cc (cpp_create_reader): Initialize cpp_warn_invalid_utf8
      	and cpp_input_charset_explicit.
      	* charset.cc (_cpp_valid_utf8): Adjust function comment.
      	* lex.cc (UCS_LIMIT): Define.
      	(utf8_continuation): New const variable.
      	(utf8_signifier): Move earlier in the file.
      	(_cpp_warn_invalid_utf8, _cpp_handle_multibyte_utf8): New functions.
      	(_cpp_skip_block_comment): Handle -Winvalid-utf8 warning.
      	(skip_line_comment): Likewise.
      	(lex_raw_string, lex_string): Likewise.
      	(_cpp_lex_direct): Likewise.
      gcc/
      	* doc/invoke.texi (-Winvalid-utf8): Document it.
      gcc/c-family/
      	* c.opt (-Winvalid-utf8): New warning.
      	* c-opts.cc (c_common_handle_option) <case OPT_finput_charset_>:
      	Set cpp_opts->cpp_input_charset_explicit.
      	(c_common_post_options): If -finput-charset=UTF-8 is explicit
      	in C++23, enable -Winvalid-utf8 by default and if -pedantic
      	or -pedantic-errors, make it a pedwarn.
      gcc/testsuite/
      	* c-c++-common/cpp/Winvalid-utf8-1.c: New test.
      	* c-c++-common/cpp/Winvalid-utf8-2.c: New test.
      	* c-c++-common/cpp/Winvalid-utf8-3.c: New test.
      	* g++.dg/cpp23/Winvalid-utf8-1.C: New test.
      	* g++.dg/cpp23/Winvalid-utf8-2.C: New test.
      	* g++.dg/cpp23/Winvalid-utf8-3.C: New test.
      	* g++.dg/cpp23/Winvalid-utf8-4.C: New test.
      	* g++.dg/cpp23/Winvalid-utf8-5.C: New test.
      	* g++.dg/cpp23/Winvalid-utf8-6.C: New test.
      	* g++.dg/cpp23/Winvalid-utf8-7.C: New test.
      	* g++.dg/cpp23/Winvalid-utf8-8.C: New test.
      	* g++.dg/cpp23/Winvalid-utf8-9.C: New test.
      	* g++.dg/cpp23/Winvalid-utf8-10.C: New test.
      	* g++.dg/cpp23/Winvalid-utf8-11.C: New test.
      	* g++.dg/cpp23/Winvalid-utf8-12.C: New test.
      0b8c57ed
  29. Aug 26, 2022
    • Jakub Jelinek's avatar
      c++: Implement C++23 P2071R2 - Named universal character escapes [PR106648] · eb4879ab
      Jakub Jelinek authored
      The following patch implements the
      C++23 P2071R2 - Named universal character escapes
      paper to support \N{LATIN SMALL LETTER E} etc.
      I've used Unicode 14.0, there are 144803 character name properties
      (including the ones generated by Unicode NR1 and NR2 rules)
      and correction/control/alternate aliases, together with zero terminators
      that would be 3884745 bytes, which is clearly unacceptable for libcpp.
      This patch instead contains a generator which from the UnicodeData.txt
      and NameAliases.txt files emits a space optimized radix tree (208765
      bytes long for 14.0), a single string literal dictionary (59418 bytes),
      maximum name length (currently 88 chars) and two small helper arrays
      for the NR1/NR2 name generation.
      The radix tree needs 2 to 9 bytes per node, the exact format is
      described in the generator program.  There could be ways to shrink
      the dictionary size somewhat at the expense of slightly slower lookups.
      
      Currently the patch implements strict matching (that is what is needed
      to actually implement it on valid code) and Unicode UAX44-LM2 algorithm
      loose matching to provide hints (that algorithm essentially ignores
      hyphens in between two alphanumeric characters, spaces and underscores
      (with one exception for hyphen) and does case insensitive matching).
      In the attachment is a WIP patch that shows how to implement also
      spellcheck.{h,cc} style discovery of misspellings, but I'll need to talk
      to David Malcolm about it, as spellcheck.{h,cc} is in gcc/ subdir
      (so the WIP incremental patch instead prints all the names to stderr).
      
      2022-08-26  Jakub Jelinek  <jakub@redhat.com>
      
      	PR c++/106648
      libcpp/
      	* charset.cc: Implement C++23 P2071R2 - Named universal character
      	escapes.  Include uname2c.h.
      	(hangul_syllables, hangul_count): New variables.
      	(struct uname2c_data): New type.
      	(_cpp_uname2c, _cpp_uname2c_uax44_lm2): New functions.
      	(_cpp_valid_ucn): Use them.  Handle named universal character escapes.
      	(convert_ucn): Adjust comment.
      	(convert_escape): Call convert_ucn even for \N.
      	(_cpp_interpret_identifier): Handle named universal character escapes.
      	* lex.cc (get_bidi_ucn): Fix up function comment formatting.
      	(get_bidi_named): New function.
      	(forms_identifier_p, lex_string): Handle named universal character
      	escapes.
      	* makeuname2c.cc: New file.  Small parts copied from makeucnid.cc.
      	* uname2c.h: New generated file.
      gcc/c-family/
      	* c-cppbuiltin.cc (c_cpp_builtins): Predefine
      	__cpp_named_character_escapes to 202207L.
      gcc/testsuite/
      	* c-c++-common/cpp/named-universal-char-escape-1.c: New test.
      	* c-c++-common/cpp/named-universal-char-escape-2.c: New test.
      	* c-c++-common/cpp/named-universal-char-escape-3.c: New test.
      	* c-c++-common/cpp/named-universal-char-escape-4.c: New test.
      	* c-c++-common/Wbidi-chars-25.c: New test.
      	* gcc.dg/cpp/named-universal-char-escape-1.c: New test.
      	* gcc.dg/cpp/named-universal-char-escape-2.c: New test.
      	* g++.dg/cpp/named-universal-char-escape-1.C: New test.
      	* g++.dg/cpp/named-universal-char-escape-2.C: New test.
      	* g++.dg/cpp23/feat-cxx2b.C: Test __cpp_named_character_escapes.
      eb4879ab
  30. Aug 20, 2022
    • Jakub Jelinek's avatar
      libcpp: Implement C++23 P2290R3 - Delimited escape sequences [PR106645] · e9dd050e
      Jakub Jelinek authored
      The following patch implements the C++23 P2290R3 paper.
      
      2022-08-20  Jakub Jelinek  <jakub@redhat.com>
      
      	PR c++/106645
      libcpp/
      	* include/cpplib.h (struct cpp_options): Implement
      	P2290R3 - Delimited escape sequences.  Add delimite_escape_seqs
      	member.
      	* init.cc (struct lang_flags): Likewise.
      	(lang_defaults): Add delim column.
      	(cpp_set_lang): Copy over delimite_escape_seqs.
      	* charset.cc (extend_char_range): New function.
      	(_cpp_valid_ucn): Use it.  Handle delimited escape sequences.
      	(convert_hex): Likewise.
      	(convert_oct): Likewise.
      	(convert_ucn): Use extend_char_range.
      	(convert_escape): Call convert_oct even for \o.
      	(_cpp_interpret_identifier): Handle delimited escape sequences.
      	* lex.cc (get_bidi_ucn_1): Likewise.  Add end argument, fill it in.
      	(get_bidi_ucn): Adjust get_bidi_ucn_1 caller.  Use end argument to
      	compute num_bytes.
      gcc/testsuite/
      	* c-c++-common/cpp/delimited-escape-seq-1.c: New test.
      	* c-c++-common/cpp/delimited-escape-seq-2.c: New test.
      	* c-c++-common/cpp/delimited-escape-seq-3.c: New test.
      	* c-c++-common/Wbidi-chars-24.c: New test.
      	* gcc.dg/cpp/delimited-escape-seq-1.c: New test.
      	* gcc.dg/cpp/delimited-escape-seq-2.c: New test.
      	* g++.dg/cpp/delimited-escape-seq-1.C: New test.
      	* g++.dg/cpp/delimited-escape-seq-2.C: New test.
      e9dd050e
  31. May 20, 2022
    • David Malcolm's avatar
      Use "final" and "override" directly, rather than via macros · ff171cb1
      David Malcolm authored
      
      As of GCC 11 onwards we have required a C++11 compiler, such as GCC 4.8
      or later.  On the assumption that any such compiler correctly implements
      "final" and "override", this patch updates the source tree to stop using
      the FINAL and OVERRIDE macros from ansidecl.h, in favor of simply using
      "final" and "override" directly.
      
      libcpp/ChangeLog:
      	* lex.cc: Replace uses of "FINAL" and "OVERRIDE" with "final" and
      	"override".
      
      gcc/analyzer/ChangeLog:
      	* analyzer-pass.cc: Replace uses of "FINAL" and "OVERRIDE" with
      	"final" and "override".
      	* call-info.h: Likewise.
      	* checker-path.h: Likewise.
      	* constraint-manager.cc: Likewise.
      	* diagnostic-manager.cc: Likewise.
      	* engine.cc: Likewise.
      	* exploded-graph.h: Likewise.
      	* feasible-graph.h: Likewise.
      	* pending-diagnostic.h: Likewise.
      	* region-model-impl-calls.cc: Likewise.
      	* region-model.cc: Likewise.
      	* region-model.h: Likewise.
      	* region.h: Likewise.
      	* sm-file.cc: Likewise.
      	* sm-malloc.cc: Likewise.
      	* sm-pattern-test.cc: Likewise.
      	* sm-sensitive.cc: Likewise.
      	* sm-signal.cc: Likewise.
      	* sm-taint.cc: Likewise.
      	* state-purge.h: Likewise.
      	* store.cc: Likewise.
      	* store.h: Likewise.
      	* supergraph.h: Likewise.
      	* svalue.h: Likewise.
      	* trimmed-graph.h: Likewise.
      	* varargs.cc: Likewise.
      
      gcc/c-family/ChangeLog:
      	* c-format.cc: Replace uses of "FINAL" and "OVERRIDE" with "final"
      	and "override".
      	* c-pretty-print.h: Likewise.
      
      gcc/cp/ChangeLog:
      	* cxx-pretty-print.h: Replace uses of "FINAL" and "OVERRIDE" with
      	"final" and "override".
      	* error.cc: Likewise.
      
      gcc/jit/ChangeLog:
      	* jit-playback.h: Replace uses of "FINAL" and "OVERRIDE" with
      	"final" and "override".
      	* jit-recording.cc: Likewise.
      	* jit-recording.h: Likewise.
      
      gcc/ChangeLog:
      	* config/aarch64/aarch64-sve-builtins-base.cc: Replace uses of
      	"FINAL" and "OVERRIDE" with "final" and "override".
      	* config/aarch64/aarch64-sve-builtins-functions.h: Likewise.
      	* config/aarch64/aarch64-sve-builtins-shapes.cc: Likewise.
      	* config/aarch64/aarch64-sve-builtins-sve2.cc: Likewise.
      	* diagnostic-path.h: Likewise.
      	* digraph.cc: Likewise.
      	* gcc-rich-location.h: Likewise.
      	* gimple-array-bounds.cc: Likewise.
      	* gimple-loop-versioning.cc: Likewise.
      	* gimple-range-cache.cc: Likewise.
      	* gimple-range-cache.h: Likewise.
      	* gimple-range-fold.cc: Likewise.
      	* gimple-range-fold.h: Likewise.
      	* gimple-range-tests.cc: Likewise.
      	* gimple-range.h: Likewise.
      	* gimple-ssa-evrp.cc: Likewise.
      	* input.cc: Likewise.
      	* json.h: Likewise.
      	* read-rtl-function.cc: Likewise.
      	* tree-complex.cc: Likewise.
      	* tree-diagnostic-path.cc: Likewise.
      	* tree-ssa-ccp.cc: Likewise.
      	* tree-ssa-copy.cc: Likewise.
      	* tree-vrp.cc: Likewise.
      	* value-query.h: Likewise.
      	* vr-values.h: Likewise.
      
      Signed-off-by: default avatarDavid Malcolm <dmalcolm@redhat.com>
      ff171cb1
  32. Jan 24, 2022
    • Marek Polacek's avatar
      preprocessor: -Wbidi-chars and UCNs [PR104030] · ae36f839
      Marek Polacek authored
      Stephan Bergmann reported that our -Wbidi-chars breaks the build
      of LibreOffice because we warn about UCNs even when their usage
      is correct: LibreOffice constructs strings piecewise, as in:
      
        aText = u"\u202D" + aText;
      
      and warning about that is overzealous.  Since no editor (AFAIK)
      interprets UCNs to show them as Unicode characters, there's less
      risk in misinterpreting them, and so perhaps we shouldn't warn
      about them by default.  However, identifiers containing UCNs or
      programs generating other programs could still cause confusion,
      so I'm keeping the UCN checking.  To turn it on, you just need
      to use -Wbidi-chars=unpaired,ucn or -Wbidi-chars=any,ucn.
      
      The implementation is done by using the new EnumSet feature.
      
      	PR preprocessor/104030
      
      gcc/c-family/ChangeLog:
      
      	* c.opt (Wbidi-chars): Mark as EnumSet.  Also accept =ucn.
      
      gcc/ChangeLog:
      
      	* doc/invoke.texi: Update documentation for -Wbidi-chars.
      
      libcpp/ChangeLog:
      
      	* include/cpplib.h (enum cpp_bidirectional_level): Add
      	bidirectional_ucn.  Set values explicitly.
      	* internal.h (cpp_reader): Adjust warn_bidi_p.
      	* lex.cc (maybe_warn_bidi_on_close): Don't warn about UCNs
      	unless UCN checking is on.
      	(maybe_warn_bidi_on_char): Likewise.
      
      gcc/testsuite/ChangeLog:
      
      	* c-c++-common/Wbidi-chars-10.c: Turn on UCN checking.
      	* c-c++-common/Wbidi-chars-11.c: Likewise.
      	* c-c++-common/Wbidi-chars-14.c: Likewise.
      	* c-c++-common/Wbidi-chars-16.c: Likewise.
      	* c-c++-common/Wbidi-chars-17.c: Likewise.
      	* c-c++-common/Wbidi-chars-4.c: Likewise.
      	* c-c++-common/Wbidi-chars-5.c: Likewise.
      	* c-c++-common/Wbidi-chars-6.c: Likewise.
      	* c-c++-common/Wbidi-chars-7.c: Likewise.
      	* c-c++-common/Wbidi-chars-8.c: Likewise.
      	* c-c++-common/Wbidi-chars-9.c: Likewise.
      	* c-c++-common/Wbidi-chars-ranges.c: Likewise.
      	* c-c++-common/Wbidi-chars-18.c: New test.
      	* c-c++-common/Wbidi-chars-19.c: New test.
      	* c-c++-common/Wbidi-chars-20.c: New test.
      	* c-c++-common/Wbidi-chars-21.c: New test.
      	* c-c++-common/Wbidi-chars-22.c: New test.
      	* c-c++-common/Wbidi-chars-23.c: New test.
      ae36f839
  33. Jan 17, 2022
    • Martin Liska's avatar
      Rename .c files to .cc files. · 5c69acb3
      Martin Liska authored
      gcc/ada/ChangeLog:
      
      	* adadecode.c: Moved to...
      	* adadecode.cc: ...here.
      	* affinity.c: Moved to...
      	* affinity.cc: ...here.
      	* argv-lynxos178-raven-cert.c: Moved to...
      	* argv-lynxos178-raven-cert.cc: ...here.
      	* argv.c: Moved to...
      	* argv.cc: ...here.
      	* aux-io.c: Moved to...
      	* aux-io.cc: ...here.
      	* cio.c: Moved to...
      	* cio.cc: ...here.
      	* cstreams.c: Moved to...
      	* cstreams.cc: ...here.
      	* env.c: Moved to...
      	* env.cc: ...here.
      	* exit.c: Moved to...
      	* exit.cc: ...here.
      	* expect.c: Moved to...
      	* expect.cc: ...here.
      	* final.c: Moved to...
      	* final.cc: ...here.
      	* gcc-interface/cuintp.c: Moved to...
      	* gcc-interface/cuintp.cc: ...here.
      	* gcc-interface/decl.c: Moved to...
      	* gcc-interface/decl.cc: ...here.
      	* gcc-interface/misc.c: Moved to...
      	* gcc-interface/misc.cc: ...here.
      	* gcc-interface/targtyps.c: Moved to...
      	* gcc-interface/targtyps.cc: ...here.
      	* gcc-interface/trans.c: Moved to...
      	* gcc-interface/trans.cc: ...here.
      	* gcc-interface/utils.c: Moved to...
      	* gcc-interface/utils.cc: ...here.
      	* gcc-interface/utils2.c: Moved to...
      	* gcc-interface/utils2.cc: ...here.
      	* init.c: Moved to...
      	* init.cc: ...here.
      	* initialize.c: Moved to...
      	* initialize.cc: ...here.
      	* libgnarl/thread.c: Moved to...
      	* libgnarl/thread.cc: ...here.
      	* link.c: Moved to...
      	* link.cc: ...here.
      	* locales.c: Moved to...
      	* locales.cc: ...here.
      	* mkdir.c: Moved to...
      	* mkdir.cc: ...here.
      	* raise.c: Moved to...
      	* raise.cc: ...here.
      	* rtfinal.c: Moved to...
      	* rtfinal.cc: ...here.
      	* rtinit.c: Moved to...
      	* rtinit.cc: ...here.
      	* seh_init.c: Moved to...
      	* seh_init.cc: ...here.
      	* sigtramp-armdroid.c: Moved to...
      	* sigtramp-armdroid.cc: ...here.
      	* sigtramp-ios.c: Moved to...
      	* sigtramp-ios.cc: ...here.
      	* sigtramp-qnx.c: Moved to...
      	* sigtramp-qnx.cc: ...here.
      	* sigtramp-vxworks.c: Moved to...
      	* sigtramp-vxworks.cc: ...here.
      	* socket.c: Moved to...
      	* socket.cc: ...here.
      	* tracebak.c: Moved to...
      	* tracebak.cc: ...here.
      	* version.c: Moved to...
      	* version.cc: ...here.
      	* vx_stack_info.c: Moved to...
      	* vx_stack_info.cc: ...here.
      
      gcc/ChangeLog:
      
      	* adjust-alignment.c: Moved to...
      	* adjust-alignment.cc: ...here.
      	* alias.c: Moved to...
      	* alias.cc: ...here.
      	* alloc-pool.c: Moved to...
      	* alloc-pool.cc: ...here.
      	* asan.c: Moved to...
      	* asan.cc: ...here.
      	* attribs.c: Moved to...
      	* attribs.cc: ...here.
      	* auto-inc-dec.c: Moved to...
      	* auto-inc-dec.cc: ...here.
      	* auto-profile.c: Moved to...
      	* auto-profile.cc: ...here.
      	* bb-reorder.c: Moved to...
      	* bb-reorder.cc: ...here.
      	* bitmap.c: Moved to...
      	* bitmap.cc: ...here.
      	* btfout.c: Moved to...
      	* btfout.cc: ...here.
      	* builtins.c: Moved to...
      	* builtins.cc: ...here.
      	* caller-save.c: Moved to...
      	* caller-save.cc: ...here.
      	* calls.c: Moved to...
      	* calls.cc: ...here.
      	* ccmp.c: Moved to...
      	* ccmp.cc: ...here.
      	* cfg.c: Moved to...
      	* cfg.cc: ...here.
      	* cfganal.c: Moved to...
      	* cfganal.cc: ...here.
      	* cfgbuild.c: Moved to...
      	* cfgbuild.cc: ...here.
      	* cfgcleanup.c: Moved to...
      	* cfgcleanup.cc: ...here.
      	* cfgexpand.c: Moved to...
      	* cfgexpand.cc: ...here.
      	* cfghooks.c: Moved to...
      	* cfghooks.cc: ...here.
      	* cfgloop.c: Moved to...
      	* cfgloop.cc: ...here.
      	* cfgloopanal.c: Moved to...
      	* cfgloopanal.cc: ...here.
      	* cfgloopmanip.c: Moved to...
      	* cfgloopmanip.cc: ...here.
      	* cfgrtl.c: Moved to...
      	* cfgrtl.cc: ...here.
      	* cgraph.c: Moved to...
      	* cgraph.cc: ...here.
      	* cgraphbuild.c: Moved to...
      	* cgraphbuild.cc: ...here.
      	* cgraphclones.c: Moved to...
      	* cgraphclones.cc: ...here.
      	* cgraphunit.c: Moved to...
      	* cgraphunit.cc: ...here.
      	* collect-utils.c: Moved to...
      	* collect-utils.cc: ...here.
      	* collect2-aix.c: Moved to...
      	* collect2-aix.cc: ...here.
      	* collect2.c: Moved to...
      	* collect2.cc: ...here.
      	* combine-stack-adj.c: Moved to...
      	* combine-stack-adj.cc: ...here.
      	* combine.c: Moved to...
      	* combine.cc: ...here.
      	* common/common-targhooks.c: Moved to...
      	* common/common-targhooks.cc: ...here.
      	* common/config/aarch64/aarch64-common.c: Moved to...
      	* common/config/aarch64/aarch64-common.cc: ...here.
      	* common/config/alpha/alpha-common.c: Moved to...
      	* common/config/alpha/alpha-common.cc: ...here.
      	* common/config/arc/arc-common.c: Moved to...
      	* common/config/arc/arc-common.cc: ...here.
      	* common/config/arm/arm-common.c: Moved to...
      	* common/config/arm/arm-common.cc: ...here.
      	* common/config/avr/avr-common.c: Moved to...
      	* common/config/avr/avr-common.cc: ...here.
      	* common/config/bfin/bfin-common.c: Moved to...
      	* common/config/bfin/bfin-common.cc: ...here.
      	* common/config/bpf/bpf-common.c: Moved to...
      	* common/config/bpf/bpf-common.cc: ...here.
      	* common/config/c6x/c6x-common.c: Moved to...
      	* common/config/c6x/c6x-common.cc: ...here.
      	* common/config/cr16/cr16-common.c: Moved to...
      	* common/config/cr16/cr16-common.cc: ...here.
      	* common/config/cris/cris-common.c: Moved to...
      	* common/config/cris/cris-common.cc: ...here.
      	* common/config/csky/csky-common.c: Moved to...
      	* common/config/csky/csky-common.cc: ...here.
      	* common/config/default-common.c: Moved to...
      	* common/config/default-common.cc: ...here.
      	* common/config/epiphany/epiphany-common.c: Moved to...
      	* common/config/epiphany/epiphany-common.cc: ...here.
      	* common/config/fr30/fr30-common.c: Moved to...
      	* common/config/fr30/fr30-common.cc: ...here.
      	* common/config/frv/frv-common.c: Moved to...
      	* common/config/frv/frv-common.cc: ...here.
      	* common/config/gcn/gcn-common.c: Moved to...
      	* common/config/gcn/gcn-common.cc: ...here.
      	* common/config/h8300/h8300-common.c: Moved to...
      	* common/config/h8300/h8300-common.cc: ...here.
      	* common/config/i386/i386-common.c: Moved to...
      	* common/config/i386/i386-common.cc: ...here.
      	* common/config/ia64/ia64-common.c: Moved to...
      	* common/config/ia64/ia64-common.cc: ...here.
      	* common/config/iq2000/iq2000-common.c: Moved to...
      	* common/config/iq2000/iq2000-common.cc: ...here.
      	* common/config/lm32/lm32-common.c: Moved to...
      	* common/config/lm32/lm32-common.cc: ...here.
      	* common/config/m32r/m32r-common.c: Moved to...
      	* common/config/m32r/m32r-common.cc: ...here.
      	* common/config/m68k/m68k-common.c: Moved to...
      	* common/config/m68k/m68k-common.cc: ...here.
      	* common/config/mcore/mcore-common.c: Moved to...
      	* common/config/mcore/mcore-common.cc: ...here.
      	* common/config/microblaze/microblaze-common.c: Moved to...
      	* common/config/microblaze/microblaze-common.cc: ...here.
      	* common/config/mips/mips-common.c: Moved to...
      	* common/config/mips/mips-common.cc: ...here.
      	* common/config/mmix/mmix-common.c: Moved to...
      	* common/config/mmix/mmix-common.cc: ...here.
      	* common/config/mn10300/mn10300-common.c: Moved to...
      	* common/config/mn10300/mn10300-common.cc: ...here.
      	* common/config/msp430/msp430-common.c: Moved to...
      	* common/config/msp430/msp430-common.cc: ...here.
      	* common/config/nds32/nds32-common.c: Moved to...
      	* common/config/nds32/nds32-common.cc: ...here.
      	* common/config/nios2/nios2-common.c: Moved to...
      	* common/config/nios2/nios2-common.cc: ...here.
      	* common/config/nvptx/nvptx-common.c: Moved to...
      	* common/config/nvptx/nvptx-common.cc: ...here.
      	* common/config/or1k/or1k-common.c: Moved to...
      	* common/config/or1k/or1k-common.cc: ...here.
      	* common/config/pa/pa-common.c: Moved to...
      	* common/config/pa/pa-common.cc: ...here.
      	* common/config/pdp11/pdp11-common.c: Moved to...
      	* common/config/pdp11/pdp11-common.cc: ...here.
      	* common/config/pru/pru-common.c: Moved to...
      	* common/config/pru/pru-common.cc: ...here.
      	* common/config/riscv/riscv-common.c: Moved to...
      	* common/config/riscv/riscv-common.cc: ...here.
      	* common/config/rs6000/rs6000-common.c: Moved to...
      	* common/config/rs6000/rs6000-common.cc: ...here.
      	* common/config/rx/rx-common.c: Moved to...
      	* common/config/rx/rx-common.cc: ...here.
      	* common/config/s390/s390-common.c: Moved to...
      	* common/config/s390/s390-common.cc: ...here.
      	* common/config/sh/sh-common.c: Moved to...
      	* common/config/sh/sh-common.cc: ...here.
      	* common/config/sparc/sparc-common.c: Moved to...
      	* common/config/sparc/sparc-common.cc: ...here.
      	* common/config/tilegx/tilegx-common.c: Moved to...
      	* common/config/tilegx/tilegx-common.cc: ...here.
      	* common/config/tilepro/tilepro-common.c: Moved to...
      	* common/config/tilepro/tilepro-common.cc: ...here.
      	* common/config/v850/v850-common.c: Moved to...
      	* common/config/v850/v850-common.cc: ...here.
      	* common/config/vax/vax-common.c: Moved to...
      	* common/config/vax/vax-common.cc: ...here.
      	* common/config/visium/visium-common.c: Moved to...
      	* common/config/visium/visium-common.cc: ...here.
      	* common/config/xstormy16/xstormy16-common.c: Moved to...
      	* common/config/xstormy16/xstormy16-common.cc: ...here.
      	* common/config/xtensa/xtensa-common.c: Moved to...
      	* common/config/xtensa/xtensa-common.cc: ...here.
      	* compare-elim.c: Moved to...
      	* compare-elim.cc: ...here.
      	* config/aarch64/aarch64-bti-insert.c: Moved to...
      	* config/aarch64/aarch64-bti-insert.cc: ...here.
      	* config/aarch64/aarch64-builtins.c: Moved to...
      	* config/aarch64/aarch64-builtins.cc: ...here.
      	* config/aarch64/aarch64-c.c: Moved to...
      	* config/aarch64/aarch64-c.cc: ...here.
      	* config/aarch64/aarch64-d.c: Moved to...
      	* config/aarch64/aarch64-d.cc: ...here.
      	* config/aarch64/aarch64.c: Moved to...
      	* config/aarch64/aarch64.cc: ...here.
      	* config/aarch64/cortex-a57-fma-steering.c: Moved to...
      	* config/aarch64/cortex-a57-fma-steering.cc: ...here.
      	* config/aarch64/driver-aarch64.c: Moved to...
      	* config/aarch64/driver-aarch64.cc: ...here.
      	* config/aarch64/falkor-tag-collision-avoidance.c: Moved to...
      	* config/aarch64/falkor-tag-collision-avoidance.cc: ...here.
      	* config/aarch64/host-aarch64-darwin.c: Moved to...
      	* config/aarch64/host-aarch64-darwin.cc: ...here.
      	* config/alpha/alpha.c: Moved to...
      	* config/alpha/alpha.cc: ...here.
      	* config/alpha/driver-alpha.c: Moved to...
      	* config/alpha/driver-alpha.cc: ...here.
      	* config/arc/arc-c.c: Moved to...
      	* config/arc/arc-c.cc: ...here.
      	* config/arc/arc.c: Moved to...
      	* config/arc/arc.cc: ...here.
      	* config/arc/driver-arc.c: Moved to...
      	* config/arc/driver-arc.cc: ...here.
      	* config/arm/aarch-common.c: Moved to...
      	* config/arm/aarch-common.cc: ...here.
      	* config/arm/arm-builtins.c: Moved to...
      	* config/arm/arm-builtins.cc: ...here.
      	* config/arm/arm-c.c: Moved to...
      	* config/arm/arm-c.cc: ...here.
      	* config/arm/arm-d.c: Moved to...
      	* config/arm/arm-d.cc: ...here.
      	* config/arm/arm.c: Moved to...
      	* config/arm/arm.cc: ...here.
      	* config/arm/driver-arm.c: Moved to...
      	* config/arm/driver-arm.cc: ...here.
      	* config/avr/avr-c.c: Moved to...
      	* config/avr/avr-c.cc: ...here.
      	* config/avr/avr-devices.c: Moved to...
      	* config/avr/avr-devices.cc: ...here.
      	* config/avr/avr-log.c: Moved to...
      	* config/avr/avr-log.cc: ...here.
      	* config/avr/avr.c: Moved to...
      	* config/avr/avr.cc: ...here.
      	* config/avr/driver-avr.c: Moved to...
      	* config/avr/driver-avr.cc: ...here.
      	* config/avr/gen-avr-mmcu-specs.c: Moved to...
      	* config/avr/gen-avr-mmcu-specs.cc: ...here.
      	* config/avr/gen-avr-mmcu-texi.c: Moved to...
      	* config/avr/gen-avr-mmcu-texi.cc: ...here.
      	* config/bfin/bfin.c: Moved to...
      	* config/bfin/bfin.cc: ...here.
      	* config/bpf/bpf.c: Moved to...
      	* config/bpf/bpf.cc: ...here.
      	* config/bpf/coreout.c: Moved to...
      	* config/bpf/coreout.cc: ...here.
      	* config/c6x/c6x.c: Moved to...
      	* config/c6x/c6x.cc: ...here.
      	* config/cr16/cr16.c: Moved to...
      	* config/cr16/cr16.cc: ...here.
      	* config/cris/cris.c: Moved to...
      	* config/cris/cris.cc: ...here.
      	* config/csky/csky.c: Moved to...
      	* config/csky/csky.cc: ...here.
      	* config/darwin-c.c: Moved to...
      	* config/darwin-c.cc: ...here.
      	* config/darwin-d.c: Moved to...
      	* config/darwin-d.cc: ...here.
      	* config/darwin-driver.c: Moved to...
      	* config/darwin-driver.cc: ...here.
      	* config/darwin-f.c: Moved to...
      	* config/darwin-f.cc: ...here.
      	* config/darwin.c: Moved to...
      	* config/darwin.cc: ...here.
      	* config/default-c.c: Moved to...
      	* config/default-c.cc: ...here.
      	* config/default-d.c: Moved to...
      	* config/default-d.cc: ...here.
      	* config/dragonfly-d.c: Moved to...
      	* config/dragonfly-d.cc: ...here.
      	* config/epiphany/epiphany.c: Moved to...
      	* config/epiphany/epiphany.cc: ...here.
      	* config/epiphany/mode-switch-use.c: Moved to...
      	* config/epiphany/mode-switch-use.cc: ...here.
      	* config/epiphany/resolve-sw-modes.c: Moved to...
      	* config/epiphany/resolve-sw-modes.cc: ...here.
      	* config/fr30/fr30.c: Moved to...
      	* config/fr30/fr30.cc: ...here.
      	* config/freebsd-d.c: Moved to...
      	* config/freebsd-d.cc: ...here.
      	* config/frv/frv.c: Moved to...
      	* config/frv/frv.cc: ...here.
      	* config/ft32/ft32.c: Moved to...
      	* config/ft32/ft32.cc: ...here.
      	* config/gcn/driver-gcn.c: Moved to...
      	* config/gcn/driver-gcn.cc: ...here.
      	* config/gcn/gcn-run.c: Moved to...
      	* config/gcn/gcn-run.cc: ...here.
      	* config/gcn/gcn-tree.c: Moved to...
      	* config/gcn/gcn-tree.cc: ...here.
      	* config/gcn/gcn.c: Moved to...
      	* config/gcn/gcn.cc: ...here.
      	* config/gcn/mkoffload.c: Moved to...
      	* config/gcn/mkoffload.cc: ...here.
      	* config/glibc-c.c: Moved to...
      	* config/glibc-c.cc: ...here.
      	* config/glibc-d.c: Moved to...
      	* config/glibc-d.cc: ...here.
      	* config/h8300/h8300.c: Moved to...
      	* config/h8300/h8300.cc: ...here.
      	* config/host-darwin.c: Moved to...
      	* config/host-darwin.cc: ...here.
      	* config/host-hpux.c: Moved to...
      	* config/host-hpux.cc: ...here.
      	* config/host-linux.c: Moved to...
      	* config/host-linux.cc: ...here.
      	* config/host-netbsd.c: Moved to...
      	* config/host-netbsd.cc: ...here.
      	* config/host-openbsd.c: Moved to...
      	* config/host-openbsd.cc: ...here.
      	* config/host-solaris.c: Moved to...
      	* config/host-solaris.cc: ...here.
      	* config/i386/djgpp.c: Moved to...
      	* config/i386/djgpp.cc: ...here.
      	* config/i386/driver-i386.c: Moved to...
      	* config/i386/driver-i386.cc: ...here.
      	* config/i386/driver-mingw32.c: Moved to...
      	* config/i386/driver-mingw32.cc: ...here.
      	* config/i386/gnu-property.c: Moved to...
      	* config/i386/gnu-property.cc: ...here.
      	* config/i386/host-cygwin.c: Moved to...
      	* config/i386/host-cygwin.cc: ...here.
      	* config/i386/host-i386-darwin.c: Moved to...
      	* config/i386/host-i386-darwin.cc: ...here.
      	* config/i386/host-mingw32.c: Moved to...
      	* config/i386/host-mingw32.cc: ...here.
      	* config/i386/i386-builtins.c: Moved to...
      	* config/i386/i386-builtins.cc: ...here.
      	* config/i386/i386-c.c: Moved to...
      	* config/i386/i386-c.cc: ...here.
      	* config/i386/i386-d.c: Moved to...
      	* config/i386/i386-d.cc: ...here.
      	* config/i386/i386-expand.c: Moved to...
      	* config/i386/i386-expand.cc: ...here.
      	* config/i386/i386-features.c: Moved to...
      	* config/i386/i386-features.cc: ...here.
      	* config/i386/i386-options.c: Moved to...
      	* config/i386/i386-options.cc: ...here.
      	* config/i386/i386.c: Moved to...
      	* config/i386/i386.cc: ...here.
      	* config/i386/intelmic-mkoffload.c: Moved to...
      	* config/i386/intelmic-mkoffload.cc: ...here.
      	* config/i386/msformat-c.c: Moved to...
      	* config/i386/msformat-c.cc: ...here.
      	* config/i386/winnt-cxx.c: Moved to...
      	* config/i386/winnt-cxx.cc: ...here.
      	* config/i386/winnt-d.c: Moved to...
      	* config/i386/winnt-d.cc: ...here.
      	* config/i386/winnt-stubs.c: Moved to...
      	* config/i386/winnt-stubs.cc: ...here.
      	* config/i386/winnt.c: Moved to...
      	* config/i386/winnt.cc: ...here.
      	* config/i386/x86-tune-sched-atom.c: Moved to...
      	* config/i386/x86-tune-sched-atom.cc: ...here.
      	* config/i386/x86-tune-sched-bd.c: Moved to...
      	* config/i386/x86-tune-sched-bd.cc: ...here.
      	* config/i386/x86-tune-sched-core.c: Moved to...
      	* config/i386/x86-tune-sched-core.cc: ...here.
      	* config/i386/x86-tune-sched.c: Moved to...
      	* config/i386/x86-tune-sched.cc: ...here.
      	* config/ia64/ia64-c.c: Moved to...
      	* config/ia64/ia64-c.cc: ...here.
      	* config/ia64/ia64.c: Moved to...
      	* config/ia64/ia64.cc: ...here.
      	* config/iq2000/iq2000.c: Moved to...
      	* config/iq2000/iq2000.cc: ...here.
      	* config/linux.c: Moved to...
      	* config/linux.cc: ...here.
      	* config/lm32/lm32.c: Moved to...
      	* config/lm32/lm32.cc: ...here.
      	* config/m32c/m32c-pragma.c: Moved to...
      	* config/m32c/m32c-pragma.cc: ...here.
      	* config/m32c/m32c.c: Moved to...
      	* config/m32c/m32c.cc: ...here.
      	* config/m32r/m32r.c: Moved to...
      	* config/m32r/m32r.cc: ...here.
      	* config/m68k/m68k.c: Moved to...
      	* config/m68k/m68k.cc: ...here.
      	* config/mcore/mcore.c: Moved to...
      	* config/mcore/mcore.cc: ...here.
      	* config/microblaze/microblaze-c.c: Moved to...
      	* config/microblaze/microblaze-c.cc: ...here.
      	* config/microblaze/microblaze.c: Moved to...
      	* config/microblaze/microblaze.cc: ...here.
      	* config/mips/driver-native.c: Moved to...
      	* config/mips/driver-native.cc: ...here.
      	* config/mips/frame-header-opt.c: Moved to...
      	* config/mips/frame-header-opt.cc: ...here.
      	* config/mips/mips-d.c: Moved to...
      	* config/mips/mips-d.cc: ...here.
      	* config/mips/mips.c: Moved to...
      	* config/mips/mips.cc: ...here.
      	* config/mmix/mmix.c: Moved to...
      	* config/mmix/mmix.cc: ...here.
      	* config/mn10300/mn10300.c: Moved to...
      	* config/mn10300/mn10300.cc: ...here.
      	* config/moxie/moxie.c: Moved to...
      	* config/moxie/moxie.cc: ...here.
      	* config/msp430/driver-msp430.c: Moved to...
      	* config/msp430/driver-msp430.cc: ...here.
      	* config/msp430/msp430-c.c: Moved to...
      	* config/msp430/msp430-c.cc: ...here.
      	* config/msp430/msp430-devices.c: Moved to...
      	* config/msp430/msp430-devices.cc: ...here.
      	* config/msp430/msp430.c: Moved to...
      	* config/msp430/msp430.cc: ...here.
      	* config/nds32/nds32-cost.c: Moved to...
      	* config/nds32/nds32-cost.cc: ...here.
      	* config/nds32/nds32-fp-as-gp.c: Moved to...
      	* config/nds32/nds32-fp-as-gp.cc: ...here.
      	* config/nds32/nds32-intrinsic.c: Moved to...
      	* config/nds32/nds32-intrinsic.cc: ...here.
      	* config/nds32/nds32-isr.c: Moved to...
      	* config/nds32/nds32-isr.cc: ...here.
      	* config/nds32/nds32-md-auxiliary.c: Moved to...
      	* config/nds32/nds32-md-auxiliary.cc: ...here.
      	* config/nds32/nds32-memory-manipulation.c: Moved to...
      	* config/nds32/nds32-memory-manipulation.cc: ...here.
      	* config/nds32/nds32-pipelines-auxiliary.c: Moved to...
      	* config/nds32/nds32-pipelines-auxiliary.cc: ...here.
      	* config/nds32/nds32-predicates.c: Moved to...
      	* config/nds32/nds32-predicates.cc: ...here.
      	* config/nds32/nds32-relax-opt.c: Moved to...
      	* config/nds32/nds32-relax-opt.cc: ...here.
      	* config/nds32/nds32-utils.c: Moved to...
      	* config/nds32/nds32-utils.cc: ...here.
      	* config/nds32/nds32.c: Moved to...
      	* config/nds32/nds32.cc: ...here.
      	* config/netbsd-d.c: Moved to...
      	* config/netbsd-d.cc: ...here.
      	* config/netbsd.c: Moved to...
      	* config/netbsd.cc: ...here.
      	* config/nios2/nios2.c: Moved to...
      	* config/nios2/nios2.cc: ...here.
      	* config/nvptx/mkoffload.c: Moved to...
      	* config/nvptx/mkoffload.cc: ...here.
      	* config/nvptx/nvptx-c.c: Moved to...
      	* config/nvptx/nvptx-c.cc: ...here.
      	* config/nvptx/nvptx.c: Moved to...
      	* config/nvptx/nvptx.cc: ...here.
      	* config/openbsd-d.c: Moved to...
      	* config/openbsd-d.cc: ...here.
      	* config/or1k/or1k.c: Moved to...
      	* config/or1k/or1k.cc: ...here.
      	* config/pa/pa-d.c: Moved to...
      	* config/pa/pa-d.cc: ...here.
      	* config/pa/pa.c: Moved to...
      	* config/pa/pa.cc: ...here.
      	* config/pdp11/pdp11.c: Moved to...
      	* config/pdp11/pdp11.cc: ...here.
      	* config/pru/pru-passes.c: Moved to...
      	* config/pru/pru-passes.cc: ...here.
      	* config/pru/pru-pragma.c: Moved to...
      	* config/pru/pru-pragma.cc: ...here.
      	* config/pru/pru.c: Moved to...
      	* config/pru/pru.cc: ...here.
      	* config/riscv/riscv-builtins.c: Moved to...
      	* config/riscv/riscv-builtins.cc: ...here.
      	* config/riscv/riscv-c.c: Moved to...
      	* config/riscv/riscv-c.cc: ...here.
      	* config/riscv/riscv-d.c: Moved to...
      	* config/riscv/riscv-d.cc: ...here.
      	* config/riscv/riscv-shorten-memrefs.c: Moved to...
      	* config/riscv/riscv-shorten-memrefs.cc: ...here.
      	* config/riscv/riscv-sr.c: Moved to...
      	* config/riscv/riscv-sr.cc: ...here.
      	* config/riscv/riscv.c: Moved to...
      	* config/riscv/riscv.cc: ...here.
      	* config/rl78/rl78-c.c: Moved to...
      	* config/rl78/rl78-c.cc: ...here.
      	* config/rl78/rl78.c: Moved to...
      	* config/rl78/rl78.cc: ...here.
      	* config/rs6000/driver-rs6000.c: Moved to...
      	* config/rs6000/driver-rs6000.cc: ...here.
      	* config/rs6000/host-darwin.c: Moved to...
      	* config/rs6000/host-darwin.cc: ...here.
      	* config/rs6000/host-ppc64-darwin.c: Moved to...
      	* config/rs6000/host-ppc64-darwin.cc: ...here.
      	* config/rs6000/rbtree.c: Moved to...
      	* config/rs6000/rbtree.cc: ...here.
      	* config/rs6000/rs6000-c.c: Moved to...
      	* config/rs6000/rs6000-c.cc: ...here.
      	* config/rs6000/rs6000-call.c: Moved to...
      	* config/rs6000/rs6000-call.cc: ...here.
      	* config/rs6000/rs6000-d.c: Moved to...
      	* config/rs6000/rs6000-d.cc: ...here.
      	* config/rs6000/rs6000-gen-builtins.c: Moved to...
      	* config/rs6000/rs6000-gen-builtins.cc: ...here.
      	* config/rs6000/rs6000-linux.c: Moved to...
      	* config/rs6000/rs6000-linux.cc: ...here.
      	* config/rs6000/rs6000-logue.c: Moved to...
      	* config/rs6000/rs6000-logue.cc: ...here.
      	* config/rs6000/rs6000-p8swap.c: Moved to...
      	* config/rs6000/rs6000-p8swap.cc: ...here.
      	* config/rs6000/rs6000-pcrel-opt.c: Moved to...
      	* config/rs6000/rs6000-pcrel-opt.cc: ...here.
      	* config/rs6000/rs6000-string.c: Moved to...
      	* config/rs6000/rs6000-string.cc: ...here.
      	* config/rs6000/rs6000.c: Moved to...
      	* config/rs6000/rs6000.cc: ...here.
      	* config/rx/rx.c: Moved to...
      	* config/rx/rx.cc: ...here.
      	* config/s390/driver-native.c: Moved to...
      	* config/s390/driver-native.cc: ...here.
      	* config/s390/s390-c.c: Moved to...
      	* config/s390/s390-c.cc: ...here.
      	* config/s390/s390-d.c: Moved to...
      	* config/s390/s390-d.cc: ...here.
      	* config/s390/s390.c: Moved to...
      	* config/s390/s390.cc: ...here.
      	* config/sh/divtab-sh4-300.c: Moved to...
      	* config/sh/divtab-sh4-300.cc: ...here.
      	* config/sh/divtab-sh4.c: Moved to...
      	* config/sh/divtab-sh4.cc: ...here.
      	* config/sh/divtab.c: Moved to...
      	* config/sh/divtab.cc: ...here.
      	* config/sh/sh-c.c: Moved to...
      	* config/sh/sh-c.cc: ...here.
      	* config/sh/sh.c: Moved to...
      	* config/sh/sh.cc: ...here.
      	* config/sol2-c.c: Moved to...
      	* config/sol2-c.cc: ...here.
      	* config/sol2-cxx.c: Moved to...
      	* config/sol2-cxx.cc: ...here.
      	* config/sol2-d.c: Moved to...
      	* config/sol2-d.cc: ...here.
      	* config/sol2-stubs.c: Moved to...
      	* config/sol2-stubs.cc: ...here.
      	* config/sol2.c: Moved to...
      	* config/sol2.cc: ...here.
      	* config/sparc/driver-sparc.c: Moved to...
      	* config/sparc/driver-sparc.cc: ...here.
      	* config/sparc/sparc-c.c: Moved to...
      	* config/sparc/sparc-c.cc: ...here.
      	* config/sparc/sparc-d.c: Moved to...
      	* config/sparc/sparc-d.cc: ...here.
      	* config/sparc/sparc.c: Moved to...
      	* config/sparc/sparc.cc: ...here.
      	* config/stormy16/stormy16.c: Moved to...
      	* config/stormy16/stormy16.cc: ...here.
      	* config/tilegx/mul-tables.c: Moved to...
      	* config/tilegx/mul-tables.cc: ...here.
      	* config/tilegx/tilegx-c.c: Moved to...
      	* config/tilegx/tilegx-c.cc: ...here.
      	* config/tilegx/tilegx.c: Moved to...
      	* config/tilegx/tilegx.cc: ...here.
      	* config/tilepro/mul-tables.c: Moved to...
      	* config/tilepro/mul-tables.cc: ...here.
      	* config/tilepro/tilepro-c.c: Moved to...
      	* config/tilepro/tilepro-c.cc: ...here.
      	* config/tilepro/tilepro.c: Moved to...
      	* config/tilepro/tilepro.cc: ...here.
      	* config/v850/v850-c.c: Moved to...
      	* config/v850/v850-c.cc: ...here.
      	* config/v850/v850.c: Moved to...
      	* config/v850/v850.cc: ...here.
      	* config/vax/vax.c: Moved to...
      	* config/vax/vax.cc: ...here.
      	* config/visium/visium.c: Moved to...
      	* config/visium/visium.cc: ...here.
      	* config/vms/vms-c.c: Moved to...
      	* config/vms/vms-c.cc: ...here.
      	* config/vms/vms-f.c: Moved to...
      	* config/vms/vms-f.cc: ...here.
      	* config/vms/vms.c: Moved to...
      	* config/vms/vms.cc: ...here.
      	* config/vxworks-c.c: Moved to...
      	* config/vxworks-c.cc: ...here.
      	* config/vxworks.c: Moved to...
      	* config/vxworks.cc: ...here.
      	* config/winnt-c.c: Moved to...
      	* config/winnt-c.cc: ...here.
      	* config/xtensa/xtensa.c: Moved to...
      	* config/xtensa/xtensa.cc: ...here.
      	* context.c: Moved to...
      	* context.cc: ...here.
      	* convert.c: Moved to...
      	* convert.cc: ...here.
      	* coverage.c: Moved to...
      	* coverage.cc: ...here.
      	* cppbuiltin.c: Moved to...
      	* cppbuiltin.cc: ...here.
      	* cppdefault.c: Moved to...
      	* cppdefault.cc: ...here.
      	* cprop.c: Moved to...
      	* cprop.cc: ...here.
      	* cse.c: Moved to...
      	* cse.cc: ...here.
      	* cselib.c: Moved to...
      	* cselib.cc: ...here.
      	* ctfc.c: Moved to...
      	* ctfc.cc: ...here.
      	* ctfout.c: Moved to...
      	* ctfout.cc: ...here.
      	* data-streamer-in.c: Moved to...
      	* data-streamer-in.cc: ...here.
      	* data-streamer-out.c: Moved to...
      	* data-streamer-out.cc: ...here.
      	* data-streamer.c: Moved to...
      	* data-streamer.cc: ...here.
      	* dbgcnt.c: Moved to...
      	* dbgcnt.cc: ...here.
      	* dbxout.c: Moved to...
      	* dbxout.cc: ...here.
      	* dce.c: Moved to...
      	* dce.cc: ...here.
      	* ddg.c: Moved to...
      	* ddg.cc: ...here.
      	* debug.c: Moved to...
      	* debug.cc: ...here.
      	* df-core.c: Moved to...
      	* df-core.cc: ...here.
      	* df-problems.c: Moved to...
      	* df-problems.cc: ...here.
      	* df-scan.c: Moved to...
      	* df-scan.cc: ...here.
      	* dfp.c: Moved to...
      	* dfp.cc: ...here.
      	* diagnostic-color.c: Moved to...
      	* diagnostic-color.cc: ...here.
      	* diagnostic-show-locus.c: Moved to...
      	* diagnostic-show-locus.cc: ...here.
      	* diagnostic-spec.c: Moved to...
      	* diagnostic-spec.cc: ...here.
      	* diagnostic.c: Moved to...
      	* diagnostic.cc: ...here.
      	* dojump.c: Moved to...
      	* dojump.cc: ...here.
      	* dominance.c: Moved to...
      	* dominance.cc: ...here.
      	* domwalk.c: Moved to...
      	* domwalk.cc: ...here.
      	* double-int.c: Moved to...
      	* double-int.cc: ...here.
      	* dse.c: Moved to...
      	* dse.cc: ...here.
      	* dumpfile.c: Moved to...
      	* dumpfile.cc: ...here.
      	* dwarf2asm.c: Moved to...
      	* dwarf2asm.cc: ...here.
      	* dwarf2cfi.c: Moved to...
      	* dwarf2cfi.cc: ...here.
      	* dwarf2ctf.c: Moved to...
      	* dwarf2ctf.cc: ...here.
      	* dwarf2out.c: Moved to...
      	* dwarf2out.cc: ...here.
      	* early-remat.c: Moved to...
      	* early-remat.cc: ...here.
      	* edit-context.c: Moved to...
      	* edit-context.cc: ...here.
      	* emit-rtl.c: Moved to...
      	* emit-rtl.cc: ...here.
      	* errors.c: Moved to...
      	* errors.cc: ...here.
      	* et-forest.c: Moved to...
      	* et-forest.cc: ...here.
      	* except.c: Moved to...
      	* except.cc: ...here.
      	* explow.c: Moved to...
      	* explow.cc: ...here.
      	* expmed.c: Moved to...
      	* expmed.cc: ...here.
      	* expr.c: Moved to...
      	* expr.cc: ...here.
      	* fibonacci_heap.c: Moved to...
      	* fibonacci_heap.cc: ...here.
      	* file-find.c: Moved to...
      	* file-find.cc: ...here.
      	* file-prefix-map.c: Moved to...
      	* file-prefix-map.cc: ...here.
      	* final.c: Moved to...
      	* final.cc: ...here.
      	* fixed-value.c: Moved to...
      	* fixed-value.cc: ...here.
      	* fold-const-call.c: Moved to...
      	* fold-const-call.cc: ...here.
      	* fold-const.c: Moved to...
      	* fold-const.cc: ...here.
      	* fp-test.c: Moved to...
      	* fp-test.cc: ...here.
      	* function-tests.c: Moved to...
      	* function-tests.cc: ...here.
      	* function.c: Moved to...
      	* function.cc: ...here.
      	* fwprop.c: Moved to...
      	* fwprop.cc: ...here.
      	* gcc-ar.c: Moved to...
      	* gcc-ar.cc: ...here.
      	* gcc-main.c: Moved to...
      	* gcc-main.cc: ...here.
      	* gcc-rich-location.c: Moved to...
      	* gcc-rich-location.cc: ...here.
      	* gcc.c: Moved to...
      	* gcc.cc: ...here.
      	* gcov-dump.c: Moved to...
      	* gcov-dump.cc: ...here.
      	* gcov-io.c: Moved to...
      	* gcov-io.cc: ...here.
      	* gcov-tool.c: Moved to...
      	* gcov-tool.cc: ...here.
      	* gcov.c: Moved to...
      	* gcov.cc: ...here.
      	* gcse-common.c: Moved to...
      	* gcse-common.cc: ...here.
      	* gcse.c: Moved to...
      	* gcse.cc: ...here.
      	* genattr-common.c: Moved to...
      	* genattr-common.cc: ...here.
      	* genattr.c: Moved to...
      	* genattr.cc: ...here.
      	* genattrtab.c: Moved to...
      	* genattrtab.cc: ...here.
      	* genautomata.c: Moved to...
      	* genautomata.cc: ...here.
      	* gencfn-macros.c: Moved to...
      	* gencfn-macros.cc: ...here.
      	* gencheck.c: Moved to...
      	* gencheck.cc: ...here.
      	* genchecksum.c: Moved to...
      	* genchecksum.cc: ...here.
      	* gencodes.c: Moved to...
      	* gencodes.cc: ...here.
      	* genconditions.c: Moved to...
      	* genconditions.cc: ...here.
      	* genconfig.c: Moved to...
      	* genconfig.cc: ...here.
      	* genconstants.c: Moved to...
      	* genconstants.cc: ...here.
      	* genemit.c: Moved to...
      	* genemit.cc: ...here.
      	* genenums.c: Moved to...
      	* genenums.cc: ...here.
      	* generic-match-head.c: Moved to...
      	* generic-match-head.cc: ...here.
      	* genextract.c: Moved to...
      	* genextract.cc: ...here.
      	* genflags.c: Moved to...
      	* genflags.cc: ...here.
      	* gengenrtl.c: Moved to...
      	* gengenrtl.cc: ...here.
      	* gengtype-parse.c: Moved to...
      	* gengtype-parse.cc: ...here.
      	* gengtype-state.c: Moved to...
      	* gengtype-state.cc: ...here.
      	* gengtype.c: Moved to...
      	* gengtype.cc: ...here.
      	* genhooks.c: Moved to...
      	* genhooks.cc: ...here.
      	* genmatch.c: Moved to...
      	* genmatch.cc: ...here.
      	* genmddeps.c: Moved to...
      	* genmddeps.cc: ...here.
      	* genmddump.c: Moved to...
      	* genmddump.cc: ...here.
      	* genmodes.c: Moved to...
      	* genmodes.cc: ...here.
      	* genopinit.c: Moved to...
      	* genopinit.cc: ...here.
      	* genoutput.c: Moved to...
      	* genoutput.cc: ...here.
      	* genpeep.c: Moved to...
      	* genpeep.cc: ...here.
      	* genpreds.c: Moved to...
      	* genpreds.cc: ...here.
      	* genrecog.c: Moved to...
      	* genrecog.cc: ...here.
      	* gensupport.c: Moved to...
      	* gensupport.cc: ...here.
      	* gentarget-def.c: Moved to...
      	* gentarget-def.cc: ...here.
      	* genversion.c: Moved to...
      	* genversion.cc: ...here.
      	* ggc-common.c: Moved to...
      	* ggc-common.cc: ...here.
      	* ggc-none.c: Moved to...
      	* ggc-none.cc: ...here.
      	* ggc-page.c: Moved to...
      	* ggc-page.cc: ...here.
      	* ggc-tests.c: Moved to...
      	* ggc-tests.cc: ...here.
      	* gimple-builder.c: Moved to...
      	* gimple-builder.cc: ...here.
      	* gimple-expr.c: Moved to...
      	* gimple-expr.cc: ...here.
      	* gimple-fold.c: Moved to...
      	* gimple-fold.cc: ...here.
      	* gimple-iterator.c: Moved to...
      	* gimple-iterator.cc: ...here.
      	* gimple-laddress.c: Moved to...
      	* gimple-laddress.cc: ...here.
      	* gimple-loop-jam.c: Moved to...
      	* gimple-loop-jam.cc: ...here.
      	* gimple-low.c: Moved to...
      	* gimple-low.cc: ...here.
      	* gimple-match-head.c: Moved to...
      	* gimple-match-head.cc: ...here.
      	* gimple-pretty-print.c: Moved to...
      	* gimple-pretty-print.cc: ...here.
      	* gimple-ssa-backprop.c: Moved to...
      	* gimple-ssa-backprop.cc: ...here.
      	* gimple-ssa-evrp-analyze.c: Moved to...
      	* gimple-ssa-evrp-analyze.cc: ...here.
      	* gimple-ssa-evrp.c: Moved to...
      	* gimple-ssa-evrp.cc: ...here.
      	* gimple-ssa-isolate-paths.c: Moved to...
      	* gimple-ssa-isolate-paths.cc: ...here.
      	* gimple-ssa-nonnull-compare.c: Moved to...
      	* gimple-ssa-nonnull-compare.cc: ...here.
      	* gimple-ssa-split-paths.c: Moved to...
      	* gimple-ssa-split-paths.cc: ...here.
      	* gimple-ssa-sprintf.c: Moved to...
      	* gimple-ssa-sprintf.cc: ...here.
      	* gimple-ssa-store-merging.c: Moved to...
      	* gimple-ssa-store-merging.cc: ...here.
      	* gimple-ssa-strength-reduction.c: Moved to...
      	* gimple-ssa-strength-reduction.cc: ...here.
      	* gimple-ssa-warn-alloca.c: Moved to...
      	* gimple-ssa-warn-alloca.cc: ...here.
      	* gimple-ssa-warn-restrict.c: Moved to...
      	* gimple-ssa-warn-restrict.cc: ...here.
      	* gimple-streamer-in.c: Moved to...
      	* gimple-streamer-in.cc: ...here.
      	* gimple-streamer-out.c: Moved to...
      	* gimple-streamer-out.cc: ...here.
      	* gimple-walk.c: Moved to...
      	* gimple-walk.cc: ...here.
      	* gimple-warn-recursion.c: Moved to...
      	* gimple-warn-recursion.cc: ...here.
      	* gimple.c: Moved to...
      	* gimple.cc: ...here.
      	* gimplify-me.c: Moved to...
      	* gimplify-me.cc: ...here.
      	* gimplify.c: Moved to...
      	* gimplify.cc: ...here.
      	* godump.c: Moved to...
      	* godump.cc: ...here.
      	* graph.c: Moved to...
      	* graph.cc: ...here.
      	* graphds.c: Moved to...
      	* graphds.cc: ...here.
      	* graphite-dependences.c: Moved to...
      	* graphite-dependences.cc: ...here.
      	* graphite-isl-ast-to-gimple.c: Moved to...
      	* graphite-isl-ast-to-gimple.cc: ...here.
      	* graphite-optimize-isl.c: Moved to...
      	* graphite-optimize-isl.cc: ...here.
      	* graphite-poly.c: Moved to...
      	* graphite-poly.cc: ...here.
      	* graphite-scop-detection.c: Moved to...
      	* graphite-scop-detection.cc: ...here.
      	* graphite-sese-to-poly.c: Moved to...
      	* graphite-sese-to-poly.cc: ...here.
      	* graphite.c: Moved to...
      	* graphite.cc: ...here.
      	* haifa-sched.c: Moved to...
      	* haifa-sched.cc: ...here.
      	* hash-map-tests.c: Moved to...
      	* hash-map-tests.cc: ...here.
      	* hash-set-tests.c: Moved to...
      	* hash-set-tests.cc: ...here.
      	* hash-table.c: Moved to...
      	* hash-table.cc: ...here.
      	* hooks.c: Moved to...
      	* hooks.cc: ...here.
      	* host-default.c: Moved to...
      	* host-default.cc: ...here.
      	* hw-doloop.c: Moved to...
      	* hw-doloop.cc: ...here.
      	* hwint.c: Moved to...
      	* hwint.cc: ...here.
      	* ifcvt.c: Moved to...
      	* ifcvt.cc: ...here.
      	* inchash.c: Moved to...
      	* inchash.cc: ...here.
      	* incpath.c: Moved to...
      	* incpath.cc: ...here.
      	* init-regs.c: Moved to...
      	* init-regs.cc: ...here.
      	* input.c: Moved to...
      	* input.cc: ...here.
      	* internal-fn.c: Moved to...
      	* internal-fn.cc: ...here.
      	* intl.c: Moved to...
      	* intl.cc: ...here.
      	* ipa-comdats.c: Moved to...
      	* ipa-comdats.cc: ...here.
      	* ipa-cp.c: Moved to...
      	* ipa-cp.cc: ...here.
      	* ipa-devirt.c: Moved to...
      	* ipa-devirt.cc: ...here.
      	* ipa-fnsummary.c: Moved to...
      	* ipa-fnsummary.cc: ...here.
      	* ipa-icf-gimple.c: Moved to...
      	* ipa-icf-gimple.cc: ...here.
      	* ipa-icf.c: Moved to...
      	* ipa-icf.cc: ...here.
      	* ipa-inline-analysis.c: Moved to...
      	* ipa-inline-analysis.cc: ...here.
      	* ipa-inline-transform.c: Moved to...
      	* ipa-inline-transform.cc: ...here.
      	* ipa-inline.c: Moved to...
      	* ipa-inline.cc: ...here.
      	* ipa-modref-tree.c: Moved to...
      	* ipa-modref-tree.cc: ...here.
      	* ipa-modref.c: Moved to...
      	* ipa-modref.cc: ...here.
      	* ipa-param-manipulation.c: Moved to...
      	* ipa-param-manipulation.cc: ...here.
      	* ipa-polymorphic-call.c: Moved to...
      	* ipa-polymorphic-call.cc: ...here.
      	* ipa-predicate.c: Moved to...
      	* ipa-predicate.cc: ...here.
      	* ipa-profile.c: Moved to...
      	* ipa-profile.cc: ...here.
      	* ipa-prop.c: Moved to...
      	* ipa-prop.cc: ...here.
      	* ipa-pure-const.c: Moved to...
      	* ipa-pure-const.cc: ...here.
      	* ipa-ref.c: Moved to...
      	* ipa-ref.cc: ...here.
      	* ipa-reference.c: Moved to...
      	* ipa-reference.cc: ...here.
      	* ipa-split.c: Moved to...
      	* ipa-split.cc: ...here.
      	* ipa-sra.c: Moved to...
      	* ipa-sra.cc: ...here.
      	* ipa-utils.c: Moved to...
      	* ipa-utils.cc: ...here.
      	* ipa-visibility.c: Moved to...
      	* ipa-visibility.cc: ...here.
      	* ipa.c: Moved to...
      	* ipa.cc: ...here.
      	* ira-build.c: Moved to...
      	* ira-build.cc: ...here.
      	* ira-color.c: Moved to...
      	* ira-color.cc: ...here.
      	* ira-conflicts.c: Moved to...
      	* ira-conflicts.cc: ...here.
      	* ira-costs.c: Moved to...
      	* ira-costs.cc: ...here.
      	* ira-emit.c: Moved to...
      	* ira-emit.cc: ...here.
      	* ira-lives.c: Moved to...
      	* ira-lives.cc: ...here.
      	* ira.c: Moved to...
      	* ira.cc: ...here.
      	* jump.c: Moved to...
      	* jump.cc: ...here.
      	* langhooks.c: Moved to...
      	* langhooks.cc: ...here.
      	* lcm.c: Moved to...
      	* lcm.cc: ...here.
      	* lists.c: Moved to...
      	* lists.cc: ...here.
      	* loop-doloop.c: Moved to...
      	* loop-doloop.cc: ...here.
      	* loop-init.c: Moved to...
      	* loop-init.cc: ...here.
      	* loop-invariant.c: Moved to...
      	* loop-invariant.cc: ...here.
      	* loop-iv.c: Moved to...
      	* loop-iv.cc: ...here.
      	* loop-unroll.c: Moved to...
      	* loop-unroll.cc: ...here.
      	* lower-subreg.c: Moved to...
      	* lower-subreg.cc: ...here.
      	* lra-assigns.c: Moved to...
      	* lra-assigns.cc: ...here.
      	* lra-coalesce.c: Moved to...
      	* lra-coalesce.cc: ...here.
      	* lra-constraints.c: Moved to...
      	* lra-constraints.cc: ...here.
      	* lra-eliminations.c: Moved to...
      	* lra-eliminations.cc: ...here.
      	* lra-lives.c: Moved to...
      	* lra-lives.cc: ...here.
      	* lra-remat.c: Moved to...
      	* lra-remat.cc: ...here.
      	* lra-spills.c: Moved to...
      	* lra-spills.cc: ...here.
      	* lra.c: Moved to...
      	* lra.cc: ...here.
      	* lto-cgraph.c: Moved to...
      	* lto-cgraph.cc: ...here.
      	* lto-compress.c: Moved to...
      	* lto-compress.cc: ...here.
      	* lto-opts.c: Moved to...
      	* lto-opts.cc: ...here.
      	* lto-section-in.c: Moved to...
      	* lto-section-in.cc: ...here.
      	* lto-section-out.c: Moved to...
      	* lto-section-out.cc: ...here.
      	* lto-streamer-in.c: Moved to...
      	* lto-streamer-in.cc: ...here.
      	* lto-streamer-out.c: Moved to...
      	* lto-streamer-out.cc: ...here.
      	* lto-streamer.c: Moved to...
      	* lto-streamer.cc: ...here.
      	* lto-wrapper.c: Moved to...
      	* lto-wrapper.cc: ...here.
      	* main.c: Moved to...
      	* main.cc: ...here.
      	* mcf.c: Moved to...
      	* mcf.cc: ...here.
      	* mode-switching.c: Moved to...
      	* mode-switching.cc: ...here.
      	* modulo-sched.c: Moved to...
      	* modulo-sched.cc: ...here.
      	* multiple_target.c: Moved to...
      	* multiple_target.cc: ...here.
      	* omp-expand.c: Moved to...
      	* omp-expand.cc: ...here.
      	* omp-general.c: Moved to...
      	* omp-general.cc: ...here.
      	* omp-low.c: Moved to...
      	* omp-low.cc: ...here.
      	* omp-offload.c: Moved to...
      	* omp-offload.cc: ...here.
      	* omp-simd-clone.c: Moved to...
      	* omp-simd-clone.cc: ...here.
      	* opt-suggestions.c: Moved to...
      	* opt-suggestions.cc: ...here.
      	* optabs-libfuncs.c: Moved to...
      	* optabs-libfuncs.cc: ...here.
      	* optabs-query.c: Moved to...
      	* optabs-query.cc: ...here.
      	* optabs-tree.c: Moved to...
      	* optabs-tree.cc: ...here.
      	* optabs.c: Moved to...
      	* optabs.cc: ...here.
      	* opts-common.c: Moved to...
      	* opts-common.cc: ...here.
      	* opts-global.c: Moved to...
      	* opts-global.cc: ...here.
      	* opts.c: Moved to...
      	* opts.cc: ...here.
      	* passes.c: Moved to...
      	* passes.cc: ...here.
      	* plugin.c: Moved to...
      	* plugin.cc: ...here.
      	* postreload-gcse.c: Moved to...
      	* postreload-gcse.cc: ...here.
      	* postreload.c: Moved to...
      	* postreload.cc: ...here.
      	* predict.c: Moved to...
      	* predict.cc: ...here.
      	* prefix.c: Moved to...
      	* prefix.cc: ...here.
      	* pretty-print.c: Moved to...
      	* pretty-print.cc: ...here.
      	* print-rtl-function.c: Moved to...
      	* print-rtl-function.cc: ...here.
      	* print-rtl.c: Moved to...
      	* print-rtl.cc: ...here.
      	* print-tree.c: Moved to...
      	* print-tree.cc: ...here.
      	* profile-count.c: Moved to...
      	* profile-count.cc: ...here.
      	* profile.c: Moved to...
      	* profile.cc: ...here.
      	* read-md.c: Moved to...
      	* read-md.cc: ...here.
      	* read-rtl-function.c: Moved to...
      	* read-rtl-function.cc: ...here.
      	* read-rtl.c: Moved to...
      	* read-rtl.cc: ...here.
      	* real.c: Moved to...
      	* real.cc: ...here.
      	* realmpfr.c: Moved to...
      	* realmpfr.cc: ...here.
      	* recog.c: Moved to...
      	* recog.cc: ...here.
      	* ree.c: Moved to...
      	* ree.cc: ...here.
      	* reg-stack.c: Moved to...
      	* reg-stack.cc: ...here.
      	* regcprop.c: Moved to...
      	* regcprop.cc: ...here.
      	* reginfo.c: Moved to...
      	* reginfo.cc: ...here.
      	* regrename.c: Moved to...
      	* regrename.cc: ...here.
      	* regstat.c: Moved to...
      	* regstat.cc: ...here.
      	* reload.c: Moved to...
      	* reload.cc: ...here.
      	* reload1.c: Moved to...
      	* reload1.cc: ...here.
      	* reorg.c: Moved to...
      	* reorg.cc: ...here.
      	* resource.c: Moved to...
      	* resource.cc: ...here.
      	* rtl-error.c: Moved to...
      	* rtl-error.cc: ...here.
      	* rtl-tests.c: Moved to...
      	* rtl-tests.cc: ...here.
      	* rtl.c: Moved to...
      	* rtl.cc: ...here.
      	* rtlanal.c: Moved to...
      	* rtlanal.cc: ...here.
      	* rtlhash.c: Moved to...
      	* rtlhash.cc: ...here.
      	* rtlhooks.c: Moved to...
      	* rtlhooks.cc: ...here.
      	* rtx-vector-builder.c: Moved to...
      	* rtx-vector-builder.cc: ...here.
      	* run-rtl-passes.c: Moved to...
      	* run-rtl-passes.cc: ...here.
      	* sancov.c: Moved to...
      	* sancov.cc: ...here.
      	* sanopt.c: Moved to...
      	* sanopt.cc: ...here.
      	* sbitmap.c: Moved to...
      	* sbitmap.cc: ...here.
      	* sched-deps.c: Moved to...
      	* sched-deps.cc: ...here.
      	* sched-ebb.c: Moved to...
      	* sched-ebb.cc: ...here.
      	* sched-rgn.c: Moved to...
      	* sched-rgn.cc: ...here.
      	* sel-sched-dump.c: Moved to...
      	* sel-sched-dump.cc: ...here.
      	* sel-sched-ir.c: Moved to...
      	* sel-sched-ir.cc: ...here.
      	* sel-sched.c: Moved to...
      	* sel-sched.cc: ...here.
      	* selftest-diagnostic.c: Moved to...
      	* selftest-diagnostic.cc: ...here.
      	* selftest-rtl.c: Moved to...
      	* selftest-rtl.cc: ...here.
      	* selftest-run-tests.c: Moved to...
      	* selftest-run-tests.cc: ...here.
      	* selftest.c: Moved to...
      	* selftest.cc: ...here.
      	* sese.c: Moved to...
      	* sese.cc: ...here.
      	* shrink-wrap.c: Moved to...
      	* shrink-wrap.cc: ...here.
      	* simplify-rtx.c: Moved to...
      	* simplify-rtx.cc: ...here.
      	* sparseset.c: Moved to...
      	* sparseset.cc: ...here.
      	* spellcheck-tree.c: Moved to...
      	* spellcheck-tree.cc: ...here.
      	* spellcheck.c: Moved to...
      	* spellcheck.cc: ...here.
      	* sreal.c: Moved to...
      	* sreal.cc: ...here.
      	* stack-ptr-mod.c: Moved to...
      	* stack-ptr-mod.cc: ...here.
      	* statistics.c: Moved to...
      	* statistics.cc: ...here.
      	* stmt.c: Moved to...
      	* stmt.cc: ...here.
      	* stor-layout.c: Moved to...
      	* stor-layout.cc: ...here.
      	* store-motion.c: Moved to...
      	* store-motion.cc: ...here.
      	* streamer-hooks.c: Moved to...
      	* streamer-hooks.cc: ...here.
      	* stringpool.c: Moved to...
      	* stringpool.cc: ...here.
      	* substring-locations.c: Moved to...
      	* substring-locations.cc: ...here.
      	* symtab.c: Moved to...
      	* symtab.cc: ...here.
      	* target-globals.c: Moved to...
      	* target-globals.cc: ...here.
      	* targhooks.c: Moved to...
      	* targhooks.cc: ...here.
      	* timevar.c: Moved to...
      	* timevar.cc: ...here.
      	* toplev.c: Moved to...
      	* toplev.cc: ...here.
      	* tracer.c: Moved to...
      	* tracer.cc: ...here.
      	* trans-mem.c: Moved to...
      	* trans-mem.cc: ...here.
      	* tree-affine.c: Moved to...
      	* tree-affine.cc: ...here.
      	* tree-call-cdce.c: Moved to...
      	* tree-call-cdce.cc: ...here.
      	* tree-cfg.c: Moved to...
      	* tree-cfg.cc: ...here.
      	* tree-cfgcleanup.c: Moved to...
      	* tree-cfgcleanup.cc: ...here.
      	* tree-chrec.c: Moved to...
      	* tree-chrec.cc: ...here.
      	* tree-complex.c: Moved to...
      	* tree-complex.cc: ...here.
      	* tree-data-ref.c: Moved to...
      	* tree-data-ref.cc: ...here.
      	* tree-dfa.c: Moved to...
      	* tree-dfa.cc: ...here.
      	* tree-diagnostic.c: Moved to...
      	* tree-diagnostic.cc: ...here.
      	* tree-dump.c: Moved to...
      	* tree-dump.cc: ...here.
      	* tree-eh.c: Moved to...
      	* tree-eh.cc: ...here.
      	* tree-emutls.c: Moved to...
      	* tree-emutls.cc: ...here.
      	* tree-if-conv.c: Moved to...
      	* tree-if-conv.cc: ...here.
      	* tree-inline.c: Moved to...
      	* tree-inline.cc: ...here.
      	* tree-into-ssa.c: Moved to...
      	* tree-into-ssa.cc: ...here.
      	* tree-iterator.c: Moved to...
      	* tree-iterator.cc: ...here.
      	* tree-loop-distribution.c: Moved to...
      	* tree-loop-distribution.cc: ...here.
      	* tree-nested.c: Moved to...
      	* tree-nested.cc: ...here.
      	* tree-nrv.c: Moved to...
      	* tree-nrv.cc: ...here.
      	* tree-object-size.c: Moved to...
      	* tree-object-size.cc: ...here.
      	* tree-outof-ssa.c: Moved to...
      	* tree-outof-ssa.cc: ...here.
      	* tree-parloops.c: Moved to...
      	* tree-parloops.cc: ...here.
      	* tree-phinodes.c: Moved to...
      	* tree-phinodes.cc: ...here.
      	* tree-predcom.c: Moved to...
      	* tree-predcom.cc: ...here.
      	* tree-pretty-print.c: Moved to...
      	* tree-pretty-print.cc: ...here.
      	* tree-profile.c: Moved to...
      	* tree-profile.cc: ...here.
      	* tree-scalar-evolution.c: Moved to...
      	* tree-scalar-evolution.cc: ...here.
      	* tree-sra.c: Moved to...
      	* tree-sra.cc: ...here.
      	* tree-ssa-address.c: Moved to...
      	* tree-ssa-address.cc: ...here.
      	* tree-ssa-alias.c: Moved to...
      	* tree-ssa-alias.cc: ...here.
      	* tree-ssa-ccp.c: Moved to...
      	* tree-ssa-ccp.cc: ...here.
      	* tree-ssa-coalesce.c: Moved to...
      	* tree-ssa-coalesce.cc: ...here.
      	* tree-ssa-copy.c: Moved to...
      	* tree-ssa-copy.cc: ...here.
      	* tree-ssa-dce.c: Moved to...
      	* tree-ssa-dce.cc: ...here.
      	* tree-ssa-dom.c: Moved to...
      	* tree-ssa-dom.cc: ...here.
      	* tree-ssa-dse.c: Moved to...
      	* tree-ssa-dse.cc: ...here.
      	* tree-ssa-forwprop.c: Moved to...
      	* tree-ssa-forwprop.cc: ...here.
      	* tree-ssa-ifcombine.c: Moved to...
      	* tree-ssa-ifcombine.cc: ...here.
      	* tree-ssa-live.c: Moved to...
      	* tree-ssa-live.cc: ...here.
      	* tree-ssa-loop-ch.c: Moved to...
      	* tree-ssa-loop-ch.cc: ...here.
      	* tree-ssa-loop-im.c: Moved to...
      	* tree-ssa-loop-im.cc: ...here.
      	* tree-ssa-loop-ivcanon.c: Moved to...
      	* tree-ssa-loop-ivcanon.cc: ...here.
      	* tree-ssa-loop-ivopts.c: Moved to...
      	* tree-ssa-loop-ivopts.cc: ...here.
      	* tree-ssa-loop-manip.c: Moved to...
      	* tree-ssa-loop-manip.cc: ...here.
      	* tree-ssa-loop-niter.c: Moved to...
      	* tree-ssa-loop-niter.cc: ...here.
      	* tree-ssa-loop-prefetch.c: Moved to...
      	* tree-ssa-loop-prefetch.cc: ...here.
      	* tree-ssa-loop-split.c: Moved to...
      	* tree-ssa-loop-split.cc: ...here.
      	* tree-ssa-loop-unswitch.c: Moved to...
      	* tree-ssa-loop-unswitch.cc: ...here.
      	* tree-ssa-loop.c: Moved to...
      	* tree-ssa-loop.cc: ...here.
      	* tree-ssa-math-opts.c: Moved to...
      	* tree-ssa-math-opts.cc: ...here.
      	* tree-ssa-operands.c: Moved to...
      	* tree-ssa-operands.cc: ...here.
      	* tree-ssa-phiopt.c: Moved to...
      	* tree-ssa-phiopt.cc: ...here.
      	* tree-ssa-phiprop.c: Moved to...
      	* tree-ssa-phiprop.cc: ...here.
      	* tree-ssa-pre.c: Moved to...
      	* tree-ssa-pre.cc: ...here.
      	* tree-ssa-propagate.c: Moved to...
      	* tree-ssa-propagate.cc: ...here.
      	* tree-ssa-reassoc.c: Moved to...
      	* tree-ssa-reassoc.cc: ...here.
      	* tree-ssa-sccvn.c: Moved to...
      	* tree-ssa-sccvn.cc: ...here.
      	* tree-ssa-scopedtables.c: Moved to...
      	* tree-ssa-scopedtables.cc: ...here.
      	* tree-ssa-sink.c: Moved to...
      	* tree-ssa-sink.cc: ...here.
      	* tree-ssa-strlen.c: Moved to...
      	* tree-ssa-strlen.cc: ...here.
      	* tree-ssa-structalias.c: Moved to...
      	* tree-ssa-structalias.cc: ...here.
      	* tree-ssa-tail-merge.c: Moved to...
      	* tree-ssa-tail-merge.cc: ...here.
      	* tree-ssa-ter.c: Moved to...
      	* tree-ssa-ter.cc: ...here.
      	* tree-ssa-threadbackward.c: Moved to...
      	* tree-ssa-threadbackward.cc: ...here.
      	* tree-ssa-threadedge.c: Moved to...
      	* tree-ssa-threadedge.cc: ...here.
      	* tree-ssa-threadupdate.c: Moved to...
      	* tree-ssa-threadupdate.cc: ...here.
      	* tree-ssa-uncprop.c: Moved to...
      	* tree-ssa-uncprop.cc: ...here.
      	* tree-ssa-uninit.c: Moved to...
      	* tree-ssa-uninit.cc: ...here.
      	* tree-ssa.c: Moved to...
      	* tree-ssa.cc: ...here.
      	* tree-ssanames.c: Moved to...
      	* tree-ssanames.cc: ...here.
      	* tree-stdarg.c: Moved to...
      	* tree-stdarg.cc: ...here.
      	* tree-streamer-in.c: Moved to...
      	* tree-streamer-in.cc: ...here.
      	* tree-streamer-out.c: Moved to...
      	* tree-streamer-out.cc: ...here.
      	* tree-streamer.c: Moved to...
      	* tree-streamer.cc: ...here.
      	* tree-switch-conversion.c: Moved to...
      	* tree-switch-conversion.cc: ...here.
      	* tree-tailcall.c: Moved to...
      	* tree-tailcall.cc: ...here.
      	* tree-vect-data-refs.c: Moved to...
      	* tree-vect-data-refs.cc: ...here.
      	* tree-vect-generic.c: Moved to...
      	* tree-vect-generic.cc: ...here.
      	* tree-vect-loop-manip.c: Moved to...
      	* tree-vect-loop-manip.cc: ...here.
      	* tree-vect-loop.c: Moved to...
      	* tree-vect-loop.cc: ...here.
      	* tree-vect-patterns.c: Moved to...
      	* tree-vect-patterns.cc: ...here.
      	* tree-vect-slp-patterns.c: Moved to...
      	* tree-vect-slp-patterns.cc: ...here.
      	* tree-vect-slp.c: Moved to...
      	* tree-vect-slp.cc: ...here.
      	* tree-vect-stmts.c: Moved to...
      	* tree-vect-stmts.cc: ...here.
      	* tree-vector-builder.c: Moved to...
      	* tree-vector-builder.cc: ...here.
      	* tree-vectorizer.c: Moved to...
      	* tree-vectorizer.cc: ...here.
      	* tree-vrp.c: Moved to...
      	* tree-vrp.cc: ...here.
      	* tree.c: Moved to...
      	* tree.cc: ...here.
      	* tsan.c: Moved to...
      	* tsan.cc: ...here.
      	* typed-splay-tree.c: Moved to...
      	* typed-splay-tree.cc: ...here.
      	* ubsan.c: Moved to...
      	* ubsan.cc: ...here.
      	* valtrack.c: Moved to...
      	* valtrack.cc: ...here.
      	* value-prof.c: Moved to...
      	* value-prof.cc: ...here.
      	* var-tracking.c: Moved to...
      	* var-tracking.cc: ...here.
      	* varasm.c: Moved to...
      	* varasm.cc: ...here.
      	* varpool.c: Moved to...
      	* varpool.cc: ...here.
      	* vec-perm-indices.c: Moved to...
      	* vec-perm-indices.cc: ...here.
      	* vec.c: Moved to...
      	* vec.cc: ...here.
      	* vmsdbgout.c: Moved to...
      	* vmsdbgout.cc: ...here.
      	* vr-values.c: Moved to...
      	* vr-values.cc: ...here.
      	* vtable-verify.c: Moved to...
      	* vtable-verify.cc: ...here.
      	* web.c: Moved to...
      	* web.cc: ...here.
      	* xcoffout.c: Moved to...
      	* xcoffout.cc: ...here.
      
      gcc/c-family/ChangeLog:
      
      	* c-ada-spec.c: Moved to...
      	* c-ada-spec.cc: ...here.
      	* c-attribs.c: Moved to...
      	* c-attribs.cc: ...here.
      	* c-common.c: Moved to...
      	* c-common.cc: ...here.
      	* c-cppbuiltin.c: Moved to...
      	* c-cppbuiltin.cc: ...here.
      	* c-dump.c: Moved to...
      	* c-dump.cc: ...here.
      	* c-format.c: Moved to...
      	* c-format.cc: ...here.
      	* c-gimplify.c: Moved to...
      	* c-gimplify.cc: ...here.
      	* c-indentation.c: Moved to...
      	* c-indentation.cc: ...here.
      	* c-lex.c: Moved to...
      	* c-lex.cc: ...here.
      	* c-omp.c: Moved to...
      	* c-omp.cc: ...here.
      	* c-opts.c: Moved to...
      	* c-opts.cc: ...here.
      	* c-pch.c: Moved to...
      	* c-pch.cc: ...here.
      	* c-ppoutput.c: Moved to...
      	* c-ppoutput.cc: ...here.
      	* c-pragma.c: Moved to...
      	* c-pragma.cc: ...here.
      	* c-pretty-print.c: Moved to...
      	* c-pretty-print.cc: ...here.
      	* c-semantics.c: Moved to...
      	* c-semantics.cc: ...here.
      	* c-ubsan.c: Moved to...
      	* c-ubsan.cc: ...here.
      	* c-warn.c: Moved to...
      	* c-warn.cc: ...here.
      	* cppspec.c: Moved to...
      	* cppspec.cc: ...here.
      	* stub-objc.c: Moved to...
      	* stub-objc.cc: ...here.
      
      gcc/c/ChangeLog:
      
      	* c-aux-info.c: Moved to...
      	* c-aux-info.cc: ...here.
      	* c-convert.c: Moved to...
      	* c-convert.cc: ...here.
      	* c-decl.c: Moved to...
      	* c-decl.cc: ...here.
      	* c-errors.c: Moved to...
      	* c-errors.cc: ...here.
      	* c-fold.c: Moved to...
      	* c-fold.cc: ...here.
      	* c-lang.c: Moved to...
      	* c-lang.cc: ...here.
      	* c-objc-common.c: Moved to...
      	* c-objc-common.cc: ...here.
      	* c-parser.c: Moved to...
      	* c-parser.cc: ...here.
      	* c-typeck.c: Moved to...
      	* c-typeck.cc: ...here.
      	* gccspec.c: Moved to...
      	* gccspec.cc: ...here.
      	* gimple-parser.c: Moved to...
      	* gimple-parser.cc: ...here.
      
      gcc/cp/ChangeLog:
      
      	* call.c: Moved to...
      	* call.cc: ...here.
      	* class.c: Moved to...
      	* class.cc: ...here.
      	* constexpr.c: Moved to...
      	* constexpr.cc: ...here.
      	* cp-gimplify.c: Moved to...
      	* cp-gimplify.cc: ...here.
      	* cp-lang.c: Moved to...
      	* cp-lang.cc: ...here.
      	* cp-objcp-common.c: Moved to...
      	* cp-objcp-common.cc: ...here.
      	* cp-ubsan.c: Moved to...
      	* cp-ubsan.cc: ...here.
      	* cvt.c: Moved to...
      	* cvt.cc: ...here.
      	* cxx-pretty-print.c: Moved to...
      	* cxx-pretty-print.cc: ...here.
      	* decl.c: Moved to...
      	* decl.cc: ...here.
      	* decl2.c: Moved to...
      	* decl2.cc: ...here.
      	* dump.c: Moved to...
      	* dump.cc: ...here.
      	* error.c: Moved to...
      	* error.cc: ...here.
      	* except.c: Moved to...
      	* except.cc: ...here.
      	* expr.c: Moved to...
      	* expr.cc: ...here.
      	* friend.c: Moved to...
      	* friend.cc: ...here.
      	* g++spec.c: Moved to...
      	* g++spec.cc: ...here.
      	* init.c: Moved to...
      	* init.cc: ...here.
      	* lambda.c: Moved to...
      	* lambda.cc: ...here.
      	* lex.c: Moved to...
      	* lex.cc: ...here.
      	* mangle.c: Moved to...
      	* mangle.cc: ...here.
      	* method.c: Moved to...
      	* method.cc: ...here.
      	* name-lookup.c: Moved to...
      	* name-lookup.cc: ...here.
      	* optimize.c: Moved to...
      	* optimize.cc: ...here.
      	* parser.c: Moved to...
      	* parser.cc: ...here.
      	* pt.c: Moved to...
      	* pt.cc: ...here.
      	* ptree.c: Moved to...
      	* ptree.cc: ...here.
      	* rtti.c: Moved to...
      	* rtti.cc: ...here.
      	* search.c: Moved to...
      	* search.cc: ...here.
      	* semantics.c: Moved to...
      	* semantics.cc: ...here.
      	* tree.c: Moved to...
      	* tree.cc: ...here.
      	* typeck.c: Moved to...
      	* typeck.cc: ...here.
      	* typeck2.c: Moved to...
      	* typeck2.cc: ...here.
      	* vtable-class-hierarchy.c: Moved to...
      	* vtable-class-hierarchy.cc: ...here.
      
      gcc/fortran/ChangeLog:
      
      	* arith.c: Moved to...
      	* arith.cc: ...here.
      	* array.c: Moved to...
      	* array.cc: ...here.
      	* bbt.c: Moved to...
      	* bbt.cc: ...here.
      	* check.c: Moved to...
      	* check.cc: ...here.
      	* class.c: Moved to...
      	* class.cc: ...here.
      	* constructor.c: Moved to...
      	* constructor.cc: ...here.
      	* convert.c: Moved to...
      	* convert.cc: ...here.
      	* cpp.c: Moved to...
      	* cpp.cc: ...here.
      	* data.c: Moved to...
      	* data.cc: ...here.
      	* decl.c: Moved to...
      	* decl.cc: ...here.
      	* dependency.c: Moved to...
      	* dependency.cc: ...here.
      	* dump-parse-tree.c: Moved to...
      	* dump-parse-tree.cc: ...here.
      	* error.c: Moved to...
      	* error.cc: ...here.
      	* expr.c: Moved to...
      	* expr.cc: ...here.
      	* f95-lang.c: Moved to...
      	* f95-lang.cc: ...here.
      	* frontend-passes.c: Moved to...
      	* frontend-passes.cc: ...here.
      	* gfortranspec.c: Moved to...
      	* gfortranspec.cc: ...here.
      	* interface.c: Moved to...
      	* interface.cc: ...here.
      	* intrinsic.c: Moved to...
      	* intrinsic.cc: ...here.
      	* io.c: Moved to...
      	* io.cc: ...here.
      	* iresolve.c: Moved to...
      	* iresolve.cc: ...here.
      	* match.c: Moved to...
      	* match.cc: ...here.
      	* matchexp.c: Moved to...
      	* matchexp.cc: ...here.
      	* misc.c: Moved to...
      	* misc.cc: ...here.
      	* module.c: Moved to...
      	* module.cc: ...here.
      	* openmp.c: Moved to...
      	* openmp.cc: ...here.
      	* options.c: Moved to...
      	* options.cc: ...here.
      	* parse.c: Moved to...
      	* parse.cc: ...here.
      	* primary.c: Moved to...
      	* primary.cc: ...here.
      	* resolve.c: Moved to...
      	* resolve.cc: ...here.
      	* scanner.c: Moved to...
      	* scanner.cc: ...here.
      	* simplify.c: Moved to...
      	* simplify.cc: ...here.
      	* st.c: Moved to...
      	* st.cc: ...here.
      	* symbol.c: Moved to...
      	* symbol.cc: ...here.
      	* target-memory.c: Moved to...
      	* target-memory.cc: ...here.
      	* trans-array.c: Moved to...
      	* trans-array.cc: ...here.
      	* trans-common.c: Moved to...
      	* trans-common.cc: ...here.
      	* trans-const.c: Moved to...
      	* trans-const.cc: ...here.
      	* trans-decl.c: Moved to...
      	* trans-decl.cc: ...here.
      	* trans-expr.c: Moved to...
      	* trans-expr.cc: ...here.
      	* trans-intrinsic.c: Moved to...
      	* trans-intrinsic.cc: ...here.
      	* trans-io.c: Moved to...
      	* trans-io.cc: ...here.
      	* trans-openmp.c: Moved to...
      	* trans-openmp.cc: ...here.
      	* trans-stmt.c: Moved to...
      	* trans-stmt.cc: ...here.
      	* trans-types.c: Moved to...
      	* trans-types.cc: ...here.
      	* trans.c: Moved to...
      	* trans.cc: ...here.
      
      gcc/go/ChangeLog:
      
      	* go-backend.c: Moved to...
      	* go-backend.cc: ...here.
      	* go-lang.c: Moved to...
      	* go-lang.cc: ...here.
      	* gospec.c: Moved to...
      	* gospec.cc: ...here.
      
      gcc/jit/ChangeLog:
      
      	* dummy-frontend.c: Moved to...
      	* dummy-frontend.cc: ...here.
      	* jit-builtins.c: Moved to...
      	* jit-builtins.cc: ...here.
      	* jit-logging.c: Moved to...
      	* jit-logging.cc: ...here.
      	* jit-playback.c: Moved to...
      	* jit-playback.cc: ...here.
      	* jit-recording.c: Moved to...
      	* jit-recording.cc: ...here.
      	* jit-result.c: Moved to...
      	* jit-result.cc: ...here.
      	* jit-spec.c: Moved to...
      	* jit-spec.cc: ...here.
      	* jit-tempdir.c: Moved to...
      	* jit-tempdir.cc: ...here.
      	* jit-w32.c: Moved to...
      	* jit-w32.cc: ...here.
      	* libgccjit.c: Moved to...
      	* libgccjit.cc: ...here.
      
      gcc/lto/ChangeLog:
      
      	* common.c: Moved to...
      	* common.cc: ...here.
      	* lto-common.c: Moved to...
      	* lto-common.cc: ...here.
      	* lto-dump.c: Moved to...
      	* lto-dump.cc: ...here.
      	* lto-lang.c: Moved to...
      	* lto-lang.cc: ...here.
      	* lto-object.c: Moved to...
      	* lto-object.cc: ...here.
      	* lto-partition.c: Moved to...
      	* lto-partition.cc: ...here.
      	* lto-symtab.c: Moved to...
      	* lto-symtab.cc: ...here.
      	* lto.c: Moved to...
      	* lto.cc: ...here.
      
      gcc/objc/ChangeLog:
      
      	* objc-act.c: Moved to...
      	* objc-act.cc: ...here.
      	* objc-encoding.c: Moved to...
      	* objc-encoding.cc: ...here.
      	* objc-gnu-runtime-abi-01.c: Moved to...
      	* objc-gnu-runtime-abi-01.cc: ...here.
      	* objc-lang.c: Moved to...
      	* objc-lang.cc: ...here.
      	* objc-map.c: Moved to...
      	* objc-map.cc: ...here.
      	* objc-next-runtime-abi-01.c: Moved to...
      	* objc-next-runtime-abi-01.cc: ...here.
      	* objc-next-runtime-abi-02.c: Moved to...
      	* objc-next-runtime-abi-02.cc: ...here.
      	* objc-runtime-shared-support.c: Moved to...
      	* objc-runtime-shared-support.cc: ...here.
      
      gcc/objcp/ChangeLog:
      
      	* objcp-decl.c: Moved to...
      	* objcp-decl.cc: ...here.
      	* objcp-lang.c: Moved to...
      	* objcp-lang.cc: ...here.
      
      libcpp/ChangeLog:
      
      	* charset.c: Moved to...
      	* charset.cc: ...here.
      	* directives.c: Moved to...
      	* directives.cc: ...here.
      	* errors.c: Moved to...
      	* errors.cc: ...here.
      	* expr.c: Moved to...
      	* expr.cc: ...here.
      	* files.c: Moved to...
      	* files.cc: ...here.
      	* identifiers.c: Moved to...
      	* identifiers.cc: ...here.
      	* init.c: Moved to...
      	* init.cc: ...here.
      	* lex.c: Moved to...
      	* lex.cc: ...here.
      	* line-map.c: Moved to...
      	* line-map.cc: ...here.
      	* macro.c: Moved to...
      	* macro.cc: ...here.
      	* makeucnid.c: Moved to...
      	* makeucnid.cc: ...here.
      	* mkdeps.c: Moved to...
      	* mkdeps.cc: ...here.
      	* pch.c: Moved to...
      	* pch.cc: ...here.
      	* symtab.c: Moved to...
      	* symtab.cc: ...here.
      	* traditional.c: Moved to...
      	* traditional.cc: ...here.
      5c69acb3
  34. Jan 03, 2022
  35. Dec 04, 2021
    • Jakub Jelinek's avatar
      libcpp: Fix up handling of deferred pragmas [PR102432] · 55dfce4d
      Jakub Jelinek authored
      The https://gcc.gnu.org/pipermail/gcc-patches/2020-November/557903.html
      change broke the following testcases.  The problem is when a pragma
      namespace allows expansion (i.e. p->is_nspace && p->allow_expansion),
      e.g. the omp or acc namespaces do, then when parsing the second pragma
      token we do it with pfile->state.in_directive set,
      pfile->state.prevent_expansion clear and pfile->state.in_deferred_pragma
      clear (the last one because we don't know yet if it will be a deferred
      pragma or not).  If the pragma line only contains a single name
      and newline after it, and there exists a function-like macro with the
      same name, the preprocessor needs to peek in funlike_invocation_p
      the next token whether it isn't ( but in this case it will see a newline.
      As pfile->state.in_directive is set, we don't read anything after the
      newline, pfile->buffer->need_line is set and CPP_EOF is lexed, which
      funlike_invocation_p doesn't push back.  Because name is a function-like
      macro and on the pragma line there is no ( after the name, it isn't
      expanded, and control flow returns to do_pragma.  If name is valid
      deferred pragma, we set pfile->state.in_deferred_pragma (and really
      need it set so that e.g. end_directive later on doesn't eat all the
      tokens from the pragma line).
      
      Before Nathan's change (which unfortunately didn't contain rationale
      on why it is better to do it like that), this wasn't a problem,
      next _cpp_lex_direct called when we want next token would return
      CPP_PRAGMA_EOF when it saw buffer->need_line, which would turn off
      pfile->state.in_deferred_pragma and following get token would already
      read the next line.  But Nathan's patch replaced it with an assertion
      failure that now triggers and CPP_PRAGMA_EOL is done only when lexing
      the '\n'.  Except for this special case that works fine, but in
      this case it doesn't because when peeking the token we still didn't know
      that it will be a deferred pragma.
      I've tried to fix that up in do_pragma by detecting this and pushing
      CPP_PRAGMA_EOL as lookahead, but that doesn't work because end_directive
      still needs to see pfile->state.in_deferred_pragma set.
      
      So, this patch affectively reverts part of Nathan's change, CPP_PRAGMA_EOL
      addition isn't done only when parsing the '\n', but is now done in both
      places, in the first one instead of the assertion failure.
      
      2021-12-04  Jakub Jelinek  <jakub@redhat.com>
      
      	PR preprocessor/102432
      	* lex.c (_cpp_lex_direct): If buffer->need_line while
      	pfile->state.in_deferred_pragma, return CPP_PRAGMA_EOL token instead
      	of assertion failure.
      
      	* c-c++-common/gomp/pr102432.c: New test.
      	* c-c++-common/goacc/pr102432.c: New test.
      55dfce4d
  36. Dec 01, 2021
    • Jakub Jelinek's avatar
      libcpp: Enable P1949R7 for C++98 too [PR100977] · c264208e
      Jakub Jelinek authored
      On Mon, Nov 29, 2021 at 05:53:58PM -0500, Jason Merrill wrote:
      > I'm inclined to go ahead and change C++98 as well; I doubt anyone is relying
      > on the particular C++98 extended character set rules, and we already accept
      > the union of the different sets when not pedantic.
      
      Ok, here is an incremental patch to do that also for -std={c,gnu}++98.
      
      2021-12-01  Jakub Jelinek  <jakub@redhat.com>
      
      	PR c++/100977
      	* init.c (struct lang_flags): Remove cxx23_identifiers.
      	(lang_defaults): Remove cxx23_identifiers initializers.
      	(cpp_set_lang): Don't copy cxx23_identifiers.
      	* include/cpplib.h (struct cpp_options): Adjust comment about
      	c11_identifiers.  Remove cxx23_identifiers field.
      	* lex.c (warn_about_normalization): Use cplusplus instead of
      	cxx23_identifiers.
      	* charset.c (ucn_valid_in_identifier): Likewise.
      
      	* g++.dg/cpp/ucnid-1.C: Adjust expected diagnostics.
      	* g++.dg/cpp/ucnid-1-utf8.C: Likewise.
      c264208e
  37. Nov 23, 2021
Loading