Skip to content
Snippets Groups Projects
  1. Jun 01, 2024
  2. May 31, 2024
    • Thomas Schwinge's avatar
      nvptx target: Global constructor, destructor support, via nvptx-tools 'ld' · d9c90c82
      Thomas Schwinge authored
      The function attributes 'constructor', 'destructor', and 'init_priority' now
      work, as do the C++ features making use of this.  Test cases with effective
      target 'global_constructor' and 'init_priority' now generally work, and
      'check-gcc-c++' test results greatly improve; no more
      "sorry, unimplemented: global constructors not supported on this target".
      
      For proper execution test results, this depends on
      <https://github.com/SourceryTools/nvptx-tools/commit/96f8fc59a757767b9e98157d95c21e9fef22a93b>
      "ld: Global constructor/destructor support".
      
      	gcc/
      	* config/nvptx/nvptx.h: Configure global constructor, destructor
      	support.
      	gcc/testsuite/
      	* gcc.dg/no_profile_instrument_function-attr-1.c: GCC/nvptx is
      	'NO_DOT_IN_LABEL' but not 'NO_DOLLAR_IN_LABEL', so '$' may apper
      	in identifiers.
      	* lib/target-supports.exp
      	(check_effective_target_global_constructor): Enable for nvptx.
      	libgcc/
      	* config/nvptx/crt0.c (__gbl_ctors): New weak function.
      	(__main): Invoke it.
      	* config/nvptx/gbl-ctors.c: New.
      	* config/nvptx/t-nvptx: Configure global constructor, destructor
      	support.
      d9c90c82
  3. May 22, 2024
  4. May 21, 2024
    • Kewen Lin's avatar
      libgcc, rs6000: Remove powerpcspe related code · 5d1d2e95
      Kewen Lin authored
      Since r9-4728 the powerpcspe support had been removed, this
      follow-up patch is to remove the remaining pieces in libgcc.
      
      libgcc/ChangeLog:
      
      	* config.host: Remove powerpc-*-eabispe* support.
      	* config/rs6000/linux-unwind.h (ppc_fallback_frame_state): Remove
      	__SPE__ code.
      	* config/rs6000/t-savresfgpr (LIB2ADD_ST): Remove e500crtres32gpr.S,
      	e500crtres32gpr.S, e500crtsav64gpr.S, e500crtsav64gprctr.S,
      	e500crtres64gpr.S, e500crtsav32gpr.S, e500crtsavg32gpr.S,
      	e500crtres64gprctr.S, e500crtsavg64gprctr.S, e500crtresx32gpr.S,
      	e500crtrest32gpr.S, e500crtrest64gpr.S and e500crtresx64gpr.S.
      	* config/rs6000/e500crtres32gpr.S: Remove.
      	* config/rs6000/e500crtres64gpr.S: Remove.
      	* config/rs6000/e500crtres64gprctr.S: Remove.
      	* config/rs6000/e500crtrest32gpr.S: Remove.
      	* config/rs6000/e500crtrest64gpr.S: Remove.
      	* config/rs6000/e500crtresx32gpr.S: Remove.
      	* config/rs6000/e500crtresx64gpr.S: Remove.
      	* config/rs6000/e500crtsav32gpr.S: Remove.
      	* config/rs6000/e500crtsav64gpr.S: Remove.
      	* config/rs6000/e500crtsav64gprctr.S: Remove.
      	* config/rs6000/e500crtsavg32gpr.S: Remove.
      	* config/rs6000/e500crtsavg64gpr.S: Remove.
      	* config/rs6000/e500crtsavg64gprctr.S: Remove.
      5d1d2e95
  5. May 19, 2024
  6. May 18, 2024
    • Wolfgang Hospital's avatar
      AVR: target/115065 - Tweak __clzhi2. · 988838da
      Wolfgang Hospital authored
      The libgcc implementation of __clzhi2 can be tweaked by
      one cycle in some situations by re-arranging the instructions.
      It also reduces the WCET by 1 cycle.
      
      libgcc/
      	PR target/115065
      	* config/avr/lib1funcs.S (__clzhi2): Tweak.
      988838da
  7. May 13, 2024
  8. May 10, 2024
    • Georg-Johann Lay's avatar
      AVR: target/114981 - Tweak __builtin_powif / __powisf2 · af64af69
      Georg-Johann Lay authored
      Implement __powisf2 in assembly.
      
      	PR target/114981
      libgcc/
      	* config/avr/t-avr (LIB2FUNCS_EXCLUDE): Add _powisf2.
      	(LIB1ASMFUNCS) [!avrtiny]: Add _powif.
      	* config/avr/lib1funcs.S (mov4): New .macro.
      	(L_powif, __powisf2) [!avrtiny]: New module and function.
      
      gcc/testsuite/
      	* gcc.target/avr/pr114981-powif.c: New test.
      af64af69
  9. May 09, 2024
  10. May 08, 2024
    • Georg-Johann Lay's avatar
      AVR: target/114981 - Support __builtin_powi[l] / __powidf2. · de4eea7d
      Georg-Johann Lay authored
      This supports __powidf2 by means of a double wrapper for already
      existing f7_powi (renamed to __f7_powi by f7-renames.h).
      It tweaks the implementation so that it does not perform trivial
      multiplications with 1.0 any more, but instead uses a move.
      It also fixes the last statement of f7_powi, which was wrong.
      Notice that f7_powi was unused until now.
      
      	PR target/114981
      libgcc/config/avr/libf7/
      	* libf7-common.mk (F7_ASM_PARTS): Add D_powi
      	* libf7-asm.sx (F7MOD_D_powi_, __powidf2): New module and function.
      	* libf7.c (f7_powi): Fix last (wrong) statement.
      	Tweak trivial multiplications with 1.0.
      
      gcc/testsuite/
      	* gcc.target/avr/pr114981-powil.c: New test.
      de4eea7d
  11. May 07, 2024
    • Zac Walker's avatar
      Add aarch64-w64-mingw32 target to libgcc · d6d7afcd
      Zac Walker authored
      Reuse MinGW definitions from i386 for libgcc. Move reused files to
      libgcc/config/mingw folder.
      
      libgcc/ChangeLog:
      
      	* config.host: Add aarch64-w64-mingw32 target. Adjust targets
      	after moving MinGW files.
      	* config/i386/t-gthr-win32: Move to...
      	* config/mingw/t-gthr-win32: ...here.
      	* config/i386/t-mingw-pthread: Move to...
      	* config/mingw/t-mingw-pthread: ...here.
      	* config/aarch64/t-no-eh: New file. EH is not yet implemented for
      	the target, and the default definition should be disabled.
      d6d7afcd
    • Wolfgang Hospital's avatar
      AVR: target/114835 - Tweak popcountqi2 · 8d2c93fc
      Wolfgang Hospital authored
      libgcc/
      	PR target/114835
      	* config/avr/lib1funcs.S (__popcountqi2): Use code that
      	is one instruction shorter / faster.
      8d2c93fc
    • Rainer Orth's avatar
      Remove obsolete Solaris 11.3 support · f68e90a0
      Rainer Orth authored
      Support for Solaris 11.3 had already been obsoleted in GCC 13.  However,
      since the only Solaris system in the cfarm was running 11.3, I've kept
      it in tree until now when both Solaris 11.4/SPARC and x86 systems have
      been added.
      
      This patch actually removes the Solaris 11.3 support.  Apart from
      several minor simplifications, there are two more widespread changes:
      
      * In Solaris 11.4, libsocket and libnsl were folded into libc, so
        there's no longer a need to link them explictly.
      
      * Since Solaris 11.4, Solaris includes all crts needed by gcc (like
        crt1.o and gcrt1.o) with the base system.  All workarounds to provide
        fallbacks can thus go.
      
      Bootstrapped without regressions on i386-pc-solaris2.11 and
      sparc-sun-solaris2.11 (as/ld, gas/ld, and gas/gld) as well as Solaris
      11.3/x86 to ascertain that version is actually rejected.
      
      2024-04-30  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
      
      	c++tools:
      	* configure.ac (ax_lib_socket_nsl.m4): Don't sinclude.
      	(AX_LIB_SOCKET_NSL): Don't call.
      	(NETLIBS): Remove.
      	* configure: Regenerate.
      	* Makefile.in (NETLIBS): Remove.
      	(g++-mapper-server$(exeext)): Remove $(NETLIBS).
      
      	gcc:
      	* config.gcc: Move *-*-solaris2.11.[0-3]* to unsupported list.
      	<*-*-solaris2*> (default_use_cxa_atexit): Set unconditionally.
      	* configure.ac (AX_LIB_SOCKET_NSL): Don't call.
      	(NETLIBS): Remove.
      	(gcc_cv_ld_aligned_shf_merge): Remove.
      	(hidden_linkonce) <i?86-*-solaris2* | x86_64-*-solaris2*>: Remove.
      	(gcc_cv_target_dl_iterate_phdr) <*-*-solaris2*>: Always set to yes.
      	* Makefile.in (NETLIBS): Remove.
      	* configure, config.in, aclocal.m4: Regenerate.
      	* config/sol2.h: Don't check HAVE_SOLARIS_CRTS.
      	(STARTFILE_SPEC): Remove !HAVE_SOLARIS_CRTS case.
      	[USE_GLD] (LINK_EH_SPEC): Remove TARGET_DL_ITERATE_PHDR guard.
      	* config/i386/i386.cc (USE_HIDDEN_LINKONCE): Remove guard.
      	* varasm.cc (mergeable_string_section): Remove
      	HAVE_LD_ALIGNED_SHF_MERGE handling.
      	(mergeable_constant_section): Likewise.
      
      	* doc/install.texi (Specific,i?86-*-solaris2*): Reference Solaris
      	11.4 only.
      	(Specific, *-*-solaris2*): Document Solaris 11.3 removal.  Remove
      	11.3 references and caveats.  Update for 11.4.
      
      	gcc/cp:
      	* Make-lang.in (cc1plus$(exeext)): Remove $(NETLIBS).
      
      	gcc/objcp:
      	* Make-lang.in (cc1objplus$(exeext)): Remove $(NETLIBS).
      
      	gcc/testsuite:
      	* lib/target-supports.exp (check_effective_target_pie): Always
      	enable on *-*-solaris2*.
      
      	libgcc:
      	* configure.ac <*-*-solaris2*> (libgcc_cv_solaris_crts): Remove.
      	* config.host <*-*-solaris2*>: Remove !libgcc_cv_solaris_crts
      	support.
      	* configure, config.in: Regenerate.
      	* config/sol2/gmon.c (internal_mcount) [!HAVE_SOLARIS_CRTS]: Remove.
      	* config/i386/sol2-c1.S, config/sparc/sol2-c1.S: Remove.
      	* config/sol2/t-sol2 (crt1.o, gcrt1.o): Remove.
      
      	libstdc++-v3:
      	* testsuite/lib/dg-options.exp (add_options_for_net_ts)
      	<*-*-solaris2*>: Don't link with -lsocket -lnsl.
      f68e90a0
    • GCC Administrator's avatar
      Daily bump. · f56280d5
      GCC Administrator authored
      f56280d5
  12. May 06, 2024
    • Xiao Zeng's avatar
      [RISC-V] Add support for _Bfloat16 · 8c7cee80
      Xiao Zeng authored
      1 At point <https://github.com/riscv/riscv-bfloat16>,
        BF16 has already been completed "post public review".
      
      2 LLVM has also added support for RISCV BF16 in
        <https://reviews.llvm.org/D151313> and
        <https://reviews.llvm.org/D150929>.
      
      3 According to the discussion <https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/367
      
      >,
        this use __bf16 and use DF16b in riscv_mangle_type like x86.
      
      Below test are passed for this patch
          * The riscv fully regression test.
      
      gcc/ChangeLog:
      
      	* config/riscv/iterators.md: New mode iterator HFBF.
      	* config/riscv/riscv-builtins.cc (riscv_init_builtin_types):
      	Initialize data type _Bfloat16.
      	* config/riscv/riscv-modes.def (FLOAT_MODE): New.
      	(ADJUST_FLOAT_FORMAT): New.
      	* config/riscv/riscv.cc (riscv_mangle_type): Support for BFmode.
      	(riscv_scalar_mode_supported_p): Ditto.
      	(riscv_libgcc_floating_mode_supported_p): Ditto.
      	(riscv_init_libfuncs): Set the conversion method for BFmode and
      	HFmode.
      	(riscv_block_arith_comp_libfuncs_for_mode): Set the arithmetic
      	and comparison libfuncs for the mode.
      	* config/riscv/riscv.md (mode" ): Add BF.
      	(movhf): Support for BFmode.
      	(mov<mode>): Ditto.
      	(*movhf_softfloat): Ditto.
      	(*mov<mode>_softfloat): Ditto.
      
      libgcc/ChangeLog:
      
      	* config/riscv/sfp-machine.h (_FP_NANFRAC_B): New.
      	(_FP_NANSIGN_B): Ditto.
      	* config/riscv/t-softfp32: Add support for BF16 libfuncs.
      	* config/riscv/t-softfp64: Ditto.
      	* soft-fp/floatsibf.c: For si -> bf16.
      	* soft-fp/floatunsibf.c: For unsi -> bf16.
      
      gcc/testsuite/ChangeLog:
      
      	* gcc.target/riscv/bf16_arithmetic.c: New test.
      	* gcc.target/riscv/bf16_call.c: New test.
      	* gcc.target/riscv/bf16_comparison.c: New test.
      	* gcc.target/riscv/bf16_float_libcall_convert.c: New test.
      	* gcc.target/riscv/bf16_integer_libcall_convert.c: New test.
      
      Co-authored-by: default avatarJin Ma <jinma@linux.alibaba.com>
      8c7cee80
    • GCC Administrator's avatar
      Daily bump. · ce343444
      GCC Administrator authored
      ce343444
  13. May 05, 2024
    • liuhongt's avatar
      Update libbid according to the latest Intel Decimal Floating-Point Math Library. · affd77d3
      liuhongt authored
      The Intel Decimal Floating-Point Math Library is available as open-source on Netlib[1].
      
      [1] https://www.netlib.org/misc/intel/
      
      .
      
      libgcc/config/libbid/ChangeLog:
      
      	* bid128_fma.c (add_and_round): Fix bug: the result
      	of (+5E+368)*(+10E-34)+(-10E+369) was returning
      	-9999999999999999999999999999999999E+336 instead of expected
      	result -1000000000000000000000000000000000E+337.
      	(bid128_ext_fma): Ditto.
      	(bid64qqq_fma): Ditto.
      	* bid128_noncomp.c: Change return type of bid128_class from
      	int to class_t.
      	* bid128_round_integral.c: Add default case to avoid compiler
      	warning.
      	* bid128_string.c (bid128_to_string): Replace 0x30 with '0'
      	for zero digit.
      	(bid128_from_string): Ditto.
      	* bid32_to_bid128.c (bid128_to_bid32): Fix Bug. In addition
      	to the INEXACT flag, the UNDERFLOW flag needs to be set (and
      	was not) when converting an input such as
      	+6931674235302037148946035460357709E+1857 to +1000000E-101
      	* bid32_to_bid64.c (bid64_to_bid32): fix Bug, In addition to
      	the INEXACT flag, the UNDERFLOW flag needs to be set (and was
      	not) when converting an input such as +9999999000000001E-111
      	to +1000000E-101. Furthermore, significant bits of NaNs are
      	set correctly now. For example,  0x7c00003b9aca0000 was
      	returning 0x7c000002 instead of 0x 7c000100.
      	* bid64_noncomp.c: Change return type of bid64_class from int
      	to class_t.
      	* bid64_round_integral.c (bid64_round_integral_exact): Add
      	default case to avoid compiler warning.
      	* bid64_string.c (bid64_from_string): Fix bug for rounding
      	up. The input string "10000000000000000" was returning
      	+1000000000000001E+1 instead of +1000000000000000E+1.
      	* bid64_to_bid128.c (bid128_to_bid64): Fix bug, in addition to
      	the INEXACT flag, the UNDERFLOW flag needs to be set (and was
      	not) when converting an input such as
      	+9999999999999999999999999999999999E-417 to
      	+1000000000000000E-398.
      	* bid_binarydecimal.c (bid32_to_binary64): Fix bug for
      	conversion between binary and bid types. For example,
      	0x7c0F4240 was returning 0x7FFFA12000000000 instead of
      	expected double precision 0x7FF8000000000000.
      	(binary64_to_bid32): Ditto.
      	(binary80_to_bid32): Ditto.
      	(binary128_to_bid32): Ditto.
      	(binary80_to_bid64): Ditto.
      	(binary128_to_bid64): Ditto.
      	* bid_conf.h (BID_HIGH_128W): New macro.
      	(BID_LOW_128W): Ditto.
      	* bid_functions.h (__ENABLE_BINARY80__): Ditto.
      	(ALIGN): Ditto.
      	* bid_inline_add.h (get_add128): Add default case to avoid compiler
      	warning.
      	* bid_internal.h (get_BID64): Ditto.
      	(fast_get_BID64_check_OF): Ditto.
      	(ALIGN): New macro.
      
      Co-authored-by: default avatarAnderson, Cristina S <cristina.s.anderson@intel.com>
      Co-authored-by: default avatarAkkas, Ahmet <ahmet.akkas@intel.com>
      Co-authored-by: default avatarCornea, Marius <marius.cornea@intel.com>
      affd77d3
  14. May 04, 2024
  15. May 03, 2024
  16. May 01, 2024
  17. Apr 30, 2024
    • Jakub Jelinek's avatar
      libgcc: Do use weakrefs for glibc 2.34 on GNU Hurd · 3146a92a
      Jakub Jelinek authored
      On Mon, Apr 29, 2024 at 01:44:24PM +0000, Joseph Myers wrote:
      > > glibc 2.34 and later doesn't have separate libpthread (libpthread.so.0 is a
      > > dummy shared library with just some symbol versions for compatibility, but
      > > all the pthread_* APIs are in libc.so.6).
      >
      > I suspect this has caused link failures in the glibc testsuite for Hurd,
      > which still has separate libpthread.
      >
      > https://sourceware.org/pipermail/libc-testresults/2024q2/012556.html
      
      So like this then?
      
      2024-04-30  Jakub Jelinek  <jakub@redhat.com>
      
      	* gthr.h (GTHREAD_USE_WEAK): Don't redefine to 0 for glibc 2.34+
      	on GNU Hurd.
      3146a92a
  18. Apr 26, 2024
  19. Apr 25, 2024
    • Jakub Jelinek's avatar
      libgcc: Don't use weakrefs for glibc 2.34 · fe02f6ca
      Jakub Jelinek authored
      glibc 2.34 and later doesn't have separate libpthread (libpthread.so.0 is a
      dummy shared library with just some symbol versions for compatibility, but
      all the pthread_* APIs are in libc.so.6).
      So, we don't need to do the .weakref dances to check whether a program
      has been linked with -lpthread or not, in dynamically linked apps those
      will be always true anyway.
      In -static linking, this fixes various issues people had when only linking
      some parts of libpthread.a and getting weird crashes.  A hack for that was
      what e.g. some Fedora glibcs used, where libpthread.a was a library
      containing just one giant *.o file which had all the normal libpthread.a
      *.o files linked with -r together.
      
      libstdc++-v3 actually does something like this already since r10-10928,
      the following patch is meant to fix it even for libgfortran, libobjc and
      whatever else uses gthr.h.
      
      2024-04-25  Jakub Jelinek  <jakub@redhat.com>
      
      	* gthr.h (GTHREAD_USE_WEAK): Redefine to 0 for GLIBC 2.34 or later.
      fe02f6ca
  20. Apr 22, 2024
  21. Apr 21, 2024
  22. Apr 20, 2024
  23. Apr 19, 2024
    • Jakub Jelinek's avatar
      libgcc: Another __divmodbitint4 bug fix [PR114762] · 36f4c8a9
      Jakub Jelinek authored
      The following testcase is miscompiled because the code to decrement
      vn on negative value with all ones in most significant limb (even partial)
      and 0 in most significant bit of the second most significant limb doesn't
      take into account the case where all bits below the most significant limb
      are zero.  This has been a problem both in the version before yesterday's
      commit where it has been done only if un was one shorter than vn before this
      decrement, and is now problem even more often when it is done earlier.
      When we decrement vn in such case and negate it, we end up with all 0s in
      the v2 value, so have both the problems with UB on __builtin_clz* and the
      expectations of the algorithm that the divisor has most significant bit set
      after shifting, plus when the decremented vn is 1 it can SIGFPE on division
      by zero even when it is not division by zero etc.  Other values shouldn't
      get 0 in the new most significant limb after negation, because the
      bitint_reduce_prec canonicalization should reduce prec if the second most
      significant limb is all ones and if that limb is all zeros, if at least
      one limb below it is non-zero, carry in will make it non-zero.
      
      The following patch fixes it by checking if at least one bit below the
      most significant limb is non-zero, in that case it decrements, otherwise
      it will do nothing (but e.g. for the un < vn case that also means the
      divisor is large enough that the result should be q 0 r u).
      
      2024-04-18  Jakub Jelinek  <jakub@redhat.com>
      
      	PR libgcc/114762
      	* libgcc2.c (__divmodbitint4): Perform the decrement on negative
      	v with most significant limb all ones and the second least
      	significant limb with most significant bit clear always, regardless of
      	un < vn.
      
      	* gcc.dg/torture/bitint-70.c: New test.
      36f4c8a9
    • GCC Administrator's avatar
      Daily bump. · 85c187b2
      GCC Administrator authored
      85c187b2
  24. Apr 18, 2024
    • Jakub Jelinek's avatar
      libgcc: Fix up __divmodbitint4 [PR114755] · 82d6d385
      Jakub Jelinek authored
      The following testcase aborts on aarch64-linux but does not on x86_64-linux.
      In both cases there is UB in the __divmodbitint4 implemenetation.
      When the divisor is negative with most significant limb (even when partial)
      all ones, has at least 2 limbs and the second most significant limb has the
      most significant bit clear, when this number is negated, it will have 0
      in the most significant limb.
      Already in the PR114397 r14-9592 fix I was dealing with such divisors, but
      thought the problem is only if because of that un < vn doesn't imply the
      quotient is 0 and remainder u.
      But as this testcase shows, the problem is with such divisors always.
      What happens is that we use __builtin_clz* on the most significant limb,
      and assume it will not be 0 because that is UB for the builtins.
      Normally the most significant limb of the divisor shouldn't be 0, as
      guaranteed by the bitint_reduce_prec e.g. for the positive numbers, unless
      the divisor is just 0 (but for vn == 1 we have special cases).
      
      The following patch moves the handling of this corner case a few lines
      earlier before the un < vn check, because adjusting the vn later is harder.
      
      2024-04-18  Jakub Jelinek  <jakub@redhat.com>
      
      	PR libgcc/114755
      	* libgcc2.c (__divmodbitint4): Perform the decrement on negative
      	v with most significant limb all ones and the second least
      	significant limb with most significant bit clear always, regardless of
      	un < vn.
      
      	* gcc.dg/torture/bitint-69.c: New test.
      82d6d385
  25. Apr 16, 2024
  26. Apr 15, 2024
    • Jakub Jelinek's avatar
      m68k: Quiet up cppcheck warning [PR114689] · f8409c31
      Jakub Jelinek authored
      cppcheck apparently warns on the | !!sticky part of the expression and
      using | (!!sticky) quiets it up (it is correct as is).
      The following patch adds the ()s, and also adds them around mant >> 1 just
      in case it makes it clearer to all readers that the expression is parsed
      that way already.
      
      2024-04-15  Jakub Jelinek  <jakub@redhat.com>
      
      	PR libgcc/114689
      	* config/m68k/fpgnulib.c (__truncdfsf2): Add parentheses around
      	!!sticky bitwise or operand to quiet up cppcheck.  Add parentheses
      	around mant >> 1 bitwise or operand.
      f8409c31
  27. Apr 11, 2024
  28. Apr 10, 2024
    • Andre Vieira's avatar
      aarch64: Add support for _BitInt · 5aa3fec3
      Andre Vieira authored
      This patch adds support for C23's _BitInt for the AArch64 port when compiling
      for little endianness.  Big Endianness requires further target-agnostic
      support and we therefor disable it for now.
      
      gcc/ChangeLog:
      
      	* config/aarch64/aarch64.cc (TARGET_C_BITINT_TYPE_INFO): Declare MACRO.
      	(aarch64_bitint_type_info): New function.
      	(aarch64_return_in_memory_1): Return large _BitInt's in memory.
      	(aarch64_function_arg_alignment): Adapt to correctly return the ABI
      	mandated alignment of _BitInt(N) where N > 128 as the alignment of
      	TImode.
      	(aarch64_composite_type_p): Return true for _BitInt(N), where N > 128.
      
      libgcc/ChangeLog:
      
      	* config/aarch64/t-softfp (softfp_extras): Add floatbitinthf,
      	floatbitintbf, floatbitinttf and fixtfbitint.
      	* config/aarch64/libgcc-softfp.ver (GCC_14.0.0): Add __floatbitinthf,
      	__floatbitintbf, __floatbitinttf and __fixtfbitint.
      
      gcc/testsuite/ChangeLog:
      
      	* gcc.target/aarch64/bitint-alignments.c: New test.
      	* gcc.target/aarch64/bitint-args.c: New test.
      	* gcc.target/aarch64/bitint-sizes.c: New test.
      	* gcc.target/aarch64/bitfield-bitint-abi.h: New header.
      	* gcc.target/aarch64/bitfield-bitint-abi-align16.c: New test.
      	* gcc.target/aarch64/bitfield-bitint-abi-align8.c: New test.
      5aa3fec3
    • GCC Administrator's avatar
      Daily bump. · 0753ae15
      GCC Administrator authored
      0753ae15
  29. Apr 09, 2024
  30. Apr 05, 2024
  31. Apr 04, 2024
    • Jørgen Kvalsvik's avatar
      Add condition coverage (MC/DC) · 08a52331
      Jørgen Kvalsvik authored
      This patch adds support in gcc+gcov for modified condition/decision
      coverage (MC/DC) with the -fcondition-coverage flag. MC/DC is a type of
      test/code coverage and it is particularly important for safety-critical
      applicaitons in industries like aviation and automotive. Notably, MC/DC
      is required or recommended by:
      
          * DO-178C for the most critical software (Level A) in avionics.
          * IEC 61508 for SIL 4.
          * ISO 26262-6 for ASIL D.
      
      From the SQLite webpage:
      
          Two methods of measuring test coverage were described above:
          "statement" and "branch" coverage. There are many other test
          coverage metrics besides these two. Another popular metric is
          "Modified Condition/Decision Coverage" or MC/DC. Wikipedia defines
          MC/DC as follows:
      
              * Each decision tries every possible outcome.
              * Each condition in a decision takes on every possible outcome.
              * Each entry and exit point is invoked.
              * Each condition in a decision is shown to independently affect
                the outcome of the decision.
      
          In the C programming language where && and || are "short-circuit"
          operators, MC/DC and branch coverage are very nearly the same thing.
          The primary difference is in boolean vector tests. One can test for
          any of several bits in bit-vector and still obtain 100% branch test
          coverage even though the second element of MC/DC - the requirement
          that each condition in a decision take on every possible outcome -
          might not be satisfied.
      
          https://sqlite.org/testing.html#mcdc
      
      MC/DC comes in different flavors, the most important being unique cause
      MC/DC and masking MC/DC. This patch implements masking MC/DC, which is
      works well with short circuiting semantics, and according to John
      Chilenski's "An Investigation of Three Forms of the Modified Condition
      Decision Coverage (MCDC) Criterion" (2001) is as good as unique cause at
      catching bugs.
      
      Whalen, Heimdahl, and De Silva "Efficient Test Coverage Measurement for
      MC/DC" describes an algorithm for finding the masking table from an AST
      walk, but my algorithm figures this out by analyzing the control flow
      graph.  The CFG is considered a reduced ordered binary decision diagram
      and an input vector a path through the BDD, which is recorded.  Specific
      edges will mask ("null out") the contribution from earlier path
      segments, which can be determined by finding short circuit endpoints.
      Masking is most easily understood as circuiting of terms in the
      reverse-ordered Boolean function, and the masked conditions do not
      affect the decision like short-circuited conditions do not affect the
      decision.
      
      A tag/discriminator mapping from gcond->uid is created during
      gimplification and made available through the function struct. The
      values are unimportant as long as basic conditions constructed from a
      single Boolean expression are given the same identifier. This happens in
      the breaking down of ANDIF/ORIF trees, so the coverage generally works
      well for frontends that create such trees.
      
      Like Whalen et al this implementation records coverage in fixed-size
      bitsets which gcov knows how to interpret. Recording conditions only
      requires a few bitwise operations per condition and is very fast, but
      comes with a limit on the number of terms in a single boolean
      expression; the number of bits in a gcov_unsigned_type (which is usually
      typedef'd to uint64_t). For most practical purposes this is acceptable,
      and by default a warning will be issued if gcc cannot instrument the
      expression.  This is a practical limitation in the implementation, and
      not a limitation of the algorithm, so support for more conditions can be
      supported by introducing arbitrary-sized bitsets.
      
      In action it looks pretty similar to the branch coverage. The -g short
      opt carries no significance, but was chosen because it was an available
      option with the upper-case free too.
      
      gcov --conditions:
      
              3:   17:void fn (int a, int b, int c, int d) {
              3:   18:    if ((a && (b || c)) && d)
      conditions covered 3/8
      condition  0 not covered (true false)
      condition  1 not covered (true)
      condition  2 not covered (true)
      condition  3 not covered (true)
              1:   19:        x = 1;
              -:   20:    else
              2:   21:        x = 2;
              3:   22:}
      
      gcov --conditions --json-format:
      
      "conditions": [
          {
              "not_covered_false": [
                  0
              ],
              "count": 8,
              "covered": 3,
              "not_covered_true": [
                  0,
                  1,
                  2,
                  3
              ]
          }
      ],
      
      Expressions with constants may be heavily rewritten before it reaches
      the gimplification, so constructs like int x = a ? 0 : 1 becomes
      _x = (_a == 0). From source you would expect coverage, but it gets
      neither branch nor condition coverage. The same applies to expressions
      like int x = 1 || a which are simply replaced by a constant.
      
      The test suite contains a lot of small programs and functions. Some of
      these were designed by hand to test for specific behaviours and graph
      shapes, and some are previously-failed test cases in other programs
      adapted into the test suite.
      
      gcc/ChangeLog:
      
      	* builtins.cc (expand_builtin_fork_or_exec): Check
      	condition_coverage_flag.
      	* collect2.cc (main): Add -fno-condition-coverage to OBSTACK.
      	* common.opt: Add new options -fcondition-coverage and
      	-Wcoverage-too-many-conditions.
      	* doc/gcov.texi: Add --conditions documentation.
      	* doc/invoke.texi: Add -fcondition-coverage documentation.
      	* function.cc (free_after_compilation): Free cond_uids.
      	* function.h (struct function): Add cond_uids.
      	* gcc.cc: Link gcov on -fcondition-coverage.
      	* gcov-counter.def (GCOV_COUNTER_CONDS): New.
      	* gcov-dump.cc (tag_conditions): New.
      	* gcov-io.h (GCOV_TAG_CONDS): New.
      	(GCOV_TAG_CONDS_LENGTH): New.
      	(GCOV_TAG_CONDS_NUM): New.
      	* gcov.cc (class condition_info): New.
      	(condition_info::condition_info): New.
      	(condition_info::popcount): New.
      	(struct coverage_info): New.
      	(add_condition_counts): New.
      	(output_conditions): New.
      	(print_usage): Add -g, --conditions.
      	(process_args): Likewise.
      	(output_intermediate_json_line): Output conditions.
      	(read_graph_file): Read condition counters.
      	(read_count_file): Likewise.
      	(file_summary): Print conditions.
      	(accumulate_line_info): Accumulate conditions.
      	(output_line_details): Print conditions.
      	* gimplify.cc (next_cond_uid): New.
      	(reset_cond_uid): New.
      	(shortcut_cond_r): Set condition discriminator.
      	(tag_shortcut_cond): New.
      	(gimple_associate_condition_with_expr): New.
      	(shortcut_cond_expr): Set condition discriminator.
      	(gimplify_cond_expr): Likewise.
      	(gimplify_function_tree): Call reset_cond_uid.
      	* ipa-inline.cc (can_early_inline_edge_p): Check
      	condition_coverage_flag.
      	* ipa-split.cc (pass_split_functions::gate): Likewise.
      	* passes.cc (finish_optimization_passes): Likewise.
      	* profile.cc (struct condcov): New declaration.
      	(cov_length): Likewise.
      	(cov_blocks): Likewise.
      	(cov_masks): Likewise.
      	(cov_maps): Likewise.
      	(cov_free): Likewise.
      	(instrument_decisions): New.
      	(read_thunk_profile): Control output to file.
      	(branch_prob): Call find_conditions, instrument_decisions.
      	(init_branch_prob): Add total_num_conds.
      	(end_branch_prob): Likewise.
      	* tree-core.h (struct tree_exp): Add condition_uid.
      	* tree-profile.cc (struct conds_ctx): New.
      	(CONDITIONS_MAX_TERMS): New.
      	(EDGE_CONDITION): New.
      	(topological_cmp): New.
      	(index_of): New.
      	(single_p): New.
      	(single_edge): New.
      	(contract_edge_up): New.
      	(struct outcomes): New.
      	(conditional_succs): New.
      	(condition_index): New.
      	(condition_uid): New.
      	(masking_vectors): New.
      	(emit_assign): New.
      	(emit_bitwise_op): New.
      	(make_top_index_visit): New.
      	(make_top_index): New.
      	(paths_between): New.
      	(struct condcov): New.
      	(cov_length): New.
      	(cov_blocks): New.
      	(cov_masks): New.
      	(cov_maps): New.
      	(cov_free): New.
      	(find_conditions): New.
      	(struct counters): New.
      	(find_counters): New.
      	(resolve_counter): New.
      	(resolve_counters): New.
      	(instrument_decisions): New.
      	(tree_profiling): Check condition_coverage_flag.
      	(pass_ipa_tree_profile::gate): Likewise.
      	* tree.h (SET_EXPR_UID): New.
      	(EXPR_COND_UID): New.
      
      libgcc/ChangeLog:
      
      	* libgcov-merge.c (__gcov_merge_ior): New.
      
      gcc/testsuite/ChangeLog:
      
      	* lib/gcov.exp: Add condition coverage test function.
      	* g++.dg/gcov/gcov-18.C: New test.
      	* gcc.misc-tests/gcov-19.c: New test.
      	* gcc.misc-tests/gcov-20.c: New test.
      	* gcc.misc-tests/gcov-21.c: New test.
      	* gcc.misc-tests/gcov-22.c: New test.
      	* gcc.misc-tests/gcov-23.c: New test.
      08a52331
    • GCC Administrator's avatar
      Daily bump. · 88ce7fbc
      GCC Administrator authored
      88ce7fbc
  32. Apr 03, 2024
Loading