Skip to content
Snippets Groups Projects
  1. Oct 25, 2024
    • Jakub Jelinek's avatar
      non-gcc: Remove trailing whitespace · 45ab93d9
      Jakub Jelinek authored
      I've tried to build stage3 with
      -Wleading-whitespace=blanks -Wtrailing-whitespace=blank -Wno-error=leading-whitespace=blanks -Wno-error=trailing-whitespace=blank
      added to STRICT_WARN and that expectably resulted in about
      2744 unique trailing whitespace warnings and 124837 leading whitespace
      warnings when excluding *.md files (which obviously is in big part a
      generator issue).  Others from that are generator related, I think those
      need to be solved later.
      
      The following patch just fixes up the easy case (trailing whitespace),
      which could be easily automated:
      for i in `find . -name \*.h -o -name \*.cc -o -name \*.c | xargs grep -l '[ 	]$' | grep -v testsuite/`; do sed -i -e 's/[ 	]*$//' $i; done
      I've excluded files which I knew are obviously generated or go FE.
      
      Is there anything else we'd want to avoid the changes?
      
      Due to patch size, I've split it between gcc/ part
      and rest (include/, libiberty/, libgcc/, libcpp/, libstdc++-v3/;
      this part).
      
      2024-10-24  Jakub Jelinek  <jakub@redhat.com>
      
      include/
      	* dyn-string.h: Remove trailing whitespace.
      	* libiberty.h: Likewise.
      	* xregex.h: Likewise.
      	* splay-tree.h: Likewise.
      	* partition.h: Likewise.
      	* plugin-api.h: Likewise.
      	* demangle.h: Likewise.
      	* vtv-change-permission.h: Likewise.
      	* fibheap.h: Likewise.
      	* hsa_ext_image.h: Likewise.
      	* hashtab.h: Likewise.
      	* libcollector.h: Likewise.
      	* sort.h: Likewise.
      	* symcat.h: Likewise.
      	* hsa_ext_amd.h: Likewise.
      libcpp/
      	* directives.cc: Remove trailing whitespace.
      	* mkdeps.cc: Likewise.
      	* line-map.cc: Likewise.
      	* internal.h: Likewise.
      	* files.cc: Likewise.
      	* init.cc: Likewise.
      	* makeucnid.cc: Likewise.
      	* system.h: Likewise.
      	* include/line-map.h: Likewise.
      	* include/symtab.h: Likewise.
      	* include/cpplib.h: Likewise.
      	* expr.cc: Likewise.
      	* charset.cc: Likewise.
      	* macro.cc: Likewise.
      	* errors.cc: Likewise.
      	* lex.cc: Likewise.
      	* traditional.cc: Likewise.
      libgcc/
      	* crtstuff.c: Remove trailing whitespace.
      	* libgcov.h: Likewise.
      	* config/alpha/crtfastmath.c: Likewise.
      	* config/alpha/vms-gcc_shell_handler.c: Likewise.
      	* config/alpha/vms-unwind.h: Likewise.
      	* config/pa/linux-atomic.c: Likewise.
      	* config/pa/linux-unwind.h: Likewise.
      	* config/pa/quadlib.c: Likewise.
      	* config/pa/fptr.c: Likewise.
      	* config/s390/32/_fixsfdi.c: Likewise.
      	* config/s390/32/_fixunssfdi.c: Likewise.
      	* config/s390/32/_fixunsdfdi.c: Likewise.
      	* config/c6x/pr-support.c: Likewise.
      	* config/lm32/_udivsi3.c: Likewise.
      	* config/lm32/libgcc_lm32.h: Likewise.
      	* config/lm32/_udivmodsi4.c: Likewise.
      	* config/lm32/_mulsi3.c: Likewise.
      	* config/lm32/_modsi3.c: Likewise.
      	* config/lm32/_umodsi3.c: Likewise.
      	* config/lm32/_divsi3.c: Likewise.
      	* config/darwin-crt3.c: Likewise.
      	* config/msp430/mpy.c: Likewise.
      	* config/ia64/tf-signs.c: Likewise.
      	* config/ia64/fde-vms.c: Likewise.
      	* config/ia64/unwind-ia64.c: Likewise.
      	* config/ia64/vms-unwind.h: Likewise.
      	* config/ia64/sfp-exceptions.c: Likewise.
      	* config/ia64/quadlib.c: Likewise.
      	* config/ia64/unwind-ia64.h: Likewise.
      	* config/rl78/vregs.h: Likewise.
      	* config/arm/bpabi.c: Likewise.
      	* config/arm/unwind-arm.c: Likewise.
      	* config/arm/pr-support.c: Likewise.
      	* config/arm/linux-atomic.c: Likewise.
      	* config/arm/bpabi-lib.h: Likewise.
      	* config/frv/frvend.c: Likewise.
      	* config/frv/cmovw.c: Likewise.
      	* config/frv/frvbegin.c: Likewise.
      	* config/frv/cmovd.c: Likewise.
      	* config/frv/cmovh.c: Likewise.
      	* config/aarch64/cpuinfo.c: Likewise.
      	* config/i386/crtfastmath.c: Likewise.
      	* config/i386/cygming-crtend.c: Likewise.
      	* config/i386/32/tf-signs.c: Likewise.
      	* config/i386/crtprec.c: Likewise.
      	* config/i386/sfp-exceptions.c: Likewise.
      	* config/i386/w32-unwind.h: Likewise.
      	* config/m32r/initfini.c: Likewise.
      	* config/sparc/crtfastmath.c: Likewise.
      	* config/gcn/amdgcn_veclib.h: Likewise.
      	* config/nios2/linux-atomic.c: Likewise.
      	* config/nios2/linux-unwind.h: Likewise.
      	* config/nios2/lib2-mul.c: Likewise.
      	* config/nios2/lib2-nios2.h: Likewise.
      	* config/xtensa/unwind-dw2-xtensa.c: Likewise.
      	* config/rs6000/darwin-fallback.c: Likewise.
      	* config/rs6000/ibm-ldouble.c: Likewise.
      	* config/rs6000/sfp-machine.h: Likewise.
      	* config/rs6000/darwin-asm.h: Likewise.
      	* config/rs6000/darwin-crt2.c: Likewise.
      	* config/rs6000/aix-unwind.h: Likewise.
      	* config/rs6000/sfp-exceptions.c: Likewise.
      	* config/gthr-vxworks.c: Likewise.
      	* config/riscv/atomic.c: Likewise.
      	* config/visium/memcpy.c: Likewise.
      	* config/darwin-crt-tm.c: Likewise.
      	* config/stormy16/lib2funcs.c: Likewise.
      	* config/arc/ieee-754/divtab-arc-sf.c: Likewise.
      	* config/arc/ieee-754/divtab-arc-df.c: Likewise.
      	* config/arc/initfini.c: Likewise.
      	* config/sol2/gmon.c: Likewise.
      	* config/microblaze/divsi3_table.c: Likewise.
      	* config/m68k/fpgnulib.c: Likewise.
      	* libgcov-driver.c: Likewise.
      	* unwind-dw2.c: Likewise.
      	* fp-bit.c: Likewise.
      	* dfp-bit.h: Likewise.
      	* dfp-bit.c: Likewise.
      	* libgcov-driver-system.c: Likewise.
      libgcc/config/libbid/
      	* _le_td.c: Remove trailing whitespace.
      	* bid128_compare.c: Likewise.
      	* bid_div_macros.h: Likewise.
      	* bid64_to_bid128.c: Likewise.
      	* bid64_to_uint32.c: Likewise.
      	* bid128_to_uint64.c: Likewise.
      	* bid64_div.c: Likewise.
      	* bid128_round_integral.c: Likewise.
      	* bid_binarydecimal.c: Likewise.
      	* bid128_string.c: Likewise.
      	* bid_flag_operations.c: Likewise.
      	* bid128_to_int64.c: Likewise.
      	* _mul_sd.c: Likewise.
      	* bid64_mul.c: Likewise.
      	* bid128_noncomp.c: Likewise.
      	* _gt_dd.c: Likewise.
      	* bid64_add.c: Likewise.
      	* bid64_string.c: Likewise.
      	* bid_from_int.c: Likewise.
      	* bid128.c: Likewise.
      	* _ge_dd.c: Likewise.
      	* _ne_sd.c: Likewise.
      	* _dd_to_td.c: Likewise.
      	* _unord_sd.c: Likewise.
      	* bid64_to_uint64.c: Likewise.
      	* _gt_sd.c: Likewise.
      	* _sd_to_td.c: Likewise.
      	* _addsub_td.c: Likewise.
      	* _ne_td.c: Likewise.
      	* bid_dpd.c: Likewise.
      	* bid128_add.c: Likewise.
      	* bid128_next.c: Likewise.
      	* _lt_sd.c: Likewise.
      	* bid64_next.c: Likewise.
      	* bid128_mul.c: Likewise.
      	* _lt_dd.c: Likewise.
      	* _ge_td.c: Likewise.
      	* _unord_dd.c: Likewise.
      	* bid64_sqrt.c: Likewise.
      	* bid_sqrt_macros.h: Likewise.
      	* bid64_fma.c: Likewise.
      	* _sd_to_dd.c: Likewise.
      	* bid_conf.h: Likewise.
      	* bid64_noncomp.c: Likewise.
      	* bid_gcc_intrinsics.h: Likewise.
      	* _gt_td.c: Likewise.
      	* _ge_sd.c: Likewise.
      	* bid128_minmax.c: Likewise.
      	* bid128_quantize.c: Likewise.
      	* bid32_to_bid64.c: Likewise.
      	* bid_round.c: Likewise.
      	* _td_to_sd.c: Likewise.
      	* bid_inline_add.h: Likewise.
      	* bid128_fma.c: Likewise.
      	* _eq_td.c: Likewise.
      	* bid32_to_bid128.c: Likewise.
      	* bid64_rem.c: Likewise.
      	* bid128_2_str_tables.c: Likewise.
      	* _mul_dd.c: Likewise.
      	* _dd_to_sd.c: Likewise.
      	* bid128_div.c: Likewise.
      	* _lt_td.c: Likewise.
      	* bid64_compare.c: Likewise.
      	* bid64_to_int32.c: Likewise.
      	* _unord_td.c: Likewise.
      	* bid128_rem.c: Likewise.
      	* bid_internal.h: Likewise.
      	* bid64_to_int64.c: Likewise.
      	* _eq_dd.c: Likewise.
      	* _td_to_dd.c: Likewise.
      	* bid128_to_int32.c: Likewise.
      	* bid128_to_uint32.c: Likewise.
      	* _ne_dd.c: Likewise.
      	* bid64_quantize.c: Likewise.
      	* _le_dd.c: Likewise.
      	* bid64_round_integral.c: Likewise.
      	* _le_sd.c: Likewise.
      	* bid64_minmax.c: Likewise.
      libgcc/config/avr/libf7/
      	* f7-renames.h: Remove trailing whitespace.
      libstdc++-v3/
      	* include/debug/debug.h: Remove trailing whitespace.
      	* include/parallel/base.h: Likewise.
      	* include/parallel/types.h: Likewise.
      	* include/parallel/settings.h: Likewise.
      	* include/parallel/multiseq_selection.h: Likewise.
      	* include/parallel/partition.h: Likewise.
      	* include/parallel/random_number.h: Likewise.
      	* include/parallel/find_selectors.h: Likewise.
      	* include/parallel/partial_sum.h: Likewise.
      	* include/parallel/list_partition.h: Likewise.
      	* include/parallel/search.h: Likewise.
      	* include/parallel/algorithmfwd.h: Likewise.
      	* include/parallel/random_shuffle.h: Likewise.
      	* include/parallel/multiway_mergesort.h: Likewise.
      	* include/parallel/sort.h: Likewise.
      	* include/parallel/algobase.h: Likewise.
      	* include/parallel/numericfwd.h: Likewise.
      	* include/parallel/multiway_merge.h: Likewise.
      	* include/parallel/losertree.h: Likewise.
      	* include/bits/basic_ios.h: Likewise.
      	* include/bits/stringfwd.h: Likewise.
      	* include/bits/ostream_insert.h: Likewise.
      	* include/bits/stl_heap.h: Likewise.
      	* include/bits/unordered_map.h: Likewise.
      	* include/bits/hashtable_policy.h: Likewise.
      	* include/bits/stl_iterator_base_funcs.h: Likewise.
      	* include/bits/valarray_before.h: Likewise.
      	* include/bits/regex.h: Likewise.
      	* include/bits/postypes.h: Likewise.
      	* include/bits/stl_iterator.h: Likewise.
      	* include/bits/localefwd.h: Likewise.
      	* include/bits/stl_algo.h: Likewise.
      	* include/bits/ios_base.h: Likewise.
      	* include/bits/stl_function.h: Likewise.
      	* include/bits/basic_string.h: Likewise.
      	* include/bits/hashtable.h: Likewise.
      	* include/bits/valarray_after.h: Likewise.
      	* include/bits/char_traits.h: Likewise.
      	* include/bits/gslice.h: Likewise.
      	* include/bits/locale_facets_nonio.h: Likewise.
      	* include/bits/mask_array.h: Likewise.
      	* include/bits/specfun.h: Likewise.
      	* include/bits/random.h: Likewise.
      	* include/bits/slice_array.h: Likewise.
      	* include/bits/valarray_array.h: Likewise.
      	* include/tr1/float.h: Likewise.
      	* include/tr1/functional_hash.h: Likewise.
      	* include/tr1/math.h: Likewise.
      	* include/tr1/hashtable_policy.h: Likewise.
      	* include/tr1/stdio.h: Likewise.
      	* include/tr1/complex.h: Likewise.
      	* include/tr1/stdbool.h: Likewise.
      	* include/tr1/stdarg.h: Likewise.
      	* include/tr1/inttypes.h: Likewise.
      	* include/tr1/fenv.h: Likewise.
      	* include/tr1/stdlib.h: Likewise.
      	* include/tr1/wchar.h: Likewise.
      	* include/tr1/tgmath.h: Likewise.
      	* include/tr1/limits.h: Likewise.
      	* include/tr1/wctype.h: Likewise.
      	* include/tr1/stdint.h: Likewise.
      	* include/tr1/ctype.h: Likewise.
      	* include/tr1/random.h: Likewise.
      	* include/tr1/shared_ptr.h: Likewise.
      	* include/ext/mt_allocator.h: Likewise.
      	* include/ext/sso_string_base.h: Likewise.
      	* include/ext/debug_allocator.h: Likewise.
      	* include/ext/vstring_fwd.h: Likewise.
      	* include/ext/pointer.h: Likewise.
      	* include/ext/pod_char_traits.h: Likewise.
      	* include/ext/malloc_allocator.h: Likewise.
      	* include/ext/vstring.h: Likewise.
      	* include/ext/bitmap_allocator.h: Likewise.
      	* include/ext/pool_allocator.h: Likewise.
      	* include/ext/type_traits.h: Likewise.
      	* include/ext/ropeimpl.h: Likewise.
      	* include/ext/codecvt_specializations.h: Likewise.
      	* include/ext/throw_allocator.h: Likewise.
      	* include/ext/extptr_allocator.h: Likewise.
      	* include/ext/atomicity.h: Likewise.
      	* include/ext/concurrence.h: Likewise.
      	* include/c_compatibility/wchar.h: Likewise.
      	* include/c_compatibility/stdint.h: Likewise.
      	* include/backward/hash_fun.h: Likewise.
      	* include/backward/binders.h: Likewise.
      	* include/backward/hashtable.h: Likewise.
      	* include/backward/auto_ptr.h: Likewise.
      	* libsupc++/eh_arm.cc: Likewise.
      	* libsupc++/unwind-cxx.h: Likewise.
      	* libsupc++/si_class_type_info.cc: Likewise.
      	* libsupc++/vec.cc: Likewise.
      	* libsupc++/class_type_info.cc: Likewise.
      	* libsupc++/vmi_class_type_info.cc: Likewise.
      	* libsupc++/guard_error.cc: Likewise.
      	* libsupc++/bad_typeid.cc: Likewise.
      	* libsupc++/eh_personality.cc: Likewise.
      	* libsupc++/atexit_arm.cc: Likewise.
      	* libsupc++/pmem_type_info.cc: Likewise.
      	* libsupc++/vterminate.cc: Likewise.
      	* libsupc++/eh_terminate.cc: Likewise.
      	* libsupc++/bad_cast.cc: Likewise.
      	* libsupc++/exception_ptr.h: Likewise.
      	* libsupc++/eh_throw.cc: Likewise.
      	* libsupc++/bad_alloc.cc: Likewise.
      	* libsupc++/nested_exception.cc: Likewise.
      	* libsupc++/pointer_type_info.cc: Likewise.
      	* libsupc++/pbase_type_info.cc: Likewise.
      	* libsupc++/bad_array_new.cc: Likewise.
      	* libsupc++/pure.cc: Likewise.
      	* libsupc++/eh_exception.cc: Likewise.
      	* libsupc++/bad_array_length.cc: Likewise.
      	* libsupc++/cxxabi.h: Likewise.
      	* libsupc++/guard.cc: Likewise.
      	* libsupc++/eh_catch.cc: Likewise.
      	* libsupc++/cxxabi_forced.h: Likewise.
      	* libsupc++/tinfo.h: Likewise.
      45ab93d9
  2. Oct 08, 2024
  3. Oct 07, 2024
    • Tobias Burnus's avatar
      OpenMP: Allocate directive for static vars, clean up · a8caeaac
      Tobias Burnus authored
      For the 'allocate' directive, remove the sorry for static variables and
      just keep using normal memory, but honor the requested alignment and set
      a DECL_ATTRIBUTE in case a target may want to make use of this later on.
      The documentation is updated accordingly.
      
      The C diagnostic to check for predefined allocators (req. for static vars)
      failed to accept GCC's ompx_gnu_... allocator, now fixed. (Fortran was
      already okay; but both now use new common #defined value for checking.)
      And while Fortran common block variables are still rejected, the check
      has been improved as before the sorry diagnostic did not work for
      common blocks in modules.
      
      Finally, for 'allocate' clause on the target/task/taskloop directives,
      there is now a warning for omp_thread_mem_alloc (i.e. predefined allocator
      with access = thread), which is undefined behavior according to the
      OpenMP specification.
      
      And, last, testing showed that var decl + static_assert sets TREE_USED
      but does not produce a statement list in C, which did run into an assert
      in gimplify. This special case is now also handled.
      
      gcc/c/ChangeLog:
      
      	* c-parser.cc (c_parser_omp_allocate): Set alignment for alignof;
      	accept static variables and fix predef allocator check.
      
      gcc/fortran/ChangeLog:
      
      	* openmp.cc (is_predefined_allocator): Use gomp-constants.h consts.
      	* trans-common.cc (translate_common): Reject OpenMP allocate directives.
      	* trans-decl.cc (gfc_finish_var_decl): Handle allocate directive
      	for static variables.
      	(gfc_trans_deferred_vars): Update for the latter.
      
      gcc/ChangeLog:
      
      	* gimplify.cc (gimplify_bind_expr): Fix corner case for OpenMP
      	allocate directive.
      	(gimplify_scan_omp_clauses): Warn if omp_thread_mem_alloc is used
      	as allocator with the target/task/taskloop directive.
      
      include/ChangeLog:
      
      	* gomp-constants.h (GOMP_OMP_PREDEF_ALLOC_MAX,
      	GOMP_OMPX_PREDEF_ALLOC_MIN, GOMP_OMPX_PREDEF_ALLOC_MAX,
      	GOMP_OMP_PREDEF_ALLOC_THREADS): New defines.
      
      libgomp/ChangeLog:
      
      	* allocator.c: Add static asserts for news
      	GOMP_OMP{,X}_PREDEF_ALLOC_{MIN,MAX} range values.
      	* libgomp.texi (OpenMP Impl. Status): Allocate directive for
      	static vars is now supported. Refer to PR for allocate clause.
      	(Memory allocation): Update for static vars; minor word tweaking.
      
      gcc/testsuite/ChangeLog:
      
      	* c-c++-common/gomp/allocate-9.c: Update for removed sorry.
      	* gfortran.dg/gomp/allocate-15.f90: Likewise.
      	* gfortran.dg/gomp/allocate-pinned-1.f90: Likewise.
      	* gfortran.dg/gomp/allocate-4.f90: Likewise; add dg-error for
      	previously missing diagnostic.
      	* c-c++-common/gomp/allocate-18.c: New test.
      	* c-c++-common/gomp/allocate-19.c: New test.
      	* gfortran.dg/gomp/allocate-clause.f90: New test.
      	* gfortran.dg/gomp/allocate-static-2.f90: New test.
      	* gfortran.dg/gomp/allocate-static.f90: New test.
      a8caeaac
  4. Sep 25, 2024
  5. Sep 24, 2024
    • Tobias Burnus's avatar
      OpenMP: Add support for 'self_maps' to the 'require' directive · b752eed3
      Tobias Burnus authored
      'self_maps' implies 'unified_shared_memory', except that the latter
      also permits that explicit maps copy data to device memory while
      self_maps does not. In GCC, currently, both are handled identical.
      
      gcc/c/ChangeLog:
      
      	* c-parser.cc (c_parser_omp_requires): Handle self_maps clause.
      
      gcc/cp/ChangeLog:
      
      	* parser.cc (cp_parser_omp_requires): Handle self_maps clause.
      
      gcc/fortran/ChangeLog:
      
      	* gfortran.h (enum gfc_omp_requires_kind): Add OMP_REQ_SELF_MAPS.
      	(gfc_namespace): Enlarge omp_requires bitfield.
      	* module.cc (enum ab_attribute, attr_bits): Add AB_OMP_REQ_SELF_MAPS.
      	(mio_symbol_attribute): Handle it.
      	* openmp.cc (gfc_check_omp_requires, gfc_match_omp_requires): Handle
      	self_maps clause.
      	* parse.cc (gfc_parse_file): Handle self_maps clause.
      
      gcc/ChangeLog:
      
      	* lto-cgraph.cc (output_offload_tables, omp_requires_to_name): Handle
      	self_maps clause.
      	* omp-general.cc (struct omp_ts_info, omp_context_selector_matches):
      	Likewise for the associated trait.
      	* omp-general.h (enum omp_requires): Add OMP_REQUIRES_SELF_MAPS.
      	* omp-selectors.h (enum omp_ts_code): Add
      	OMP_TRAIT_IMPLEMENTATION_SELF_MAPS.
      
      include/ChangeLog:
      
      	* gomp-constants.h (GOMP_REQUIRES_SELF_MAPS): #define.
      
      libgomp/ChangeLog:
      
      	* plugin/plugin-gcn.c (GOMP_OFFLOAD_get_num_devices):
      	Accept self_maps clause.
      	* plugin/plugin-nvptx.c (GOMP_OFFLOAD_get_num_devices):
      	Likewise.
      	* libgomp.texi (TR13 Impl. Status): Set to 'Y'.
      	* target.c (gomp_requires_to_name, GOMP_offload_register_ver,
      	gomp_target_init): Handle self_maps clause.
      	* testsuite/libgomp.fortran/self_maps.f90: New test.
      
      gcc/testsuite/ChangeLog:
      
      	* c-c++-common/gomp/declare-variant-1.c: Add self_maps test.
      	* c-c++-common/gomp/requires-4.c: Likewise.
      	* gfortran.dg/gomp/declare-variant-3.f90:  Likewise.
      	* c-c++-common/gomp/requires-2.c: Update dg-error msg.
      	* gfortran.dg/gomp/requires-2.f90: Likewise.
      	* gfortran.dg/gomp/requires-self-maps-aux.f90: New.
      	* gfortran.dg/gomp/requires-self-maps.f90: New.
      b752eed3
    • GCC Administrator's avatar
      Daily bump. · 4d6fa5b7
      GCC Administrator authored
      4d6fa5b7
  6. Sep 23, 2024
    • Matthieu Longo's avatar
      dwarf2: add hooks for architecture-specific CFIs · 9e1c71ba
      Matthieu Longo authored
      Architecture-specific CFI directives are currently declared an processed
      among others architecture-independent CFI directives in gcc/dwarf2* files.
      This approach creates confusion, specifically in the case of DWARF
      instructions in the vendor space and using the same instruction code.
      
      Such a clash currently happen between DW_CFA_GNU_window_save (used on
      SPARC) and DW_CFA_AARCH64_negate_ra_state (used on AArch64), and both
      having the same instruction code 0x2d.
      Then AArch64 compilers generates a SPARC CFI directive (.cfi_window_save)
      instead of .cfi_negate_ra_state, contrarilly to what is expected in
      [DWARF for the Arm 64-bit Architecture (AArch64)](https://github.com/
      ARM-software/abi-aa/blob/main/aadwarf64/aadwarf64.rst).
      
      This refactoring does not solve completely the problem, but improve the
      situation by moving some of the processing of those directives (more
      specifically their output in the assembly) to the backend via 2 target
      hooks:
      - DW_CFI_OPRND1_DESC: parse the first operand of the directive (if any).
      - OUTPUT_CFI_DIRECTIVE: output the CFI directive as a string.
      
      Additionally, this patch also contains a renaming of an enum used for
      return address mangling on AArch64.
      
      gcc/ChangeLog:
      
      	* config/aarch64/aarch64.cc
      	(aarch64_output_cfi_directive): New hook for CFI directives.
      	(aarch64_dw_cfi_oprnd1_desc): Same.
      	(TARGET_OUTPUT_CFI_DIRECTIVE): Hook for output_cfi_directive.
      	(TARGET_DW_CFI_OPRND1_DESC): Hook for dw_cfi_oprnd1_desc.
      	* config/sparc/sparc.cc
      	(sparc_output_cfi_directive): New hook for CFI directives.
      	(sparc_dw_cfi_oprnd1_desc): Same.
      	(TARGET_OUTPUT_CFI_DIRECTIVE): Hook for output_cfi_directive.
      	(TARGET_DW_CFI_OPRND1_DESC): Hook for dw_cfi_oprnd1_desc.
      	* coretypes.h
      	(struct dw_cfi_node): Forward declaration of CFI type from
      	gcc/dwarf2out.h.
      	(enum dw_cfi_oprnd_type): Same.
      	(enum dwarf_call_frame_info): Same.
      	* doc/tm.texi: Regenerated from doc/tm.texi.in.
      	* doc/tm.texi.in: Add doc for new target hooks.
      	type of enum to allow forward declaration.
      	* dwarf2cfi.cc
      	(struct dw_cfi_row): Update the description for window_save
      	and ra_mangled.
      	(dwarf2out_frame_debug_cfa_negate_ra_state): Use AArch64 CFI
      	directive instead of the SPARC one.
      	(change_cfi_row): Use the right CFI directive's name for RA
      	mangling.
      	(output_cfi): Remove explicit architecture-specific CFI
      	directive DW_CFA_GNU_window_save that falls into default case.
      	(output_cfi_directive): Use target hook as default.
      	* dwarf2out.cc (dw_cfi_oprnd1_desc): Use target hook as default.
      	* dwarf2out.h (enum dw_cfi_oprnd_type): specify underlying type
      	of enum to allow forward declaration.
      	(dw_cfi_oprnd1_desc): Call target hook.
      	(output_cfi_directive): Use dw_cfi_ref instead of struct
      	dw_cfi_node *.
      	* hooks.cc
      	(hook_bool_dwcfi_dwcfioprndtyperef_false): New.
      	(hook_bool_FILEptr_dwcfiptr_false): New.
      	* hooks.h
      	(hook_bool_dwcfi_dwcfioprndtyperef_false): New.
      	(hook_bool_FILEptr_dwcfiptr_false): New.
      	* target.def: Documentation for new hooks.
      
      include/ChangeLog:
      
      	* dwarf2.h (enum dwarf_call_frame_info): specify underlying
      
      libffi/ChangeLog:
      
      	* include/ffi_cfi.h (cfi_negate_ra_state): Declare AArch64 cfi
      	directive.
      
      libgcc/ChangeLog:
      
      	* config/aarch64/aarch64-asm.h (PACIASP): Replace SPARC CFI
      	directive by AArch64 one.
      	(AUTIASP): Same.
      
      libitm/ChangeLog:
      
      	* config/aarch64/sjlj.S: Replace SPARC CFI directive by
      	AArch64 one.
      
      gcc/testsuite/ChangeLog:
      
      	* g++.target/aarch64/pr94515-1.C: Replace SPARC CFI directive by
      	AArch64 one.
      	* g++.target/aarch64/pr94515-2.C: Same.
      9e1c71ba
  7. Sep 20, 2024
    • GCC Administrator's avatar
      Daily bump. · 442db842
      GCC Administrator authored
      442db842
    • Tobias Burnus's avatar
      OpenMP: Add get_device_from_uid/omp_get_uid_from_device routines · bf4a5efa
      Tobias Burnus authored
      Those TR13/OpenMP 6.0 routines permit a reproducible offloading to
      a specific device by mapping an OpenMP device number to a
      unique ID (UID). The GPU device UIDs should be universally unique,
      the one for the host is not.
      
      gcc/ChangeLog:
      
      	* omp-general.cc (omp_runtime_api_procname): Add
      	get_device_from_uid and omp_get_uid_from_device routines.
      
      include/ChangeLog:
      
      	* cuda/cuda.h (cuDeviceGetUuid): Declare.
      	(cuDeviceGetUuid_v2): Add prototype.
      
      libgomp/ChangeLog:
      
      	* config/gcn/target.c (omp_get_uid_from_device,
      	omp_get_device_from_uid): Add stub implementation.
      	* config/nvptx/target.c (omp_get_uid_from_device,
      	omp_get_device_from_uid): Likewise.
      	* fortran.c (omp_get_uid_from_device_,
      	omp_get_uid_from_device_8_): New functions.
      	* libgomp-plugin.h (GOMP_OFFLOAD_get_uid): Add prototype.
      	* libgomp.h (struct gomp_device_descr): Add 'uid' and 'get_uid_func'.
      	* libgomp.map (GOMP_6.0): New, includind the new UID routines.
      	* libgomp.texi (OpenMP Technical Report 13): Mark UID routines as 'Y'.
      	(Device Information Routines): Document new UID routines.
      	(Offload-Target Specifics): Document UID format.
      	* omp.h.in (omp_get_device_from_uid, omp_get_uid_from_device):
      	New prototype.
      	* omp_lib.f90.in (omp_get_device_from_uid, omp_get_uid_from_device):
      	New interface.
      	* omp_lib.h.in: Likewise.
      	* plugin/cuda-lib.def: Add cuDeviceGetUuid and cuDeviceGetUuid_v2 via
      	CUDA_ONE_CALL_MAYBE_NULL.
      	* plugin/plugin-gcn.c (GOMP_OFFLOAD_get_uid): New.
      	* plugin/plugin-nvptx.c (GOMP_OFFLOAD_get_uid): New.
      	* target.c (str_omp_initial_device): New static var.
      	(STR_OMP_DEV_PREFIX): Define.
      	(gomp_get_uid_for_device, omp_get_uid_from_device,
      	omp_get_device_from_uid): New.
      	(gomp_load_plugin_for_device): DLSYM_OPT the function 'get_uid'.
      	(gomp_target_init): Set the device's 'uid' field to NULL.
      	* testsuite/libgomp.c/device_uid.c: New test.
      	* testsuite/libgomp.fortran/device_uid.f90: New test.
      bf4a5efa
  8. Sep 14, 2024
  9. Sep 13, 2024
    • Tobias Burnus's avatar
      Fortran: Fixes to OpenMP 'interop' directive parsing support · 99988464
      Tobias Burnus authored
      Handle lists as argument to 'fr' and 'attr'; fix parsing corner cases.
      Additionally, 'fr' values are now internally stored as integer, permitting
      the diagnoses (warning) for values not defined in the OpenMP additional
      definitions document.
      
      	PR fortran/116661
      
      gcc/fortran/ChangeLog:
      
      	* gfortran.h (gfc_omp_namelist): Rename 'init' members for clarity.
      	* match.cc (gfc_free_omp_namelist): Handle renaming.
      	* dump-parse-tree.cc (show_omp_namelist): Update for new format
      	and features.
      	* openmp.cc (gfc_match_omp_prefer_type): Parse list to 'fr' and 'attr';
      	store 'fr' values as integer.
      	(gfc_match_omp_init): Rename variable names.
      
      gcc/ChangeLog:
      
      	* omp-api.h (omp_get_fr_id_from_name, omp_get_name_from_fr_id): New
      	prototypes.
      	* omp-general.cc (omp_get_fr_id_from_name, omp_get_name_from_fr_id):
      	New.
      
      include/ChangeLog:
      
      	* gomp-constants.h (GOMP_INTEROP_IFR_LAST,
      	GOMP_INTEROP_IFR_SEPARATOR, GOMP_INTEROP_IFR_NONE): New.
      
      gcc/testsuite/ChangeLog:
      
      	* gfortran.dg/gomp/interop-1.f90: Extend, update dg-*.
      	* gfortran.dg/gomp/interop-2.f90: Update dg-error.
      	* gfortran.dg/gomp/interop-3.f90: Add dg-warning.
      99988464
  10. Aug 10, 2024
  11. Aug 09, 2024
  12. Jul 03, 2024
  13. Jul 02, 2024
    • David Faust's avatar
      ctf: use pointers instead of IDs internally · 36774cec
      David Faust authored
      This patch replaces all inter-type references in the ctfc internal data
      structures with pointers, rather than the references-by-ID which were
      used previously.
      
      A couple of small updates in the BPF backend are included to make it
      compatible with the change.
      
      This change is only to the in-memory representation of various CTF
      structures to make them easier to work with in various cases.  It is
      outwardly transparent; there is no change in emitted CTF.
      
      gcc/
      	* btfout.cc (BTF_VOID_TYPEID, BTF_INIT_TYPEID): Move defines to
      	include/btf.h.
      	(btf_dvd_emit_preprocess_cb, btf_emit_preprocess)
      	(btf_dmd_representable_bitfield_p, btf_asm_array, btf_asm_varent)
      	(btf_asm_sou_member, btf_asm_func_arg, btf_init_postprocess):
      	Adapt to structural changes in ctf_* structs.
      	* ctfc.h (struct ctf_dtdef): Add forward declaration.
      	(ctf_dtdef_t, ctf_dtdef_ref): Move typedefs earlier.
      	(struct ctf_arinfo, struct ctf_funcinfo, struct ctf_sliceinfo)
      	(struct ctf_itype, struct ctf_dmdef, struct ctf_func_arg)
      	(struct ctf_dvdef): Use pointers instead of type IDs for
      	references to other types and use typedefs where appropriate.
      	(struct ctf_dtdef): Add ref_type member.
      	(ctf_type_exists): Use pointer instead of type ID.
      	(ctf_add_reftype, ctf_add_enum, ctf_add_slice, ctf_add_float)
      	(ctf_add_integer, ctf_add_unknown, ctf_add_pointer)
      	(ctf_add_array, ctf_add_forward, ctf_add_typedef)
      	(ctf_add_function, ctf_add_sou, ctf_add_enumerator)
      	(ctf_add_variable): Likewise. Return pointer instead of ID.
      	(ctf_lookup_tree_type): Return pointer to type instead of ID.
      	* ctfc.cc: Analogous changes.
      	* ctfout.cc (ctf_asm_type, ctf_asm_slice, ctf_asm_varent)
      	(ctf_asm_sou_lmember, ctf_asm_sou_member, ctf_asm_func_arg)
      	(output_ctf_objt_info): Adapt to changes.
      	* dwarf2ctf.cc (gen_ctf_type, gen_ctf_void_type)
      	(gen_ctf_unknown_type, gen_ctf_base_type, gen_ctf_pointer_type)
      	(gen_ctf_subrange_type, gen_ctf_array_type, gen_ctf_typedef)
      	(gen_ctf_modifier_type, gen_ctf_sou_type, gen_ctf_function_type)
      	(gen_ctf_enumeration_type, gen_ctf_variable, gen_ctf_function)
      	(gen_ctf_type, ctf_do_die): Likewise.
      	* config/bpf/btfext-out.cc (struct btf_ext_core_reloc): Use
      	pointer instead of type ID.
      	(bpf_core_reloc_add, bpf_core_get_sou_member_index)
      	(output_btfext_core_sections): Adapt to above changes.
      	* config/bpf/core-builtins.cc (process_type): Likewise.
      
      include/
      	* btf.h (BTF_VOID_TYPEID, BTF_INIT_TYPEID): Move defines here,
      	from gcc/btfout.cc.
      36774cec
  14. May 30, 2024
  15. May 29, 2024
    • Tobias Burnus's avatar
      libgomp: Enable USM for AMD APUs and MI200 devices · 18f47798
      Tobias Burnus authored
      If HSA_AMD_SYSTEM_INFO_SVM_ACCESSIBLE_BY_DEFAULT is true,
      all GPUs on the system support unified shared memory. That's
      the case for APUs and MI200 devices when XNACK is enabled.
      
      XNACK can be enabled by setting HSA_XNACK=1 as env var for
      supported devices; otherwise, if disable, USM code will
      use host fallback.
      
      gcc/ChangeLog:
      
      	* config/gcn/gcn-hsa.h (gcn_local_sym_hash): Fix typo.
      
      include/ChangeLog:
      
      	* hsa.h (HSA_AMD_SYSTEM_INFO_SVM_ACCESSIBLE_BY_DEFAULT): Add
      	enum value.
      
      libgomp/ChangeLog:
      
      	* libgomp.texi (gcn): Update USM handling
      	* plugin/plugin-gcn.c (GOMP_OFFLOAD_get_num_devices): Handle
      	USM if HSA_AMD_SYSTEM_INFO_SVM_ACCESSIBLE_BY_DEFAULT is true.
      18f47798
    • Tobias Burnus's avatar
      libgomp: Enable USM for some nvptx devices · 4ccb3366
      Tobias Burnus authored
      A few high-end nvptx devices support the attribute
      CU_DEVICE_ATTRIBUTE_PAGEABLE_MEMORY_ACCESS; for those, unified shared
      memory is supported in hardware. This patch enables support for those -
      if all installed nvptx devices have this feature (as the capabilities
      are per device type).
      
      This exposes a bug in gomp_copy_back_icvs as it did before use
      omp_get_mapped_ptr to find mapped variables, but that returns
      the unchanged pointer in cased of shared memory. But in this case,
      we have a few actually mapped pointers - like the ICV variables.
      Additionally, there was a mismatch with regards to '-1' for the
      device number as gomp_copy_back_icvs and omp_get_mapped_ptr count
      differently. Hence, do the lookup manually.
      
      include/ChangeLog:
      
      	* cuda/cuda.h (CU_DEVICE_ATTRIBUTE_PAGEABLE_MEMORY_ACCESS): Add.
      
      libgomp/ChangeLog:
      
      	* libgomp.texi (nvptx): Update USM description.
      	* plugin/plugin-nvptx.c (GOMP_OFFLOAD_get_num_devices):
      	Claim support when requesting USM and all devices support
      	CU_DEVICE_ATTRIBUTE_PAGEABLE_MEMORY_ACCESS.
      	* target.c (gomp_copy_back_icvs): Fix device ptr lookup.
      	(gomp_target_init): Set GOMP_OFFLOAD_CAP_SHARED_MEM is the
      	devices supports USM.
      4ccb3366
  16. Apr 09, 2024
  17. Apr 08, 2024
    • Thomas Schwinge's avatar
      GCN, nvptx: Errors during device probing are fatal · a02d7f0e
      Thomas Schwinge authored
      Currently, we silently disable libgomp GCN and nvptx plugins/devices in
      presence of certain error conditions during device probing, thus typically
      silently resorting to host-fallback execution.  Make such errors fatal, similar
      as for any other device access later on, so that we early and reliably notice
      when things go wrong.  (Keep just two cases non-fatal: (a) libgomp GCN or nvptx
      plugins are available but 'libhsa-runtime64.so.1' or 'libcuda.so.1' are not,
      and (b) those are available, but the corresponding devices are not.)
      
      This resolves the issue that we've got execution test cases unexpectedly
      PASSing, despite:
      
          libgomp: GCN fatal error: Run-time could not be initialized
          Runtime message: HSA_STATUS_ERROR_OUT_OF_RESOURCES: The runtime failed to allocate the necessary resources. This error may also occur when the core runtime library needs to spawn threads or create internal OS-specific events.
      
      ..., and therefore they were not offloaded to the GCN device, but ran in
      host-fallback execution mode.  What happend in that scenario is that in
      'init_hsa_context' during the initial 'GOMP_OFFLOAD_get_num_devices' we ran
      into 'HSA_STATUS_ERROR_OUT_OF_RESOURCES', but it wasn't fatal, but just
      silently disabled the libgomp plugin/device.
      
      Especially "entertaining" were cases where such unintended host-fallback
      execution happened during effective-target checks like
      'offload_device_available' (host-fallback execution there meaning: no offload
      device available), but actual test cases then were running with an offload
      device available, and therefore mis-configured.
      
      	include/
      	* cuda/cuda.h (CUresult): Add 'CUDA_ERROR_NO_DEVICE'.
      	libgomp/
      	* plugin/plugin-gcn.c (init_hsa_context): Add and handle
      	'bool probe' parameter.  Adjust all users; errors during device
      	probing are fatal.
      	* plugin/plugin-nvptx.c (nvptx_get_num_devices): Aside from
      	'CUDA_ERROR_NO_DEVICE', errors during device probing are fatal.
      a02d7f0e
  18. Mar 01, 2024
  19. Feb 29, 2024
    • Tom Tromey's avatar
      Fix PR libcc1/113977 · bc0e18a9
      Tom Tromey authored
      PR libcc1/113977 points out a case where a simple expression is
      rejected with a compiler error message.  The bug here is that gdb does
      not inform the plugin of the correct alignment -- in fact, there is no
      way to do that.
      
      This patch adds a new method to allow the alignment to be set, and
      bumps the C front end protocol version.
      
      It also includes some updates to various comments in 'include', done
      here to simplify the merge to binutils-gdb.
      
      include
      
      	* gcc-cp-interface.h (gcc_cp_fe_context_function): Update
      	comment.
      	* gcc-c-interface.h (enum gcc_c_api_version) <GCC_C_FE_VERSION_2>:
      	New constant.
      	(gcc_c_fe_context_function): Update comment.
      	* gcc-c-fe.def (finish_record_with_alignment): New method.
      	Update documentation.
      
      libcc1
      
      	PR libcc1/113977
      	* libcc1plugin.cc (plugin_finish_record_or_union): New function.
      	(plugin_finish_record_or_union): Rewrite.
      	(plugin_init): Use GCC_C_FE_VERSION_2.
      	* libcc1.cc (c_vtable): Use GCC_C_FE_VERSION_2.
      	(gcc_c_fe_context): Check for GCC_C_FE_VERSION_2.
      
      
      bc0e18a9
  20. Jan 14, 2024
  21. Jan 13, 2024
    • Jakub Jelinek's avatar
      c++, demangle: Implement https://github.com/itanium-cxx-abi/cxx-abi/issues/148 non-proposal · 65388b28
      Jakub Jelinek authored
      The following patch attempts to implement what apparently clang++
      implemented for explicit object member function mangling, but nobody
      actually proposed in patch form in
      https://github.com/itanium-cxx-abi/cxx-abi/issues/148
      
      2024-01-13  Jakub Jelinek  <jakub@redhat.com>
      
      gcc/cp/
      	* mangle.cc (write_nested_name): Mangle explicit object
      	member functions with H as per
      	https://github.com/itanium-cxx-abi/cxx-abi/issues/148 non-proposal.
      gcc/testsuite/
      	* g++.dg/abi/mangle79.C: New test.
      include/
      	* demangle.h (enum demangle_component_type): Add
      	DEMANGLE_COMPONENT_XOBJ_MEMBER_FUNCTION.
      libiberty/
      	* cp-demangle.c (FNQUAL_COMPONENT_CASE): Add case for
      	DEMANGLE_COMPONENT_XOBJ_MEMBER_FUNCTION.
      	(d_dump): Handle DEMANGLE_COMPONENT_XOBJ_MEMBER_FUNCTION.
      	(d_nested_name): Parse H after N in nested name.
      	(d_count_templates_scopes): Handle
      	DEMANGLE_COMPONENT_XOBJ_MEMBER_FUNCTION.
      	(d_print_mod): Likewise.
      	(d_print_function_type): Likewise.
      	* testsuite/demangle-expected: Add tests for explicit object
      	member functions.
      65388b28
  22. Jan 10, 2024
  23. Jan 09, 2024
    • Jeff Law's avatar
      [committed] Adding missing prototype for __clzhi2 to xstormy port · 9f7afa99
      Jeff Law authored
      xstormy16 has failed since the c99 transition due to a missing prototype for
      __clzhi2 in the implementation of stormy16_count_leading_zeros.
      
      This fixes the missing prototype.  Pushed to the trunk.
      
      include/
      	* longlong.h (__stormy16_count_leading_zeros): Add prototype for
      	__clzhi2.
      9f7afa99
  24. Jan 03, 2024
  25. Dec 16, 2023
  26. Dec 15, 2023
    • Julian Brown's avatar
      OpenMP/OpenACC: Unordered/non-constant component offset runtime diagnostic · f5745dc1
      Julian Brown authored
      This patch adds support for non-constant component offsets in "map"
      clauses for OpenMP (and the equivalants for OpenACC), which are not able
      to be sorted into order at compile time.  Normally struct accesses in
      such clauses are gathered together and sorted into increasing address
      order after a "GOMP_MAP_STRUCT" node: if we have variable indices,
      that is no longer possible.
      
      This version of the patch scales back the previously-posted version to
      merely add a diagnostic for incorrect usage of component accesses with
      variably-indexed arrays of structs: the only permitted variant is where
      we have multiple indices that are the same, but we could not prove so
      at compile time.  Rather than silently producing the wrong result for
      cases where the indices are in fact different, we error out (e.g.,
      "map(dtarr(i)%arrptr, dtarr(j)%arrptr(4:8))", for different i/j).
      
      For now, multiple *constant* array indices are still supported (see
      map-arrayofstruct-1.c).  That could perhaps be addressed with a follow-up
      patch, if necessary.
      
      This version of the patch renumbers the GOMP_MAP_STRUCT_UNORD kind to
      avoid clashing with the OpenACC "non-contiguous" dynamic array support
      (though that is not yet applied to mainline).
      
      2023-08-18  Julian Brown  <julian@codesourcery.com>
      
      gcc/
      	* gimplify.cc (extract_base_bit_offset): Add VARIABLE_OFFSET parameter.
      	(omp_get_attachment, omp_group_last, omp_group_base,
      	omp_directive_maps_explicitly): Add GOMP_MAP_STRUCT_UNORD support.
      	(omp_accumulate_sibling_list): Update calls to extract_base_bit_offset.
      	Support GOMP_MAP_STRUCT_UNORD.
      	(omp_build_struct_sibling_lists, gimplify_scan_omp_clauses,
      	gimplify_adjust_omp_clauses, gimplify_omp_target_update): Add
      	GOMP_MAP_STRUCT_UNORD support.
      	* omp-low.cc (lower_omp_target): Add GOMP_MAP_STRUCT_UNORD support.
      	* tree-pretty-print.cc (dump_omp_clause): Likewise.
      
      include/
      	* gomp-constants.h (gomp_map_kind): Add GOMP_MAP_STRUCT_UNORD.
      
      libgomp/
      	* oacc-mem.c (find_group_last, goacc_enter_data_internal,
      	goacc_exit_data_internal, GOACC_enter_exit_data): Add
      	GOMP_MAP_STRUCT_UNORD support.
      	* target.c (gomp_map_vars_internal): Add GOMP_MAP_STRUCT_UNORD support.
      	Detect incorrect use of variable indexing of arrays of structs.
      	(GOMP_target_enter_exit_data, gomp_target_task_fn): Add
      	GOMP_MAP_STRUCT_UNORD support.
      	* testsuite/libgomp.c-c++-common/map-arrayofstruct-1.c: New test.
      	* testsuite/libgomp.c-c++-common/map-arrayofstruct-2.c: New test.
      	* testsuite/libgomp.c-c++-common/map-arrayofstruct-3.c: New test.
      	* testsuite/libgomp.fortran/map-subarray-5.f90: New test.
      f5745dc1
  27. Dec 11, 2023
  28. Dec 10, 2023
    • Tom Tromey's avatar
      Add some new DW_IDX_* constants · 748766b8
      Tom Tromey authored
      I've reimplemented the .debug_names code in GDB -- it was quite far
      from being correct, and the new implementation is much closer to what
      is specified by DWARF.
      
      However, the new writer in GDB needs to emit some symbol properties,
      so that the reader can be fully functional.  This patch adds a few new
      DW_IDX_* constants, and tries to document the existing extensions as
      well.  (My patch series add more documentation of these to the GDB
      manual as well.)
      
      include/ChangeLog
      2023-12-10  Tom Tromey  <tom@tromey.com>
      
      	* dwarf2.def (DW_IDX_GNU_internal, DW_IDX_GNU_external): Comment.
      	(DW_IDX_GNU_main, DW_IDX_GNU_language, DW_IDX_GNU_linkage_name):
      	New constants.
      748766b8
  29. Dec 02, 2023
  30. Dec 01, 2023
    • Jason Merrill's avatar
      c++: mangle function template constraints · c3f281a0
      Jason Merrill authored
      Per https://github.com/itanium-cxx-abi/cxx-abi/issues/24 and
      https://github.com/itanium-cxx-abi/cxx-abi/pull/166
      
      We need to mangle constraints to be able to distinguish between function
      templates that only differ in constraints.  From the latter link, we want to
      use the template parameter mangling previously specified for lambdas to also
      make explicit the form of a template parameter where the argument is not a
      "natural" fit for it, such as when the parameter is constrained or deduced.
      
      I'm concerned about how the latter link changes the mangling for some C++98
      and C++11 patterns, so I've limited template_parm_natural_p to avoid two
      cases found by running the testsuite with -Wabi forced on:
      
      template <class T, T V> T f() { return V; }
      int main() { return f<int,42>(); }
      
      template <int i> int max() { return i; }
      template <int i, int j, int... rest> int max()
      {
        int sub = max<j, rest...>();
        return i > sub ? i : sub;
      }
      int main() {  return max<1,2,3>(); }
      
      A third C++11 pattern is changed by this patch:
      
      template <template <typename...> class TT, typename... Ts> TT<Ts...> f();
      template <typename> struct A { };
      int main() { f<A,int>(); }
      
      I aim to resolve these with the ABI committee before GCC 14.1.
      
      We also need to resolve https://github.com/itanium-cxx-abi/cxx-abi/issues/38
      (mangling references to dependent template-ids where the name is fully
      resolved) as references to concepts in std:: will consistently run into this
      area.  This is why mangle-concepts1.C only refers to concepts in the global
      namespace so far.
      
      The library changes are to avoid trying to mangle builtins, which fails.
      
      Demangler support and test coverage is not complete yet.
      
      gcc/cp/ChangeLog:
      
      	* cp-tree.h (TEMPLATE_ARGS_TYPE_CONSTRAINT_P): New.
      	(get_concept_check_template): Declare.
      	* constraint.cc (combine_constraint_expressions)
      	(finish_shorthand_constraint): Use UNKNOWN_LOCATION.
      	* pt.cc (convert_generic_types_to_packs): Likewise.
      	* mangle.cc (write_constraint_expression)
      	(write_tparms_constraints, write_type_constraint)
      	(template_parm_natural_p, write_requirement)
      	(write_requires_expr): New.
      	(write_encoding): Mangle trailing requires-clause.
      	(write_name): Pass parms to write_template_args.
      	(write_template_param_decl): Factor out from...
      	(write_closure_template_head): ...here.
      	(write_template_args): Mangle non-natural parms
      	and requires-clause.
      	(write_expression): Handle REQUIRES_EXPR.
      
      include/ChangeLog:
      
      	* demangle.h (enum demangle_component_type): Add
      	DEMANGLE_COMPONENT_CONSTRAINTS.
      
      libiberty/ChangeLog:
      
      	* cp-demangle.c (d_make_comp): Handle
      	DEMANGLE_COMPONENT_CONSTRAINTS.
      	(d_count_templates_scopes): Likewise.
      	(d_print_comp_inner): Likewise.
      	(d_maybe_constraints): New.
      	(d_encoding, d_template_args_1): Call it.
      	(d_parmlist): Handle 'Q'.
      	* testsuite/demangle-expected: Add some constraint tests.
      
      libstdc++-v3/ChangeLog:
      
      	* include/std/bit: Avoid builtins in requires-clauses.
      	* include/std/variant: Likewise.
      
      gcc/testsuite/ChangeLog:
      
      	* g++.dg/abi/mangle10.C: Disable compat aliases.
      	* g++.dg/abi/mangle52.C: Specify ABI 18.
      	* g++.dg/cpp2a/class-deduction-alias3.C
      	* g++.dg/cpp2a/class-deduction-alias8.C:
      	Avoid builtins in requires-clauses.
      	* g++.dg/abi/mangle-concepts1.C: New test.
      	* g++.dg/abi/mangle-ttp1.C: New test.
      c3f281a0
  31. Nov 29, 2023
  32. Nov 28, 2023
    • Jakub Jelinek's avatar
      libiberty: Use x86 HW optimized sha1 · bf4f40cc
      Jakub Jelinek authored
      Nick has approved this patch (+ small ld change to use it for --build-id=),
      so I'm commiting it to GCC as master as well.
      
      If anyone from ARM would be willing to implement it similarly with
      vsha1{cq,mq,pq,h,su0q,su1q}_u32 intrinsics, it could be a useful linker
      speedup on those hosts as well, the intent in sha1.c was that
      sha1_hw_process_bytes, sha1_hw_process_block functions
      would be defined whenever
      defined (HAVE_X86_SHA1_HW_SUPPORT) || defined (HAVE_WHATEVERELSE_SHA1_HW_SUPPORT)
      but the body of sha1_hw_process_block and sha1_choose_process_bytes
      would then have #elif defined (HAVE_WHATEVERELSE_SHA1_HW_SUPPORT) for
      the other arch support, similarly for any target attributes on
      sha1_hw_process_block if needed.
      
      2023-11-28  Jakub Jelinek  <jakub@redhat.com>
      
      include/
      	* sha1.h (sha1_process_bytes_fn): New typedef.
      	(sha1_choose_process_bytes): Declare.
      libiberty/
      	* configure.ac (HAVE_X86_SHA1_HW_SUPPORT): New check.
      	* sha1.c: If HAVE_X86_SHA1_HW_SUPPORT is defined, include x86intrin.h
      	and cpuid.h.
      	(sha1_hw_process_bytes, sha1_hw_process_block,
      	sha1_choose_process_bytes): New functions.
      	* config.in: Regenerated.
      	* configure: Regenerated.
      bf4f40cc
  33. Nov 08, 2023
  34. Nov 07, 2023
    • Kwok Cheung Yeung's avatar
      openmp: Add support for the 'indirect' clause in C/C++ · a49c7d31
      Kwok Cheung Yeung authored
      This adds support for the 'indirect' clause in the 'declare target'
      directive.  Functions declared as indirect may be called via function
      pointers passed from the host in offloaded code.
      
      Virtual calls to member functions via the object pointer in C++ are
      currently not supported in target regions.
      
      2023-11-07  Kwok Cheung Yeung  <kcy@codesourcery.com>
      
      gcc/c-family/
      	* c-attribs.cc (c_common_attribute_table): Add attribute for
      	indirect functions.
      	* c-pragma.h (enum parma_omp_clause): Add entry for indirect clause.
      
      gcc/c/
      	* c-decl.cc (c_decl_attributes): Add attribute for indirect
      	functions.
      	* c-lang.h (c_omp_declare_target_attr): Add indirect field.
      	* c-parser.cc (c_parser_omp_clause_name): Handle indirect clause.
      	(c_parser_omp_clause_indirect): New.
      	(c_parser_omp_all_clauses): Handle indirect clause.
      	(OMP_DECLARE_TARGET_CLAUSE_MASK): Add indirect clause to mask.
      	(c_parser_omp_declare_target): Handle indirect clause.  Emit error
      	message if device_type or indirect clauses used alone.  Emit error
      	if indirect clause used with device_type that is not 'any'.
      	(OMP_BEGIN_DECLARE_TARGET_CLAUSE_MASK): Add indirect clause to mask.
      	(c_parser_omp_begin): Handle indirect clause.
      	* c-typeck.cc (c_finish_omp_clauses): Handle indirect clause.
      
      gcc/cp/
      	* cp-tree.h (cp_omp_declare_target_attr): Add indirect field.
      	* decl2.cc (cplus_decl_attributes): Add attribute for indirect
      	functions.
      	* parser.cc (cp_parser_omp_clause_name): Handle indirect clause.
      	(cp_parser_omp_clause_indirect): New.
      	(cp_parser_omp_all_clauses): Handle indirect clause.
      	(handle_omp_declare_target_clause): Add extra parameter.  Add
      	indirect attribute for indirect functions.
      	(OMP_DECLARE_TARGET_CLAUSE_MASK): Add indirect clause to mask.
      	(cp_parser_omp_declare_target): Handle indirect clause.  Emit error
      	message if device_type or indirect clauses used alone.  Emit error
      	if indirect clause used with device_type that is not 'any'.
      	(OMP_BEGIN_DECLARE_TARGET_CLAUSE_MASK): Add indirect clause to mask.
      	(cp_parser_omp_begin): Handle indirect clause.
      	* semantics.cc (finish_omp_clauses): Handle indirect clause.
      
      gcc/
      	* lto-cgraph.cc (enum LTO_symtab_tags): Add tag for indirect
      	functions.
      	(output_offload_tables): Write indirect functions.
      	(input_offload_tables): read indirect functions.
      	* lto-section-names.h (OFFLOAD_IND_FUNC_TABLE_SECTION_NAME): New.
      	* omp-builtins.def (BUILT_IN_GOMP_TARGET_MAP_INDIRECT_PTR): New.
      	* omp-offload.cc (offload_ind_funcs): New.
      	(omp_discover_implicit_declare_target): Add functions marked with
      	'omp declare target indirect' to indirect functions list.
      	(omp_finish_file): Add indirect functions to section for offload
      	indirect functions.
      	(execute_omp_device_lower): Redirect indirect calls on target by
      	passing function pointer to BUILT_IN_GOMP_TARGET_MAP_INDIRECT_PTR.
      	(pass_omp_device_lower::gate): Run pass_omp_device_lower if
      	indirect functions are present on an accelerator device.
      	* omp-offload.h (offload_ind_funcs): New.
      	* tree-core.h (omp_clause_code): Add OMP_CLAUSE_INDIRECT.
      	* tree.cc (omp_clause_num_ops): Add entry for OMP_CLAUSE_INDIRECT.
      	(omp_clause_code_name): Likewise.
      	* tree.h (OMP_CLAUSE_INDIRECT_EXPR): New.
      	* config/gcn/mkoffload.cc (process_asm): Process offload_ind_funcs
      	section.  Count number of indirect functions.
      	(process_obj): Emit number of indirect functions.
      	* config/nvptx/mkoffload.cc (ind_func_ids, ind_funcs_tail): New.
      	(process): Emit offload_ind_func_table in PTX code.  Emit indirect
      	function names and count in image.
      	* config/nvptx/nvptx.cc (nvptx_record_offload_symbol): Mark
      	indirect functions in PTX code with IND_FUNC_MAP.
      
      gcc/testsuite/
      	* c-c++-common/gomp/declare-target-7.c: Update expected error message.
      	* c-c++-common/gomp/declare-target-indirect-1.c: New.
      	* c-c++-common/gomp/declare-target-indirect-2.c: New.
      	* g++.dg/gomp/attrs-21.C (v12): Update expected error message.
      	* g++.dg/gomp/declare-target-indirect-1.C: New.
      	* gcc.dg/gomp/attrs-21.c (v12): Update expected error message.
      
      include/
      	* gomp-constants.h (GOMP_VERSION): Increment to 3.
      	(GOMP_VERSION_SUPPORTS_INDIRECT_FUNCS): New.
      
      libgcc/
      	* offloadstuff.c (OFFLOAD_IND_FUNC_TABLE_SECTION_NAME): New.
      	(__offload_ind_func_table): New.
      	(__offload_ind_funcs_end): New.
      	(__OFFLOAD_TABLE__): Add entries for indirect functions.
      
      libgomp/
      	* Makefile.am (libgomp_la_SOURCES): Add target-indirect.c.
      	* Makefile.in: Regenerate.
      	* libgomp-plugin.h (GOMP_INDIRECT_ADDR_MAP): New define.
      	(GOMP_OFFLOAD_load_image): Add extra argument.
      	* libgomp.h (struct indirect_splay_tree_key_s): New.
      	(indirect_splay_tree_node, indirect_splay_tree,
      	indirect_splay_tree_key): New.
      	(indirect_splay_compare): New.
      	* libgomp.map (GOMP_5.1.1): Add GOMP_target_map_indirect_ptr.
      	* libgomp.texi (OpenMP 5.1): Update documentation on indirect
      	calls in target region and on indirect clause.
      	(Other new OpenMP 5.2 features): Add entry for virtual function calls.
      	* libgomp_g.h (GOMP_target_map_indirect_ptr): Add prototype.
      	* oacc-host.c (host_load_image): Add extra argument.
      	* target.c (gomp_load_image_to_device): If the GOMP_VERSION is high
      	enough, read host indirect functions table and pass to
      	load_image_func.
      	* config/accel/target-indirect.c: New.
      	* config/linux/target-indirect.c: New.
      	* config/gcn/team.c (build_indirect_map): Add prototype.
      	(gomp_gcn_enter_kernel): Initialize support for indirect
      	function calls on GCN target.
      	* config/nvptx/team.c (build_indirect_map): Add prototype.
      	(gomp_nvptx_main): Initialize support for indirect function
      	calls on NVPTX target.
      	* plugin/plugin-gcn.c (struct gcn_image_desc): Add field for
      	indirect functions count.
      	(GOMP_OFFLOAD_load_image): Add extra argument.  If the GOMP_VERSION
      	is high enough, build address translation table and copy it to target
      	memory.
      	* plugin/plugin-nvptx.c (nvptx_tdata): Add field for indirect
      	functions count.
      	(GOMP_OFFLOAD_load_image): Add extra argument.  If the GOMP_VERSION
      	is high enough, Build address translation table and copy it to target
      	memory.
      	* testsuite/libgomp.c-c++-common/declare-target-indirect-1.c: New.
      	* testsuite/libgomp.c-c++-common/declare-target-indirect-2.c: New.
      	* testsuite/libgomp.c++/declare-target-indirect-1.C: New.
      a49c7d31
  35. Oct 26, 2023
  36. Oct 25, 2023
    • Chung-Lin Tang's avatar
      OpenACC 2.7: Implement self clause for compute constructs · 3a359638
      Chung-Lin Tang authored
      This patch implements the 'self' clause for compute constructs: parallel,
      kernels, and serial. This clause conditionally uses the local device
      (the host mult-core CPU) as the executing device of the compute region.
      
      The actual implementation of the "local device" device type inside libgomp
      (presumably using pthreads) is still not yet completed, so the libgomp
      side is still implemented the exact same as host-fallback mode. (so as of now,
      it essentially behaves like the 'if' clause with the condition inverted)
      
      gcc/c/ChangeLog:
      
      	* c-parser.cc (c_parser_oacc_compute_clause_self): New function.
      	(c_parser_oacc_all_clauses): Add new 'bool compute_p = false'
      	parameter, add parsing of self clause when compute_p is true.
      	(OACC_KERNELS_CLAUSE_MASK): Add PRAGMA_OACC_CLAUSE_SELF.
      	(OACC_PARALLEL_CLAUSE_MASK): Likewise,
      	(OACC_SERIAL_CLAUSE_MASK): Likewise.
      	(c_parser_oacc_compute): Adjust call to c_parser_oacc_all_clauses to
      	set compute_p argument to true.
      	* c-typeck.cc (c_finish_omp_clauses): Add OMP_CLAUSE_SELF case.
      
      gcc/cp/ChangeLog:
      
      	* parser.cc (cp_parser_oacc_compute_clause_self): New function.
      	(cp_parser_oacc_all_clauses): Add new 'bool compute_p = false'
      	parameter, add parsing of self clause when compute_p is true.
      	(OACC_KERNELS_CLAUSE_MASK): Add PRAGMA_OACC_CLAUSE_SELF.
      	(OACC_PARALLEL_CLAUSE_MASK): Likewise,
      	(OACC_SERIAL_CLAUSE_MASK): Likewise.
      	(cp_parser_oacc_compute): Adjust call to c_parser_oacc_all_clauses to
      	set compute_p argument to true.
      	* pt.cc (tsubst_omp_clauses): Add OMP_CLAUSE_SELF case.
      	* semantics.cc (c_finish_omp_clauses): Add OMP_CLAUSE_SELF case, merged
      	with OMP_CLAUSE_IF case.
      
      gcc/fortran/ChangeLog:
      
      	* gfortran.h (typedef struct gfc_omp_clauses): Add self_expr field.
      	* openmp.cc (enum omp_mask2): Add OMP_CLAUSE_SELF.
      	(gfc_match_omp_clauses): Add handling for OMP_CLAUSE_SELF.
      	(OACC_PARALLEL_CLAUSES): Add OMP_CLAUSE_SELF.
      	(OACC_KERNELS_CLAUSES): Likewise.
      	(OACC_SERIAL_CLAUSES): Likewise.
      	(resolve_omp_clauses): Add handling for omp_clauses->self_expr.
      	* trans-openmp.cc (gfc_trans_omp_clauses): Add handling of
      	clauses->self_expr and building of OMP_CLAUSE_SELF tree clause.
      	(gfc_split_omp_clauses): Add handling of self_expr field copy.
      
      gcc/ChangeLog:
      
      	* gimplify.cc (gimplify_scan_omp_clauses): Add OMP_CLAUSE_SELF case.
      	(gimplify_adjust_omp_clauses): Likewise.
      	* omp-expand.cc (expand_omp_target): Add OMP_CLAUSE_SELF expansion code,
      	* omp-low.cc (scan_sharing_clauses): Add OMP_CLAUSE_SELF case.
      	* tree-core.h (enum omp_clause_code): Add OMP_CLAUSE_SELF enum.
      	* tree-nested.cc (convert_nonlocal_omp_clauses): Add OMP_CLAUSE_SELF
      	case.
      	(convert_local_omp_clauses): Likewise.
      	* tree-pretty-print.cc (dump_omp_clause): Add OMP_CLAUSE_SELF case.
      	* tree.cc (omp_clause_num_ops): Add OMP_CLAUSE_SELF entry.
      	(omp_clause_code_name): Likewise.
      	* tree.h (OMP_CLAUSE_SELF_EXPR): New macro.
      
      gcc/testsuite/ChangeLog:
      
      	* c-c++-common/goacc/self-clause-1.c: New test.
      	* c-c++-common/goacc/self-clause-2.c: New test.
      	* gfortran.dg/goacc/self.f95: New test.
      
      include/ChangeLog:
      
      	* gomp-constants.h (GOACC_FLAG_LOCAL_DEVICE): New flag bit value.
      
      libgomp/ChangeLog:
      
      	* oacc-parallel.c (GOACC_parallel_keyed): Add code to handle
      	GOACC_FLAG_LOCAL_DEVICE case.
      	* testsuite/libgomp.oacc-c-c++-common/self-1.c: New test.
      3a359638
  37. Oct 13, 2023
Loading