Especially in the recent CRC commits, I see
\ No newline at end of file
in almost every second file.  So, I went through
the diff between r15-1 and current trunk in gcc/, looking for
additions of such problems which don't intentional (e.g.
Wtrailing-whitespace* tests had it there intentionally) and
just added the missing newline elsewhere.

2024-12-02  Jakub Jelinek  <jakub@redhat.com>

gcc/
	* config/mingw/mingw-stdint.h: Add newline at the end of the file.
	* config/mingw/winnt-dll.cc: Likewise.
	* sym-exec/sym-exec-expression.h: Likewise.
	* sym-exec/sym-exec-expression.cc: Likewise.
	* sym-exec/sym-exec-condition.cc: Likewise.
	* sym-exec/sym-exec-expr-is-a-helper.h: Likewise.
	* sym-exec/sym-exec-condition.h: Likewise.
	* hwint.cc: Likewise.
	* crc-verification.cc: Likewise.
	* sarif-spec-urls.def: Likewise.
gcc/testsuite/
	* g++.target/aarch64/pr94515-2.C: Add newline at the end of the file.
	* g++.target/aarch64/return_address_sign_ab_exception.C: Likewise.
	* gcc.target/arm/thumb2-switchstatement.c: Likewise.
	* gcc.target/riscv/rvv/base/vssubu-2.c: Likewise.
	* gcc.target/riscv/rvv/base/vssubu-1.c: Likewise.
	* gcc.target/riscv/and-shift32.c: Likewise.
	* gcc.target/riscv/crc-builtin-zbc32.c: Likewise.
	* gcc.target/riscv/and-shift64.c: Likewise.
	* gcc.target/riscv/xtheadbb-extu-4.c: Likewise.
	* gcc.target/i386/avx2-bf16-vec-absneg.c: Likewise.
	* gcc.target/i386/avx512f-bf16-vec-absneg.c: Likewise.
	* gcc.target/aarch64/cpunative/native_cpu_26.c: Likewise.
	* gcc.target/aarch64/cpunative/info_26: Likewise.
	* gcc.target/aarch64/cpunative/info_25: Likewise.
	* g++.dg/contracts/pr116607.C: Likewise.
	* gfortran.dg/pr108889.f90: Likewise.
	* gcc.dg/crc-not-crc-14.c: Likewise.
	* gcc.dg/crc-from-fedora-packages-13.c: Likewise.
	* gcc.dg/crc-not-crc-25.c: Likewise.
	* gcc.dg/crc-from-fedora-packages-29.c: Likewise.
	* gcc.dg/crc-from-fedora-packages-10.c: Likewise.
	* gcc.dg/crc-side-instr-10.c: Likewise.
	* gcc.dg/crc-side-instr-1.c: Likewise.
	* gcc.dg/crc-side-instr-3.c: Likewise.
	* gcc.dg/crc-side-instr-2.c: Likewise.
	* gcc.dg/crc-not-crc-17.c: Likewise.
	* gcc.dg/crc-from-fedora-packages-7.c: Likewise.
	* gcc.dg/crc-side-instr-12.c: Likewise.
	* gcc.dg/crc-side-instr-16.c: Likewise.
	* gcc.dg/crc-not-crc-16.c: Likewise.
	* gcc.dg/crc-from-fedora-packages-4.c: Likewise.
	* gcc.dg/crc-not-crc-20.c: Likewise.
	* gcc.dg/crc-linux-3.c: Likewise.
	* gcc.dg/crc-from-fedora-packages-27.c: Likewise.
	* gcc.dg/pr109393.c: Likewise.
	* gcc.dg/crc-side-instr-7.c: Likewise.
	* gcc.dg/crc-side-instr-4.c: Likewise.
	* gcc.dg/tree-ssa/ldexp.c: Likewise.
	* gcc.dg/tree-ssa/pr114760-2.c: Likewise.
	* gcc.dg/tree-ssa/pr114760-1.c: Likewise.
	* gcc.dg/crc-side-instr-15.c: Likewise.
	* gcc.dg/crc-side-instr-9.c: Likewise.
	* gcc.dg/crc-not-crc-26.c: Likewise.
	* gcc.dg/crc-side-instr-8.c: Likewise.
	* gcc.dg/crc-not-crc-23.c: Likewise.
	* gcc.dg/crc-not-crc-19.c: Likewise.
	* gcc.dg/crc-from-fedora-packages-22.c: Likewise.
	* gcc.dg/crc-from-fedora-packages-16.c: Likewise.
	* gcc.dg/crc-side-instr-11.c: Likewise.
	* gcc.dg/crc-from-fedora-packages-5.c: Likewise.
	* gcc.dg/crc-not-crc-22.c: Likewise.
	* gcc.dg/crc-side-instr-17.c: Likewise.
	* gcc.dg/crc-linux-4.c: Likewise.
	* gcc.dg/crc-side-instr-14.c: Likewise.
	* gcc.dg/crc-not-crc-18.c: Likewise.
	* gcc.dg/crc-from-fedora-packages-23.c: Likewise.
	* gcc.dg/crc-not-crc-21.c: Likewise.
	* gcc.dg/crc-linux-2.c: Likewise.
	* gcc.dg/crc-from-fedora-packages-1.c: Likewise.
	* gcc.dg/crc-from-fedora-packages-30.c: Likewise.
	* gcc.dg/torture/crc-11.c: Likewise.
	* gcc.dg/torture/crc-27.c: Likewise.
	* gcc.dg/torture/crc-2.c: Likewise.
	* gcc.dg/torture/crc-24.c: Likewise.
	* gcc.dg/torture/crc-crc8.c: Likewise.
	* gcc.dg/torture/crc-crc8-data8-xorOustideFor.c: Likewise.
	* gcc.dg/torture/crc-16.c: Likewise.
	* gcc.dg/torture/crc-crc64-data64.c: Likewise.
	* gcc.dg/crc-from-fedora-packages-32.c: Likewise.
	* gcc.dg/crc-side-instr-6.c: Likewise.
	* gcc.dg/crc-side-instr-5.c: Likewise.
	* gcc.dg/crc-side-instr-13.c: Likewise.
	* gcc.dg/crc-not-crc-15.c: Likewise.
	* gcc.dg/crc-not-crc-13.c: Likewise.
	* gcc.dg/crc-from-fedora-packages-6.c: Likewise.
	* gcc.dg/crc-not-crc-24.c: Likewise.

Symbolically execute potential CRC loops and check whether the loop actually
calculates CRC (uses LFSR matching).  Calculated CRC and created LFSR are
compared on each iteration of the potential CRC loop.

gcc/

	* Makefile.in (OBJS): Add crc-verification.o.
	* crc-verification.cc: New file.
	* crc-verification.h: New file.
	* gimple-crc-optimization.cc (loop_calculates_crc): New function.
	(is_output_crc): Likewise.
	(swap_crc_and_data_if_needed): Likewise.
	(validate_crc_and_data): Likewise.
	(optimize_crc_loop): Likewise.
	(get_output_phi): Likewise.
	(execute): Add check whether potential CRC loop calculates CRC.
	* sym-exec/sym-exec-state.cc (create_reversed_lfsr): New function.
	(create_forward_lfsr): Likewise.
	(last_set_bit): Likewise.
	(create_lfsr): Likewise.
	* sym-exec/sym-exec-state.h (is_bit_vector): Reorder, make the function public and static.
	(create_reversed_lfsr) New static function declaration.
	(create_forward_lfsr) New static function declaration.