Skip to content
Snippets Groups Projects
  1. Nov 23, 2022
  2. Nov 22, 2022
    • Jeff Law's avatar
      Fix thinko in last patch · ee86077c
      Jeff Law authored
      gcc/
      	* tree-ssa-dom.cc (record_edge_info): Fix thinko in last commit.
      ee86077c
    • Jeff Law's avatar
      Fix comment typos noticed by Bernhard · a03b35a2
      Jeff Law authored
      gcc/
      	* tree-ssa-dom.cc (record_edge_info): Fix comment typos.
      a03b35a2
    • Jeff Law's avatar
      Fix recent rvv/base/spill testcase failures · ca73d4c8
      Jeff Law authored
      he core issue is we're expecting the frame to have a constant size, but it
      doesn't.  So when using the to_constant method we abort.
      
      The safest thing to do is to set no shrink-wrapping components when the
      frame size is not fixed.  We might be able to do better later -- iff we
      know the offset to the GPRs/FPRs is fixed and fits into the appropriate
      number of bits.
      
      Bootstrapped and regression tested (C-only) on riscv64-linux-gnu.  As
      expected, it fixes a bucketload of failures in rvv/base/spill-*.c.
      
      gcc/
      	* config/riscv/riscv.cc (riscv_get_separate_components): Do not
      	do shrink-wrapping for a frame with a variable size.
      ca73d4c8
    • Siddhesh Poyarekar's avatar
      tree-object-size: Support strndup and strdup · e5cfb9ca
      Siddhesh Poyarekar authored
      Use string length of input to strdup to determine the usable size of the
      resulting object.  Avoid doing the same for strndup since there's a
      chance that the input may be too large, resulting in an unnecessary
      overhead or worse, the input may not be NULL terminated, resulting in a
      crash where there would otherwise have been none.
      
      gcc/ChangeLog:
      
      	* tree-object-size.cc (todo): New variable.
      	(object_sizes_execute): Use it.
      	(strdup_object_size): New function.
      	(call_object_size): Use it.
      
      gcc/testsuite/ChangeLog:
      
      	* gcc.dg/builtin-dynamic-object-size-0.c (test_strdup,
      	test_strndup, test_strdup_min, test_strndup_min): New tests.
      	(main): Call them.
      	* gcc.dg/builtin-dynamic-object-size-1.c: Silence overread
      	warnings.
      	* gcc.dg/builtin-dynamic-object-size-2.c: Likewise.
      	* gcc.dg/builtin-dynamic-object-size-3.c: Likewise.
      	* gcc.dg/builtin-dynamic-object-size-4.c: Likewise.
      	* gcc.dg/builtin-object-size-1.c: Silence overread warnings.
      	Declare free, strdup and strndup.
      	(test11): New test.
      	(main): Call it.
      	* gcc.dg/builtin-object-size-2.c: Silence overread warnings.
      	Declare free, strdup and strndup.
      	(test9): New test.
      	(main): Call it.
      	* gcc.dg/builtin-object-size-3.c: Silence overread warnings.
      	Declare free, strdup and strndup.
      	(test11): New test.
      	(main): Call it.
      	* gcc.dg/builtin-object-size-4.c: Silence overread warnings.
      	Declare free, strdup and strndup.
      	(test9): New test.
      	(main): Call it.
      e5cfb9ca
    • David Malcolm's avatar
      analyzer: only look for named functions in root ns [PR107788] · ec7c796d
      David Malcolm authored
      
      gcc/analyzer/ChangeLog:
      	PR analyzer/107788
      	* known-function-manager.cc (known_function_manager::get_match):
      	Don't look up fndecls by name when they're not in the root
      	namespace.
      
      gcc/testsuite/ChangeLog:
      	PR analyzer/107788
      	* g++.dg/analyzer/named-functions.C: New test.
      
      Signed-off-by: default avatarDavid Malcolm <dmalcolm@redhat.com>
      ec7c796d
    • David Malcolm's avatar
      analyzer: fix ICE on 'bind(INT_CST, ...)' [PR107783] · 64fb291c
      David Malcolm authored
      
      This was crashing inside fd_phase_mismatch's ctor with assertion
      failure when the state was "fd-constant".
      
      Fix the ICE by not complaining about constants passed to these APIs.
      
      gcc/analyzer/ChangeLog:
      	PR analyzer/107783
      	* sm-fd.cc (fd_state_machine::check_for_new_socket_fd): Don't
      	complain when old state is "fd-constant".
      	(fd_state_machine::on_listen): Likewise.
      	(fd_state_machine::on_accept): Likewise.
      
      gcc/testsuite/ChangeLog:
      	PR analyzer/107783
      	* gcc.dg/analyzer/fd-accept.c (test_accept_on_constant): New.
      	* gcc.dg/analyzer/fd-bind.c (test_bind_on_constant): New.
      	* gcc.dg/analyzer/fd-connect.c (test_connect_on_constant): New.
      	* gcc.dg/analyzer/fd-listen.c (test_listen_on_connected_socket):
      	Fix typo.
      	(test_listen_on_constant): New.
      
      Signed-off-by: default avatarDavid Malcolm <dmalcolm@redhat.com>
      64fb291c
    • David Malcolm's avatar
      analyzer: fix 'errno' on Solaris and OS X [PR107807] · 7c9717fc
      David Malcolm authored
      
      gcc/analyzer/ChangeLog:
      	PR analyzer/107807
      	* region-model-impl-calls.cc (register_known_functions): Register
      	"___errno" and "__error" as synonyms  for "__errno_location".
      
      gcc/testsuite/ChangeLog:
      	PR analyzer/107807
      	* gcc.dg/analyzer/errno-___errno.c: New test.
      	* gcc.dg/analyzer/errno-__error.c: New test.
      	* gcc.dg/analyzer/errno-global-var.c: New test.
      
      Signed-off-by: default avatarDavid Malcolm <dmalcolm@redhat.com>
      7c9717fc
    • David Malcolm's avatar
      analyzer: eliminate region_model::impl_call_* special cases · 6bd31b33
      David Malcolm authored
      
      Eliminate all of the remaining special cases in class region_model that
      handle various specific functions, replacing them with uses of
      known_function subclasses.
      
      Add various type-checks that ought to prevent ICEs for cases where
      functions match the name of a standard C library or POSIX function, but
      have incompatible arguments.
      
      gcc/analyzer/ChangeLog:
      	* analyzer.h (class internal_known_function): New.
      	(register_varargs_builtins): New decl.
      	* engine.cc (exploded_node::on_stmt_pre): Remove
      	"out_terminate_path" param from call to region_model::on_stmt_pre.
      	(feasibility_state::maybe_update_for_edge): Likewise.
      	* known-function-manager.cc: Include "basic-block.h", "gimple.h",
      	and "analyzer/region-model.h".
      	(known_function_manager::known_function_manager): Initialize
      	m_combined_fns_arr.
      	(known_function_manager::~known_function_manager): Clean up
      	m_combined_fns_arr.
      	(known_function_manager::get_by_identifier): Make const.
      	(known_function_manager::add): New overloaded definitions for
      	enum built_in_function and enum internal_fn.
      	(known_function_manager::get_by_fndecl): Delete.
      	(known_function_manager::get_match): New.
      	(known_function_manager::get_internal_fn): New.
      	(known_function_manager::get_normal_builtin): New.
      	* known-function-manager.h
      	(known_function_manager::get_by_identifier): Make private and
      	add const qualifier.
      	(known_function_manager::get_by_fndecl): Delete.
      	(known_function_manager::add): Add overloaded decls for
      	enum built_in_function name and enum internal_fn.
      	(known_function_manager::get_match): New decl.
      	(known_function_manager::get_internal_fn): New decl.
      	(known_function_manager::get_normal_builtin): New decl.
      	(known_function_manager::m_combined_fns_arr): New field.
      	* region-model-impl-calls.cc (call_details::arg_is_size_p): New.
      	(class kf_alloca): New.
      	(region_model::impl_call_alloca): Convert to...
      	(kf_alloca::impl_call_pre): ...this.
      	(kf_analyzer_dump_capacity::matches_call_types_p): Rewrite check
      	to use call_details::arg_is_pointer_p.
      	(region_model::impl_call_builtin_expect): Convert to...
      	(class kf_expect): ...this.
      	(class kf_calloc): New, adding check that both arguments are
      	size_t.
      	(region_model::impl_call_calloc): Convert to...
      	(kf_calloc::impl_call_pre): ...this.
      	(kf_connect::matches_call_types_p): Rewrite check to use
      	call_details::arg_is_pointer_p.
      	(region_model::impl_call_error): Convert to...
      	(class kf_error): ...this, and...
      	(kf_error::impl_call_pre): ...this.
      	(class kf_fgets): New, adding checks that args 0 and 2 are
      	pointers.
      	(region_model::impl_call_fgets): Convert to...
      	(kf_fgets::impl_call_pre): ...this.
      	(class kf_fread): New, adding checks on the argument types.
      	(region_model::impl_call_fread): Convert to...
      	(kf_fread::impl_call_pre): ...this.
      	(class kf_free): New, adding check that the argument is a pointer.
      	(region_model::impl_call_free): Convert to...
      	(kf_free::impl_call_post): ...this.
      	(class kf_getchar): New.
      	(class kf_malloc): New, adding check that the argument is a
      	size_t.
      	(region_model::impl_call_malloc): Convert to...
      	(kf_malloc::impl_call_pre): ...this.
      	(class kf_memcpy): New, adding checks on arguments.
      	(region_model::impl_call_memcpy): Convert to...
      	(kf_memcpy::impl_call_pre): ...this.
      	(class kf_memset): New.
      	(region_model::impl_call_memset): Convert to...
      	(kf_memset::impl_call_pre): ...this.
      	(kf_pipe::matches_call_types_p): Rewrite check to use
      	call_details::arg_is_pointer_p.
      	(kf_putenv::matches_call_types_p): Likewise.
      	(class kf_realloc): New, adding checks on the argument types.
      	(region_model::impl_call_realloc): Convert to...
      	(kf_realloc::impl_call_post): ...this.
      	(class kf_strchr): New.
      	(region_model::impl_call_strchr): Convert to...
      	(kf_strchr::impl_call_post): ...this.
      	(class kf_stack_restore): New.
      	(class kf_stack_save): New.
      	(class kf_stdio_output_fn): New.
      	(class kf_strcpy): New,
      	(region_model::impl_call_strcpy): Convert to...
      	(kf_strcpy::impl_call_pre): ...this.
      	(class kf_strlen): New.
      	(region_model::impl_call_strlen): Convert to...
      	(kf_strlen::impl_call_pre): ...this.
      	(class kf_ubsan_bounds): New.
      	(region_model::impl_deallocation_call): Reimplement to avoid call
      	to impl_call_free.
      	(register_known_functions): Add handlers for IFN_BUILTIN_EXPECT
      	and IFN_UBSAN_BOUNDS.  Add handlers for BUILT_IN_ALLOCA,
      	BUILT_IN_ALLOCA_WITH_ALIGN, BUILT_IN_CALLOC, BUILT_IN_EXPECT,
      	BUILT_IN_EXPECT_WITH_PROBABILITY, BUILT_IN_FPRINTF,
      	BUILT_IN_FPRINTF_UNLOCKED, BUILT_IN_FPUTC,
      	BUILT_IN_FPUTC_UNLOCKED, BUILT_IN_FPUTS, BUILT_IN_FPUTS_UNLOCKED,
      	BUILT_IN_FREE, BUILT_IN_FWRITE, BUILT_IN_FWRITE_UNLOCKED,
      	BUILT_IN_MALLOC, BUILT_IN_MEMCPY, BUILT_IN_MEMCPY_CHK,
      	BUILT_IN_MEMSET, BUILT_IN_MEMSET_CHK, BUILT_IN_PRINTF,
      	BUILT_IN_PRINTF_UNLOCKED, BUILT_IN_PUTC, BUILT_IN_PUTCHAR,
      	BUILT_IN_PUTCHAR_UNLOCKED, BUILT_IN_PUTC_UNLOCKED, BUILT_IN_PUTS,
      	BUILT_IN_PUTS_UNLOCKED, BUILT_IN_REALLOC, BUILT_IN_STACK_RESTORE,
      	BUILT_IN_STACK_SAVE, BUILT_IN_STRCHR, BUILT_IN_STRCPY,
      	BUILT_IN_STRCPY_CHK, BUILT_IN_STRLEN, BUILT_IN_VFPRINTF, and
      	BUILT_IN_VPRINTF. Call register_varargs_builtins.  Add handlers
      	for "getchar", "memset", "fgets", "fgets_unlocked", "fread",
      	"error", and "error_at_line".
      	* region-model.cc (region_model::on_stmt_pre): Drop
      	"out_terminate_path" param.
      	(region_model::get_known_function): Reimplement by calling
      	known_function_manager::get_match, passing new "cd" param.
      	Add overload taking enum internal_fn.
      	(region_model::on_call_pre): Drop "out_terminate_path" param.
      	Remove special-case handling of internal fns IFN_BUILTIN_EXPECT,
      	IFN_UBSAN_BOUNDS, and IFN_VA_ARG, of built-in fns BUILT_IN_ALLOCA,
      	BUILT_IN_ALLOCA_WITH_ALIGN, BUILT_IN_CALLOC, BUILT_IN_EXPECT,
      	BUILT_IN_EXPECT_WITH_PROBABILITY, BUILT_IN_FREE, BUILT_IN_MALLOC,
      	BUILT_IN_MEMCPY, BUILT_IN_MEMCPY_CHK, BUILT_IN_MEMSET,
      	BUILT_IN_MEMSET_CHK, BUILT_IN_REALLOC, BUILT_IN_STRCHR,
      	BUILT_IN_STRCPY, BUILT_IN_STRCPY_CHK, BUILT_IN_STRLEN,
      	BUILT_IN_STACK_SAVE, BUILT_IN_STACK_RESTORE, BUILT_IN_FPRINTF,
      	BUILT_IN_FPRINTF_UNLOCKED, BUILT_IN_PUTC, BUILT_IN_PUTC_UNLOCKED,
      	BUILT_IN_FPUTC, BUILT_IN_FPUTC_UNLOCKED, BUILT_IN_FPUTS,
      	BUILT_IN_FPUTS_UNLOCKED, BUILT_IN_FWRITE,
      	BUILT_IN_FWRITE_UNLOCKED, BUILT_IN_PRINTF,
      	BUILT_IN_PRINTF_UNLOCKED, BUILT_IN_PUTCHAR,
      	BUILT_IN_PUTCHAR_UNLOCKED, BUILT_IN_PUTS, BUILT_IN_PUTS_UNLOCKED,
      	BUILT_IN_VFPRINTF, BUILT_IN_VPRINTF, BUILT_IN_VA_START, and
      	BUILT_IN_VA_COPY, and of named functions "malloc", "calloc",
      	"alloca", "realloc", "error", "error_at_line", "fgets",
      	"fgets_unlocked", "fread", "getchar", "memset", "strchr", and
      	"strlen".  Replace all this special-casing with calls to
      	get_known_function for internal fns and for fn decls.
      	(region_model::on_call_post): Remove special-casing handling for
      	"free" and "strchr", and for BUILT_IN_REALLOC, BUILT_IN_STRCHR,
      	and BUILT_IN_VA_END.  Replace by consolidating on usage of
      	get_known_function.
      	* region-model.h (call_details::arg_is_size_p): New.
      	(region_model::on_stmt_pre): Drop "out_terminate_path" param.
      	(region_model::on_call_pre): Likewise.
      	(region_model::impl_call_alloca): Delete.
      	(region_model::impl_call_builtin_expect): Delete.
      	(region_model::impl_call_calloc): Delete.
      	(region_model::impl_call_error): Delete.
      	(region_model::impl_call_fgets): Delete.
      	(region_model::impl_call_fread): Delete.
      	(region_model::impl_call_free): Delete.
      	(region_model::impl_call_malloc): Delete.
      	(region_model::impl_call_memcpy): Delete.
      	(region_model::impl_call_memset): Delete.
      	(region_model::impl_call_realloc): Delete.
      	(region_model::impl_call_strchr): Delete.
      	(region_model::impl_call_strcpy): Delete.
      	(region_model::impl_call_strlen): Delete.
      	(region_model::impl_call_va_start): Delete.
      	(region_model::impl_call_va_copy): Delete.
      	(region_model::impl_call_va_arg): Delete.
      	(region_model::impl_call_va_end): Delete.
      	(region_model::check_region_for_write): Public.
      	(region_model::get_known_function): Add "cd" param.  Add
      	overloaded decl taking enum internal_fn.
      	* sm-malloc.cc: Update comments.
      	* varargs.cc (class kf_va_start): New.
      	(region_model::impl_call_va_start): Convert to...
      	(kf_va_start::impl_call_pre): ...this.
      	(class kf_va_copy): New.
      	(region_model::impl_call_va_copy): Convert to...
      	(kf_va_copy::impl_call_pre): ...this.
      	(class kf_va_arg): New.
      	(region_model::impl_call_va_arg): Convert to...
      	(kf_va_arg::impl_call_pre): ...this.
      	(class kf_va_end): New.
      	(region_model::impl_call_va_end): Delete.
      	(register_varargs_builtins): New.
      
      Signed-off-by: default avatarDavid Malcolm <dmalcolm@redhat.com>
      6bd31b33
    • Maciej W. Rozycki's avatar
      testsuite: Fix missing EFFECTIVE_TARGETS variable errors · 936d40b9
      Maciej W. Rozycki authored
      Permit running vector tests outside `check_vect_support_and_set_flags'
      environment, removing errors such as:
      
      ERROR: gcc.dg/analyzer/torture/pr93350.c   -O0 : can't read "EFFECTIVE_TARGETS": no such variable for " dg-require-effective-target 1 vect_int "
      
      or:
      
      ERROR: gcc.dg/bic-bitmask-13.c: error executing dg-final: can't read "EFFECTIVE_TARGETS": no such variable
      
      with `mips-linux-gnu' target testing.
      
      The EFFECTIVE_TARGETS variable has originated from commit 9b7937cf
      ("Add support to run auto-vectorization tests for multiple effective
      targets."), where arrangements have been made to run vector tests run
      within `check_vect_support_and_set_flags' environment iteratively over
      all the vector unit variants available in the architecture using extra
      compilation flags regardless of whether the target environment arranged
      for a particular testsuite run has vector support enabled by default.
      So far this has been used for the MIPS target only.
      
      Vector tests have since been added though that run outside environment
      set up by `check_vect_support_and_set_flags' just using the current
      compilation environment with no extra flags added.  This works for most
      targets, however causes problems with the MIPS target, because outside
      `check_vect_support_and_set_flags' environment the EFFECTIVE_TARGETS
      variable will not have been correctly set up even if it was added to
      the particular script invoking the test in question.
      
      Fix this by using just the current compilation environment whenever a
      vector feature is requested by `et-is-effective-target' in the absence
      of the EFFECTIVE_TARGETS variable.  This required some modification to
      individual vector feature tests, which always added the compilation
      flags required for the determination of whether the given vector unit
      variant can be verified with the current testsuite run (except for the
      Loongson MMI variant).  Now explicit flags are only passed in setting up
      EFFECTIVE_TARGETS and otherwise the current compilation environment will
      determine whether such a vector test is applicable.
      
      This changes how Loongson MMI is handled in that the `-mloongson-mmi'
      flag is explicitly passed for the determination of whether this vector
      unit variant can be verified, which I gather is how it was supposed to
      be arranged anyway because the flag is then added for testing the
      Loongson MMI variant.
      
      	gcc/testsuite/
      	* lib/target-supports.exp
      	(check_effective_target_mpaired_single): Add `args' argument and
      	pass it to `check_no_compiler_messages' replacing
      	`-mpaired-single'.
      	(add_options_for_mips_loongson_mmi): Add `args' argument and
      	pass it to `check_no_compiler_messages'.
      	(check_effective_target_mips_msa): Add `args' argument and pass
      	it to `check_no_compiler_messages' replacing `-mmsa'.
      	(check_effective_target_mpaired_single_runtime)
      	(add_options_for_mpaired_single): Pass `-mpaired-single' to
      	`check_effective_target_mpaired_single'.
      	(check_effective_target_mips_loongson_mmi_runtime)
      	(add_options_for_mips_loongson_mmi): Pass `-mloongson-mmi' to
      	`check_effective_target_mips_loongson_mmi'.
      	(check_effective_target_mips_msa_runtime)
      	(add_options_for_mips_msa): Pass `-mmsa' to
      	`check_effective_target_mips_msa'.
      	(et-is-effective-target): Verify that EFFECTIVE_TARGETS exists
      	and if not, just check if the current compilation environment
      	supports the target feature requested.
      	(check_vect_support_and_set_flags): Pass `-mpaired-single',
      	`-mloongson-mmi', and `-mmsa' to the respective target feature
      	checks.
      936d40b9
    • Eric Botcazou's avatar
      Fix wrong array type conversion with different storage orde · 55cb8c5c
      Eric Botcazou authored
      When two arrays of scalars have a different storage order in Ada, the
      front-end makes sure that the conversion is performed component-wise
      so that each component can be reversed.  So it's a little bit counter
      productive that the ldist pass performs the opposite transformation
      and synthesizes a memcpy/memmove in this case.
      
      gcc/
      	* tree-loop-distribution.cc (loop_distribution::classify_builtin_ldst):
      	Bail out if source and destination do not have the same storage order.
      
      gcc/testsuite/
      	* gnat.dg/sso18.adb: New test.
      55cb8c5c
    • Jonathan Wakely's avatar
      libstdc++: Replace std::isdigit and std::isxdigit in <format> [PR107817] · dfc1ea41
      Jonathan Wakely authored
      These functions aren't usable in constant expressions. Provide our own
      implementations, based on __from_chars_alnum_to_val from <charconv>.
      
      libstdc++-v3/ChangeLog:
      
      	PR libstdc++/107817
      	* include/std/charconv (__from_chars_alnum_to_val): Add
      	constexpr for C++20.
      	* include/std/format (__is_digit, __is_xdigit): New functions.
      	(_Spec::_S_parse_width_or_precision): Use __is_digit.
      	(__formatter_fp::parse): Use __is_xdigit.
      dfc1ea41
    • Jonathan Wakely's avatar
      libstdc++: Add testcase for fs::path constraint recursion [PR106201] · 6b859736
      Jonathan Wakely authored
      libstdc++-v3/ChangeLog:
      
      	PR libstdc++/106201
      	* testsuite/27_io/filesystem/iterators/106201.cc: New test.
      6b859736
    • Martin Jambor's avatar
      ipa-sra: Dump edge summaries also for non-candidates · 95489a2a
      Martin Jambor authored
      This should have been part of r12-578-g717d278af93a4a.  Call edge
      summaries provide information required for IPA-SRA transformations in
      the callees but are generated when analyzing callers and thus also
      callers which are not IPA-SRA candidates themselves.  Therefore we
      analyze them but don't dump them, which makes the dumops quite
      incomplete. This patch fixes that.
      
      gcc/ChangeLog:
      
      2021-12-14  Martin Jambor  <mjambor@suse.cz>
      
      	* ipa-sra.cc (ipa_sra_dump_all_summaries): Dump edge summaries even
      	for non-candidates.
      95489a2a
    • Martin Jambor's avatar
      ipa-cp: Do not consider useless aggregate constants · feeb0d68
      Martin Jambor authored
      When building vectors of known aggregate values, there is no point in
      including those for parameters which are not used in any way
      whatsoever.  This patch avoids that together with also other kinds of
      constants.
      
      gcc/ChangeLog:
      
      2022-11-13  Martin Jambor  <mjambor@suse.cz>
      
      	* ipa-cp.cc (push_agg_values_from_edge): Do not consider constants
      	in unused aggregate parameters.
      feeb0d68
    • Martin Jambor's avatar
      ipa: IPA-SRA split detection simplification · c826a041
      Martin Jambor authored
      I have noticed that the flag m_split_modifications_p of
      ipa_param_body_adjustments is not really necessary as it has to
      correspond to whether m_replacements is non-empty so this patches
      removes it.  This also simplifies a bit some patches I work on.
      
      gcc/ChangeLog:
      
      2022-11-10  Martin Jambor  <mjambor@suse.cz>
      
      	* ipa-param-manipulation.h (ipa_param_body_adjustments): Removed
      	member m_split_modifications_p.
      	* ipa-param-manipulation.cc
      	(ipa_param_body_adjustments::common_initialization): Do not set
      	m_split_modifications_p.
      	(ipa_param_body_adjustments::ipa_param_body_adjustments): Remove
      	initializations of m_split_modifications_p.
      	(ipa_param_body_adjustments::modify_call_stmt): Check that
      	m_replacements is empty instead of m_split_modifications_p.
      c826a041
    • Martin Jambor's avatar
      ipa-cp: Do not be too optimistic about self-recursive edges (PR 107661) · c4a92a91
      Martin Jambor authored
      PR 107661 shows that function push_agg_values_for_index_from_edge
      should not attempt to optimize self-recursive call graph edges when
      called from cgraph_edge_brings_all_agg_vals_for_node.  Unlike when
      being called from find_aggregate_values_for_callers_subset, we cannot
      expect that any cloning for constants would lead to the edge leading
      from a new clone to the same new clone, in this case it would only be
      redirected to a new callee.
      
      Fixed by adding a parameter to push_agg_values_from_edge whether being
      optimistic about self-recursive edges is possible.
      
      gcc/ChangeLog:
      
      2022-11-22  Martin Jambor  <mjambor@suse.cz>
      
      	PR ipa/107661
      	* ipa-cp.cc (push_agg_values_from_edge): New parameter
      	optimize_self_recursion, use it to decide whether to pass interim to
      	the helper function.
      	(find_aggregate_values_for_callers_subset): Pass true in the new
      	parameter of push_agg_values_from_edge.
      	(cgraph_edge_brings_all_agg_vals_for_node): Pass false in the new
      	parameter of push_agg_values_from_edge.
      
      gcc/testsuite/ChangeLog:
      
      2022-11-22  Martin Jambor  <mjambor@suse.cz>
      
      	PR ipa/107661
      	* g++.dg/ipa/pr107661.C: New test.
      c4a92a91
    • Tobias Burnus's avatar
      gcn: Add __builtin_gcn_{get_stack_limit,first_call_this_thread_p} · d6bbca7b
      Tobias Burnus authored
      
      The new builtins have been added for newlib to reduce dependency on
      compiler-internal implementation choices of GCC in newlibs' getreent.c.
      
      gcc/ChangeLog:
      
      	* config/gcn/gcn-builtins.def (FIRST_CALL_THIS_THREAD_P,
      	GET_STACK_LIMIT): Add new builtins.
      	* config/gcn/gcn.cc (gcn_expand_builtin_1): Expand them.
      	* config/gcn/gcn.md (prologue_use): Add "register_operand" as
      	arg to match_operand.
      	(prologue_use_di): New; DI insn_and_split variant of the former.
      
      Co-Authored-By: default avatarAndrew Stubbs <ams@codesourcery.com>
      d6bbca7b
    • Jason Merrill's avatar
      c++: don't use strchrnul [PR107781] · ac505414
      Jason Merrill authored
      The contracts implementation was using strchrnul, which is a glibc
      extension, so bootstrap broke on non-glibc targets.  Use C89 strcspn
      instead.
      
      	PR c++/107781
      
      gcc/cp/ChangeLog:
      
      	* contracts.cc (role_name_equal): Use strcspn instead
      	of strchrnul.
      ac505414
    • Christophe Lyon's avatar
      aarch64: Fix test_dfp_17.c for big-endian [PR 107604] · 4eb3a486
      Christophe Lyon authored
      gcc.target/aarch64/aapcs64/test_dfp_17.c has been failing on
      big-endian, because the _Decimal32 on-stack argument is not padded in
      the same direction depending on endianness.
      
      This patch fixes the testcase so that it expects the argument in the
      right stack location, similarly to what other tests do in the same
      directory.
      
      gcc/testsuite/ChangeLog:
      
      	PR target/107604
      	* gcc.target/aarch64/aapcs64/test_dfp_17.c: Fix for big-endian.
      4eb3a486
    • Piotr Trojanek's avatar
      ada: Accept aspects Global and Depends on abstract subprograms · 61351ab9
      Piotr Trojanek authored
      Aspects Global and Depends are now allowed on abstract subprograms
      (as substitutes for Global'Class and Depends'Class).
      
      This patch implements the recently modified rules SPARK RM 6.1.2(2-3).
      The behavior for Contract_Cases and aspects on null subprograms stays
      as it was.
      
      gcc/ada/
      
      	* sem_prag.adb (Analyze_Depends_Global): Accept aspects on
      	abstract subprograms.
      61351ab9
    • Ghjuvan Lacambre's avatar
      ada: Disable checking of Elab_Spec procedures in CodePeer_Mode · 05894d1c
      Ghjuvan Lacambre authored
      This commit re-enables the Validate_Subprogram_Calls check that had been
      disabled in a previous commit and has said check skip over Elab_Spec
      procedures in CodePeer_Mode.
      
      gcc/ada/
      
      	* frontend.adb (Frontend): Re-enable Validate_Subprogram_Calls.
      	* exp_ch6.adb (Check_BIP_Actuals): When in CodePeer mode, do not
      	attempt to validate procedures coming from an
      	Elab_Spec/Elab_Body/Elab_Subp_Body procedure.
      05894d1c
    • Piotr Trojanek's avatar
      ada: Adjust number of errors when removing warning in dead code · 29b7e005
      Piotr Trojanek authored
      When a warning about a runtime exception is emitted for a code in
      generic instance, we add continuation warnings "in instantiation ..."
      and only the original message increase the total number of errors.
      
      When removing these messages, e.g. after detecting that the code inside
      generic instance is dead, we must decrease the total number of errors,
      as otherwise the compiler exit status might stop gnatmake or gprbuild.
      
      gcc/ada/
      
      	* errout.adb (To_Be_Removed): Decrease total number of errors when
      	removing a warning that has been escalated into error.
      	* erroutc.adb (dmsg): Print Warn_Runtime_Raise flag.
      29b7e005
    • Eric Botcazou's avatar
      ada: Fix formatting glitches in Make_Tag_Assignment · 3b5f3138
      Eric Botcazou authored
      gcc/ada/
      
      	* exp_ch3.adb (Make_Tag_Assignment): Fix formatting glitches.
      3b5f3138
    • Eric Botcazou's avatar
      ada: Fix recent assertion failure on GPR2 · cd4b47a9
      Eric Botcazou authored
      It's the compiler trying to load the nonexistent body of a generic package
      when trying to inline a call to an expression function of this package that
      has a pre or post-condition (hence the need for -gnata to trigger the ICE).
      
      gcc/ada/
      
      	* contracts.adb (Build_Subprogram_Contract_Wrapper): Do not fiddle
      	with the Was_Expression_Function flag. Move a few lines around.
      cd4b47a9
    • Richard Biener's avatar
      tree-optimization/107803 - abnormal cleanup from the SSA propagator · e4faee8d
      Richard Biener authored
      The SSA propagator is missing abnormal cleanup which shows in a
      sanity check in the uninit engine (and missed CFG verification).
      The following adds that.
      
      	PR tree-optimization/107803
      	* tree-ssa-propagate.cc (substitute_and_fold_dom_walker): Add
      	need_ab_cleanup member.
      	(substitute_and_fold_dom_walker::before_dom_children): When
      	a stmt can no longer transfer control flow abnormally set
      	need_ab_cleanup.
      	(substitute_and_fold_engine::substitute_and_fold): Cleanup
      	abnormal control flow.
      
      	* g++.dg/pr107803.C: New testcase.
      e4faee8d
    • Jonathan Wakely's avatar
      libstdc++: Fix pool resource build errors for H8 [PR107801] · 0f9659e7
      Jonathan Wakely authored
      The array of pool sizes was previously adjusted to work for msp430-elf
      which has 16-bit int and either 16-bit size_t or 20-bit size_t. The
      largest pool sizes were disabled unless size_t has more than 20 bits.
      
      The H8 family has 16-bit int but 32-bit size_t, which means that the
      largest sizes are enabled, but 1<<15 produces a negative number that
      then cannot be narrowed to size_t.
      
      Replace the test for 32-bit size_t with a test for 32-bit int, which
      means we won't use the 4kiB to 4MiB pools for targets with 16-bit int
      even if they have a wider size_t.
      
      libstdc++-v3/ChangeLog:
      
      	PR libstdc++/107801
      	* src/c++17/memory_resource.cc (pool_sizes): Disable large pools
      	for targets with 16-bit int.
      0f9659e7
    • Richard Biener's avatar
      tree-optimization/107672 - avoid vector mode type_for_mode call · 09b7993a
      Richard Biener authored
      The following avoids using type_for_mode on vector modes which might
      not work for all frontends.  Instead we look for the inner mode
      type and use build_vector_type_for_mode instead.
      
      	PR tree-optimization/107672
      	* tree-vect-stmts.cc (supportable_widening_operation): Avoid
      	type_for_mode on vector modes.
      09b7993a
    • Richard Biener's avatar
      tree-optimization/107766 - ICE with recent -ffp-contract=off fix · 1a06ae6f
      Richard Biener authored
      The following uses *node to check for FP types rather than the
      child nodes which could be constant leafs and thus without a
      vector type.
      
      	PR tree-optimization/107766
      	* tree-vect-slp-patterns.cc (complex_mul_pattern::matches):
      	Use *node to check for FP vector types.
      
      	* g++.dg/vect/pr107766.cc: New testcase.
      1a06ae6f
    • liuhongt's avatar
      Guard 64/32-bit vector move patterns with ix86_hard_reg_move_ok. · d5fce9f6
      liuhongt authored
      gcc/ChangeLog:
      
      	* config/i386/mmx.md (*mov<mode>_internal): Add
      	ix86_hard_reg_move_ok to condition.
      d5fce9f6
    • liuhongt's avatar
      Some tidy up for RA related hooks. · 826c22df
      liuhongt authored
      1. We also need to guard size of TO to be
      less than TARGET_SSE2 ? 2 : 4 in ix86_can_change_mode_class.
      2. Merge VALID_AVX512FP16_SCALAR_MODE plus BFmode
      into VALID_AVX512F_SCALAR_MODE since we've support 16-bit data move
      above SSE2, so no need for the condition of AVX512FP16 for those evex
      sse registers.
      3. Allocate DI/HImode to sse register for SSE2 above just like
      SImode since we've supported 16-bit data move between sse and gpr
      above SSE2, this will help RA to handle cases like (subreg:HI (reg:V8HI)
      0) or else RA will spill it. This enable optimization for
      pices-memset-{3,37,39}.c
      
      gcc/ChangeLog:
      
      	* config/i386/i386.cc (ix86_can_change_mode_class): Also guard
      	size of TO.
      	(ix86_hard_regno_mode_ok): Remove VALID_AVX512FP16_SCALAR_MODE
      	* config/i386/i386.h (VALID_AVX512FP16_SCALAR_MODE): Merged to
      	..
      	(VALID_AVX512F_SCALAR_MODE): .. this, also add HImode.
      	(VALID_SSE_REG_MODE): Add DI/HImode.
      
      gcc/testsuite/ChangeLog:
      
      	* gcc.target/i386/pieces-memset-3.c: Remove xfail.
      	* gcc.target/i386/pieces-memset-37.c: Remove xfail.
      	* gcc.target/i386/pieces-memset-39.c: Remove xfail.
      826c22df
    • Jason Merrill's avatar
      c++: contracts fixes · b20a3854
      Jason Merrill authored
      Fixing -Wunused-parm warnings and link errors depending on where -fcontracts
      appears on the command line.
      
      gcc/cp/ChangeLog:
      
      	* contracts.cc (build_contract_condition_function):
      	Set DECL_ARTIFICIAL on return value parm.
      	* g++spec.cc (lang_specific_driver): Add -lstdc++exp
      	just before -lstdc++.
      b20a3854
    • GCC Administrator's avatar
      Daily bump. · 8b7fee1d
      GCC Administrator authored
      8b7fee1d
    • David Malcolm's avatar
      analyzer: fix ICE on 'bind' that returns a struct [PR107788] · 4e4e45a4
      David Malcolm authored
      
      gcc/analyzer/ChangeLog:
      	PR analyzer/107788
      	* region-model.cc (region_model::update_for_int_cst_return):
      	Require that the return type be an integer type.
      	(region_model::update_for_nonzero_return): Likewise.
      
      gcc/testsuite/ChangeLog:
      	PR analyzer/107788
      	* g++.dg/analyzer/fd-bind-pr107783.C: New test.
      
      Signed-off-by: default avatarDavid Malcolm <dmalcolm@redhat.com>
      4e4e45a4
    • David Malcolm's avatar
      analyzer: fix ICE on 'bind' with non-pointer arg [P107783] · 12a4785c
      David Malcolm authored
      
      gcc/analyzer/ChangeLog:
      	PR analyzer/107783
      	* region-model-impl-calls.cc (kf_accept::matches_call_types_p):
      	Require that args 1 and 2 be pointers.
      	(kf_bind::matches_call_types_p): Require that arg 1 be a pointer.
      	* region-model.h (call_details::arg_is_pointer_p): New
      
      gcc/testsuite/ChangeLog:
      	PR analyzer/107783
      	* gcc.dg/analyzer/fd-bind-pr107783.c: New test.
      
      Signed-off-by: default avatarDavid Malcolm <dmalcolm@redhat.com>
      12a4785c
    • David Malcolm's avatar
      analyzer: fix ICE on writes to errno [PR107777] · 358dab90
      David Malcolm authored
      
      gcc/analyzer/ChangeLog:
      	PR analyzer/107777
      	* call-summary.cc
      	(call_summary_replay::convert_region_from_summary_1): Handle
      	RK_THREAD_LOCAL and RK_ERRNO in switch.
      	* region-model.cc (region_model::get_representative_path_var_1):
      	Likewise.
      
      gcc/testsuite/ChangeLog:
      	PR analyzer/107777
      	* gcc.dg/analyzer/call-summaries-errno.c: New test.
      	* gcc.dg/analyzer/errno-pr107777.c: New test.
      
      Signed-off-by: default avatarDavid Malcolm <dmalcolm@redhat.com>
      358dab90
    • David Malcolm's avatar
      analyzer, testsuite: add more examples taken from CWE · 9ada4596
      David Malcolm authored
      
      gcc/testsuite/ChangeLog:
      	* gcc.dg/analyzer/CWE-131-examples.c: New test.
      	* gcc.dg/analyzer/file-CWE-1341-example.c: New test.
      	* gcc.dg/analyzer/malloc-CWE-401-example.c: New test.
      	* gcc.dg/analyzer/malloc-CWE-415-examples.c: New test.
      	* gcc.dg/analyzer/malloc-CWE-416-examples.c: New test.
      	* gcc.dg/analyzer/malloc-CWE-590-examples.c: New test.
      
      Signed-off-by: default avatarDavid Malcolm <dmalcolm@redhat.com>
      9ada4596
  3. Nov 21, 2022
    • Lewis Hyatt's avatar
      libcpp: Fix paste error with unknown pragma after macro expansion · 6f46d14d
      Lewis Hyatt authored
      In directives.cc, do_pragma() contains logic to handle a case such as the new
      testcase pragma-omp-unknown.c, where an unknown pragma was the result of macro
      expansion (for pragma namespaces that permit expansion). This no longer works
      correctly as shown by the testcase, fixed by adding PREV_WHITE to the flags on
      the second token to prevent an unwanted paste.  Also fixed the memory leak,
      since the temporary tokens are pushed on their own context, nothing prevents
      freeing of the buffer that holds them when the context is eventually popped.
      
      libcpp/ChangeLog:
      
      	* directives.cc (do_pragma): Fix memory leak in token buffer.  Fix
      	unwanted paste between two tokens.
      
      gcc/testsuite/ChangeLog:
      
      	* c-c++-common/gomp/pragma-omp-unknown.c: New test.
      6f46d14d
    • Sebastian Huber's avatar
      RTEMS: Use local-exec TLS model by default · 5c0d171f
      Sebastian Huber authored
      gcc/ChangeLog:
      
      	* config/rtems.h (SUBTARGET_CC1_SPEC): Undef and define.
      5c0d171f
    • Sebastian Huber's avatar
      Allow subtarget customization of CC1_SPEC · 58c3d9cd
      Sebastian Huber authored
      gcc/ChangeLog:
      
      	* gcc.cc (SUBTARGET_CC1_SPEC): Define if not defined.
      	(cc1_spec): Append SUBTARGET_CC1_SPEC.
      58c3d9cd
Loading