Skip to content
Snippets Groups Projects
  1. Oct 23, 2024
    • Jakub Jelinek's avatar
      libcpp: Add -Wleading-whitespace= warning · d4499a23
      Jakub Jelinek authored
      The following patch on top of the r15-4346 patch adds
      -Wleading-whitespace= warning option.
      This warning doesn't care how much one actually indents which line
      in the source (that is something that can't be easily done in the
      preprocessor without doing syntactic analysis), but just simple checks
      on what kind of whitespace is used in the indentation.
      I think it is still useful to get warnings about such issues early,
      while git diagnoses some of it in patches (e.g. the tab after space
      case), getting the warnings earlier might help avoiding such issues
      sooner.
      
      There are projects which ban use of tabs and require just spaces,
      others which require indentation just with horizontal tabs, and finally
      projects which want indentation with tabs for multiples of tabstop size
      followed by spaces (fewer than tabstop size), like GCC.
      For all 3 kinds the warning diagnoses indentation with '\v' or '\f'
      characters (unless line contains just whitespace), and for the last one
      also cases where a space in the indentation is followed by horizontal
      tab or where there are N or more consecutive spaces in the indentation
      (for -ftabstop=N).
      
      BTW, for additional testing I've enabled the warnings (without -Werror
      for them) in stage3.  There are many warnings (both trailing and leading
      whitespace), some of them something that can be easily fixed in the headers
      or source files, but others with whitespace issues in generated sources,
      so if we enable the warnings, either we'd need to adjust the generators
      or disable the warnings in (some of the) generated files.
      
      2024-10-23  Jakub Jelinek  <jakub@redhat.com>
      
      libcpp/
      	* include/cpplib.h (struct cpp_options): Add
      	cpp_warn_leading_whitespace and cpp_tabstop members.
      	(enum cpp_warning_reason): Add CPP_W_LEADING_WHITESPACE.
      	* internal.h (struct _cpp_line_note): Document new
      	line note kinds.
      	* init.cc (cpp_create_reader): Set cpp_tabstop to 8.
      	* lex.cc (find_leading_whitespace_issues): New function.
      	(_cpp_clean_line): Use it.
      	(_cpp_process_line_notes): Handle 'L', 'S' and 'T' line notes.
      	(lex_raw_string): Clear type on 'L', 'S' and 'T' line notes
      	inside of raw string literals.
      gcc/
      	* doc/invoke.texi (Wleading-whitespace=): Document.
      gcc/c-family/
      	* c.opt (Wleading-whitespace=): New option.
      	* c-opts.cc (c_common_post_options): Set cpp_opts->cpp_tabstop
      	to global_dc->m_tabstop.
      gcc/testsuite/
      	* c-c++-common/cpp/Wleading-whitespace-1.c: New test.
      	* c-c++-common/cpp/Wleading-whitespace-2.c: New test.
      	* c-c++-common/cpp/Wleading-whitespace-3.c: New test.
      	* c-c++-common/cpp/Wleading-whitespace-4.c: New test.
      d4499a23
  2. Oct 19, 2024
    • Lewis Hyatt's avatar
      diagnostics: libcpp: Improve locations for _Pragma lexing diagnostics [PR114423] · 65c5bbe1
      Lewis Hyatt authored
      libcpp is not currently set up to be able to generate valid
      locations for tokens lexed from a _Pragma string. Instead, after obtaining
      the tokens, it sets their locations all to the location of the _Pragma
      operator itself. This makes things like _Pragma("GCC diagnostic") work well
      enough, but if any diagnostics are issued during lexing, prior to resetting
      the token locations, those diagnostics get issued at the invalid
      locations. Fix that up by adding a new field pfile->diagnostic_override_loc
      that instructs libcpp to issue diagnostics at the alternate location.
      
      libcpp/ChangeLog:
      
      	PR preprocessor/114423
      	* internal.h (struct cpp_reader): Add DIAGNOSTIC_OVERRIDE_LOC
      	field.
      	* directives.cc (destringize_and_run): Set the new field to the
      	location of the _Pragma operator.
      	* errors.cc (cpp_diagnostic_at): Support DIAGNOSTIC_OVERRIDE_LOC to
      	temporarily issue diagnostics at a different location.
      	(cpp_diagnostic_with_line): Likewise.
      
      gcc/testsuite/ChangeLog:
      
      	PR preprocessor/114423
      	* c-c++-common/cpp/pragma-diagnostic-loc.c: New test.
      	* c-c++-common/cpp/diagnostic-pragma-1.c: Adjust expected output.
      	* g++.dg/pch/operator-1.C: Likewise.
      65c5bbe1
  3. Oct 15, 2024
    • Jakub Jelinek's avatar
      libcpp: Add -Wtrailing-blanks warning · ac615e10
      Jakub Jelinek authored
      Trailing blanks is something even git diff diagnoses; while it is a coding
      style issue, if it is so common that git diff diagnoses it, I think it could
      be useful to various projects to check that at compile time.
      
      Dunno if it should be included in -Wextra, currently it isn't, and due to
      tons of trailing whitespace in our sources, haven't enabled it for when
      building gcc itself either.
      
      Note, git diff also diagnoses indentation with tab following space, wonder
      if we couldn't have trivial warning options where one would simply ask for
      checking of indentation with no tabs, just spaces vs. indentation with
      tabs followed by spaces (but never tab width or more spaces in the
      indentation).  I think that would be easy to do also on the libcpp side.
      Checking how much something should be exactly indented requires syntax
      analysis (at least some limited one) and can consider columns of first token
      on line, but what the exact indentation blanks were is something only libcpp
      knows.
      
      On Thu, Sep 19, 2024 at 08:17:24AM +0200, Richard Biener wrote:
      > Generally I like diagnosing this early.  For the above I'd say -Wtrailing-whitespace=
      > with a set of things to diagnose (and a sane default - just spaces and tabs - for
      > -Wtrailiing-whitespace) would be nice.  As for naming possibly follow the
      > is{space,blank,cntrl} character classifications?  If those are a good
      > fit, that is.
      
      The patch currently allows blank (' ' '\t') and space (' ' '\t' '\f' '\v'),
      cntrl not yet added, not anything non-ASCII, but in theory could
      be added later (though, non-ASCII would be just for inside of comments,
      say non-breaking space etc. in the source is otherwise an error).
      
      2024-10-15  Jakub Jelinek  <jakub@redhat.com>
      
      libcpp/
      	* include/cpplib.h (struct cpp_options): Add
      	cpp_warn_trailing_whitespace member.
      	(enum cpp_warning_reason): Add CPP_W_TRAILING_WHITESPACE.
      	* internal.h (struct _cpp_line_note): Document 'W' line note.
      	* lex.cc (_cpp_clean_line): Add 'W' line note for trailing whitespace
      	except for trailing whitespace after backslash.  Formatting fix.
      	(_cpp_process_line_notes): Emit -Wtrailing-whitespace diagnostics.
      	Formatting fixes.
      	(lex_raw_string): Clear type on 'W' notes.
      gcc/
      	* doc/invoke.texi (Wtrailing-whitespace): Document.
      gcc/c-family/
      	* c.opt (Wtrailing-whitespace=): New option.
      	(Wtrailing-whitespace): New alias.
      	* c.opt.urls: Regenerate.
      gcc/testsuite/
      	* c-c++-common/cpp/Wtrailing-whitespace-1.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-2.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-3.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-4.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-5.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-6.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-7.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-8.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-9.c: New test.
      	* c-c++-common/cpp/Wtrailing-whitespace-10.c: New test.
      ac615e10
  4. Oct 14, 2024
    • Lewis Hyatt's avatar
      libcpp: Support extended characters for #pragma {push,pop}_macro [PR109704] · 998eb2a1
      Lewis Hyatt authored
      The implementation of #pragma push_macro and #pragma pop_macro has to date
      made use of an ad-hoc function, _cpp_lex_identifier(), which lexes an
      identifier out of a string. When support was added for extended characters
      in identifiers ($, UCNs, or UTF-8), that support was added only for the
      "normal" way of lexing identifiers out of a cpp_buffer (_cpp_lex_direct) and
      not for the ad-hoc way. Consequently, extended identifiers are not usable
      with these pragmas.
      
      The logic for lexing identifiers has become more complicated than it was
      when _cpp_lex_identifier() was written -- it now handles things like \N{}
      escapes in C++, for instance -- and it no longer seems practical to maintain
      a redundant code path for lexing identifiers. Address the issue by changing
      the implementation of #pragma {push,pop}_macro to lex identifiers in the
      expected way, i.e. by pushing a cpp_buffer and lexing the identifier from
      there.
      
      The existing implementation has some quirks because of the ad-hoc parsing
      logic. For example:
      
       #pragma push_macro("X ")
       ...
       #pragma pop_macro("X")
      
      will not restore macro X (note the extra space in the first string). However:
      
       #pragma push_macro("X ")
       ...
       #pragma pop_macro("X ")
      
      actually does sucessfully restore "X". This is because the key for looking
      up the saved macro on the push stack is the original string passed, so the
      string passed to pop_macro needs to match it exactly. It is not that easy to
      reproduce this logic in the world of extended characters, given that for
      example it should be valid to pass a UCN to push_macro, and the
      corresponding UTF-8 to pop_macro. Given that this aspect of the existing
      behavior seems unintentional and has no tests (and does not match other
      implementations), I opted to make the new logic more straightforward. The
      string passed needs to lex to one token, which must be a valid identifier,
      or else no action is taken and no error is generated. Any diagnostics
      encountered during lexing (e.g., due to a UTF-8 character not permitted to
      appear in an identifier) are also suppressed.
      
      It could be nice (for GCC 15) to also add a warning if a pop_macro does not
      match a previous push_macro.
      
      libcpp/ChangeLog:
      
      	PR preprocessor/109704
      	* include/cpplib.h (class cpp_auto_suppress_diagnostics): New class.
      	* errors.cc
      	(cpp_auto_suppress_diagnostics::cpp_auto_suppress_diagnostics): New
      	function.
      	(cpp_auto_suppress_diagnostics::~cpp_auto_suppress_diagnostics): New
      	function.
      	* charset.cc (noop_diagnostic_cb): Remove.
      	(cpp_interpret_string_ranges): Refactor diagnostic suppression logic
      	into new class cpp_auto_suppress_diagnostics.
      	(count_source_chars): Likewise.
      	* directives.cc (cpp_pop_definition): Add cpp_hashnode argument.
      	(lex_identifier_from_string): New static helper function.
      	(push_pop_macro_common): Refactor common logic from
      	do_pragma_push_macro and do_pragma_pop_macro; use
      	lex_identifier_from_string instead of _cpp_lex_identifier.
      	(do_pragma_push_macro): Reimplement using push_pop_macro_common.
      	(do_pragma_pop_macro): Likewise.
      	* internal.h (_cpp_lex_identifier): Remove.
      	* lex.cc (lex_identifier_intern): Remove.
      	(_cpp_lex_identifier): Remove.
      
      gcc/testsuite/ChangeLog:
      
      	PR preprocessor/109704
      	* c-c++-common/cpp/pragma-push-pop-utf8.c: New test.
      	* g++.dg/pch/pushpop-2.C: New test.
      	* g++.dg/pch/pushpop-2.Hs: New test.
      	* gcc.dg/pch/pushpop-2.c: New test.
      	* gcc.dg/pch/pushpop-2.hs: New test.
      998eb2a1
  5. Oct 07, 2024
    • Jakub Jelinek's avatar
      libcpp: Use constexpr for _cpp_trigraph_map initialization for C++14 · e4c0595e
      Jakub Jelinek authored
      The _cpp_trigraph_map initialization used to be done for C99+ using
      designated initializers, but can't be done that way for C++ because
      the designated initializer support in C++ as array designators are just
      an extension there and don't allow skipping anything nor going backwards.
      
      But, we can get the same effect using C++14 constexpr constructor.
      With the following patch we get rid of the runtime initialization
      and the array can be in .rodata.
      
      2024-10-07  Jakub Jelinek  <jakub@redhat.com>
      
      	* internal.h (_cpp_trigraph_map_s): New type for C++14 or later.
      	(_cpp_trigraph_map_d): New variable for C++14 or later.
      	(_cpp_trigraph_map): Define to _cpp_trigraph_map_d.map for C++14 or
      	later.
      	* init.cc (init_trigraph_map): Define to nothing for C++14 or later.
      	(TRIGRAPH_MAP, END, s): Define differently for C++14 or later.
      e4c0595e
  6. Oct 02, 2024
    • Jakub Jelinek's avatar
      libcpp: Implement clang -Wheader-guard warning [PR96842] · 5943a2fa
      Jakub Jelinek authored
      The following patch implements the clang -Wheader-guard warning, which warns
      if a valid multiple inclusion header guard's #ifndef/#if !defined directive
      is immediately (no other non-line directives nor other (non-comment)
      tokens in between) followed by #define directive for some different macro,
      which in get_suggestion rules is close enough to the actual header guard
      macro (i.e. likely misspelling), the #define is object-like with empty
      definition (I've followed what clang implements) and the macro isn't defined
      later on (at least not on the final #endif at the end of a header).
      
      In this case it emits a warning, so that
        #ifndef STDIO_H
        #define STDOI_H
        ...
        #endif
      or similar misspellings can be caught.
      
      clang enables this warning by default, but I've put it into -Wall instead
      as it still seems to be a style warning, nothing more severe; if a header
      doesn't survive multiple inclusion because of the misspelling, users will
      get different diagnostics.
      
      2024-10-02  Jakub Jelinek  <jakub@redhat.com>
      
      	PR preprocessor/96842
      libcpp/
      	* include/cpplib.h (struct cpp_options): Add warn_header_guard member.
      	(enum cpp_warning_reason): Add CPP_W_HEADER_GUARD enumerator.
      	* internal.h (struct cpp_reader): Add mi_def_cmacro, mi_loc and
      	mi_def_loc members.
      	(_cpp_defined_macro_p): Constify type pointed by argument type.
      	Formatting fix.
      	* init.cc (cpp_create_reader): Clear
      	CPP_OPTION (pfile, warn_header_guard).
      	* directives.cc (struct if_stack): Add def_loc and mi_def_cmacro
      	members.
      	(DIRECTIVE_TABLE): Add IF_COND flag to define.
      	(do_define): Set ifs->mi_def_cmacro on a define immediately following
      	#ifndef directive for the guard.  Clear pfile->mi_valid.  Formatting
      	fix.
      	(do_endif): Copy over pfile->mi_def_cmacro and pfile->mi_def_loc
      	if ifs->mi_def_cmacro is set and pfile->mi_cmacro isn't a defined
      	macro.
      	(push_conditional): Clear mi_def_cmacro and mi_def_loc members.
      	* files.cc (_cpp_pop_file_buffer): Emit -Wheader-guard diagnostics.
      gcc/
      	* doc/invoke.texi (Wheader-guard): Document.
      gcc/c-family/
      	* c.opt (Wheader-guard): New option.
      	* c.opt.urls: Regenerated.
      	* c-ppoutput.cc (init_pp_output): Initialize also cb->get_suggestion.
      gcc/testsuite/
      	* c-c++-common/cpp/Wheader-guard-1.c: New test.
      	* c-c++-common/cpp/Wheader-guard-1-1.h: New test.
      	* c-c++-common/cpp/Wheader-guard-1-2.h: New test.
      	* c-c++-common/cpp/Wheader-guard-1-3.h: New test.
      	* c-c++-common/cpp/Wheader-guard-1-4.h: New test.
      	* c-c++-common/cpp/Wheader-guard-1-5.h: New test.
      	* c-c++-common/cpp/Wheader-guard-1-6.h: New test.
      	* c-c++-common/cpp/Wheader-guard-1-7.h: New test.
      	* c-c++-common/cpp/Wheader-guard-1-8.h: New test.
      	* c-c++-common/cpp/Wheader-guard-1-9.h: New test.
      	* c-c++-common/cpp/Wheader-guard-1-10.h: New test.
      	* c-c++-common/cpp/Wheader-guard-1-11.h: New test.
      	* c-c++-common/cpp/Wheader-guard-1-12.h: New test.
      	* c-c++-common/cpp/Wheader-guard-2.c: New test.
      	* c-c++-common/cpp/Wheader-guard-2.h: New test.
      	* c-c++-common/cpp/Wheader-guard-3.c: New test.
      	* c-c++-common/cpp/Wheader-guard-3.h: New test.
      5943a2fa
  7. Sep 12, 2024
    • Jakub Jelinek's avatar
      libcpp, v2: Add support for gnu::base64 #embed parameter · ce0aecc7
      Jakub Jelinek authored
      This patch which adds another #embed extension, gnu::base64.
      
      As mentioned in the documentation, this extension is primarily
      intended for use by the preprocessor, so that for the larger (say 32+ or
      64+ bytes long embeds it doesn't have to emit tens of thousands or
      millions of comma separated string literals which would be very expensive
      to parse again, but can emit
       #embed "." __gnu__::__base64__( \
       "Tm9uIGVyYW0gbsOpc2NpdXMsIEJydXRlLCBjdW0sIHF1w6Ygc3VtbWlzIGluZ8OpbmlpcyBleHF1" \
       "aXNpdMOhcXVlIGRvY3Ryw61uYSBwaGlsw7Nzb3BoaSBHcsOmY28gc2VybcOzbmUgdHJhY3RhdsOt" \
       "c3NlbnQsIGVhIExhdMOtbmlzIGzDrXR0ZXJpcyBtYW5kYXLDqW11cywgZm9yZSB1dCBoaWMgbm9z" \
       "dGVyIGxhYm9yIGluIHbDoXJpYXMgcmVwcmVoZW5zacOzbmVzIGluY8O6cnJlcmV0LiBuYW0gcXVp" \
       "YsO6c2RhbSwgZXQgaWlzIHF1aWRlbSBub24gw6FkbW9kdW0gaW5kw7NjdGlzLCB0b3R1bSBob2Mg" \
       "ZMOtc3BsaWNldCBwaGlsb3NvcGjDoXJpLiBxdWlkYW0gYXV0ZW0gbm9uIHRhbSBpZCByZXByZWjD" \
       "qW5kdW50LCBzaSByZW3DrXNzaXVzIGFnw6F0dXIsIHNlZCB0YW50dW0gc3TDumRpdW0gdGFtcXVl" \
       "IG11bHRhbSDDs3BlcmFtIHBvbsOpbmRhbSBpbiBlbyBub24gYXJiaXRyw6FudHVyLiBlcnVudCDD" \
       "qXRpYW0sIGV0IGlpIHF1aWRlbSBlcnVkw610aSBHcsOmY2lzIGzDrXR0ZXJpcywgY29udGVtbsOp" \
       "bnRlcyBMYXTDrW5hcywgcXVpIHNlIGRpY2FudCBpbiBHcsOmY2lzIGxlZ8OpbmRpcyDDs3BlcmFt" \
       "IG1hbGxlIGNvbnPDum1lcmUuIHBvc3Ryw6ltbyDDoWxpcXVvcyBmdXTDunJvcyBzw7pzcGljb3Is" \
       "IHF1aSBtZSBhZCDDoWxpYXMgbMOtdHRlcmFzIHZvY2VudCwgZ2VudXMgaG9jIHNjcmliw6luZGks" \
       "IGV0c2kgc2l0IGVsw6lnYW5zLCBwZXJzw7Nuw6YgdGFtZW4gZXQgZGlnbml0w6F0aXMgZXNzZSBu" \
       "ZWdlbnQu")
      with the meaning don't actually load some file, instead base64 decode
      (RFC4648 with A-Za-z0-9+/ chars and = padding, no newlines in between)
      the string and use that as data.  This is chosen because it should be
      -pedantic-errors clean, fairly cheap to decode and then in optimizing
      compiler could be handled as similar binary blob to normal #embed,
      while the data isn't left somewhere on the disk, so distcc/ccache etc.
      can move the preprocessed source without issues.
      It makes no sense to support limit and gnu::offset parameters together
      with it IMHO, why would somebody waste providing full data and then
      threw some away?  prefix/suffix/if_empty are normally supported though,
      but not intended to be used by the preprocessor.
      
      This patch adds just the extension side, not the actual emitting of this
      during -E or -E -fdirectives-only for now, that will be included in the
      upcoming patch.
      
      Compared to the earlier posted version of this extension, this patch
      allows the string concatenation in the parameter argument (but still
      doesn't allow escapes in the string, why would anyone use them when
      only A-Za-z0-9+/= are valid).  The patch also adds support for parsing
      this even in -fpreprocessed compilation.
      
      2024-09-12  Jakub Jelinek  <jakub@redhat.com>
      
      libcpp/
      	* internal.h (struct cpp_embed_params): Add base64 member.
      	(_cpp_free_embed_params_tokens): Declare.
      	* directives.cc (DIRECTIVE_TABLE): Add IN_I flag to T_EMBED.
      	(save_token_for_embed, _cpp_free_embed_params_tokens): New functions.
      	(EMBED_PARAMS): Add gnu::base64 entry.
      	(_cpp_parse_embed_params): Parse gnu::base64 parameter.  If
      	-fpreprocessed without -fdirectives-only, require #embed to have
      	gnu::base64 parameter.  Diagnose conflict between gnu::base64 and
      	limit or gnu::offset parameters.
      	(do_embed): Use _cpp_free_embed_params_tokens.
      	* files.cc (finish_embed, base64_dec_fn): New functions.
      	(base64_dec): New array.
      	(B64D0, B64D1, B64D2, B64D3): Define.
      	(finish_base64_embed): New function.
      	(_cpp_stack_embed): Use finish_embed.  Handle params->base64
      	using finish_base64_embed.
      	* macro.cc (builtin_has_embed): Call _cpp_free_embed_params_tokens.
      gcc/
      	* doc/cpp.texi (Binary Resource Inclusion): Document gnu::base64
      	parameter.
      gcc/testsuite/
      	* c-c++-common/cpp/embed-17.c: New test.
      	* c-c++-common/cpp/embed-18.c: New test.
      	* c-c++-common/cpp/embed-19.c: New test.
      	* c-c++-common/cpp/embed-27.c: New test.
      	* gcc.dg/cpp/embed-6.c: New test.
      	* gcc.dg/cpp/embed-7.c: New test.
      ce0aecc7
    • Jakub Jelinek's avatar
      libcpp: Add support for gnu::offset #embed/__has_embed parameter · 44058b84
      Jakub Jelinek authored
      The following patch adds on top of the just posted #embed patch
      a first extension, gnu::offset which allows to seek in the data
      file (for seekable files, otherwise read and throw away).
      I think this is useful e.g. when some binary data start with
      some well known header which shouldn't be included in the data etc.
      
      2024-09-12  Jakub Jelinek  <jakub@redhat.com>
      
      libcpp/
      	* internal.h (struct cpp_embed_params): Add offset member.
      	* directives.cc (EMBED_PARAMS): Add gnu::offset entry.
      	(enum embed_param_kind): Add NUM_EMBED_STD_PARAMS.
      	(_cpp_parse_embed_params): Use NUM_EMBED_STD_PARAMS rather than
      	NUM_EMBED_PARAMS when parsing standard parameters.  Parse gnu::offset
      	parameter.
      	* files.cc (struct _cpp_file): Add offset member.
      	(_cpp_stack_embed): Handle params->offset.
      gcc/
      	* doc/cpp.texi (Binary Resource Inclusion): Document gnu::offset
      	#embed parameter.
      gcc/testsuite/
      	* c-c++-common/cpp/embed-15.c: New test.
      	* c-c++-common/cpp/embed-16.c: New test.
      	* gcc.dg/cpp/embed-5.c: New test.
      44058b84
    • Jakub Jelinek's avatar
      libcpp, c-family: Add (dumb) C23 N3017 #embed support [PR105863] · eba6d2aa
      Jakub Jelinek authored
      The following patch implements the C23 N3017 "#embed - a scannable,
      tooling-friendly binary resource inclusion mechanism" paper.
      
      The implementation is intentionally dumb, in that it doesn't significantly
      speed up compilation of larger initializers and doesn't make it possible
      to use huge #embeds (like several gigabytes large, that is compile time
      and memory still infeasible).
      There are 2 reasons for this.  One is that I think like it is implemented
      now in the patch is how we should use it for the smaller #embed sizes,
      dunno with which boundary, whether 32 bytes or 64 or something like that,
      certainly handling the single byte cases which is something that can appear
      anywhere in the source where constant integer literal can appear is
      desirable and I think for a few bytes it isn't worth it to come up with
      something smarter and users would like to e.g. see it in -E readably as
      well (perhaps the slow vs. fast boundary should be determined by command
      line option).  And the other one is to be able to more easily find
      regressions in behavior caused by the optimizations, so we have something
      to get back in git to compare against.
      I'm definitely willing to work on the optimizations (likely introduce a new
      CPP_* token type to refer to a range of libcpp owned memory (start + size)
      and similarly some tree which can do the same, and can be at any time e.g.
      split into 2 subparts + say INTEGER_CST in between if needed say for
      const unsigned char d[] = {
       #embed "2GB.dat" prefix (0, 0, ) suffix (, [0x40000000] = 42)
      }; still without having to copy around huge amounts of data; STRING_CST
      owns the memory it points to and can be only 2GB in size), but would
      like to do that incrementally.
      And would like to first include some extensions also not included in
      this patch, like gnu::offset (off) parameter to allow to skip certain
      constant amount of bytes at the start of the files, plus
      gnu::base64 ("base64_encoded_data") parameter to add something which can
      store more efficiently large amounts of the #embed data in preprocessed
      source.
      
      I've been cross-checking all the tests also against the LLVM implementation
      https://github.com/llvm/llvm-project/pull/68620
      which has been for a few hours even committed to LLVM trunk but reverted
      afterwards.  LLVM now has the support committed and I admit I haven't
      rechecked whether the behavior on the below mentioned spots have been fixed
      in it already or not yet.
      
      The patch uses --embed-dir= option that clang plans to add above and doesn't
      use other variants on the search directories yet, plus there are no
      default directories at least for the time being where to search for embed
      files.  So, #embed "..." works if it is found in the same directory (or
      relative to the current file's directory) and #embed "/..." or #embed </...>
      work always, but relative #embed <...> doesn't unless at least one
      --embed-dir= is specified.  There is no reason to differentiate between
      system and non-system directories, so we don't need -isystem like
      counterpart, perhaps -iquote like counterpart could be useful in the future,
      dunno what else.  It has --embed-directory=dir and --embed-directory dir
      as aliases.
      
      There are some differences beyond clang ICEs, so I'd like to point them out
      to make sure there is agreement on the choices in the patch.  They are also
      mentioned in the comments of the llvm pull request.
      
      The most important is that the GCC patch (as well as the original thephd.dev
      LLVM branch on godbolt) expands #embed (or acts as if it is expanded) into
      a mere sequence of numbers like 123,2,35,26 rather then what clang
      effectively treats as (unsigned char)123,(unsigned char)2,(unsigned
      char)35,(unsigned char)26 but only does that when using integrated
      preprocessor, not when using -save-temps where it acts as GCC.
      JeanHeyd as the original author agrees that is how it is currently worded in
      C23.
      
      Another difference (not tested in the testsuite, not sure how to check for
      effective target /dev/urandom nor am sure it is desirable to check that
      during testsuite) is how to treat character devices, named pipes etc.
      (block devices are errored on).  The original paper uses /dev/urandom
      in various examples and seems to assume that unlike regular files the
      devices aren't really cached, so
       #embed </dev/urandom> limit(1) prefix(int a = ) suffix(;)
       #embed </dev/urandom> limit(1) prefix(int b = ) suffix(;)
      usually results in a != b.  That is what the godbolt thephd.dev branch
      implements too and what this patch does as well, but clang actually seems
      to just go from st.st_size == 0, ergo it must be zero-sized resource and
      so just copies over if_empty if present.  It is really questionable
      what to do about the character devices/named pipes with __has_embed, for
      regular files the patch doesn't read anything from them, relies on
      st.st_size + limit for whether it is empty or non-empty.  But I don't know
      of a way to check if read on say a character device would read anything
      or not (the </dev/null> limit (1) vs. </dev/zero> limit (1) cases), and
      if we read something, that would be better cached for later because
       #embed later if it reads again could read no further data even when it
      first read something.  So, the patch currently for __has_embed just
      always returns 2 on the non-regular files, like the thephd.dev
      branch does as well and like the clang pull request as well.
      A question is also what to do for gnu::offset on the non-regular files
      even for #embed, those aren't seekable and do we want to just read and throw
      away the offset bytes each time we see it used?
      
      clang also chokes on the
       #if __has_embed (__FILE__ __limit__ (1) __prefix__ () suffix (1 / 0) \
       __if_empty__ ((({{[0[0{0{0(0(0)1)1}1}]]}})))) != __STDC_EMBED_FOUND__
       #error "__has_embed fail"
       #endif
      in embed-1.c, but thephd.dev branch accepts it and I don't see why
      it shouldn't, (({{[0[0{0{0(0(0)1)1}1}]]}}))) is a balanced token
      sequence and the file isn't empty, so it should just be parsed and
      discarded.
      
      clang also IMHO mishandles
       const unsigned char w[] = {
       #embed __FILE__ prefix([0] = 42, [15] =) limit(32)
       };
      but again only without -save-temps, seems like it
      treats it as
      [0] = 42, [15] = (99,111,110,115,116,32,117,110,115,105,103,110,101,100,
      32,99,104,97,114,32,119,91,93,32,61,32,123,10,35,101,109,98)
      rather than
      [0] = 42, [15] = 99,111,110,115,116,32,117,110,115,105,103,110,101,100,
      32,99,104,97,114,32,119,91,93,32,61,32,123,10,35,101,109,98
      and warns on it for -Wunused-value and just compiles it as
      [0] = 42, [15] = 98
      
      And also
       void foo (int, int, int, int);
       void bar (void) { foo (
       #embed __FILE__ limit (4) prefix (172 + ) suffix (+ 2)
       ); }
      is treated as
      172 + (118, 111, 105, 100) + 2
      rather than
      172 + 118, 111, 105, 100 + 2
      which clang -save-temps or GCC treats it like, so results
      in just one argument passed rather than 4.
      
      if (!strstr ((const char *) magna_carta, "imprisonétur")) abort ();
      in the testcase fails as well, but in that case calling it in gdb succeeds:
      p ((char *(*)(char *, char *))__strstr_sse2) (magna_carta, "imprisonétur")
      $2 = 0x555555558d3c <magna_carta+11564> "imprisonétur aut disseisiátur"...
      so I guess they are just trying to constant evaluate strstr and do it
      incorrectly.
      
      They started with making the optimizations together in the initial patch
      set, so they don't have the luxury to compare if it is just because of
      the optimization they are trying to do or because that is how the
      feature works for them.  At least unless they use -save-temps for now.
      
      There is also different behavior between clang and gcc on -M or other
      dependency generating options.  Seems clang includes the __has_embed
      searched files in dependencies, while my patch doesn't.  But so does
      clang for __has_include and GCC doesn't.  Emitting a hard dependency
      on some header just because there was __has_include/__has_embed for it
      seems wrong to me, because (at least when properly written) the source
      likely doesn't mind if the file is missing, it will do something else,
      so a hard error from make because of it doesn't seem right.  Does
      make have some weaker dependencies, such that if some file can be remade
      it is but if it doesn't exist, it isn't fatal?
      
      I wonder whether #embed <non-existent-file> really needs to be fatal
      or whether we could simply after diagnosing it pretend the file exists
      and is empty.  For #include I think fatal errors make tons of sense,
      but perhaps for #embed which is more localized we'd get better error
      reporting if we didn't bail out immediately.  Note, both GCC and clang
      currently treat those as fatal errors.
      
      clang also added -dE option which with -E instead of preprocessing
      the #embed directives keeps them as is, but the preprocessed source
      then isn't self-contained.  That option looks more harmful than useful to
      me.
      
      Also, it isn't clear to me from C23 whether it is possible to have
      __has_include/__has_c_attribute/__has_embed expressions inside of
      the limit #embed/__has_embed argument.
      6.10.3.2/2 says that defined should not appear there (and the patch
      diagnoses it and testsuite tests), but for __has_include/__has_embed
      etc. 6.10.1/11 says:
      "The identifiers __has_include, __has_embed, and __has_c_attribute
      shall not appear in any context not mentioned in this subclause."
      If that subclause in that case means 6.10.1, then it presumably shouldn't
      appear in #embed in 6.10.3, but __has_embed is in 6.10.1...
      But 6.10.3.2/3 says that it should be parsed according to the 6.10.1
      rules.  Haven't included tests like
       #if __has_embed (__FILE__ limit (__has_embed (__FILE__ limit (1))))
      or
       #embed __FILE__ limit (__has_include (__FILE__))
      into the testsuite because of the doubts but I think the patch should
      handle those right now.
      
      The reason I've used Magna Carta text in some of the testcases is that
      I hope it shouldn't be copyrighted after the centuries and I'd strongly
      prefer not to have binary blobs in git after the xz backdoor lesson
      and wanted something larger which doesn't change all the time.
      
      Oh, BTW, I see in C23 draft 6.10.3.2 in Example 4
      if (f_source == NULL);
        return 1;
      (note the spurious semicolon after closing paren), has that been fixed
      already?
      
      Like the thephd.dev and clang implementations, the patch always macro
      expands the whole #embed and __has_embed directives except for the
      embed keyword.  That is most likely not what C23 says, my limited
      understanding right now is that in #embed one needs to parse the whole
      directive line with macro expansion disabled and check if it satisfies the
      grammar, if not, the whole directive is macro expanded, if yes, only
      the limit parameter argument is macro expanded and the prefix/suffix/if_empty
      arguments are maybe macro expanded when actually used (and not at all if
      unused).  And I think __has_embed macro expansion has conflicting rules.
      
      2024-09-12  Jakub Jelinek  <jakub@redhat.com>
      
      	PR c/105863
      libcpp/
      	* include/cpplib.h: Implement C23 N3017 #embed - a scannable,
      	tooling-friendly binary resource inclusion mechanism paper.
      	(struct cpp_options): Add embed member.
      	(enum cpp_builtin_type): Add BT_HAS_EMBED.
      	(cpp_set_include_chains): Add another cpp_dir * argument to
      	the declaration.
      	* internal.h (enum include_type): Add IT_EMBED.
      	(struct cpp_reader): Add embed_include member.
      	(struct cpp_embed_params_tokens): New type.
      	(struct cpp_embed_params): New type.
      	(_cpp_get_token_no_padding): Declare.
      	(enum _cpp_find_file_kind): Add _cpp_FFK_EMBED and _cpp_FFK_HAS_EMBED.
      	(_cpp_stack_embed): Declare.
      	(_cpp_parse_expr): Change return type to cpp_num_part instead of
      	bool, change second argument from bool to const char * and add third
      	argument.
      	(_cpp_parse_embed_params): Declare.
      	* directives.cc (DIRECTIVE_TABLE): Add embed entry.
      	(end_directive): Don't call skip_rest_of_line for T_EMBED directive.
      	(_cpp_handle_directive): Return 2 rather than 1 for T_EMBED in
      	directives-only mode.
      	(parse_include): Don't Call check_eol for T_EMBED directive.
      	(skip_balanced_token_seq): New function.
      	(EMBED_PARAMS): Define.
      	(enum embed_param_kind): New type.
      	(embed_params): New variable.
      	(_cpp_parse_embed_params): New function.
      	(do_embed): New function.
      	(do_if): Adjust _cpp_parse_expr caller.
      	(do_elif): Likewise.
      	* expr.cc (parse_defined): Diagnose defined in #embed or __has_embed
      	parameters.
      	(_cpp_parse_expr): Change return type to cpp_num_part instead of
      	bool, change second argument from bool to const char * and add third
      	argument.  Adjust function comment.  For #embed/__has_embed parameters
      	add an artificial CPP_OPEN_PAREN.  Use the second argument DIR
      	directly instead of string literals conditional on IS_IF.
      	For #embed/__has_embed parameter, stop on reaching CPP_CLOSE_PAREN
      	matching the artificial one.  Diagnose negative or too large embed
      	parameter operands.
      	(num_binary_op): Use #embed instead of #if for diagnostics if inside
      	#embed/__has_embed parameter.
      	(num_div_op): Likewise.
      	* files.cc (struct _cpp_file): Add limit member and embed bitfield.
      	(search_cache): Add IS_EMBED argument, formatting fix.  Skip over
      	files with different file->embed from the argument.
      	(find_file_in_dir): Don't call pch_open_file if file->embed.
      	(_cpp_find_file): Handle _cpp_FFK_EMBED and _cpp_FFK_HAS_EMBED.
      	(read_file_guts): Formatting fix.
      	(has_unique_contents): Ignore file->embed files.
      	(search_path_head): Handle IT_EMBED type.
      	(_cpp_stack_embed): New function.
      	(_cpp_get_file_stat): Formatting fix.
      	(cpp_set_include_chains): Add embed argument, save it to
      	pfile->embed_include and compute lens for the chain.
      	* init.cc (struct lang_flags): Add embed member.
      	(lang_defaults): Add embed initializers.
      	(cpp_set_lang): Initialize CPP_OPTION (pfile, embed).
      	(builtin_array): Add __has_embed entry.
      	(cpp_init_builtins): Predefine __STDC_EMBED_NOT_FOUND__,
      	__STDC_EMBED_FOUND__ and __STDC_EMBED_EMPTY__.
      	* lex.cc (cpp_directive_only_process): Handle #embed.
      	* macro.cc (cpp_get_token_no_padding): Rename to ...
      	(_cpp_get_token_no_padding): ... this.  No longer static.
      	(builtin_has_include_1): New function.
      	(builtin_has_include): Use it.  Use _cpp_get_token_no_padding
      	instead of cpp_get_token_no_padding.
      	(builtin_has_embed): New function.
      	(_cpp_builtin_macro_text): Handle BT_HAS_EMBED.
      gcc/
      	* doc/cppdiropts.texi (--embed-dir=): Document.
      	* doc/cpp.texi (Binary Resource Inclusion): New chapter.
      	(__has_embed): Document.
      	* doc/invoke.texi (Directory Options): Mention --embed-dir=.
      	* gcc.cc (cpp_unique_options): Add %{-embed*}.
      	* genmatch.cc (main): Adjust cpp_set_include_chains caller.
      	* incpath.h (enum incpath_kind): Add INC_EMBED.
      	* incpath.cc (merge_include_chains): Handle INC_EMBED.
      	(register_include_chains): Adjust cpp_set_include_chains caller.
      gcc/c-family/
      	* c.opt (-embed-dir=): New option.
      	(-embed-directory): New alias.
      	(-embed-directory=): New alias.
      	* c-opts.cc (c_common_handle_option): Handle OPT__embed_dir_.
      gcc/testsuite/
      	* c-c++-common/cpp/embed-1.c: New test.
      	* c-c++-common/cpp/embed-2.c: New test.
      	* c-c++-common/cpp/embed-3.c: New test.
      	* c-c++-common/cpp/embed-4.c: New test.
      	* c-c++-common/cpp/embed-5.c: New test.
      	* c-c++-common/cpp/embed-6.c: New test.
      	* c-c++-common/cpp/embed-7.c: New test.
      	* c-c++-common/cpp/embed-8.c: New test.
      	* c-c++-common/cpp/embed-9.c: New test.
      	* c-c++-common/cpp/embed-10.c: New test.
      	* c-c++-common/cpp/embed-11.c: New test.
      	* c-c++-common/cpp/embed-12.c: New test.
      	* c-c++-common/cpp/embed-13.c: New test.
      	* c-c++-common/cpp/embed-14.c: New test.
      	* c-c++-common/cpp/embed-25.c: New test.
      	* c-c++-common/cpp/embed-26.c: New test.
      	* c-c++-common/cpp/embed-dir/embed-1.inc: New test.
      	* c-c++-common/cpp/embed-dir/embed-3.c: New test.
      	* c-c++-common/cpp/embed-dir/embed-4.c: New test.
      	* c-c++-common/cpp/embed-dir/magna-carta.txt: New test.
      	* gcc.dg/cpp/embed-1.c: New test.
      	* gcc.dg/cpp/embed-2.c: New test.
      	* gcc.dg/cpp/embed-3.c: New test.
      	* gcc.dg/cpp/embed-4.c: New test.
      	* g++.dg/cpp/embed-1.C: New test.
      	* g++.dg/cpp/embed-2.C: New test.
      	* g++.dg/cpp/embed-3.C: New test.
      eba6d2aa
  8. Aug 26, 2024
    • Alexander Monakov's avatar
      libcpp: deduplicate definition of padding size · a8260ebe
      Alexander Monakov authored
      Tie together the two functions that ensure tail padding with
      search_line_ssse3 via CPP_BUFFER_PADDING macro.
      
      libcpp/ChangeLog:
      
      	* internal.h (CPP_BUFFER_PADDING): New macro; use it ...
      	* charset.cc (_cpp_convert_input): ...here, and ...
      	* files.cc (read_file_guts): ...here, and ...
      	* lex.cc (search_line_ssse3): here.
      a8260ebe
  9. Jan 03, 2024
  10. Nov 19, 2023
    • David Malcolm's avatar
      libcpp: split decls out to rich-location.h · 78d132d7
      David Malcolm authored
      
      The various decls relating to rich_location are in
      libcpp/include/line-map.h, but they don't relate to line maps.
      
      Split them out to their own header: libcpp/include/rich-location.h
      
      No functional change intended.
      
      gcc/ChangeLog:
      	* Makefile.in (CPPLIB_H): Add libcpp/include/rich-location.h.
      	* coretypes.h (class rich_location): New forward decl.
      
      gcc/analyzer/ChangeLog:
      	* analyzer.h: Include "rich-location.h".
      
      gcc/c-family/ChangeLog:
      	* c-lex.cc: Include "rich-location.h".
      
      gcc/cp/ChangeLog:
      	* mapper-client.cc: Include "rich-location.h".
      
      gcc/ChangeLog:
      	* diagnostic.h: Include "rich-location.h".
      	* edit-context.h (class fixit_hint): New forward decl.
      	* gcc-rich-location.h: Include "rich-location.h".
      	* genmatch.cc: Likewise.
      	* pretty-print.h: Likewise.
      
      gcc/rust/ChangeLog:
      	* rust-location.h: Include "rich-location.h".
      
      libcpp/ChangeLog:
      	* Makefile.in (TAGS_SOURCES): Add "include/rich-location.h".
      	* include/cpplib.h (class rich_location): New forward decl.
      	* include/line-map.h (class range_label)
      	(enum range_display_kind, struct location_range)
      	(class semi_embedded_vec, class rich_location, class label_text)
      	(class range_label, class fixit_hint): Move to...
      	* include/rich-location.h: ...this new file.
      	* internal.h: Include "rich-location.h".
      
      Signed-off-by: default avatarDavid Malcolm <dmalcolm@redhat.com>
      78d132d7
  11. Oct 23, 2023
    • Lewis Hyatt's avatar
      libcpp: Improve the diagnostic for poisoned identifiers [PR36887] · cb05acdc
      Lewis Hyatt authored
      The PR requests an enhancement to the diagnostic issued for the use of a
      poisoned identifier. Currently, we show the location of the usage, but not
      the location which requested the poisoning, which would be helpful for the
      user if the decision to poison an identifier was made externally, such as
      in a library header.
      
      In order to output this information, we need to remember a location_t for
      each identifier that has been poisoned, and that data needs to be preserved
      as well in a PCH. One option would be to add a field to struct cpp_hashnode,
      but there is no convenient place to add it without increasing the size of
      the struct for all identifiers. Given this facility will be needed rarely,
      it seemed better to add a second hash map, which is handled PCH-wise the
      same as the current one in gcc/stringpool.cc. This hash map associates a new
      struct cpp_hashnode_extra with each identifier that needs one. Currently
      that struct only contains the new location_t, but it could be extended in
      the future if there is other ancillary data that may be convenient to put
      there for other purposes.
      
      libcpp/ChangeLog:
      
      	PR preprocessor/36887
      	* directives.cc (do_pragma_poison): Store in the extra hash map the
      	location from which an identifier has been poisoned.
      	* lex.cc (identifier_diagnostics_on_lex): When issuing a diagnostic
      	for the use of a poisoned identifier, also add a note indicating the
      	location from which it was poisoned.
      	* identifiers.cc (alloc_node): Convert to template function.
      	(_cpp_init_hashtable): Handle the new extra hash map.
      	(_cpp_destroy_hashtable): Likewise.
      	* include/cpplib.h (struct cpp_hashnode_extra): New struct.
      	(cpp_create_reader): Update prototype to...
      	* init.cc (cpp_create_reader): ...accept an argument for the extra
      	hash table and pass it to _cpp_init_hashtable.
      	* include/symtab.h (ht_lookup): New overload for convenience.
      	* internal.h (struct cpp_reader): Add EXTRA_HASH_TABLE member.
      	(_cpp_init_hashtable): Adjust prototype.
      
      gcc/c-family/ChangeLog:
      
      	PR preprocessor/36887
      	* c-opts.cc (c_common_init_options): Pass new extra hash map
      	argument to cpp_create_reader().
      
      gcc/ChangeLog:
      
      	PR preprocessor/36887
      	* toplev.h (ident_hash_extra): Declare...
      	* stringpool.cc (ident_hash_extra): ...this new global variable.
      	(init_stringpool): Handle ident_hash_extra as well as ident_hash.
      	(ggc_mark_stringpool): Likewise.
      	(ggc_purge_stringpool): Likewise.
      	(struct string_pool_data_extra): New struct.
      	(spd2): New GC root variable.
      	(gt_pch_save_stringpool): Use spd2 to handle ident_hash_extra,
      	analogous to how spd is used to handle ident_hash.
      	(gt_pch_restore_stringpool): Likewise.
      
      gcc/testsuite/ChangeLog:
      
      	PR preprocessor/36887
      	* c-c++-common/cpp/diagnostic-poison.c: New test.
      	* g++.dg/pch/pr36887.C: New test.
      	* g++.dg/pch/pr36887.Hs: New test.
      cb05acdc
  12. Oct 08, 2023
    • David Malcolm's avatar
      libcpp: "const" and other cleanups · 25af7c1a
      David Malcolm authored
      
      No functional change intended.
      
      gcc/ChangeLog:
      	* input.cc (make_location): Move implementation to
      	line_maps::make_location.
      
      libcpp/ChangeLog:
      	* include/line-map.h (line_maps::pure_location_p): New decl.
      	(line_maps::get_pure_location): New decl.
      	(line_maps::get_range_from_loc): New decl.
      	(line_maps::get_start): New.
      	(line_maps::get_finish): New.
      	(line_maps::make_location): New decl.
      	(get_range_from_loc): Make line_maps param const.
      	(get_discriminator_from_loc): Likewise.
      	(pure_location_p): Likewise.
      	(get_pure_location): Likewise.
      	(linemap_check_files_exited): Likewise.
      	(linemap_tracks_macro_expansion_locs_p): Likewise.
      	(linemap_location_in_system_header_p): Likewise.
      	(linemap_location_from_macro_definition_p): Likewise.
      	(linemap_macro_map_loc_unwind_toward_spelling): Likewise.
      	(linemap_included_from_linemap): Likewise.
      	(first_map_in_common): Likewise.
      	(linemap_compare_locations): Likewise.
      	(linemap_location_before_p): Likewise.
      	(linemap_resolve_location): Likewise.
      	(linemap_unwind_toward_expansion): Likewise.
      	(linemap_unwind_to_first_non_reserved_loc): Likewise.
      	(linemap_expand_location): Likewise.
      	(linemap_get_file_highest_location): Likewise.
      	(linemap_get_statistics): Likewise.
      	(linemap_dump_location): Likewise.
      	(linemap_dump): Likewise.
      	(line_table_dump): Likewise.
      	* internal.h (linemap_get_expansion_line): Likewise.
      	(linemap_get_expansion_filename): Likewise.
      	* line-map.cc (can_be_stored_compactly_p): Likewise.
      	(get_data_from_adhoc_loc): Drop redundant "class".
      	(get_discriminator_from_adhoc_loc): Likewise.
      	(get_location_from_adhoc_loc): Likewise.
      	(get_range_from_adhoc_loc): Likewise.
      	(get_range_from_loc): Make const and move implementation to...
      	(line_maps::get_range_from_loc): ...this new function.
      	(get_discriminator_from_loc): Make line_maps param const.
      	(pure_location_p): Make const and move implementation to...
      	(line_maps::pure_location_p): ...this new function.
      	(get_pure_location): Make const and move implementation to...
      	(line_maps::get_pure_location): ...this new function.
      	(linemap_included_from_linemap): Make line_maps param const.
      	(linemap_check_files_exited): Likewise.
      	(linemap_tracks_macro_expansion_locs_p): Likewise.
      	(linemap_macro_map_loc_unwind_toward_spelling): Likewise.
      	(linemap_get_expansion_line): Likewise.
      	(linemap_get_expansion_filename): Likewise.
      	(linemap_location_in_system_header_p): Likewise.
      	(first_map_in_common_1): Likewise.
      	(linemap_compare_locations): Likewise.
      	(linemap_macro_loc_to_spelling_point): Likewise.
      	(linemap_macro_loc_to_def_point): Likewise.
      	(linemap_macro_loc_to_exp_point): Likewise.
      	(linemap_resolve_location): Likewise.
      	(linemap_location_from_macro_definition_p): Likewise.
      	(linemap_unwind_toward_expansion): Likewise.
      	(linemap_unwind_to_first_non_reserved_loc): Likewise.
      	(linemap_expand_location): Likewise.
      	(linemap_dump): Likewise.
      	(linemap_dump_location): Likewise.
      	(linemap_get_file_highest_location): Likewise.
      	(linemap_get_statistics): Likewise.
      	(line_table_dump): Likewise.
      
      Signed-off-by: default avatarDavid Malcolm <dmalcolm@redhat.com>
      25af7c1a
  13. Jun 20, 2023
    • Lewis Hyatt's avatar
      libcpp: Improve location for macro names [PR66290] · 4f3be7cb
      Lewis Hyatt authored
      When libcpp reports diagnostics whose locus is a macro name (such as for
      -Wunused-macros), it uses the location in the cpp_macro object that was
      stored by _cpp_new_macro. This is currently set to pfile->directive_line,
      which contains the line number only and no column information. This patch
      changes the stored location to the src_loc for the token defining the macro
      name, which includes the location and range information.
      
      libcpp/ChangeLog:
      
      	PR c++/66290
      	* macro.cc (_cpp_create_definition): Add location argument.
      	* internal.h (_cpp_create_definition): Adjust prototype.
      	* directives.cc (do_define): Pass new location argument to
      	_cpp_create_definition.
      	(do_undef): Stop passing inferior location to cpp_warning_with_line;
      	the default from cpp_warning is better.
      	(cpp_pop_definition): Pass new location argument to
      	_cpp_create_definition.
      	* pch.cc (cpp_read_state): Likewise.
      
      gcc/testsuite/ChangeLog:
      
      	PR c++/66290
      	* c-c++-common/cpp/macro-ranges.c: New test.
      	* c-c++-common/cpp/line-2.c: Adapt to check for column information
      	on macro-related libcpp warnings.
      	* c-c++-common/cpp/line-3.c: Likewise.
      	* c-c++-common/cpp/macro-arg-count-1.c: Likewise.
      	* c-c++-common/cpp/pr58844-1.c: Likewise.
      	* c-c++-common/cpp/pr58844-2.c: Likewise.
      	* c-c++-common/cpp/warning-zero-location.c: Likewise.
      	* c-c++-common/pragma-diag-14.c: Likewise.
      	* c-c++-common/pragma-diag-15.c: Likewise.
      	* g++.dg/modules/macro-2_d.C: Likewise.
      	* g++.dg/modules/macro-4_d.C: Likewise.
      	* g++.dg/modules/macro-4_e.C: Likewise.
      	* g++.dg/spellcheck-macro-ordering.C: Likewise.
      	* gcc.dg/builtin-redefine.c: Likewise.
      	* gcc.dg/cpp/Wunused.c: Likewise.
      	* gcc.dg/cpp/redef2.c: Likewise.
      	* gcc.dg/cpp/redef3.c: Likewise.
      	* gcc.dg/cpp/redef4.c: Likewise.
      	* gcc.dg/cpp/ucnid-11-utf8.c: Likewise.
      	* gcc.dg/cpp/ucnid-11.c: Likewise.
      	* gcc.dg/cpp/undef2.c: Likewise.
      	* gcc.dg/cpp/warn-redefined-2.c: Likewise.
      	* gcc.dg/cpp/warn-redefined.c: Likewise.
      	* gcc.dg/cpp/warn-unused-macros-2.c: Likewise.
      	* gcc.dg/cpp/warn-unused-macros.c: Likewise.
      4f3be7cb
  14. Jan 16, 2023
  15. Jan 24, 2022
    • Marek Polacek's avatar
      preprocessor: -Wbidi-chars and UCNs [PR104030] · ae36f839
      Marek Polacek authored
      Stephan Bergmann reported that our -Wbidi-chars breaks the build
      of LibreOffice because we warn about UCNs even when their usage
      is correct: LibreOffice constructs strings piecewise, as in:
      
        aText = u"\u202D" + aText;
      
      and warning about that is overzealous.  Since no editor (AFAIK)
      interprets UCNs to show them as Unicode characters, there's less
      risk in misinterpreting them, and so perhaps we shouldn't warn
      about them by default.  However, identifiers containing UCNs or
      programs generating other programs could still cause confusion,
      so I'm keeping the UCN checking.  To turn it on, you just need
      to use -Wbidi-chars=unpaired,ucn or -Wbidi-chars=any,ucn.
      
      The implementation is done by using the new EnumSet feature.
      
      	PR preprocessor/104030
      
      gcc/c-family/ChangeLog:
      
      	* c.opt (Wbidi-chars): Mark as EnumSet.  Also accept =ucn.
      
      gcc/ChangeLog:
      
      	* doc/invoke.texi: Update documentation for -Wbidi-chars.
      
      libcpp/ChangeLog:
      
      	* include/cpplib.h (enum cpp_bidirectional_level): Add
      	bidirectional_ucn.  Set values explicitly.
      	* internal.h (cpp_reader): Adjust warn_bidi_p.
      	* lex.cc (maybe_warn_bidi_on_close): Don't warn about UCNs
      	unless UCN checking is on.
      	(maybe_warn_bidi_on_char): Likewise.
      
      gcc/testsuite/ChangeLog:
      
      	* c-c++-common/Wbidi-chars-10.c: Turn on UCN checking.
      	* c-c++-common/Wbidi-chars-11.c: Likewise.
      	* c-c++-common/Wbidi-chars-14.c: Likewise.
      	* c-c++-common/Wbidi-chars-16.c: Likewise.
      	* c-c++-common/Wbidi-chars-17.c: Likewise.
      	* c-c++-common/Wbidi-chars-4.c: Likewise.
      	* c-c++-common/Wbidi-chars-5.c: Likewise.
      	* c-c++-common/Wbidi-chars-6.c: Likewise.
      	* c-c++-common/Wbidi-chars-7.c: Likewise.
      	* c-c++-common/Wbidi-chars-8.c: Likewise.
      	* c-c++-common/Wbidi-chars-9.c: Likewise.
      	* c-c++-common/Wbidi-chars-ranges.c: Likewise.
      	* c-c++-common/Wbidi-chars-18.c: New test.
      	* c-c++-common/Wbidi-chars-19.c: New test.
      	* c-c++-common/Wbidi-chars-20.c: New test.
      	* c-c++-common/Wbidi-chars-21.c: New test.
      	* c-c++-common/Wbidi-chars-22.c: New test.
      	* c-c++-common/Wbidi-chars-23.c: New test.
      ae36f839
  16. Jan 17, 2022
    • Martin Liska's avatar
      Change references of .c files to .cc files · e53b6e56
      Martin Liska authored
      ChangeLog:
      
      	* MAINTAINERS: Rename .c names to .cc.
      
      contrib/ChangeLog:
      
      	* filter-clang-warnings.py: Rename .c names to .cc.
      	* gcc_update: Likewise.
      	* paranoia.cc: Likewise.
      
      contrib/header-tools/ChangeLog:
      
      	* README: Rename .c names to .cc.
      
      gcc/ChangeLog:
      
      	* Makefile.in: Rename .c names to .cc.
      	* alias.h: Likewise.
      	* asan.cc: Likewise.
      	* auto-profile.h: Likewise.
      	* basic-block.h (struct basic_block_d): Likewise.
      	* btfout.cc: Likewise.
      	* builtins.cc (expand_builtin_longjmp): Likewise.
      	(validate_arg): Likewise.
      	(access_ref::offset_bounded): Likewise.
      	* caller-save.cc (reg_restore_code): Likewise.
      	(setup_save_areas): Likewise.
      	* calls.cc (initialize_argument_information): Likewise.
      	(expand_call): Likewise.
      	(emit_library_call_value_1): Likewise.
      	* cfg-flags.def (RTL): Likewise.
      	(SIBCALL): Likewise.
      	(CAN_FALLTHRU): Likewise.
      	* cfganal.cc (post_order_compute): Likewise.
      	* cfgcleanup.cc (try_simplify_condjump): Likewise.
      	(merge_blocks_move_predecessor_nojumps): Likewise.
      	(merge_blocks_move_successor_nojumps): Likewise.
      	(merge_blocks_move): Likewise.
      	(old_insns_match_p): Likewise.
      	(try_crossjump_bb): Likewise.
      	* cfgexpand.cc (expand_gimple_stmt): Likewise.
      	* cfghooks.cc (split_block_before_cond_jump): Likewise.
      	(profile_record_check_consistency): Likewise.
      	* cfghooks.h: Likewise.
      	* cfgrtl.cc (pass_free_cfg::execute): Likewise.
      	(rtl_can_merge_blocks): Likewise.
      	(try_redirect_by_replacing_jump): Likewise.
      	(make_pass_outof_cfg_layout_mode): Likewise.
      	(cfg_layout_can_merge_blocks_p): Likewise.
      	* cgraph.cc (release_function_body): Likewise.
      	(cgraph_node::get_fun): Likewise.
      	* cgraph.h (struct cgraph_node): Likewise.
      	(asmname_hasher::equal): Likewise.
      	(cgraph_inline_failed_type): Likewise.
      	(thunk_adjust): Likewise.
      	(dump_callgraph_transformation): Likewise.
      	(record_references_in_initializer): Likewise.
      	(ipa_discover_variable_flags): Likewise.
      	* cgraphclones.cc (GTY): Likewise.
      	* cgraphunit.cc (symbol_table::finalize_compilation_unit): Likewise.
      	* collect-utils.h (GCC_COLLECT_UTILS_H): Likewise.
      	* collect2-aix.h (GCC_COLLECT2_AIX_H): Likewise.
      	* collect2.cc (maybe_run_lto_and_relink): Likewise.
      	* combine-stack-adj.cc: Likewise.
      	* combine.cc (setup_incoming_promotions): Likewise.
      	(combine_simplify_rtx): Likewise.
      	(count_rtxs): Likewise.
      	* common.opt: Likewise.
      	* common/config/aarch64/aarch64-common.cc: Likewise.
      	* common/config/arm/arm-common.cc (arm_asm_auto_mfpu): Likewise.
      	* common/config/avr/avr-common.cc: Likewise.
      	* common/config/i386/i386-isas.h (struct _isa_names_table): Likewise.
      	* conditions.h: Likewise.
      	* config.gcc: Likewise.
      	* config/aarch64/aarch64-builtins.cc (aarch64_resolve_overloaded_memtag): Likewise.
      	* config/aarch64/aarch64-protos.h (aarch64_classify_address): Likewise.
      	(aarch64_get_extension_string_for_isa_flags): Likewise.
      	* config/aarch64/aarch64-sve-builtins.cc (function_builder::add_function): Likewise.
      	* config/aarch64/aarch64.cc (aarch64_regmode_natural_size): Likewise.
      	(aarch64_sched_first_cycle_multipass_dfa_lookahead): Likewise.
      	(aarch64_option_valid_attribute_p): Likewise.
      	(aarch64_short_vector_p): Likewise.
      	(aarch64_float_const_representable_p): Likewise.
      	* config/aarch64/aarch64.h (DBX_REGISTER_NUMBER): Likewise.
      	(ASM_OUTPUT_POOL_EPILOGUE): Likewise.
      	(GTY): Likewise.
      	* config/aarch64/cortex-a57-fma-steering.cc: Likewise.
      	* config/aarch64/driver-aarch64.cc (contains_core_p): Likewise.
      	* config/aarch64/t-aarch64: Likewise.
      	* config/aarch64/x-aarch64: Likewise.
      	* config/aarch64/x-darwin: Likewise.
      	* config/alpha/alpha-protos.h: Likewise.
      	* config/alpha/alpha.cc (alpha_scalar_mode_supported_p): Likewise.
      	* config/alpha/alpha.h (LONG_DOUBLE_TYPE_SIZE): Likewise.
      	(enum reg_class): Likewise.
      	* config/alpha/alpha.md: Likewise.
      	* config/alpha/driver-alpha.cc (AMASK_LOCKPFTCHOK): Likewise.
      	* config/alpha/x-alpha: Likewise.
      	* config/arc/arc-protos.h (arc_eh_uses): Likewise.
      	* config/arc/arc.cc (ARC_OPT): Likewise.
      	(arc_ccfsm_advance): Likewise.
      	(arc_arg_partial_bytes): Likewise.
      	(conditionalize_nonjump): Likewise.
      	* config/arc/arc.md: Likewise.
      	* config/arc/builtins.def: Likewise.
      	* config/arc/t-arc: Likewise.
      	* config/arm/arm-c.cc (arm_resolve_overloaded_builtin): Likewise.
      	(arm_pragma_target_parse): Likewise.
      	* config/arm/arm-protos.h (save_restore_target_globals): Likewise.
      	(arm_cpu_cpp_builtins): Likewise.
      	* config/arm/arm.cc (vfp3_const_double_index): Likewise.
      	(shift_op): Likewise.
      	(thumb2_final_prescan_insn): Likewise.
      	(arm_final_prescan_insn): Likewise.
      	(arm_asm_output_labelref): Likewise.
      	(arm_small_register_classes_for_mode_p): Likewise.
      	* config/arm/arm.h: Likewise.
      	* config/arm/arm.md: Likewise.
      	* config/arm/driver-arm.cc: Likewise.
      	* config/arm/symbian.h: Likewise.
      	* config/arm/t-arm: Likewise.
      	* config/arm/thumb1.md: Likewise.
      	* config/arm/x-arm: Likewise.
      	* config/avr/avr-c.cc (avr_register_target_pragmas): Likewise.
      	* config/avr/avr-fixed.md: Likewise.
      	* config/avr/avr-log.cc (avr_log_vadump): Likewise.
      	* config/avr/avr-mcus.def: Likewise.
      	* config/avr/avr-modes.def (FRACTIONAL_INT_MODE): Likewise.
      	* config/avr/avr-passes.def (INSERT_PASS_BEFORE): Likewise.
      	* config/avr/avr-protos.h (make_avr_pass_casesi): Likewise.
      	* config/avr/avr.cc (avr_option_override): Likewise.
      	(avr_build_builtin_va_list): Likewise.
      	(avr_mode_dependent_address_p): Likewise.
      	(avr_function_arg_advance): Likewise.
      	(avr_asm_output_aligned_decl_common): Likewise.
      	* config/avr/avr.h (RETURN_ADDR_RTX): Likewise.
      	(SUPPORTS_INIT_PRIORITY): Likewise.
      	* config/avr/avr.md: Likewise.
      	* config/avr/builtins.def: Likewise.
      	* config/avr/gen-avr-mmcu-specs.cc (IN_GEN_AVR_MMCU_TEXI): Likewise.
      	* config/avr/gen-avr-mmcu-texi.cc (IN_GEN_AVR_MMCU_TEXI): Likewise.
      	(main): Likewise.
      	* config/avr/t-avr: Likewise.
      	* config/bfin/bfin.cc (frame_related_constant_load): Likewise.
      	* config/bpf/bpf-protos.h (GCC_BPF_PROTOS_H): Likewise.
      	* config/bpf/bpf.h (enum reg_class): Likewise.
      	* config/bpf/t-bpf: Likewise.
      	* config/c6x/c6x-protos.h (GCC_C6X_PROTOS_H): Likewise.
      	* config/cr16/cr16-protos.h: Likewise.
      	* config/cris/cris.cc (cris_address_cost): Likewise.
      	(cris_side_effect_mode_ok): Likewise.
      	(cris_init_machine_status): Likewise.
      	(cris_emit_movem_store): Likewise.
      	* config/cris/cris.h (INDEX_REG_CLASS): Likewise.
      	(enum reg_class): Likewise.
      	(struct cum_args): Likewise.
      	* config/cris/cris.opt: Likewise.
      	* config/cris/sync.md: Likewise.
      	* config/csky/csky.cc (csky_expand_prologue): Likewise.
      	* config/darwin-c.cc: Likewise.
      	* config/darwin-f.cc: Likewise.
      	* config/darwin-sections.def (zobj_const_section): Likewise.
      	* config/darwin.cc (output_objc_section_asm_op): Likewise.
      	(fprintf): Likewise.
      	* config/darwin.h (GTY): Likewise.
      	* config/elfos.h: Likewise.
      	* config/epiphany/epiphany-sched.md: Likewise.
      	* config/epiphany/epiphany.cc (epiphany_function_value): Likewise.
      	* config/epiphany/epiphany.h (GTY): Likewise.
      	(NO_FUNCTION_CSE): Likewise.
      	* config/epiphany/mode-switch-use.cc: Likewise.
      	* config/epiphany/predicates.md: Likewise.
      	* config/epiphany/t-epiphany: Likewise.
      	* config/fr30/fr30-protos.h: Likewise.
      	* config/frv/frv-protos.h: Likewise.
      	* config/frv/frv.cc (TLS_BIAS): Likewise.
      	* config/frv/frv.h (ASM_OUTPUT_ALIGNED_LOCAL): Likewise.
      	* config/ft32/ft32-protos.h: Likewise.
      	* config/gcn/gcn-hsa.h (ASM_APP_OFF): Likewise.
      	* config/gcn/gcn.cc (gcn_init_libfuncs): Likewise.
      	* config/gcn/mkoffload.cc (copy_early_debug_info): Likewise.
      	* config/gcn/t-gcn-hsa: Likewise.
      	* config/gcn/t-omp-device: Likewise.
      	* config/h8300/h8300-protos.h (GCC_H8300_PROTOS_H): Likewise.
      	(same_cmp_following_p): Likewise.
      	* config/h8300/h8300.cc (F): Likewise.
      	* config/h8300/h8300.h (struct cum_arg): Likewise.
      	(BRANCH_COST): Likewise.
      	* config/i386/cygming.h (DEFAULT_PCC_STRUCT_RETURN): Likewise.
      	* config/i386/djgpp.h (TARGET_ASM_LTO_END): Likewise.
      	* config/i386/dragonfly.h (NO_PROFILE_COUNTERS): Likewise.
      	* config/i386/driver-i386.cc (detect_caches_intel): Likewise.
      	* config/i386/freebsd.h (NO_PROFILE_COUNTERS): Likewise.
      	* config/i386/i386-c.cc (ix86_target_macros): Likewise.
      	* config/i386/i386-expand.cc (get_mode_wider_vector): Likewise.
      	* config/i386/i386-options.cc (ix86_set_func_type): Likewise.
      	* config/i386/i386-protos.h (ix86_extract_perm_from_pool_constant): Likewise.
      	(ix86_register_pragmas): Likewise.
      	(ix86_d_has_stdcall_convention): Likewise.
      	(i386_pe_seh_init_sections): Likewise.
      	* config/i386/i386.cc (ix86_function_arg_regno_p): Likewise.
      	(ix86_function_value_regno_p): Likewise.
      	(ix86_compute_frame_layout): Likewise.
      	(legitimize_pe_coff_symbol): Likewise.
      	(output_pic_addr_const): Likewise.
      	* config/i386/i386.h (defined): Likewise.
      	(host_detect_local_cpu): Likewise.
      	(CONSTANT_ADDRESS_P): Likewise.
      	(DEFAULT_LARGE_SECTION_THRESHOLD): Likewise.
      	(struct machine_frame_state): Likewise.
      	* config/i386/i386.md: Likewise.
      	* config/i386/lynx.h (ASM_OUTPUT_ALIGN): Likewise.
      	* config/i386/mmx.md: Likewise.
      	* config/i386/sse.md: Likewise.
      	* config/i386/t-cygming: Likewise.
      	* config/i386/t-djgpp: Likewise.
      	* config/i386/t-gnu-property: Likewise.
      	* config/i386/t-i386: Likewise.
      	* config/i386/t-intelmic: Likewise.
      	* config/i386/t-omp-device: Likewise.
      	* config/i386/winnt-cxx.cc (i386_pe_type_dllimport_p): Likewise.
      	(i386_pe_adjust_class_at_definition): Likewise.
      	* config/i386/winnt.cc (gen_stdcall_or_fastcall_suffix): Likewise.
      	(i386_pe_mangle_decl_assembler_name): Likewise.
      	(i386_pe_encode_section_info): Likewise.
      	* config/i386/x-cygwin: Likewise.
      	* config/i386/x-darwin: Likewise.
      	* config/i386/x-i386: Likewise.
      	* config/i386/x-mingw32: Likewise.
      	* config/i386/x86-tune-sched-core.cc: Likewise.
      	* config/i386/x86-tune.def: Likewise.
      	* config/i386/xm-djgpp.h (STANDARD_STARTFILE_PREFIX_1): Likewise.
      	* config/ia64/freebsd.h: Likewise.
      	* config/ia64/hpux.h (REGISTER_TARGET_PRAGMAS): Likewise.
      	* config/ia64/ia64-protos.h (ia64_except_unwind_info): Likewise.
      	* config/ia64/ia64.cc (ia64_function_value_regno_p): Likewise.
      	(ia64_secondary_reload_class): Likewise.
      	(bundling): Likewise.
      	* config/ia64/ia64.h: Likewise.
      	* config/ia64/ia64.md: Likewise.
      	* config/ia64/predicates.md: Likewise.
      	* config/ia64/sysv4.h: Likewise.
      	* config/ia64/t-ia64: Likewise.
      	* config/iq2000/iq2000.h (FUNCTION_MODE): Likewise.
      	* config/iq2000/iq2000.md: Likewise.
      	* config/linux.h (TARGET_HAS_BIONIC): Likewise.
      	(if): Likewise.
      	* config/m32c/m32c.cc (m32c_function_needs_enter): Likewise.
      	* config/m32c/m32c.h (MAX_REGS_PER_ADDRESS): Likewise.
      	* config/m32c/t-m32c: Likewise.
      	* config/m32r/m32r-protos.h: Likewise.
      	* config/m32r/m32r.cc (m32r_print_operand): Likewise.
      	* config/m32r/m32r.h: Likewise.
      	* config/m32r/m32r.md: Likewise.
      	* config/m68k/m68k-isas.def: Likewise.
      	* config/m68k/m68k-microarchs.def: Likewise.
      	* config/m68k/m68k-protos.h (strict_low_part_peephole_ok): Likewise.
      	(m68k_epilogue_uses): Likewise.
      	* config/m68k/m68k.cc (m68k_call_tls_get_addr): Likewise.
      	(m68k_sched_adjust_cost): Likewise.
      	(m68k_sched_md_init): Likewise.
      	* config/m68k/m68k.h (__transfer_from_trampoline): Likewise.
      	(enum m68k_function_kind): Likewise.
      	* config/m68k/m68k.md: Likewise.
      	* config/m68k/m68kemb.h: Likewise.
      	* config/m68k/uclinux.h (ENDFILE_SPEC): Likewise.
      	* config/mcore/mcore-protos.h: Likewise.
      	* config/mcore/mcore.cc (mcore_expand_insv): Likewise.
      	(mcore_expand_prolog): Likewise.
      	* config/mcore/mcore.h (TARGET_MCORE): Likewise.
      	* config/mcore/mcore.md: Likewise.
      	* config/microblaze/microblaze-protos.h: Likewise.
      	* config/microblaze/microblaze.cc (microblaze_legitimate_pic_operand): Likewise.
      	(microblaze_function_prologue): Likewise.
      	(microblaze_function_epilogue): Likewise.
      	(microblaze_select_section): Likewise.
      	(microblaze_asm_output_mi_thunk): Likewise.
      	(microblaze_eh_return): Likewise.
      	* config/microblaze/microblaze.h: Likewise.
      	* config/microblaze/microblaze.md: Likewise.
      	* config/microblaze/t-microblaze: Likewise.
      	* config/mips/driver-native.cc: Likewise.
      	* config/mips/loongson2ef.md: Likewise.
      	* config/mips/mips-protos.h (mips_expand_vec_cmp_expr): Likewise.
      	* config/mips/mips.cc (mips_rtx_costs): Likewise.
      	(mips_output_filename): Likewise.
      	(mips_output_function_prologue): Likewise.
      	(mips_output_function_epilogue): Likewise.
      	(mips_output_mi_thunk): Likewise.
      	* config/mips/mips.h: Likewise.
      	* config/mips/mips.md: Likewise.
      	* config/mips/t-mips: Likewise.
      	* config/mips/x-native: Likewise.
      	* config/mmix/mmix-protos.h: Likewise.
      	* config/mmix/mmix.cc (mmix_option_override): Likewise.
      	(mmix_dbx_register_number): Likewise.
      	(mmix_expand_prologue): Likewise.
      	* config/mmix/mmix.h: Likewise.
      	* config/mmix/mmix.md: Likewise.
      	* config/mmix/predicates.md: Likewise.
      	* config/mn10300/mn10300.cc (mn10300_symbolic_operand): Likewise.
      	(mn10300_legitimate_pic_operand_p): Likewise.
      	* config/mn10300/mn10300.h (enum reg_class): Likewise.
      	(NO_FUNCTION_CSE): Likewise.
      	* config/moxie/moxie-protos.h: Likewise.
      	* config/moxie/uclinux.h (TARGET_LIBC_HAS_FUNCTION): Likewise.
      	* config/msp430/msp430-devices.cc (extract_devices_dir_from_exec_prefix): Likewise.
      	* config/msp430/msp430.cc (msp430_gimplify_va_arg_expr): Likewise.
      	(msp430_incoming_return_addr_rtx): Likewise.
      	* config/msp430/msp430.h (msp430_get_linker_devices_include_path): Likewise.
      	* config/msp430/t-msp430: Likewise.
      	* config/nds32/nds32-cost.cc (nds32_rtx_costs_speed_prefer): Likewise.
      	(nds32_rtx_costs_size_prefer): Likewise.
      	(nds32_init_rtx_costs): Likewise.
      	* config/nds32/nds32-doubleword.md: Likewise.
      	* config/nds32/nds32.cc (nds32_memory_move_cost): Likewise.
      	(nds32_builtin_decl): Likewise.
      	* config/nds32/nds32.h (enum nds32_16bit_address_type): Likewise.
      	(enum nds32_isr_nested_type): Likewise.
      	(enum reg_class): Likewise.
      	* config/nds32/predicates.md: Likewise.
      	* config/nds32/t-nds32: Likewise.
      	* config/nios2/nios2.cc (nios2_pragma_target_parse): Likewise.
      	* config/nvptx/nvptx-protos.h: Likewise.
      	* config/nvptx/nvptx.cc (nvptx_goacc_expand_var_decl): Likewise.
      	* config/nvptx/nvptx.h (TARGET_CPU_CPP_BUILTINS): Likewise.
      	* config/nvptx/t-nvptx: Likewise.
      	* config/nvptx/t-omp-device: Likewise.
      	* config/pa/elf.h: Likewise.
      	* config/pa/pa-linux.h (GLOBAL_ASM_OP): Likewise.
      	* config/pa/pa-netbsd.h (GLOBAL_ASM_OP): Likewise.
      	* config/pa/pa-openbsd.h (TARGET_ASM_GLOBALIZE_LABEL): Likewise.
      	* config/pa/pa-protos.h (pa_eh_return_handler_rtx): Likewise.
      	(pa_legitimize_reload_address): Likewise.
      	(pa_can_use_return_insn): Likewise.
      	* config/pa/pa.cc (mem_shadd_or_shadd_rtx_p): Likewise.
      	(som_output_text_section_asm_op): Likewise.
      	* config/pa/pa.h (PROFILE_BEFORE_PROLOGUE): Likewise.
      	* config/pa/pa.md: Likewise.
      	* config/pa/som.h: Likewise.
      	* config/pa/t-pa: Likewise.
      	* config/pdp11/pdp11.cc (decode_pdp11_d): Likewise.
      	* config/pdp11/pdp11.h: Likewise.
      	* config/pdp11/pdp11.md: Likewise.
      	* config/pdp11/t-pdp11: Likewise.
      	* config/pru/pru.md: Likewise.
      	* config/pru/t-pru: Likewise.
      	* config/riscv/riscv-protos.h (NUM_SYMBOL_TYPES): Likewise.
      	(riscv_gpr_save_operation_p): Likewise.
      	(riscv_d_register_target_info): Likewise.
      	(riscv_init_builtins): Likewise.
      	* config/riscv/riscv.cc (riscv_output_mi_thunk): Likewise.
      	* config/riscv/riscv.h (CSW_MAX_OFFSET): Likewise.
      	* config/riscv/t-riscv: Likewise.
      	* config/rl78/rl78.cc (rl78_asm_ctor_dtor): Likewise.
      	* config/rl78/t-rl78: Likewise.
      	* config/rs6000/aix.h: Likewise.
      	* config/rs6000/aix71.h (ASM_SPEC_COMMON): Likewise.
      	* config/rs6000/aix72.h (ASM_SPEC_COMMON): Likewise.
      	* config/rs6000/aix73.h (ASM_SPEC_COMMON): Likewise.
      	* config/rs6000/darwin.h (TARGET_ASM_GLOBALIZE_LABEL): Likewise.
      	* config/rs6000/driver-rs6000.cc: Likewise.
      	* config/rs6000/freebsd.h: Likewise.
      	* config/rs6000/freebsd64.h: Likewise.
      	* config/rs6000/lynx.h (ASM_OUTPUT_ALIGN): Likewise.
      	* config/rs6000/rbtree.cc: Likewise.
      	* config/rs6000/rbtree.h: Likewise.
      	* config/rs6000/rs6000-c.cc (rs6000_target_modify_macros): Likewise.
      	* config/rs6000/rs6000-call.cc (rs6000_invalid_builtin): Likewise.
      	(rs6000_expand_builtin): Likewise.
      	(rs6000_init_builtins): Likewise.
      	* config/rs6000/rs6000-cpus.def: Likewise.
      	* config/rs6000/rs6000-gen-builtins.cc (write_init_ovld_table): Likewise.
      	* config/rs6000/rs6000-internal.h (ALTIVEC_REG_BIT): Likewise.
      	(quad_address_offset_p): Likewise.
      	* config/rs6000/rs6000-logue.cc (interesting_frame_related_regno): Likewise.
      	(rs6000_emit_epilogue): Likewise.
      	* config/rs6000/rs6000-overload.def: Likewise.
      	* config/rs6000/rs6000-p8swap.cc: Likewise.
      	* config/rs6000/rs6000-protos.h (GCC_RS6000_PROTOS_H): Likewise.
      	(rs6000_const_f32_to_i32): Likewise.
      	* config/rs6000/rs6000.cc (legitimate_lo_sum_address_p): Likewise.
      	(rs6000_debug_legitimize_address): Likewise.
      	(rs6000_mode_dependent_address): Likewise.
      	(rs6000_adjust_priority): Likewise.
      	(rs6000_c_mode_for_suffix): Likewise.
      	* config/rs6000/rs6000.h (defined): Likewise.
      	(LONG_DOUBLE_TYPE_SIZE): Likewise.
      	* config/rs6000/rs6000.md: Likewise.
      	* config/rs6000/sysv4.h: Likewise.
      	* config/rs6000/t-linux: Likewise.
      	* config/rs6000/t-linux64: Likewise.
      	* config/rs6000/t-rs6000: Likewise.
      	* config/rs6000/x-darwin: Likewise.
      	* config/rs6000/x-darwin64: Likewise.
      	* config/rs6000/x-rs6000: Likewise.
      	* config/rs6000/xcoff.h (ASM_OUTPUT_LABELREF): Likewise.
      	* config/rx/rx.cc (rx_expand_builtin): Likewise.
      	* config/s390/constraints.md: Likewise.
      	* config/s390/driver-native.cc: Likewise.
      	* config/s390/htmxlintrin.h: Likewise.
      	* config/s390/s390-builtins.def (B_DEF): Likewise.
      	(OB_DEF_VAR): Likewise.
      	* config/s390/s390-builtins.h: Likewise.
      	* config/s390/s390-c.cc: Likewise.
      	* config/s390/s390-opts.h: Likewise.
      	* config/s390/s390-protos.h (s390_check_symref_alignment): Likewise.
      	(s390_register_target_pragmas): Likewise.
      	* config/s390/s390.cc (s390_init_builtins): Likewise.
      	(s390_expand_plus_operand): Likewise.
      	(s390_expand_atomic): Likewise.
      	(s390_valid_target_attribute_inner_p): Likewise.
      	* config/s390/s390.h (LONG_DOUBLE_TYPE_SIZE): Likewise.
      	* config/s390/s390.md: Likewise.
      	* config/s390/t-s390: Likewise.
      	* config/s390/vx-builtins.md: Likewise.
      	* config/s390/x-native: Likewise.
      	* config/sh/divtab-sh4-300.cc (main): Likewise.
      	* config/sh/divtab-sh4.cc (main): Likewise.
      	* config/sh/divtab.cc (main): Likewise.
      	* config/sh/elf.h: Likewise.
      	* config/sh/sh-protos.h (sh_fsca_int2sf): Likewise.
      	* config/sh/sh.cc (SYMBOL_FLAG_FUNCVEC_FUNCTION): Likewise.
      	(sh_struct_value_rtx): Likewise.
      	(sh_remove_reg_dead_or_unused_notes): Likewise.
      	* config/sh/sh.h (MIN_UNITS_PER_WORD): Likewise.
      	* config/sh/t-sh: Likewise.
      	* config/sol2-protos.h (solaris_override_options): Likewise.
      	* config/sol2.h: Likewise.
      	* config/sparc/driver-sparc.cc: Likewise.
      	* config/sparc/freebsd.h: Likewise.
      	* config/sparc/sparc-protos.h (make_pass_work_around_errata): Likewise.
      	* config/sparc/sparc.cc (sparc_output_mi_thunk): Likewise.
      	(sparc_asan_shadow_offset): Likewise.
      	* config/sparc/sparc.h: Likewise.
      	* config/sparc/sparc.md: Likewise.
      	* config/sparc/t-sparc: Likewise.
      	* config/sparc/x-sparc: Likewise.
      	* config/stormy16/stormy16.cc (xstormy16_mode_dependent_address_p): Likewise.
      	* config/t-darwin: Likewise.
      	* config/t-dragonfly: Likewise.
      	* config/t-freebsd: Likewise.
      	* config/t-glibc: Likewise.
      	* config/t-linux: Likewise.
      	* config/t-netbsd: Likewise.
      	* config/t-openbsd: Likewise.
      	* config/t-pnt16-warn: Likewise.
      	* config/t-sol2: Likewise.
      	* config/t-vxworks: Likewise.
      	* config/t-winnt: Likewise.
      	* config/tilegx/t-tilegx: Likewise.
      	* config/tilegx/tilegx-c.cc: Likewise.
      	* config/tilegx/tilegx-protos.h (tilegx_function_profiler): Likewise.
      	* config/tilegx/tilegx.md: Likewise.
      	* config/tilepro/t-tilepro: Likewise.
      	* config/tilepro/tilepro-c.cc: Likewise.
      	* config/v850/t-v850: Likewise.
      	* config/v850/v850-protos.h: Likewise.
      	* config/v850/v850.cc (F): Likewise.
      	* config/v850/v850.h (enum reg_class): Likewise.
      	(SLOW_BYTE_ACCESS): Likewise.
      	* config/vax/vax.cc (vax_mode_dependent_address_p): Likewise.
      	* config/vax/vax.h (enum reg_class): Likewise.
      	* config/vax/vax.md: Likewise.
      	* config/visium/visium.cc (visium_legitimate_address_p): Likewise.
      	* config/visium/visium.h: Likewise.
      	* config/vms/t-vms: Likewise.
      	* config/vms/vms-crtlmap.map: Likewise.
      	* config/vms/vms-protos.h (vms_c_get_vms_ver): Likewise.
      	* config/vx-common.h: Likewise.
      	* config/x-darwin: Likewise.
      	* config/x-hpux: Likewise.
      	* config/x-linux: Likewise.
      	* config/x-netbsd: Likewise.
      	* config/x-openbsd: Likewise.
      	* config/x-solaris: Likewise.
      	* config/xtensa/xtensa-protos.h (xtensa_mem_offset): Likewise.
      	* config/xtensa/xtensa.cc (xtensa_option_override): Likewise.
      	* config/xtensa/xtensa.h: Likewise.
      	* configure.ac: Likewise.
      	* context.cc: Likewise.
      	* convert.h: Likewise.
      	* coretypes.h: Likewise.
      	* coverage.cc: Likewise.
      	* coverage.h: Likewise.
      	* cppdefault.h (struct default_include): Likewise.
      	* cprop.cc (local_cprop_pass): Likewise.
      	(one_cprop_pass): Likewise.
      	* cse.cc (hash_rtx_cb): Likewise.
      	(fold_rtx): Likewise.
      	* ctfc.h (ctfc_get_num_vlen_bytes): Likewise.
      	* data-streamer.h (bp_unpack_var_len_int): Likewise.
      	(streamer_write_widest_int): Likewise.
      	* dbgcnt.def: Likewise.
      	* dbxout.cc (dbxout_early_global_decl): Likewise.
      	(dbxout_common_check): Likewise.
      	* dbxout.h: Likewise.
      	* debug.h (struct gcc_debug_hooks): Likewise.
      	(dump_go_spec_init): Likewise.
      	* df-core.cc: Likewise.
      	* df-scan.cc (df_insn_info_delete): Likewise.
      	(df_insn_delete): Likewise.
      	* df.h (debug_df_chain): Likewise.
      	(can_move_insns_across): Likewise.
      	* dfp.cc (decimal_from_binary): Likewise.
      	* diagnostic-color.cc: Likewise.
      	* diagnostic-event-id.h: Likewise.
      	* diagnostic-show-locus.cc (test_one_liner_labels): Likewise.
      	* diagnostic.cc (bt_callback): Likewise.
      	(num_digits): Likewise.
      	* doc/avr-mmcu.texi: Likewise.
      	* doc/cfg.texi: Likewise.
      	* doc/contrib.texi: Likewise.
      	* doc/cppinternals.texi: Likewise.
      	* doc/extend.texi: Likewise.
      	* doc/generic.texi: Likewise.
      	* doc/gimple.texi: Likewise.
      	* doc/gty.texi: Likewise.
      	* doc/invoke.texi: Likewise.
      	* doc/loop.texi: Likewise.
      	* doc/lto.texi: Likewise.
      	* doc/match-and-simplify.texi: Likewise.
      	* doc/md.texi: Likewise.
      	* doc/optinfo.texi: Likewise.
      	* doc/options.texi: Likewise.
      	* doc/passes.texi: Likewise.
      	* doc/plugins.texi: Likewise.
      	* doc/rtl.texi: Likewise.
      	* doc/sourcebuild.texi: Likewise.
      	* doc/tm.texi: Likewise.
      	* doc/tm.texi.in: Likewise.
      	* doc/tree-ssa.texi: Likewise.
      	* dojump.cc (do_jump): Likewise.
      	* dojump.h: Likewise.
      	* dumpfile.cc (test_impl_location): Likewise.
      	(test_capture_of_dump_calls): Likewise.
      	* dumpfile.h (enum dump_kind): Likewise.
      	(class dump_location_t): Likewise.
      	(dump_enabled_p): Likewise.
      	(enable_rtl_dump_file): Likewise.
      	(dump_combine_total_stats): Likewise.
      	* dwarf2asm.cc (dw2_asm_output_delta_uleb128): Likewise.
      	* dwarf2ctf.h (ctf_debug_finish): Likewise.
      	* dwarf2out.cc (dwarf2out_begin_prologue): Likewise.
      	(struct loc_descr_context): Likewise.
      	(rtl_for_decl_location): Likewise.
      	(gen_subprogram_die): Likewise.
      	(gen_label_die): Likewise.
      	(is_trivial_indirect_ref): Likewise.
      	(dwarf2out_late_global_decl): Likewise.
      	(dwarf_file_hasher::hash): Likewise.
      	(dwarf2out_end_source_file): Likewise.
      	(dwarf2out_define): Likewise.
      	(dwarf2out_early_finish): Likewise.
      	* dwarf2out.h (struct dw_fde_node): Likewise.
      	(struct dw_discr_list_node): Likewise.
      	(output_loc_sequence_raw): Likewise.
      	* emit-rtl.cc (gen_raw_REG): Likewise.
      	(maybe_set_max_label_num): Likewise.
      	* emit-rtl.h (struct rtl_data): Likewise.
      	* errors.cc (internal_error): Likewise.
      	(trim_filename): Likewise.
      	* et-forest.cc: Likewise.
      	* except.cc (init_eh_for_function): Likewise.
      	* explow.cc (promote_ssa_mode): Likewise.
      	(get_dynamic_stack_size): Likewise.
      	* explow.h: Likewise.
      	* expmed.h: Likewise.
      	* expr.cc (safe_from_p): Likewise.
      	(expand_expr_real_2): Likewise.
      	(expand_expr_real_1): Likewise.
      	* file-prefix-map.cc (remap_filename): Likewise.
      	* final.cc (app_enable): Likewise.
      	(make_pass_compute_alignments): Likewise.
      	(final_scan_insn_1): Likewise.
      	(final_scan_insn): Likewise.
      	* fixed-value.h (fixed_from_string): Likewise.
      	* flag-types.h (NO_DEBUG): Likewise.
      	(DWARF2_DEBUG): Likewise.
      	(VMS_DEBUG): Likewise.
      	(BTF_DEBUG): Likewise.
      	(enum ctf_debug_info_levels): Likewise.
      	* fold-const.cc (const_binop): Likewise.
      	(fold_binary_loc): Likewise.
      	(fold_checksum_tree): Likewise.
      	* fp-test.cc: Likewise.
      	* function.cc (expand_function_end): Likewise.
      	* function.h (struct function): Likewise.
      	* fwprop.cc (should_replace_address): Likewise.
      	* gcc-main.cc: Likewise.
      	* gcc-rich-location.h (class gcc_rich_location): Likewise.
      	* gcc-symtab.h: Likewise.
      	* gcc.cc (MIN_FATAL_STATUS): Likewise.
      	(driver_handle_option): Likewise.
      	(quote_spec_arg): Likewise.
      	(driver::finalize): Likewise.
      	* gcc.h (set_input): Likewise.
      	* gcov-dump.cc: Likewise.
      	* gcov.cc (solve_flow_graph): Likewise.
      	* gcse-common.cc: Likewise.
      	* gcse.cc (make_pass_rtl_hoist): Likewise.
      	* genattr-common.cc: Likewise.
      	* genattrtab.cc (min_fn): Likewise.
      	(write_const_num_delay_slots): Likewise.
      	* genautomata.cc: Likewise.
      	* genconditions.cc (write_one_condition): Likewise.
      	* genconstants.cc: Likewise.
      	* genemit.cc (gen_exp): Likewise.
      	* generic-match-head.cc: Likewise.
      	* genextract.cc: Likewise.
      	* gengenrtl.cc (always_void_p): Likewise.
      	* gengtype-parse.cc (gtymarker_opt): Likewise.
      	* gengtype-state.cc (state_writer::state_writer): Likewise.
      	(write_state_trailer): Likewise.
      	(equals_type_number): Likewise.
      	(read_state): Likewise.
      	* gengtype.cc (open_base_files): Likewise.
      	(struct file_rule_st): Likewise.
      	(header_dot_h_frul): Likewise.
      	* gengtype.h: Likewise.
      	* genmatch.cc (main): Likewise.
      	* genmddeps.cc: Likewise.
      	* genmodes.cc (emit_mode_inner): Likewise.
      	(emit_mode_unit_size): Likewise.
      	* genpeep.cc (gen_peephole): Likewise.
      	* genpreds.cc (write_tm_preds_h): Likewise.
      	* genrecog.cc (validate_pattern): Likewise.
      	(write_header): Likewise.
      	(main): Likewise.
      	* gensupport.cc (change_subst_attribute): Likewise.
      	(traverse_c_tests): Likewise.
      	(add_predicate): Likewise.
      	(init_predicate_table): Likewise.
      	* gensupport.h (struct optab_pattern): Likewise.
      	(get_num_insn_codes): Likewise.
      	(maybe_eval_c_test): Likewise.
      	(struct pred_data): Likewise.
      	* ggc-internal.h: Likewise.
      	* gimple-fold.cc (maybe_fold_reference): Likewise.
      	(get_range_strlen_tree): Likewise.
      	* gimple-fold.h (gimple_stmt_integer_valued_real_p): Likewise.
      	* gimple-low.cc: Likewise.
      	* gimple-match-head.cc (directly_supported_p): Likewise.
      	* gimple-pretty-print.h: Likewise.
      	* gimple-ssa-sprintf.cc (format_percent): Likewise.
      	(adjust_range_for_overflow): Likewise.
      	* gimple-streamer.h: Likewise.
      	* gimple.h (struct GTY): Likewise.
      	(is_gimple_resx): Likewise.
      	* gimplify.cc (gimplify_expr): Likewise.
      	(gimplify_init_constructor): Likewise.
      	(omp_construct_selector_matches): Likewise.
      	(gimplify_omp_target_update): Likewise.
      	(gimplify_omp_ordered): Likewise.
      	(gimplify_va_arg_expr): Likewise.
      	* graphite-isl-ast-to-gimple.cc (should_copy_to_new_region): Likewise.
      	* haifa-sched.cc (increase_insn_priority): Likewise.
      	(try_ready): Likewise.
      	(sched_create_recovery_edges): Likewise.
      	* ifcvt.cc (find_if_case_1): Likewise.
      	(find_if_case_2): Likewise.
      	* inchash.h: Likewise.
      	* incpath.cc (add_env_var_paths): Likewise.
      	* input.cc (dump_location_info): Likewise.
      	(assert_loceq): Likewise.
      	(test_lexer_string_locations_concatenation_1): Likewise.
      	(test_lexer_string_locations_concatenation_2): Likewise.
      	(test_lexer_string_locations_concatenation_3): Likewise.
      	* input.h (BUILTINS_LOCATION): Likewise.
      	(class string_concat_db): Likewise.
      	* internal-fn.cc (expand_MUL_OVERFLOW): Likewise.
      	(expand_LOOP_VECTORIZED): Likewise.
      	* ipa-cp.cc (make_pass_ipa_cp): Likewise.
      	* ipa-fnsummary.cc (remap_freqcounting_preds_after_dup): Likewise.
      	(ipa_fn_summary_t::duplicate): Likewise.
      	(make_pass_ipa_fn_summary): Likewise.
      	* ipa-fnsummary.h (enum ipa_hints_vals): Likewise.
      	* ipa-free-lang-data.cc (fld_simplified_type): Likewise.
      	(free_lang_data_in_decl): Likewise.
      	* ipa-inline.cc (compute_inlined_call_time): Likewise.
      	(inline_always_inline_functions): Likewise.
      	* ipa-inline.h (free_growth_caches): Likewise.
      	(inline_account_function_p): Likewise.
      	* ipa-modref.cc (modref_access_analysis::analyze_stmt): Likewise.
      	(modref_eaf_analysis::analyze_ssa_name): Likewise.
      	* ipa-param-manipulation.cc (ipa_param_body_adjustments::mark_dead_statements): Likewise.
      	(ipa_param_body_adjustments::remap_with_debug_expressions): Likewise.
      	* ipa-prop.cc (ipa_set_node_agg_value_chain): Likewise.
      	* ipa-prop.h (IPA_UNDESCRIBED_USE): Likewise.
      	(unadjusted_ptr_and_unit_offset): Likewise.
      	* ipa-reference.cc (make_pass_ipa_reference): Likewise.
      	* ipa-reference.h (GCC_IPA_REFERENCE_H): Likewise.
      	* ipa-split.cc (consider_split): Likewise.
      	* ipa-sra.cc (isra_read_node_info): Likewise.
      	* ipa-utils.h (struct ipa_dfs_info): Likewise.
      	(recursive_call_p): Likewise.
      	(ipa_make_function_pure): Likewise.
      	* ira-build.cc (ira_create_allocno): Likewise.
      	(ira_flattening): Likewise.
      	* ira-color.cc (do_coloring): Likewise.
      	(update_curr_costs): Likewise.
      	* ira-conflicts.cc (process_regs_for_copy): Likewise.
      	* ira-int.h (struct ira_emit_data): Likewise.
      	(ira_prohibited_mode_move_regs): Likewise.
      	(ira_get_dup_out_num): Likewise.
      	(ira_destroy): Likewise.
      	(ira_tune_allocno_costs): Likewise.
      	(ira_implicitly_set_insn_hard_regs): Likewise.
      	(ira_build_conflicts): Likewise.
      	(ira_color): Likewise.
      	* ira-lives.cc (process_bb_node_lives): Likewise.
      	* ira.cc (class ira_spilled_reg_stack_slot): Likewise.
      	(setup_uniform_class_p): Likewise.
      	(def_dominates_uses): Likewise.
      	* ira.h (ira_nullify_asm_goto): Likewise.
      	* langhooks.cc (lhd_post_options): Likewise.
      	* langhooks.h (class substring_loc): Likewise.
      	(struct lang_hooks_for_tree_inlining): Likewise.
      	(struct lang_hooks_for_types): Likewise.
      	(struct lang_hooks): Likewise.
      	* libfuncs.h (synchronize_libfunc): Likewise.
      	* loop-doloop.cc (doloop_condition_get): Likewise.
      	* loop-init.cc (fix_loop_structure): Likewise.
      	* loop-invariant.cc: Likewise.
      	* lower-subreg.h: Likewise.
      	* lra-constraints.cc (curr_insn_transform): Likewise.
      	* lra-int.h (struct lra_insn_reg): Likewise.
      	(lra_undo_inheritance): Likewise.
      	(lra_setup_reload_pseudo_preferenced_hard_reg): Likewise.
      	(lra_split_hard_reg_for): Likewise.
      	(lra_coalesce): Likewise.
      	(lra_final_code_change): Likewise.
      	* lra-spills.cc (lra_final_code_change): Likewise.
      	* lra.cc (lra_process_new_insns): Likewise.
      	* lto-compress.h (struct lto_compression_stream): Likewise.
      	* lto-streamer-out.cc (DFS::DFS_write_tree_body): Likewise.
      	(write_symbol): Likewise.
      	* lto-streamer.h (enum LTO_tags): Likewise.
      	(lto_value_range_error): Likewise.
      	(lto_append_block): Likewise.
      	(lto_streamer_hooks_init): Likewise.
      	(stream_read_tree_ref): Likewise.
      	(lto_prepare_function_for_streaming): Likewise.
      	(select_what_to_stream): Likewise.
      	(omp_lto_input_declare_variant_alt): Likewise.
      	(cl_optimization_stream_in): Likewise.
      	* lto-wrapper.cc (append_compiler_options): Likewise.
      	* machmode.def: Likewise.
      	* machmode.h (struct int_n_data_t): Likewise.
      	* main.cc (main): Likewise.
      	* match.pd: Likewise.
      	* omp-builtins.def (BUILT_IN_GOMP_CRITICAL_NAME_END): Likewise.
      	(BUILT_IN_GOMP_LOOP_ULL_ORDERED_RUNTIME_NEXT): Likewise.
      	* omp-expand.cc (expand_omp_atomic_fetch_op): Likewise.
      	(make_pass_expand_omp_ssa): Likewise.
      	* omp-low.cc (struct omp_context): Likewise.
      	(struct omp_taskcopy_context): Likewise.
      	(lower_omp): Likewise.
      	* omp-oacc-neuter-broadcast.cc (omp_sese_active_worker_call): Likewise.
      	(mask_name): Likewise.
      	(omp_sese_dump_pars): Likewise.
      	(worker_single_simple): Likewise.
      	* omp-offload.cc (omp_finish_file): Likewise.
      	(execute_oacc_loop_designation): Likewise.
      	* optabs-query.cc (lshift_cheap_p): Likewise.
      	* optc-gen.awk: Likewise.
      	* optc-save-gen.awk: Likewise.
      	* optinfo-emit-json.cc (optrecord_json_writer::optrecord_json_writer): Likewise.
      	* opts-common.cc: Likewise.
      	* output.h (app_enable): Likewise.
      	(output_operand_lossage): Likewise.
      	(insn_current_reference_address): Likewise.
      	(get_insn_template): Likewise.
      	(output_quoted_string): Likewise.
      	* pass_manager.h (struct register_pass_info): Likewise.
      	* plugin.cc: Likewise.
      	* plugin.def (PLUGIN_ANALYZER_INIT): Likewise.
      	* plugin.h (invoke_plugin_callbacks): Likewise.
      	* pointer-query.cc (handle_mem_ref): Likewise.
      	* postreload-gcse.cc (alloc_mem): Likewise.
      	* predict.h (enum prediction): Likewise.
      	(add_reg_br_prob_note): Likewise.
      	* prefix.h: Likewise.
      	* profile.h (get_working_sets): Likewise.
      	* read-md.cc: Likewise.
      	* read-md.h (struct mapping): Likewise.
      	(class md_reader): Likewise.
      	(class noop_reader): Likewise.
      	* read-rtl-function.cc (function_reader::create_function): Likewise.
      	(function_reader::extra_parsing_for_operand_code_0): Likewise.
      	* read-rtl.cc (initialize_iterators): Likewise.
      	* real.cc: Likewise.
      	* real.h (struct real_value): Likewise.
      	(format_helper::format_helper): Likewise.
      	(real_hash): Likewise.
      	(real_can_shorten_arithmetic): Likewise.
      	* recog.cc (struct target_recog): Likewise.
      	(offsettable_nonstrict_memref_p): Likewise.
      	(constrain_operands): Likewise.
      	* recog.h (MAX_RECOG_ALTERNATIVES): Likewise.
      	(which_op_alt): Likewise.
      	(struct insn_gen_fn): Likewise.
      	* reg-notes.def (REG_NOTE): Likewise.
      	* reg-stack.cc: Likewise.
      	* regs.h (reg_is_parm_p): Likewise.
      	* regset.h: Likewise.
      	* reload.cc (push_reload): Likewise.
      	(find_reloads): Likewise.
      	(find_reloads_address_1): Likewise.
      	(find_replacement): Likewise.
      	(refers_to_regno_for_reload_p): Likewise.
      	(refers_to_mem_for_reload_p): Likewise.
      	* reload.h (push_reload): Likewise.
      	(deallocate_reload_reg): Likewise.
      	* reload1.cc (emit_input_reload_insns): Likewise.
      	* reorg.cc (relax_delay_slots): Likewise.
      	* rtl.def (UNKNOWN): Likewise.
      	(SEQUENCE): Likewise.
      	(BARRIER): Likewise.
      	(ASM_OPERANDS): Likewise.
      	(EQ_ATTR_ALT): Likewise.
      	* rtl.h (struct GTY): Likewise.
      	(LABEL_NAME): Likewise.
      	(LABEL_ALT_ENTRY_P): Likewise.
      	(SUBREG_BYTE): Likewise.
      	(get_stack_check_protect): Likewise.
      	(dump_rtx_statistics): Likewise.
      	(unwrap_const_vec_duplicate): Likewise.
      	(subreg_promoted_mode): Likewise.
      	(gen_lowpart_common): Likewise.
      	(operand_subword): Likewise.
      	(immed_wide_int_const): Likewise.
      	(decide_function_section): Likewise.
      	(active_insn_p): Likewise.
      	(delete_related_insns): Likewise.
      	(try_split): Likewise.
      	(val_signbit_known_clear_p): Likewise.
      	(simplifiable_subregs): Likewise.
      	(set_insn_deleted): Likewise.
      	(subreg_get_info): Likewise.
      	(remove_free_EXPR_LIST_node): Likewise.
      	(finish_subregs_of_mode): Likewise.
      	(get_mem_attrs): Likewise.
      	(lookup_constant_def): Likewise.
      	(rtx_to_tree_code): Likewise.
      	(hash_rtx): Likewise.
      	(condjump_in_parallel_p): Likewise.
      	(validate_subreg): Likewise.
      	(make_compound_operation): Likewise.
      	(schedule_ebbs): Likewise.
      	(print_inline_rtx): Likewise.
      	(fixup_args_size_notes): Likewise.
      	(expand_dec): Likewise.
      	(prepare_copy_insn): Likewise.
      	(mark_elimination): Likewise.
      	(valid_mode_changes_for_regno): Likewise.
      	(make_debug_expr_from_rtl): Likewise.
      	(delete_vta_debug_insns): Likewise.
      	(simplify_using_condition): Likewise.
      	(set_insn_locations): Likewise.
      	(fatal_insn_not_found): Likewise.
      	(word_register_operation_p): Likewise.
      	* rtlanal.cc (get_call_fndecl): Likewise.
      	(side_effects_p): Likewise.
      	(subreg_nregs): Likewise.
      	(rtx_cost): Likewise.
      	(canonicalize_condition): Likewise.
      	* rtlanal.h (rtx_properties::try_to_add_note): Likewise.
      	* run-rtl-passes.cc (run_rtl_passes): Likewise.
      	* sanitizer.def (BUILT_IN_ASAN_VERSION_MISMATCH_CHECK): Likewise.
      	* sched-deps.cc (add_dependence_1): Likewise.
      	* sched-ebb.cc (begin_move_insn): Likewise.
      	(add_deps_for_risky_insns): Likewise.
      	(advance_target_bb): Likewise.
      	* sched-int.h (reemit_notes): Likewise.
      	(struct _haifa_insn_data): Likewise.
      	(HID): Likewise.
      	(DEP_CANCELLED): Likewise.
      	(debug_ds): Likewise.
      	(number_in_ready): Likewise.
      	(schedule_ebbs_finish): Likewise.
      	(find_modifiable_mems): Likewise.
      	* sched-rgn.cc (debug_rgn_dependencies): Likewise.
      	* sel-sched-dump.cc (dump_lv_set): Likewise.
      	* sel-sched-dump.h: Likewise.
      	* sel-sched-ir.cc (sel_insn_rtx_cost): Likewise.
      	(setup_id_reg_sets): Likewise.
      	(has_dependence_p): Likewise.
      	(sel_num_cfg_preds_gt_1): Likewise.
      	(bb_ends_ebb_p): Likewise.
      	* sel-sched-ir.h (struct _list_node): Likewise.
      	(struct idata_def): Likewise.
      	(bb_next_bb): Likewise.
      	* sel-sched.cc (vinsn_writes_one_of_regs_p): Likewise.
      	(choose_best_pseudo_reg): Likewise.
      	(verify_target_availability): Likewise.
      	(can_speculate_dep_p): Likewise.
      	(sel_rank_for_schedule): Likewise.
      	* selftest-run-tests.cc (selftest::run_tests): Likewise.
      	* selftest.h (class auto_fix_quotes): Likewise.
      	* shrink-wrap.cc (handle_simple_exit): Likewise.
      	* shrink-wrap.h: Likewise.
      	* simplify-rtx.cc (simplify_context::simplify_associative_operation): Likewise.
      	(simplify_context::simplify_gen_vec_select): Likewise.
      	* spellcheck-tree.h: Likewise.
      	* spellcheck.h: Likewise.
      	* statistics.h (struct function): Likewise.
      	* stmt.cc (conditional_probability): Likewise.
      	* stmt.h: Likewise.
      	* stor-layout.h: Likewise.
      	* streamer-hooks.h: Likewise.
      	* stringpool.h: Likewise.
      	* symtab.cc (symbol_table::change_decl_assembler_name): Likewise.
      	* target.def (HOOK_VECTOR_END): Likewise.
      	(type.): Likewise.
      	* target.h (union cumulative_args_t): Likewise.
      	(by_pieces_ninsns): Likewise.
      	(class predefined_function_abi): Likewise.
      	* targhooks.cc (default_translate_mode_attribute): Likewise.
      	* timevar.def: Likewise.
      	* timevar.h (class timer): Likewise.
      	* toplev.h (enable_rtl_dump_file): Likewise.
      	* trans-mem.cc (collect_bb2reg): Likewise.
      	* tree-call-cdce.cc (gen_conditions_for_pow): Likewise.
      	* tree-cfg.cc (remove_bb): Likewise.
      	(verify_gimple_debug): Likewise.
      	(remove_edge_and_dominated_blocks): Likewise.
      	(push_fndecl): Likewise.
      	* tree-cfgcleanup.h (GCC_TREE_CFGCLEANUP_H): Likewise.
      	* tree-complex.cc (expand_complex_multiplication): Likewise.
      	(expand_complex_div_straight): Likewise.
      	* tree-core.h (enum tree_index): Likewise.
      	(enum operand_equal_flag): Likewise.
      	* tree-eh.cc (honor_protect_cleanup_actions): Likewise.
      	* tree-if-conv.cc (if_convertible_gimple_assign_stmt_p): Likewise.
      	* tree-inline.cc (initialize_inlined_parameters): Likewise.
      	* tree-inline.h (force_value_to_type): Likewise.
      	* tree-nested.cc (get_chain_decl): Likewise.
      	(walk_all_functions): Likewise.
      	* tree-object-size.h: Likewise.
      	* tree-outof-ssa.cc: Likewise.
      	* tree-parloops.cc (create_parallel_loop): Likewise.
      	* tree-pretty-print.cc (print_generic_expr_to_str): Likewise.
      	(dump_generic_node): Likewise.
      	* tree-profile.cc (tree_profiling): Likewise.
      	* tree-sra.cc (maybe_add_sra_candidate): Likewise.
      	* tree-ssa-address.cc: Likewise.
      	* tree-ssa-alias.cc: Likewise.
      	* tree-ssa-alias.h (ao_ref::max_size_known_p): Likewise.
      	(dump_alias_stats): Likewise.
      	* tree-ssa-ccp.cc: Likewise.
      	* tree-ssa-coalesce.h: Likewise.
      	* tree-ssa-live.cc (remove_unused_scope_block_p): Likewise.
      	* tree-ssa-loop-manip.cc (copy_phi_node_args): Likewise.
      	* tree-ssa-loop-unswitch.cc: Likewise.
      	* tree-ssa-math-opts.cc: Likewise.
      	* tree-ssa-operands.cc (class operands_scanner): Likewise.
      	* tree-ssa-pre.cc: Likewise.
      	* tree-ssa-reassoc.cc (optimize_ops_list): Likewise.
      	(debug_range_entry): Likewise.
      	* tree-ssa-sccvn.cc (eliminate_dom_walker::eliminate_stmt): Likewise.
      	* tree-ssa-sccvn.h (TREE_SSA_SCCVN_H): Likewise.
      	* tree-ssa-scopedtables.cc (add_expr_commutative): Likewise.
      	(equal_mem_array_ref_p): Likewise.
      	* tree-ssa-strlen.cc (is_strlen_related_p): Likewise.
      	* tree-ssa-strlen.h (get_range_strlen_dynamic): Likewise.
      	* tree-ssa-tail-merge.cc (stmt_local_def): Likewise.
      	* tree-ssa-ter.h: Likewise.
      	* tree-ssa-threadupdate.h (enum bb_dom_status): Likewise.
      	* tree-streamer-in.cc (lto_input_ts_block_tree_pointers): Likewise.
      	* tree-streamer-out.cc (pack_ts_block_value_fields): Likewise.
      	(write_ts_block_tree_pointers): Likewise.
      	* tree-streamer.h (struct streamer_tree_cache_d): Likewise.
      	(streamer_read_tree_bitfields): Likewise.
      	(streamer_write_integer_cst): Likewise.
      	* tree-vect-patterns.cc (apply_binop_and_append_stmt): Likewise.
      	(vect_synth_mult_by_constant): Likewise.
      	* tree-vect-stmts.cc (vectorizable_operation): Likewise.
      	* tree-vectorizer.cc: Likewise.
      	* tree-vectorizer.h (class auto_purge_vect_location): Likewise.
      	(vect_update_inits_of_drs): Likewise.
      	(vect_get_mask_type_for_stmt): Likewise.
      	(vect_rgroup_iv_might_wrap_p): Likewise.
      	(cse_and_gimplify_to_preheader): Likewise.
      	(vect_free_slp_tree): Likewise.
      	(vect_pattern_recog): Likewise.
      	(vect_stmt_dominates_stmt_p): Likewise.
      	* tree.cc (initialize_tree_contains_struct): Likewise.
      	(need_assembler_name_p): Likewise.
      	(type_with_interoperable_signedness): Likewise.
      	* tree.def (SWITCH_EXPR): Likewise.
      	* tree.h (TYPE_SYMTAB_ADDRESS): Likewise.
      	(poly_int_tree_p): Likewise.
      	(inlined_function_outer_scope_p): Likewise.
      	(tree_code_for_canonical_type_merging): Likewise.
      	* value-prof.cc: Likewise.
      	* value-prof.h (get_nth_most_common_value): Likewise.
      	(find_func_by_profile_id): Likewise.
      	* value-range.cc (vrp_operand_equal_p): Likewise.
      	* value-range.h: Likewise.
      	* var-tracking.cc: Likewise.
      	* varasm.cc (default_function_section): Likewise.
      	(function_section_1): Likewise.
      	(assemble_variable): Likewise.
      	(handle_vtv_comdat_section): Likewise.
      	* vec.h (struct vec_prefix): Likewise.
      	* vmsdbgout.cc (full_name): Likewise.
      	* vtable-verify.cc: Likewise.
      	* vtable-verify.h (struct vtv_graph_node): Likewise.
      	* xcoffout.cc: Likewise.
      	* xcoffout.h (DEBUG_SYMS_TEXT): Likewise.
      
      gcc/ada/ChangeLog:
      
      	* Make-generated.in: Rename .c names to .cc.
      	* adaint.c: Likewise.
      	* ctrl_c.c (dummy_handler): Likewise.
      	* gcc-interface/Makefile.in: Likewise.
      	* gcc-interface/config-lang.in: Likewise.
      	* gcc-interface/decl.cc (concat_name): Likewise.
      	(init_gnat_decl): Likewise.
      	* gcc-interface/gigi.h (concat_name): Likewise.
      	(init_gnat_utils): Likewise.
      	(build_call_raise_range): Likewise.
      	(gnat_mark_addressable): Likewise.
      	(gnat_protect_expr): Likewise.
      	(gnat_rewrite_reference): Likewise.
      	* gcc-interface/lang-specs.h (ADA_DUMPS_OPTIONS): Likewise.
      	* gcc-interface/utils.cc (GTY): Likewise.
      	(add_deferred_type_context): Likewise.
      	(init_gnat_utils): Likewise.
      	* gcc-interface/utils2.cc (gnat_stable_expr_p): Likewise.
      	(gnat_protect_expr): Likewise.
      	(gnat_stabilize_reference_1): Likewise.
      	(gnat_rewrite_reference): Likewise.
      	* gsocket.h: Likewise.
      	* init.cc (__gnat_error_handler): Likewise.
      	* libgnarl/s-intman.ads: Likewise.
      	* libgnarl/s-osinte__android.ads: Likewise.
      	* libgnarl/s-osinte__darwin.ads: Likewise.
      	* libgnarl/s-osinte__hpux.ads: Likewise.
      	* libgnarl/s-osinte__linux.ads: Likewise.
      	* libgnarl/s-osinte__qnx.ads: Likewise.
      	* libgnarl/s-taskin.ads: Likewise.
      	* rtfinal.cc: Likewise.
      	* s-oscons-tmplt.c (CND): Likewise.
      	* set_targ.ads: Likewise.
      
      gcc/analyzer/ChangeLog:
      
      	* analyzer.cc (is_special_named_call_p): Rename .c names to .cc.
      	(is_named_call_p): Likewise.
      	* region-model-asm.cc (deterministic_p): Likewise.
      	* region.cc (field_region::get_relative_concrete_offset): Likewise.
      	* sm-malloc.cc (method_p): Likewise.
      	* supergraph.cc (superedge::dump_dot): Likewise.
      
      gcc/c-family/ChangeLog:
      
      	* c-ada-spec.cc: Rename .c names to .cc.
      	* c-ada-spec.h: Likewise.
      	* c-common.cc (c_build_vec_convert): Likewise.
      	(warning_candidate_p): Likewise.
      	* c-common.h (enum rid): Likewise.
      	(build_real_imag_expr): Likewise.
      	(finish_label_address_expr): Likewise.
      	(c_get_substring_location): Likewise.
      	(c_build_bind_expr): Likewise.
      	(conflict_marker_get_final_tok_kind): Likewise.
      	(c_parse_error): Likewise.
      	(check_missing_format_attribute): Likewise.
      	(invalid_array_size_error): Likewise.
      	(warn_for_multistatement_macros): Likewise.
      	(build_attr_access_from_parms): Likewise.
      	* c-cppbuiltin.cc (c_cpp_builtins): Likewise.
      	* c-format.cc: Likewise.
      	* c-gimplify.cc (c_gimplify_expr): Likewise.
      	* c-indentation.h: Likewise.
      	* c-objc.h (objc_prop_attr_kind_for_rid): Likewise.
      	* c-omp.cc (c_omp_predetermined_mapping): Likewise.
      	* c-opts.cc (c_common_post_options): Likewise.
      	(set_std_cxx23): Likewise.
      	* c-pragma.cc (handle_pragma_redefine_extname): Likewise.
      	* c-pretty-print.h: Likewise.
      
      gcc/c/ChangeLog:
      
      	* Make-lang.in: Rename .c names to .cc.
      	* c-convert.cc: Likewise.
      	* c-decl.cc (struct lang_identifier): Likewise.
      	(pop_scope): Likewise.
      	(finish_decl): Likewise.
      	* c-objc-common.h (GCC_C_OBJC_COMMON): Likewise.
      	* c-parser.cc (c_parser_skip_to_end_of_block_or_statement): Likewise.
      	* c-parser.h (GCC_C_PARSER_H): Likewise.
      	* c-tree.h (c_keyword_starts_typename): Likewise.
      	(finish_declspecs): Likewise.
      	(c_get_alias_set): Likewise.
      	(enum c_oracle_request): Likewise.
      	(tag_exists_p): Likewise.
      	(set_c_expr_source_range): Likewise.
      	* c-typeck.cc (c_common_type): Likewise.
      	(c_finish_omp_clauses): Likewise.
      	* config-lang.in: Likewise.
      
      gcc/cp/ChangeLog:
      
      	* Make-lang.in: Rename .c names to .cc.
      	* config-lang.in: Likewise.
      	* constexpr.cc (cxx_eval_constant_expression): Likewise.
      	* coroutines.cc (morph_fn_to_coro): Likewise.
      	* cp-gimplify.cc (cp_gimplify_expr): Likewise.
      	* cp-lang.cc (struct lang_hooks): Likewise.
      	(get_template_argument_pack_elems_folded): Likewise.
      	* cp-objcp-common.cc (cp_tree_size): Likewise.
      	(cp_unit_size_without_reusable_padding): Likewise.
      	(pop_file_scope): Likewise.
      	(cp_pushdecl): Likewise.
      	* cp-objcp-common.h (GCC_CP_OBJCP_COMMON): Likewise.
      	(cxx_simulate_record_decl): Likewise.
      	* cp-tree.h (struct named_label_entry): Likewise.
      	(current_function_return_value): Likewise.
      	(more_aggr_init_expr_args_p): Likewise.
      	(get_function_version_dispatcher): Likewise.
      	(common_enclosing_class): Likewise.
      	(strip_fnptr_conv): Likewise.
      	(current_decl_namespace): Likewise.
      	(do_aggregate_paren_init): Likewise.
      	(cp_check_const_attributes): Likewise.
      	(qualified_name_lookup_error): Likewise.
      	(generic_targs_for): Likewise.
      	(mark_exp_read): Likewise.
      	(is_global_friend): Likewise.
      	(maybe_reject_flexarray_init): Likewise.
      	(module_token_lang): Likewise.
      	(handle_module_option): Likewise.
      	(literal_integer_zerop): Likewise.
      	(build_extra_args): Likewise.
      	(build_if_nonnull): Likewise.
      	(maybe_check_overriding_exception_spec): Likewise.
      	(finish_omp_target_clauses): Likewise.
      	(maybe_warn_zero_as_null_pointer_constant): Likewise.
      	(cxx_print_error_function): Likewise.
      	(decl_in_std_namespace_p): Likewise.
      	(merge_exception_specifiers): Likewise.
      	(mangle_module_global_init): Likewise.
      	(cxx_block_may_fallthru): Likewise.
      	(fold_builtin_source_location): Likewise.
      	(enum cp_oracle_request): Likewise.
      	(subsumes): Likewise.
      	(cp_finish_injected_record_type): Likewise.
      	(vtv_build_vtable_verify_fndecl): Likewise.
      	(cp_tree_c_finish_parsing): Likewise.
      	* cvt.cc (diagnose_ref_binding): Likewise.
      	(convert_to_void): Likewise.
      	(convert_force): Likewise.
      	(type_promotes_to): Likewise.
      	* decl.cc (make_unbound_class_template_raw): Likewise.
      	(cxx_init_decl_processing): Likewise.
      	(check_class_member_definition_namespace): Likewise.
      	(cxx_maybe_build_cleanup): Likewise.
      	* decl2.cc (maybe_emit_vtables): Likewise.
      	* error.cc (dump_function_name): Likewise.
      	* init.cc (is_class_type): Likewise.
      	(build_new_1): Likewise.
      	* lang-specs.h: Likewise.
      	* method.cc (make_alias_for_thunk): Likewise.
      	* module.cc (specialization_add): Likewise.
      	(module_state::read_cluster): Likewise.
      	* name-lookup.cc (check_extern_c_conflict): Likewise.
      	* name-lookup.h (struct cxx_binding): Likewise.
      	* parser.cc (cp_parser_identifier): Likewise.
      	* parser.h (struct cp_parser): Likewise.
      	* pt.cc (has_value_dependent_address): Likewise.
      	(push_tinst_level_loc): Likewise.
      	* semantics.cc (finish_omp_clauses): Likewise.
      	(finish_omp_atomic): Likewise.
      	* tree.cc (cp_save_expr): Likewise.
      	(cp_free_lang_data): Likewise.
      	* typeck.cc (cp_common_type): Likewise.
      	(strip_array_domain): Likewise.
      	(rationalize_conditional_expr): Likewise.
      	(check_return_expr): Likewise.
      	* vtable-class-hierarchy.cc: Likewise.
      
      gcc/d/ChangeLog:
      
      	* d-gimplify.cc: Rename .c names to .cc.
      	* d-incpath.cc: Likewise.
      	* lang-specs.h: Likewise.
      
      gcc/fortran/ChangeLog:
      
      	* check.cc (gfc_check_all_any): Rename .c names to .cc.
      	* class.cc (find_intrinsic_vtab): Likewise.
      	* config-lang.in: Likewise.
      	* cpp.cc (cpp_define_builtins): Likewise.
      	* data.cc (get_array_index): Likewise.
      	* decl.cc (match_clist_expr): Likewise.
      	(get_proc_name): Likewise.
      	(gfc_verify_c_interop_param): Likewise.
      	(gfc_get_pdt_instance): Likewise.
      	(gfc_match_formal_arglist): Likewise.
      	(gfc_get_type_attr_spec): Likewise.
      	* dependency.cc: Likewise.
      	* error.cc (gfc_format_decoder): Likewise.
      	* expr.cc (check_restricted): Likewise.
      	(gfc_build_default_init_expr): Likewise.
      	* f95-lang.cc: Likewise.
      	* gfc-internals.texi: Likewise.
      	* gfortran.h (enum match): Likewise.
      	(enum procedure_type): Likewise.
      	(enum oacc_routine_lop): Likewise.
      	(gfc_get_pdt_instance): Likewise.
      	(gfc_end_source_files): Likewise.
      	(gfc_mpz_set_hwi): Likewise.
      	(gfc_get_option_string): Likewise.
      	(gfc_find_sym_in_expr): Likewise.
      	(gfc_errors_to_warnings): Likewise.
      	(gfc_real_4_kind): Likewise.
      	(gfc_free_finalizer): Likewise.
      	(gfc_sym_get_dummy_args): Likewise.
      	(gfc_check_intrinsic_standard): Likewise.
      	(gfc_free_case_list): Likewise.
      	(gfc_resolve_oacc_routines): Likewise.
      	(gfc_check_vardef_context): Likewise.
      	(gfc_free_association_list): Likewise.
      	(gfc_implicit_pure_function): Likewise.
      	(gfc_ref_dimen_size): Likewise.
      	(gfc_compare_actual_formal): Likewise.
      	(gfc_resolve_wait): Likewise.
      	(gfc_dt_upper_string): Likewise.
      	(gfc_generate_module_code): Likewise.
      	(gfc_delete_bbt): Likewise.
      	(debug): Likewise.
      	(gfc_build_block_ns): Likewise.
      	(gfc_dep_difference): Likewise.
      	(gfc_invalid_null_arg): Likewise.
      	(gfc_is_finalizable): Likewise.
      	(gfc_fix_implicit_pure): Likewise.
      	(gfc_is_size_zero_array): Likewise.
      	(gfc_is_reallocatable_lhs): Likewise.
      	* gfortranspec.cc: Likewise.
      	* interface.cc (compare_actual_expr): Likewise.
      	* intrinsic.cc (add_functions): Likewise.
      	* iresolve.cc (gfc_resolve_matmul): Likewise.
      	(gfc_resolve_alarm_sub): Likewise.
      	* iso-c-binding.def: Likewise.
      	* lang-specs.h: Likewise.
      	* libgfortran.h (GFC_STDERR_UNIT_NUMBER): Likewise.
      	* match.cc (gfc_match_label): Likewise.
      	(gfc_match_symbol): Likewise.
      	(match_derived_type_spec): Likewise.
      	(copy_ts_from_selector_to_associate): Likewise.
      	* match.h (gfc_match_call): Likewise.
      	(gfc_get_common): Likewise.
      	(gfc_match_omp_end_single): Likewise.
      	(gfc_match_volatile): Likewise.
      	(gfc_match_bind_c): Likewise.
      	(gfc_match_literal_constant): Likewise.
      	(gfc_match_init_expr): Likewise.
      	(gfc_match_array_constructor): Likewise.
      	(gfc_match_end_interface): Likewise.
      	(gfc_match_print): Likewise.
      	(gfc_match_expr): Likewise.
      	* matchexp.cc (next_operator): Likewise.
      	* mathbuiltins.def: Likewise.
      	* module.cc (free_true_name): Likewise.
      	* openmp.cc (gfc_resolve_omp_parallel_blocks): Likewise.
      	(gfc_omp_save_and_clear_state): Likewise.
      	* parse.cc (parse_union): Likewise.
      	(set_syms_host_assoc): Likewise.
      	* resolve.cc (resolve_actual_arglist): Likewise.
      	(resolve_elemental_actual): Likewise.
      	(check_host_association): Likewise.
      	(resolve_typebound_function): Likewise.
      	(resolve_typebound_subroutine): Likewise.
      	(gfc_resolve_expr): Likewise.
      	(resolve_assoc_var): Likewise.
      	(resolve_typebound_procedures): Likewise.
      	(resolve_equivalence_derived): Likewise.
      	* simplify.cc (simplify_bound): Likewise.
      	* symbol.cc (gfc_set_default_type): Likewise.
      	(gfc_add_ext_attribute): Likewise.
      	* target-memory.cc (gfc_target_interpret_expr): Likewise.
      	* target-memory.h (gfc_target_interpret_expr): Likewise.
      	* trans-array.cc (gfc_get_cfi_dim_sm): Likewise.
      	(gfc_conv_shift_descriptor_lbound): Likewise.
      	(gfc_could_be_alias): Likewise.
      	(gfc_get_dataptr_offset): Likewise.
      	* trans-const.cc: Likewise.
      	* trans-decl.cc (trans_function_start): Likewise.
      	(gfc_trans_deferred_vars): Likewise.
      	(generate_local_decl): Likewise.
      	(gfc_generate_function_code): Likewise.
      	* trans-expr.cc (gfc_vptr_size_get): Likewise.
      	(gfc_trans_class_array_init_assign): Likewise.
      	(POWI_TABLE_SIZE): Likewise.
      	(gfc_conv_procedure_call): Likewise.
      	(gfc_trans_arrayfunc_assign): Likewise.
      	* trans-intrinsic.cc (gfc_conv_intrinsic_len): Likewise.
      	(gfc_conv_intrinsic_loc): Likewise.
      	(conv_intrinsic_event_query): Likewise.
      	* trans-io.cc (gfc_build_st_parameter): Likewise.
      	* trans-openmp.cc (gfc_omp_check_optional_argument): Likewise.
      	(gfc_omp_unshare_expr_r): Likewise.
      	(gfc_trans_omp_array_section): Likewise.
      	(gfc_trans_omp_clauses): Likewise.
      	* trans-stmt.cc (trans_associate_var): Likewise.
      	(gfc_trans_deallocate): Likewise.
      	* trans-stmt.h (gfc_trans_class_init_assign): Likewise.
      	(gfc_trans_deallocate): Likewise.
      	(gfc_trans_oacc_declare): Likewise.
      	* trans-types.cc: Likewise.
      	* trans-types.h (enum gfc_packed): Likewise.
      	* trans.cc (N_): Likewise.
      	(trans_code): Likewise.
      	* trans.h (gfc_build_compare_string): Likewise.
      	(gfc_conv_expr_type): Likewise.
      	(gfc_trans_deferred_vars): Likewise.
      	(getdecls): Likewise.
      	(gfc_get_array_descr_info): Likewise.
      	(gfc_omp_firstprivatize_type_sizes): Likewise.
      	(GTY): Likewise.
      
      gcc/go/ChangeLog:
      
      	* config-lang.in: Rename .c names to .cc.
      	* go-backend.cc: Likewise.
      	* go-lang.cc: Likewise.
      	* gospec.cc: Likewise.
      	* lang-specs.h: Likewise.
      
      gcc/jit/ChangeLog:
      
      	* config-lang.in: Rename .c names to .cc.
      	* docs/_build/texinfo/libgccjit.texi: Likewise.
      	* docs/internals/index.rst: Likewise.
      	* jit-builtins.cc (builtins_manager::make_builtin_function): Likewise.
      	* jit-playback.cc (fold_const_var): Likewise.
      	(playback::context::~context): Likewise.
      	(new_field): Likewise.
      	(new_bitfield): Likewise.
      	(new_compound_type): Likewise.
      	(playback::compound_type::set_fields): Likewise.
      	(global_set_init_rvalue): Likewise.
      	(load_blob_in_ctor): Likewise.
      	(new_global_initialized): Likewise.
      	(double>): Likewise.
      	(new_string_literal): Likewise.
      	(as_truth_value): Likewise.
      	(build_call): Likewise.
      	(playback::context::build_cast): Likewise.
      	(new_array_access): Likewise.
      	(new_field_access): Likewise.
      	(dereference): Likewise.
      	(postprocess): Likewise.
      	(add_jump): Likewise.
      	(add_switch): Likewise.
      	(build_goto_operands): Likewise.
      	(playback::context::read_dump_file): Likewise.
      	(init_types): Likewise.
      	* jit-recording.cc (recording::context::get_int_type): Likewise.
      	* jit-recording.h: Likewise.
      	* libgccjit.cc (compatible_types): Likewise.
      	(gcc_jit_context_acquire): Likewise.
      	(gcc_jit_context_release): Likewise.
      	(gcc_jit_context_new_child_context): Likewise.
      	(gcc_jit_type_as_object): Likewise.
      	(gcc_jit_context_get_type): Likewise.
      	(gcc_jit_context_get_int_type): Likewise.
      	(gcc_jit_type_get_pointer): Likewise.
      	(gcc_jit_type_get_const): Likewise.
      	(gcc_jit_type_get_volatile): Likewise.
      	(gcc_jit_type_dyncast_array): Likewise.
      	(gcc_jit_type_is_bool): Likewise.
      	(gcc_jit_type_is_pointer): Likewise.
      	(gcc_jit_type_is_integral): Likewise.
      	(gcc_jit_type_dyncast_vector): Likewise.
      	(gcc_jit_type_is_struct): Likewise.
      	(gcc_jit_vector_type_get_num_units): Likewise.
      	(gcc_jit_vector_type_get_element_type): Likewise.
      	(gcc_jit_type_unqualified): Likewise.
      	(gcc_jit_type_dyncast_function_ptr_type): Likewise.
      	(gcc_jit_function_type_get_return_type): Likewise.
      	(gcc_jit_function_type_get_param_count): Likewise.
      	(gcc_jit_function_type_get_param_type): Likewise.
      	(gcc_jit_context_new_array_type): Likewise.
      	(gcc_jit_context_new_field): Likewise.
      	(gcc_jit_field_as_object): Likewise.
      	(gcc_jit_context_new_struct_type): Likewise.
      	(gcc_jit_struct_as_type): Likewise.
      	(gcc_jit_struct_set_fields): Likewise.
      	(gcc_jit_struct_get_field_count): Likewise.
      	(gcc_jit_context_new_union_type): Likewise.
      	(gcc_jit_context_new_function_ptr_type): Likewise.
      	(gcc_jit_param_as_rvalue): Likewise.
      	(gcc_jit_context_new_function): Likewise.
      	(gcc_jit_function_get_return_type): Likewise.
      	(gcc_jit_function_dump_to_dot): Likewise.
      	(gcc_jit_block_get_function): Likewise.
      	(gcc_jit_global_set_initializer_rvalue): Likewise.
      	(gcc_jit_rvalue_get_type): Likewise.
      	(gcc_jit_context_new_rvalue_from_int): Likewise.
      	(gcc_jit_context_one): Likewise.
      	(gcc_jit_context_new_rvalue_from_double): Likewise.
      	(gcc_jit_context_null): Likewise.
      	(gcc_jit_context_new_string_literal): Likewise.
      	(valid_binary_op_p): Likewise.
      	(gcc_jit_context_new_binary_op): Likewise.
      	(gcc_jit_context_new_comparison): Likewise.
      	(gcc_jit_context_new_call): Likewise.
      	(is_valid_cast): Likewise.
      	(gcc_jit_context_new_cast): Likewise.
      	(gcc_jit_object_get_context): Likewise.
      	(gcc_jit_object_get_debug_string): Likewise.
      	(gcc_jit_lvalue_access_field): Likewise.
      	(gcc_jit_rvalue_access_field): Likewise.
      	(gcc_jit_rvalue_dereference_field): Likewise.
      	(gcc_jit_rvalue_dereference): Likewise.
      	(gcc_jit_lvalue_get_address): Likewise.
      	(gcc_jit_lvalue_set_tls_model): Likewise.
      	(gcc_jit_lvalue_set_link_section): Likewise.
      	(gcc_jit_function_new_local): Likewise.
      	(gcc_jit_block_add_eval): Likewise.
      	(gcc_jit_block_add_assignment): Likewise.
      	(is_bool): Likewise.
      	(gcc_jit_block_end_with_conditional): Likewise.
      	(gcc_jit_block_add_comment): Likewise.
      	(gcc_jit_block_end_with_jump): Likewise.
      	(gcc_jit_block_end_with_return): Likewise.
      	(gcc_jit_block_end_with_void_return): Likewise.
      	(case_range_validator::case_range_validator): Likewise.
      	(case_range_validator::validate): Likewise.
      	(case_range_validator::get_wide_int): Likewise.
      	(gcc_jit_block_end_with_switch): Likewise.
      	(gcc_jit_context_set_str_option): Likewise.
      	(gcc_jit_context_set_int_option): Likewise.
      	(gcc_jit_context_set_bool_option): Likewise.
      	(gcc_jit_context_set_bool_allow_unreachable_blocks): Likewise.
      	(gcc_jit_context_set_bool_use_external_driver): Likewise.
      	(gcc_jit_context_add_command_line_option): Likewise.
      	(gcc_jit_context_add_driver_option): Likewise.
      	(gcc_jit_context_enable_dump): Likewise.
      	(gcc_jit_context_compile): Likewise.
      	(gcc_jit_context_compile_to_file): Likewise.
      	(gcc_jit_context_set_logfile): Likewise.
      	(gcc_jit_context_dump_reproducer_to_file): Likewise.
      	(gcc_jit_context_get_first_error): Likewise.
      	(gcc_jit_context_get_last_error): Likewise.
      	(gcc_jit_result_get_code): Likewise.
      	(gcc_jit_result_get_global): Likewise.
      	(gcc_jit_rvalue_set_bool_require_tail_call): Likewise.
      	(gcc_jit_type_get_aligned): Likewise.
      	(gcc_jit_type_get_vector): Likewise.
      	(gcc_jit_function_get_address): Likewise.
      	(gcc_jit_version_patchlevel): Likewise.
      	(gcc_jit_block_add_extended_asm): Likewise.
      	(gcc_jit_extended_asm_as_object): Likewise.
      	(gcc_jit_extended_asm_set_volatile_flag): Likewise.
      	(gcc_jit_extended_asm_set_inline_flag): Likewise.
      	(gcc_jit_extended_asm_add_output_operand): Likewise.
      	(gcc_jit_extended_asm_add_input_operand): Likewise.
      	(gcc_jit_extended_asm_add_clobber): Likewise.
      	* notes.txt: Likewise.
      
      gcc/lto/ChangeLog:
      
      	* config-lang.in: Rename .c names to .cc.
      	* lang-specs.h: Likewise.
      	* lto-common.cc (gimple_register_canonical_type_1): Likewise.
      	* lto-common.h: Likewise.
      	* lto-dump.cc (lto_main): Likewise.
      	* lto-lang.cc (handle_fnspec_attribute): Likewise.
      	(lto_getdecls): Likewise.
      	(lto_init): Likewise.
      	* lto.cc (lto_main): Likewise.
      	* lto.h: Likewise.
      
      gcc/objc/ChangeLog:
      
      	* Make-lang.in: Rename .c names to .cc.
      	* config-lang.in: Likewise.
      	* lang-specs.h: Likewise.
      	* objc-act.cc (objc_build_component_ref): Likewise.
      	(objc_copy_binfo): Likewise.
      	(lookup_method_in_hash_lists): Likewise.
      	(objc_finish_foreach_loop): Likewise.
      	* objc-act.h (objc_common_init_ts): Likewise.
      	* objc-gnu-runtime-abi-01.cc: Likewise.
      	* objc-lang.cc (struct lang_hooks): Likewise.
      	* objc-map.cc: Likewise.
      	* objc-next-runtime-abi-01.cc (generate_objc_symtab_decl): Likewise.
      	* objc-runtime-shared-support.cc: Likewise.
      	* objc-runtime-shared-support.h (build_protocol_initializer): Likewise.
      
      gcc/objcp/ChangeLog:
      
      	* Make-lang.in: Rename .c names to .cc.
      	* config-lang.in: Likewise.
      	* lang-specs.h: Likewise.
      	* objcp-decl.cc (objcp_end_compound_stmt): Likewise.
      	* objcp-lang.cc (struct lang_hooks): Likewise.
      
      gcc/po/ChangeLog:
      
      	* EXCLUDES: Rename .c names to .cc.
      
      libcpp/ChangeLog:
      
      	* Makefile.in: Rename .c names to .cc.
      	* charset.cc (convert_escape): Likewise.
      	* directives.cc (directive_diagnostics): Likewise.
      	(_cpp_handle_directive): Likewise.
      	(lex_macro_node): Likewise.
      	* include/cpplib.h (struct _cpp_file): Likewise.
      	(PURE_ZERO): Likewise.
      	(cpp_defined): Likewise.
      	(cpp_error_at): Likewise.
      	(cpp_forall_identifiers): Likewise.
      	(cpp_compare_macros): Likewise.
      	(cpp_get_converted_source): Likewise.
      	(cpp_read_state): Likewise.
      	(cpp_directive_only_process): Likewise.
      	(struct cpp_decoded_char): Likewise.
      	* include/line-map.h (enum lc_reason): Likewise.
      	(enum location_aspect): Likewise.
      	* include/mkdeps.h: Likewise.
      	* init.cc (cpp_destroy): Likewise.
      	(cpp_finish): Likewise.
      	* internal.h (struct cpp_reader): Likewise.
      	(_cpp_defined_macro_p): Likewise.
      	(_cpp_backup_tokens_direct): Likewise.
      	(_cpp_destroy_hashtable): Likewise.
      	(_cpp_has_header): Likewise.
      	(_cpp_expand_op_stack): Likewise.
      	(_cpp_commit_buff): Likewise.
      	(_cpp_restore_special_builtin): Likewise.
      	(_cpp_bracket_include): Likewise.
      	(_cpp_replacement_text_len): Likewise.
      	(ufputs): Likewise.
      	* line-map.cc (linemap_macro_loc_to_exp_point): Likewise.
      	(linemap_check_files_exited): Likewise.
      	(line_map_new_raw): Likewise.
      	* traditional.cc (enum ls): Likewise.
      e53b6e56
  17. Jan 03, 2022
  18. Nov 22, 2021
    • Jakub Jelinek's avatar
      libcpp: Fix _Pragma stringification [PR103165] · a6e0d593
      Jakub Jelinek authored
      
      As the testcase show, sometimes _Pragma is turned into CPP_PRAGMA
      .. CPP_PRAGMA_EOL tokens, even when it might still need to be
      stringized later on.  We are then ICEing because we don't handle
      stringification of CPP_PRAGMA or CPP_PRAGMA_EOL, but trying to
      reconstruct the exact tokens with exact spacing after it has been
      lowered is very hard.  So, instead this patch ensures we don't
      lower _Pragma during expand_arg calls, but only later when
      cpp_get_token_1 is called outside of expand_arg.
      
      2021-11-22  Jakub Jelinek  <jakub@redhat.com>
      	    Tobias Burnus  <tobias@codesourcery.com>
      
      	PR preprocessor/103165
      libcpp/
      	* internal.h (struct lexer_state): Add ignore__Pragma field.
      	* macro.c (builtin_macro): Don't interpret _Pragma if
      	pfile->state.ignore__Pragma.
      	(expand_arg): Temporarily set pfile->state.ignore__Pragma to 1.
      gcc/testsuite/
      	* c-c++-common/gomp/pragma-3.c: New test.
      	* c-c++-common/gomp/pragma-4.c: New test.
      	* c-c++-common/gomp/pragma-5.c: New test.
      
      Co-Authored-By: default avatarTobias Burnus <tobias@codesourcery.com>
      a6e0d593
  19. Nov 17, 2021
    • Marek Polacek's avatar
      libcpp: Implement -Wbidi-chars for CVE-2021-42574 [PR103026] · 51c50026
      Marek Polacek authored
      From a link below:
      "An issue was discovered in the Bidirectional Algorithm in the Unicode
      Specification through 14.0. It permits the visual reordering of
      characters via control sequences, which can be used to craft source code
      that renders different logic than the logical ordering of tokens
      ingested by compilers and interpreters. Adversaries can leverage this to
      encode source code for compilers accepting Unicode such that targeted
      vulnerabilities are introduced invisibly to human reviewers."
      
      More info:
      https://nvd.nist.gov/vuln/detail/CVE-2021-42574
      https://trojansource.codes/
      
      This is not a compiler bug.  However, to mitigate the problem, this patch
      implements -Wbidi-chars=[none|unpaired|any] to warn about possibly
      misleading Unicode bidirectional control characters the preprocessor may
      encounter.
      
      The default is =unpaired, which warns about improperly terminated
      bidirectional control characters; e.g. a LRE without its corresponding PDF.
      The level =any warns about any use of bidirectional control characters.
      
      This patch handles both UCNs and UTF-8 characters.  UCNs designating
      bidi characters in identifiers are accepted since r204886.  Then r217144
      enabled -fextended-identifiers by default.  Extended characters in C/C++
      identifiers have been accepted since r275979.  However, this patch still
      warns about mixing UTF-8 and UCN bidi characters; there seems to be no
      good reason to allow mixing them.
      
      We warn in different contexts: comments (both C and C++-style), string
      literals, character constants, and identifiers.  Expectedly, UCNs are ignored
      in comments and raw string literals.  The bidirectional control characters
      can nest so this patch handles that as well.
      
      I have not included nor tested this at all with Fortran (which also has
      string literals and line comments).
      
      Dave M. posted patches improving diagnostic involving Unicode characters.
      This patch does not make use of this new infrastructure yet.
      
      	PR preprocessor/103026
      
      gcc/c-family/ChangeLog:
      
      	* c.opt (Wbidi-chars, Wbidi-chars=): New option.
      
      gcc/ChangeLog:
      
      	* doc/invoke.texi: Document -Wbidi-chars.
      
      libcpp/ChangeLog:
      
      	* include/cpplib.h (enum cpp_bidirectional_level): New.
      	(struct cpp_options): Add cpp_warn_bidirectional.
      	(enum cpp_warning_reason): Add CPP_W_BIDIRECTIONAL.
      	* internal.h (struct cpp_reader): Add warn_bidi_p member
      	function.
      	* init.c (cpp_create_reader): Set cpp_warn_bidirectional.
      	* lex.c (bidi): New namespace.
      	(get_bidi_utf8): New function.
      	(get_bidi_ucn): Likewise.
      	(maybe_warn_bidi_on_close): Likewise.
      	(maybe_warn_bidi_on_char): Likewise.
      	(_cpp_skip_block_comment): Implement warning about bidirectional
      	control characters.
      	(skip_line_comment): Likewise.
      	(forms_identifier_p): Likewise.
      	(lex_identifier): Likewise.
      	(lex_string): Likewise.
      	(lex_raw_string): Likewise.
      
      gcc/testsuite/ChangeLog:
      
      	* c-c++-common/Wbidi-chars-1.c: New test.
      	* c-c++-common/Wbidi-chars-2.c: New test.
      	* c-c++-common/Wbidi-chars-3.c: New test.
      	* c-c++-common/Wbidi-chars-4.c: New test.
      	* c-c++-common/Wbidi-chars-5.c: New test.
      	* c-c++-common/Wbidi-chars-6.c: New test.
      	* c-c++-common/Wbidi-chars-7.c: New test.
      	* c-c++-common/Wbidi-chars-8.c: New test.
      	* c-c++-common/Wbidi-chars-9.c: New test.
      	* c-c++-common/Wbidi-chars-10.c: New test.
      	* c-c++-common/Wbidi-chars-11.c: New test.
      	* c-c++-common/Wbidi-chars-12.c: New test.
      	* c-c++-common/Wbidi-chars-13.c: New test.
      	* c-c++-common/Wbidi-chars-14.c: New test.
      	* c-c++-common/Wbidi-chars-15.c: New test.
      	* c-c++-common/Wbidi-chars-16.c: New test.
      	* c-c++-common/Wbidi-chars-17.c: New test.
      51c50026
  20. Nov 01, 2021
    • David Malcolm's avatar
      diagnostics: escape non-ASCII source bytes for certain diagnostics · bd5e882c
      David Malcolm authored
      
      This patch adds support to GCC's diagnostic subsystem for escaping certain
      bytes and Unicode characters when quoting source code.
      
      Specifically, this patch adds a new flag rich_location::m_escape_on_output
      which is a hint from a diagnostic that non-ASCII bytes in the pertinent
      lines of the user's source code should be escaped when printed.
      
      The patch sets this for the following diagnostics:
      - when complaining about stray bytes in the program (when these
      are non-printable)
      - when complaining about "null character(s) ignored");
      - for -Wnormalized= (and generate source ranges for such warnings)
      
      The escaping is controlled by a new option:
        -fdiagnostics-escape-format=[unicode|bytes]
      
      For example, consider a diagnostic involing a source line containing the
      string "before" followed by the Unicode character U+03C0 ("GREEK SMALL
      LETTER PI", with UTF-8 encoding 0xCF 0x80) followed by the byte 0xBF
      (a stray UTF-8 trailing byte), followed by the string "after", where the
      diagnostic highlights the U+03C0 character.
      
      By default, this line will be printed verbatim to the user when
      reporting a diagnostic at it, as:
      
       beforeπXafter
             ^
      
      (using X for the stray byte to avoid putting invalid UTF-8 in this
      commit message)
      
      If the diagnostic sets the "escape" flag, it will be printed as:
      
       before<U+03C0><BF>after
             ^~~~~~~~
      
      with -fdiagnostics-escape-format=unicode (the default), or as:
      
        before<CF><80><BF>after
              ^~~~~~~~
      
      if the user supplies -fdiagnostics-escape-format=bytes.
      
      This only affects how the source is printed; it does not affect
      how column numbers that are printed (as per -fdiagnostics-column-unit=
      and -fdiagnostics-column-origin=).
      
      gcc/c-family/ChangeLog:
      	* c-lex.c (c_lex_with_flags): When complaining about non-printable
      	CPP_OTHER tokens, set the "escape on output" flag.
      
      gcc/ChangeLog:
      	* common.opt (fdiagnostics-escape-format=): New.
      	(diagnostics_escape_format): New enum.
      	(DIAGNOSTICS_ESCAPE_FORMAT_UNICODE): New enum value.
      	(DIAGNOSTICS_ESCAPE_FORMAT_BYTES): Likewise.
      	* diagnostic-format-json.cc (json_end_diagnostic): Add
      	"escape-source" attribute.
      	* diagnostic-show-locus.c
      	(exploc_with_display_col::exploc_with_display_col): Replace
      	"tabstop" param with a cpp_char_column_policy and add an "aspect"
      	param.  Use these to compute m_display_col accordingly.
      	(struct char_display_policy): New struct.
      	(layout::m_policy): New field.
      	(layout::m_escape_on_output): New field.
      	(def_policy): New function.
      	(make_range): Update for changes to exploc_with_display_col ctor.
      	(default_print_decoded_ch): New.
      	(width_per_escaped_byte): New.
      	(escape_as_bytes_width): New.
      	(escape_as_bytes_print): New.
      	(escape_as_unicode_width): New.
      	(escape_as_unicode_print): New.
      	(make_policy): New.
      	(layout::layout): Initialize new fields.  Update m_exploc ctor
      	call for above change to ctor.
      	(layout::maybe_add_location_range): Update for changes to
      	exploc_with_display_col ctor.
      	(layout::calculate_x_offset_display): Update for change to
      	cpp_display_width.
      	(layout::print_source_line): Pass policy
      	to cpp_display_width_computation. Capture cpp_decoded_char when
      	calling process_next_codepoint.  Move printing of source code to
      	m_policy.m_print_cb.
      	(line_label::line_label): Pass in policy rather than context.
      	(layout::print_any_labels): Update for change to line_label ctor.
      	(get_affected_range): Pass in policy rather than context, updating
      	calls to location_compute_display_column accordingly.
      	(get_printed_columns): Likewise, also for cpp_display_width.
      	(correction::correction): Pass in policy rather than tabstop.
      	(correction::compute_display_cols): Pass m_policy rather than
      	m_tabstop to cpp_display_width.
      	(correction::m_tabstop): Replace with...
      	(correction::m_policy): ...this.
      	(line_corrections::line_corrections): Pass in policy rather than
      	context.
      	(line_corrections::m_context): Replace with...
      	(line_corrections::m_policy): ...this.
      	(line_corrections::add_hint): Update to use m_policy rather than
      	m_context.
      	(line_corrections::add_hint): Likewise.
      	(layout::print_trailing_fixits): Likewise.
      	(selftest::test_display_widths): New.
      	(selftest::test_layout_x_offset_display_utf8): Update to use
      	policy rather than tabstop.
      	(selftest::test_one_liner_labels_utf8): Add test of escaping
      	source lines.
      	(selftest::test_diagnostic_show_locus_one_liner_utf8): Update to
      	use policy rather than tabstop.
      	(selftest::test_overlapped_fixit_printing): Likewise.
      	(selftest::test_overlapped_fixit_printing_utf8): Likewise.
      	(selftest::test_overlapped_fixit_printing_2): Likewise.
      	(selftest::test_tab_expansion): Likewise.
      	(selftest::test_escaping_bytes_1): New.
      	(selftest::test_escaping_bytes_2): New.
      	(selftest::diagnostic_show_locus_c_tests): Call the new tests.
      	* diagnostic.c (diagnostic_initialize): Initialize
      	context->escape_format.
      	(convert_column_unit): Update to use default character width policy.
      	(selftest::test_diagnostic_get_location_text): Likewise.
      	* diagnostic.h (enum diagnostics_escape_format): New enum.
      	(diagnostic_context::escape_format): New field.
      	* doc/invoke.texi (-fdiagnostics-escape-format=): New option.
      	(-fdiagnostics-format=): Add "escape-source" attribute to examples
      	of JSON output, and document it.
      	* input.c (location_compute_display_column): Pass in "policy"
      	rather than "tabstop", passing to
      	cpp_byte_column_to_display_column.
      	(selftest::test_cpp_utf8): Update to use cpp_char_column_policy.
      	* input.h (class cpp_char_column_policy): New forward decl.
      	(location_compute_display_column): Pass in "policy" rather than
      	"tabstop".
      	* opts.c (common_handle_option): Handle
      	OPT_fdiagnostics_escape_format_.
      	* selftest.c (temp_source_file::temp_source_file): New ctor
      	overload taking a size_t.
      	* selftest.h (temp_source_file::temp_source_file): Likewise.
      
      gcc/testsuite/ChangeLog:
      	* c-c++-common/diagnostic-format-json-1.c: Add regexp to consume
      	"escape-source" attribute.
      	* c-c++-common/diagnostic-format-json-2.c: Likewise.
      	* c-c++-common/diagnostic-format-json-3.c: Likewise.
      	* c-c++-common/diagnostic-format-json-4.c: Likewise, twice.
      	* c-c++-common/diagnostic-format-json-5.c: Likewise.
      	* gcc.dg/cpp/warn-normalized-4-bytes.c: New test.
      	* gcc.dg/cpp/warn-normalized-4-unicode.c: New test.
      	* gcc.dg/encoding-issues-bytes.c: New test.
      	* gcc.dg/encoding-issues-unicode.c: New test.
      	* gfortran.dg/diagnostic-format-json-1.F90: Add regexp to consume
      	"escape-source" attribute.
      	* gfortran.dg/diagnostic-format-json-2.F90: Likewise.
      	* gfortran.dg/diagnostic-format-json-3.F90: Likewise.
      
      libcpp/ChangeLog:
      	* charset.c (convert_escape): Use encoding_rich_location when
      	complaining about nonprintable unknown escape sequences.
      	(cpp_display_width_computation::::cpp_display_width_computation):
      	Pass in policy rather than tabstop.
      	(cpp_display_width_computation::process_next_codepoint): Add "out"
      	param and populate *out if non-NULL.
      	(cpp_display_width_computation::advance_display_cols): Pass NULL
      	to process_next_codepoint.
      	(cpp_byte_column_to_display_column): Pass in policy rather than
      	tabstop.  Pass NULL to process_next_codepoint.
      	(cpp_display_column_to_byte_column): Pass in policy rather than
      	tabstop.
      	* errors.c (cpp_diagnostic_get_current_location): New function,
      	splitting out the logic from...
      	(cpp_diagnostic): ...here.
      	(cpp_warning_at): New function.
      	(cpp_pedwarning_at): New function.
      	* include/cpplib.h (cpp_warning_at): New decl for rich_location.
      	(cpp_pedwarning_at): Likewise.
      	(struct cpp_decoded_char): New.
      	(struct cpp_char_column_policy): New.
      	(cpp_display_width_computation::cpp_display_width_computation):
      	Replace "tabstop" param with "policy".
      	(cpp_display_width_computation::process_next_codepoint): Add "out"
      	param.
      	(cpp_display_width_computation::m_tabstop): Replace with...
      	(cpp_display_width_computation::m_policy): ...this.
      	(cpp_byte_column_to_display_column): Replace "tabstop" param with
      	"policy".
      	(cpp_display_width): Likewise.
      	(cpp_display_column_to_byte_column): Likewise.
      	* include/line-map.h (rich_location::escape_on_output_p): New.
      	(rich_location::set_escape_on_output): New.
      	(rich_location::m_escape_on_output): New.
      	* internal.h (cpp_diagnostic_get_current_location): New decl.
      	(class encoding_rich_location): New.
      	* lex.c (skip_whitespace): Use encoding_rich_location when
      	complaining about null characters.
      	(warn_about_normalization): Generate a source range when
      	complaining about improperly normalized tokens, rather than just a
      	point, and use encoding_rich_location so that the source code
      	is escaped on printing.
      	* line-map.c (rich_location::rich_location): Initialize
      	m_escape_on_output.
      
      Signed-off-by: default avatarDavid Malcolm <dmalcolm@redhat.com>
      bd5e882c
  21. Feb 18, 2021
    • Nathan Sidwell's avatar
      c++: header-unit build capability [PR 99023] · 1f9db692
      Nathan Sidwell authored
      This defect really required building header-units and include translation
      of pieces of the standard library.  This adds smarts to the modules
      test harness to do that -- accept .X files as the source file, but
      provide '-x c++-system-header $HDR' in the options.  The .X file will
      be considered by the driver to be a linker script and ignored (with a
      warning).
      
      Using this we can add 2 tests that end up building list_initializer
      and iostream, along with a test that iostream's build
      include-translates list_initializer's #include.  That discovered a set
      of issues with the -flang-info-include-translate=HDR handling, also
      fixed and documented here.
      
      	PR c++/99023
      	gcc/cp/
      	* module.cc (canonicalize_header_name): Use
      	cpp_probe_header_unit.
      	(maybe_translate_include): Fix note_includes comparison.
      	(init_modules): Fix note_includes string termination.
      	libcpp/
      	* include/cpplib.h (cpp_find_header_unit): Rename to ...
      	(cpp_probe_header_unit): ... this.
      	* internal.h (_cp_find_header_unit): Declare.
      	* files.c (cpp_find_header_unit): Break apart to ..
      	(test_header_unit): ... this, and ...
      	(_cpp_find_header_unit): ... and, or and ...
      	(cpp_probe_header_unit): ... this.
      	* macro.c (cpp_get_token_1): Call _cpp_find_header_unit.
      	gcc/
      	* doc/invoke.texi (flang-info-include-translate): Document header
      	lookup behaviour.
      	gcc/testsuite/
      	* g++.dg/modules/modules.exp: Bail on cross-testing.  Add support
      	for .X files.
      	* g++.dg/modules/pr99023_a.X: New.
      	* g++.dg/modules/pr99023_b.X: New.
      1f9db692
  22. Jan 04, 2021
  23. Dec 01, 2020
    • JeanHeyd Meneide's avatar
      Feature: Macros for identifying the wide and narrow execution string literal encoding · eccec868
      JeanHeyd Meneide authored
      gcc/c-family
      	* c-cppbuiltin.c (c_cpp_builtins): Add predefined
      	{__GNUC_EXECUTION_CHARSET_NAME} and
      	_WIDE_EXECUTION_CHARSET_NAME} macros.
      
      gcc/
      	* doc/cpp.texi: Document new macros.
      
      gcc/testsuite/
      	* c-c++-common/cpp/wide-narrow-predef-macros.c: New test.
      
      libcpp/
      	* charset.c (init_iconv_desc): Initialize "to" and "from" fields.
      	* directives.c (cpp_get_narrow_charset_name): New function.
      	(cpp_get_wide_charset_name): Likewise.
      	* include/cpplib.h (cpp_get_narrow_charset_name): Prototype.
      	(cpp_get_wide_charset_name): Likewise.
      	* internal.h (cset_converter): Add "to" and "from" fields.
      eccec868
  24. Nov 24, 2020
    • Nathan Sidwell's avatar
      preprocessor: Add deferred macros · 13f93cf5
      Nathan Sidwell authored
      Deferred macros are needed for C++ modules.  Header units may export
      macro definitions and undefinitions.  These are resolved lazily at the
      point of (potential) use.  (The language specifies that, it's not just
      a useful optimization.)  Thus, identifier nodes grow a 'deferred'
      field, which fortunately doesn't expand the structure on 64-bit
      systems as there was padding there.  This is non-zero on NT_MACRO
      nodes, if the macro is deferred.  When such an identifier is lexed, it
      is resolved via a callback that I added recently.  That will either
      provide the macro definition, or discover it there was an overriding
      undef.  Either way the identifier is no longer a deferred macro.
      Notice it is now possible for NT_MACRO nodes to have a NULL macro
      expansion.
      
      	libcpp/
      	* include/cpplib.h (struct cpp_hashnode): Add deferred field.
      	(cpp_set_deferred_macro): Define.
      	(cpp_get_deferred_macro): Declare.
      	(cpp_macro_definition): Reformat, add overload.
      	(cpp_macro_definition_location): Deal with deferred macro.
      	(cpp_alloc_token_string, cpp_compare_macro): Declare.
      	* internal.h (_cpp_notify_macro_use): Return bool
      	(_cpp_maybe_notify_macro_use): Likewise.
      	* directives.c (do_undef): Check macro is not undef before
      	warning.
      	(do_ifdef, do_ifndef): Deal with deferred macro.
      	* expr.c (parse_defined): Likewise.
      	* lex.c (cpp_allocate_token_string): Break out of ...
      	(create_literal): ... here.  Call it.
      	(cpp_maybe_module_directive): Deal with deferred macro.
      	* macro.c (cpp_get_token_1): Deal with deferred macro.
      	(warn_of_redefinition): Deal with deferred macro.
      	(compare_macros): Rename to ...
      	(cpp_compare_macro): ... here.  Make extern.
      	(cpp_get_deferred_macro): New.
      	(_cpp_notify_macro_use): Deal with deferred macro, return bool
      	indicating definedness.
      	(cpp_macro_definition): Deal with deferred macro.
      13f93cf5
  25. Nov 19, 2020
    • Nathan Sidwell's avatar
      preprocessor: main file searching · 9844497a
      Nathan Sidwell authored
      This adds the capability to locate the main file on the user or system
      include paths.  That's extremely useful to users building header
      units.  Searching has to be requiested (plain header-unit compilation
      will not search).  Also, to make include_next work as expected when
      building a header unit, we add a mechanism to retrofit a non-searched
      source file as one on the include path.
      
      	libcpp/
      	* include/cpplib.h (enum cpp_main_search): New.
      	(struct cpp_options): Add main_search field.
      	(cpp_main_loc): Declare.
      	(cpp_retrofit_as_include): Declare.
      	* internal.h (struct cpp_reader): Add main_loc field.
      	(_cpp_in_main_source_file): Not main if main is a header.
      	* init.c (cpp_read_main_file): Use main_search option to locate
      	main file.  Set main_loc
      	* files.c (cpp_retrofit_as_include): New.
      9844497a
    • Nathan Sidwell's avatar
      preprocessor: main-file cleanup · bf425849
      Nathan Sidwell authored
      In preparing module patch 7 I realized there was a cleanup I could
      make to simplify it.  This is that cleanup.  Also, when doing the
      cleanup I noticed some macros had been turned into inline functions,
      but not renamed to the preprocessors internal namespace
      (_cpp_$INTERNAL rather than cpp_$USER).  Thus, this renames those
      functions, deletes an internal field of the file structure, and
      determines whether we're in the main file by comparing to
      pfile->main_file, the _cpp_file of the main file.
      
      	libcpp/
      	* internal.h (cpp_in_system_header): Rename to ...
      	(_cpp_in_system_header): ... here.
      	(cpp_in_primary_file): Rename to ...
      	(_cpp_in_main_source_file): ... here.  Compare main_file equality
      	and check main_search value.
      	* lex.c (maybe_va_opt_error, _cpp_lex_direct): Adjust for rename.
      	* macro.c (_cpp_builtin_macro_text): Likewise.
      	(replace_args): Likewise.
      	* directives.c (do_include_next): Likewise.
      	(do_pragma_once, do_pragma_system_header): Likewise.
      	* files.c (struct _cpp_file): Delete main_file field.
      	(pch_open): Check pfile->main_file equality.
      	(make_cpp_file): Drop cpp_reader parm, don't set main_file.
      	(_cpp_find_file): Adjust.
      	(_cpp_stack_file): Check pfile->main_file equality.
      	(struct report_missing_guard_data): Add cpp_reader field.
      	(report_missing_guard): Check pfile->main_file equality.
      	(_cpp_report_missing_guards): Adjust.
      bf425849
  26. Nov 18, 2020
    • Nathan Sidwell's avatar
      preprocessor: C++ module-directives · c9c3d5f2
      Nathan Sidwell authored
      C++20 modules introduces a new kind of preprocessor directive -- a
      module directive.  These are directives but without the leading '#'.
      We have to detect them by sniffing the start of a logical line.  When
      detected we replace the initial identifiers with unspellable tokens
      and pass them through to the language parser the same way deferred
      pragmas are.  There's a PRAGMA_EOL at the logical end of line too.
      
      One additional complication is that we have to do header-name lexing
      after the initial tokens, and that requires changes in the macro-aware
      piece of the preprocessor.  The above sniffer sets a counter in the
      lexer state, and that triggers at the appropriate point.  We then do
      the same header-name lexing that occurs on a #include directive or
      has_include pseudo-macro.  Except that the header name ends up in the
      token stream.
      
      A couple of token emitters need to deal with the new token possibility.
      
      	gcc/c-family/
      	* c-lex.c (c_lex_with_flags): CPP_HEADER_NAMEs can now be seen.
      	libcpp/
      	* include/cpplib.h (struct cpp_options): Add module_directives
      	option.
      	(NODE_MODULE): New node flag.
      	(struct cpp_hashnode): Make rid-code a bitfield, increase bits in
      	flags and swap with type field.
      	* init.c (post_options): Create module-directive identifier nodes.
      	* internal.h (struct lexer_state): Add directive_file_token &
      	n_modules fields.  Add module node enumerator.
      	* lex.c (cpp_maybe_module_directive): New.
      	(_cpp_lex_token): Call it.
      	(cpp_output_token): Add '"' around CPP_HEADER_NAME token.
      	(do_peek_ident, do_peek_module): New.
      	(cpp_directives_only): Detect module-directive lines.
      	* macro.c (cpp_get_token_1): Deal with directive_file_token
      	triggering.
      c9c3d5f2
  27. Nov 17, 2020
    • Nathan Sidwell's avatar
      preprocessor: module line maps · 1f8ac759
      Nathan Sidwell authored
      This patch adds LC_MODULE as a map kind, used to indicate a c++
      module.  Unlike a regular source file, it only contains a single
      location, and the source locations in that module are represented by
      ordinary locations whose 'included_from' location is the module.
      
      It also exposes some entry points that modules will use to create
      blocks of line maps.
      
      In the original posting, I'd missed the deletion of the
      linemap_enter_macro from internal.h.  That's included here.
      
      	libcpp/
      	* include/line-map.h (enum lc_reason): Add LC_MODULE.
      	(MAP_MODULE_P): New.
      	(line_map_new_raw): Declare.
      	(linemap_enter_macro): Move declaration from internal.h
      	(linemap_module_loc, linemap_module_reparent)
      	(linemap_module_restore): Declare.
      	(linemap_lookup_macro_indec): Declare.
      	* internal.h (linemap_enter_macro): Moved to line-map.h.
      	* line-map.c (linemap_new_raw): New, broken out of ...
      	(new_linemap): ... here.  Call it.
      	(LAST_SOURCE_LINE_LOCATION): New.
      	(liemap_module_loc, linemap_module_reparent)
      	(linemap_module_restore): New.
      	(linemap_lookup_macro_index): New, broken out of ...
      	(linemap_macro_map_lookup): ... here.  Call it.
      	(linemap_dump): Add module dump.
      1f8ac759
  28. Nov 06, 2020
    • Nathan Sidwell's avatar
      libcpp: Provide date routine · 4b5f564a
      Nathan Sidwell authored
      Joseph pointed me at cb_get_source_date_epoch, which allows repeatable
      builds and solves a FIXME I had on the modules branch.  Unfortunately
      it's used exclusively to generate __DATE__ and __TIME__ values, which
      fallback to using a time(2) call.  It'd be nicer if the preprocessor
      made whatever time value it determined available to the rest of the
      compiler.  So this patch adds a new cpp_get_date function, which
      abstracts the call to the get_source_date_epoch hook, or uses time
      directly.  The value is cached.  Thus the timestamp I end up putting
      on CMI files matches __DATE__ and __TIME__ expansions.  That seems
      worthwhile.
      
      	libcpp/
      	* include/cpplib.h (enum class CPP_time_kind): New.
      	(cpp_get_date): Declare.
      	* internal.h (struct cpp_reader): Replace source_date_epoch with
      	time_stamp and time_stamp_kind.
      	* init.c (cpp_create_reader): Initialize them.
      	* macro.c (_cpp_builtin_macro_text): Use cpp_get_date.
      	(cpp_get_date): Broken out from _cpp_builtin_macro_text and
      	genericized.
      4b5f564a
  29. Nov 02, 2020
    • Nathan Sidwell's avatar
      cpplib: Macro use location and comparison · e9a2e208
      Nathan Sidwell authored
      Our macro use hook passes a location, but doesn't recieve it from the
      using location.  This patch adds the extra location_t parameter and
      passes it though.
      
      A second cleanup is breaking out the macro comparison code from the
      redefinition warning.  That;ll turn out useful for modules.
      
      Finally, there's a filename comparison needed for the location
      optimization of rewinding from line 2 (occurs during the emission of
      builtin macros).
      
      	libcpp/
      	* internal.h (_cpp_notify_macro_use): Add location parm.
      	(_cpp_maybe_notify_macro_use): Likewise.
      	* directives.c (_cpp_do_file_change): Check we've not changed file
      	when optimizing a rewind.
      	(do_ifdef): Pass location to _cpp_maybe_notify_macro_use.
      	(do_ifndef): Likewise.  Delete obsolete comment about powerpc.
      	* expr.c (parse_defined): Pass location to
      	_cpp_maybe_notify_macro_use.
      	* macro.c (enter_macro_context): Likewise.
      	(warn_of_redefinition): Break out helper function.  Call it.
      	(compare_macros): New function broken out of warn_of_redefinition.
      	(_cpp_new_macro): Zero all fields.
      	(_cpp_notify_macro_use): Add location parameter.
      e9a2e208
  30. Oct 19, 2020
    • Nathan Sidwell's avatar
      preprocessor: Fix non-fn fn-like macro at EOF [PR97471] · 5abe05b4
      Nathan Sidwell authored
      We inject EOF tokens between macro argument lists, but had
      confused/stale logic in the non-fn invocation.  Renamed the magic
      'eof' token, as it's now only used for macro argument termination.
      Always rewind the non-OPEN_PAREN token.
      
      	libcpp/
      	* internal.h (struct cpp_reader): Rename 'eof' field to 'endarg'.
      	* init.c (cpp_create_reader): Adjust.
      	* macro.c (collect_args): Use endarg for separator.  Always rewind
      	in the not-fn case.
      	gcc/testsuite/
      	* c-c++-common/cpp/pr97471.c: New.
      5abe05b4
  31. Oct 08, 2020
    • Nathan Sidwell's avatar
      libcpp: Directly peek for initial line marker · d1c566d7
      Nathan Sidwell authored
      Using the tokenizer to sniff for an initial line marker for
      preprocessed input is a little brittle, particularly with
      -fdirectives-only.  If there is no marker we'll happily munch initial
      comments.  This patch directly sniffs the buffer.  This is safe
      because the initial line marker was machine generated and must be
      right at the beginning of the file.  Anything else is not such a line
      marker.  The same is true for the initial directory marker.  For that
      tokenizing the string is simplest, but at that point it's either a
      regular line marker or a directory marker.  If it's a regular marker,
      unwinding tokens is fine.
      
      	libcpp/
      	* internal.h (enum include_type): Rename IT_MAIN_INJECT to
      	IT_PRE_MAIN.
      	* init.c (cpp_read_main_file): If there is no line marker, adjust
      	the initial line marker.
      	(read_original_filename): Return bool, peek the buffer directly
      	before trying to tokenize.
      	(read_original_directory): Likewise.  Directly prod the string
      	literal.
      	* files.c (_cpp_stack_file): Adjust for IT_PRE_MAIN change.
      d1c566d7
  32. Jul 07, 2020
    • Nathan Sidwell's avatar
      preprocessor: Better line info for <builtin> & <command-line> · 6bf2ff0d
      Nathan Sidwell authored
      With C++ module header units it becomes important to distinguish
      between macros defined in forced headers (& commandline & builtins)
      from those defined in the header file being processed.  We weren't
      making that easy because we treated the builtins and command-line
      locations somewhat file-like, with incrementing line numbers, and
      showing them as included from line 1 of the main file.  This patch does
      3 things:
      
      0) extend the idiom that 'line 0' of a file means 'the file as a whole'
      
      1) builtins and command-line macros are shown as-if included from line zero.
      
      2) when emitting preprocessed output we keep resetting the line number
      so that re-reading that preprocessed output will get the same set of
      locations for the command line etc.
      
      For instance the new c-c++-common/cpp/line-2.c test, now emits
      
      In file included from <command-line>:
      ./line-2.h:4:2: error: #error wrong
          4 | #error wrong
            |  ^~~~~
      line-2.c:3:11: error: macro "bill" passed 1 arguments, but takes just 0
          3 | int bill(1);
            |           ^
      In file included from <command-line>:
      ./line-2.h:3: note: macro "bill" defined here
          3 | #define bill() 2
            |
      
      Before it told you about including from <command-line>:31.
      
      the preprocessed output looks like:
      ...
      
      (There's a new optimization in do_line_marker to stop each of these
      line markers causing a new line map.  We can simply rewind the
      location, and keep using the same line map.)
      
      	libcpp/
      	* directives.c (do_linemarker): Optimize rewinding to line zero.
      	* files.c (_cpp_stack_file): Start on line zero when about to inject
      	headers.
      	(cpp_push_include, cpp_push_default_include): Use highest_line as
      	the location.
      	* include/cpplib.h (cpp_read_main_file): Add injecting parm.
      	* init.c (cpp_read_main_file): Likewise, inform _cpp_stack_file.
      	* internal.h (enum include_type): Add IT_MAIN_INJECT.
      	gcc/c-family/
      	* c-opts.c (c_common_post_options): Add 'injecting' arg to
      	cpp_read_main_file.
      	(c_finish_options): Add linemap_line_start calls for builtin and cmd
      	maps.  Force token position to line_table's highest line.
      	* c-ppoutput.c (print_line_1): Refactor, print line zero.
      	(cb_define): Always increment source line.
      	gcc/testsuite/
      	* c-c++-common/cpp/line-2.c: New.
      	* c-c++-common/cpp/line-2.h: New.
      	* c-c++-common/cpp/line-3.c: New.
      	* c-c++-common/cpp/line-4.c: New.
      	* c-c++-common/cpp/line-4.h: New.
      6bf2ff0d
  33. May 20, 2020
    • Nathan Sidwell's avatar
      preprocessor: Replace some flags with a single enum · 4623a6f2
      Nathan Sidwell authored
      _cpp_find_file has 3 bool arguments, at most one of which is ever set.
      Ripe for replacing with a 4-state enum.  Also, this is C++, so
      'typedef struct Foo Foo' is unnecessary.
      
      	* internal.h (typedef _cpp_file): Delete, unnecessary in C++.
      	(enum _cpp_find_file_kind): New.
      	(_cpp_find_file): Use it, not 3 bools.
      	* files.c (_cpp_find_file): Use _cpp_find_file_kind enum, not
      	bools.
      	(cpp_make_system_header): Break overly long line.
      	(_cpp_stack_include, _cpp_fake_include)
      	(_cpp_do_file_change, _cpp_compare_file_date, _cpp_has_header): Adjust.
      	* init.c (cpp_read_main): Adjust _cpp_find_file call.
      4623a6f2
  34. May 19, 2020
    • Nathan Sidwell's avatar
      preprocessor: Random cleanups · 7cf3f604
      Nathan Sidwell authored
      This fixes a bunch of poorly formatted decls, marks some getters as
      PURE, deletes some C-relevant bool hackery, and finally uses a
      passed-in location rather than deducing a closely-related but not
      necessarily the same location.
      
      	* include/cpplib.h (cpp_get_otions, cpp_get_callbacks)
      	(cpp_get_deps): Mark as PURE.
      	* include/line-map.h (get_combined_adhoc_loc)
      	(get_location_from_adhoc_loc, get_pure_location): Reformat decls.
      	* internal.h (struct lexer_state): Clarify comment.
      	* system.h: Remove now-unneeded bool hackery.
      	* files.c (_cpp_find_file): Store LOC not highest_location.
      7cf3f604
  35. May 08, 2020
    • Nathan Sidwell's avatar
      preprocessor: Reimplement directives only processing, support raw literals. · b224c376
      Nathan Sidwell authored
      The existing directives-only code (a) punched a hole through the
      libcpp interface and (b) didn't support raw string literals.  This
      reimplements this preprocessing mode.  I added a proper callback
      interface, and adjusted c-ppoutput to use it.  Sadly I cannot get rid
      of the libcpp/internal.h include for unrelated reasons.
      
      The new scanner is in lex.x, and works doing some backwards scanning
      when it finds a charater of interest.  This reduces the number of
      cases one has to deal with in forward scanning.  It may have different
      failure mode than forward scanning on bad tokenization.
      
      Finally, Moved some cpp tests from the c-specific dg.gcc/cpp directory
      to the c-c++-common/cpp shared directory,
      
      	libcpp/
      	* directives-only.c: Delete.
      	* Makefile.in (libcpp_a_OBJS, libcpp_a_SOURCES): Remove it.
      	* include/cpplib.h (enum CPP_DO_task): New enum.
      	(cpp_directive_only_preprocess): Declare.
      	* internal.h (_cpp_dir_only_callbacks): Delete.
      	(_cpp_preprocess_dir_only): Delete.
      	* lex.c (do_peek_backslask, do_peek_next, do_peek_prev): New.
      	(cpp_directives_only_process): New implementation.
      
      	gcc/c-family/
      	Reimplement directives only processing.
      	* c-ppoutput.c (token_streamer): Ne.
      	(directives_only_cb): New.  Swallow ...
      	(print_lines_directives_only): ... this.
      	(scan_translation_unit_directives_only): Reimplment using the
      	published interface.
      
      	gcc/testsuite/
      	* gcc.dg/cpp/counter-[23].c: Move to c-c+_-common/cpp.
      	* gcc.dg/cpp/dir-only-*: Likewise.
      	* c-c++-common/cpp/dir-only-[78].c: New.
      b224c376
  36. Jan 28, 2020
    • Nathan Sidwell's avatar
      preprocessor: Make __has_include a builtin macro [PR93452] · 3d056cbf
      Nathan Sidwell authored
      The clever hack of '#define __has_include __has_include' breaks -dD
      and -fdirectives-only, because that emits definitions.  This turns
      __has_include into a proper builtin macro.  Thus it's never emitted
      via -dD, and because use outside of directive processing is undefined,
      we can just expand it anywhere.
      
      	PR preprocessor/93452
      	* internal.h (struct spec_nodes): Drop n__has_include{,_next}.
      	* directives.c (lex_macro_node): Don't check __has_include redef.
      	* expr.c (eval_token): Drop __has_include eval.
      	(parse_has_include): Move to ...
      	* macro.c (builtin_has_include): ... here.
      	(_cpp_builtin_macro_text): Eval __has_include{,_next}.
      	* include/cpplib.h (enum cpp_builtin_type): Add BT_HAS_INCLUDE{,_NEXT}.
      	* init.c (builtin_array): Add them.
      	(cpp_init_builtins): Drop __has_include{,_next} init here ...
      	* pch.c (cpp_read_state): ... and here.
      	* traditional.c (enum ls): Drop has_include states ...
      	(_cpp_scan_out_logical_line): ... and here.
      3d056cbf
  37. Jan 20, 2020
    • Nathan Sidwell's avatar
      [PR 80005] Fix __has_include · ad1a3914
      Nathan Sidwell authored
      __has_include is funky in that it is macro-like from the POV of #ifdef and
      friends, but lexes its parenthesize argument #include-like.  We were
      failing the second part of that, because we used a forwarding macro to an
      internal name, and hence always lexed the argument in macro-parameter
      context.  We componded that by not setting the right flag when lexing, so
      it didn't even know.  Mostly users got lucky.
      
      This reimplements the handline.
      1) Remove the forwarding, but declare object-like macros that
      expand to themselves.  This satisfies the #ifdef requirement
      
      2) Correctly set angled_brackets when lexing the parameter.  This tells
      the lexer (a) <...> is a header name and (b) "..." is too (not a string).
      
      3) Remove the in__has_include lexer state, just tell find_file that that's
      what's happenning, so it doesn't emit an error.
      
      We lose the (undocumented) ability to #undef __has_include.  That may well
      have been an accident of implementation.  There are no tests for it.
      
      We gain __has_include behaviour for all users of the preprocessors -- not
      just the C-family ones that defined a forwarding macro.
      
      	libcpp/
      	PR preprocessor/80005
      	* include/cpplib.h (BT_HAS_ATTRIBUTE): Fix comment.
      	* internal.h (struct lexer_state): Delete in__has_include field.
      	(struct spec_nodes): Rename n__has_include{,_next}__ fields.
      	(_cpp_defined_macro_p): New.
      	(_cpp_find_file): Add has_include parm.
      	* directives.c (lex_macro_node): Combine defined,
      	__has_inline{,_next} checking.
      	(do_ifdef, do_ifndef): Use _cpp_defined_macro_p.
      	(_cpp_init_directives): Refactor.
      	* expr.c (parse_defined): Use _cpp_defined_macro_p.
      	(eval_token): Adjust parse_has_include calls.
      	(parse_has_include): Add OP parameter.  Reimplement.
      	* files.c (_cpp_find_file): Add HAS_INCLUDE parm.  Use it to
      	inhibit error message.
      	(_cpp_stack_include): Adjust _cpp_find_file call.
      	(_cpp_fake_include, _cpp_compare_file_date): Likewise.
      	(open_file_failed): Remove in__has_include check.
      	(_cpp_has_header): Adjust _cpp_find_file call.
      	* identifiers.c (_cpp_init_hashtable): Don't init
      	__has_include{,_next} here ...
      	* init.c (cpp_init_builtins): ... init them here.  Define as
      	macros.
      	(cpp_read_main_file): Adjust _cpp_find_file call.
      	* pch.c (cpp_read_state): Adjust __has_include{,_next} access.
      	* traditional.c (_cpp_scan_out_locgical_line): Likewise.
      
      	gcc/c-family/
      	PR preprocessor/80005
      	* c-cppbuiltins.c (c_cpp_builtins): Don't define __has_include{,_next}.
      
      	gcc/testsuite/
      	PR preprocessor/80005
      	* g++.dg/cpp1y/feat-cxx14.C: Adjust.
      	* g++.dg/cpp1z/feat-cxx17.C: Adjust.
      	* g++.dg/cpp2a/feat-cxx2a.C: Adjust.
      	* g++.dg/cpp/pr80005.C: New.
      ad1a3914
Loading