Skip to content
Snippets Groups Projects
  1. Oct 28, 2022
    • Aldy Hernandez's avatar
      Change remaining flag_finite_math_only use in value-range.cc. · c6567d2c
      Aldy Hernandez authored
      gcc/ChangeLog:
      
      	* value-range.cc (range_tests_floats): Use HONOR_INFINITIES.
      c6567d2c
    • Kewen Lin's avatar
      testsuite: Adjust vect-bitfield-read-* with vect_shift and vect_long_long [PR107240] · 225f9c88
      Kewen Lin authored
      The test cases vect-bitfield-read-* requires vector shift
      target support, they need one explicit vect_shift effective
      target requirement checking.  Besides, the vectype for struct
      in test cases vect-bitfield-read-{2,4} is vector of long long,
      we need to check effective target vect_long_long for them.
      This patch can help to fix all remaining vect-bitfield-{read,
      write}-* test failures on powerpc.
      
      	PR testsuite/107240
      
      gcc/testsuite/ChangeLog:
      
      	* gcc.dg/vect/vect-bitfield-read-1.c: Add effective target checking
      	vect_shift.
      	* gcc.dg/vect/vect-bitfield-read-3.c: Likewise.
      	* gcc.dg/vect/vect-bitfield-read-5.c: Likewise.
      	* gcc.dg/vect/vect-bitfield-read-6.c: Likewise.
      	* gcc.dg/vect/vect-bitfield-read-7.c: Likewise.
      	* gcc.dg/vect/vect-bitfield-read-2.c: Add effective target checking
      	vect_shift and replace vect_int with vect_long_long.
      	* gcc.dg/vect/vect-bitfield-read-4.c: Likewise.
      225f9c88
    • Joseph Myers's avatar
      c: C2x enums with fixed underlying type [PR61469] · e0997c14
      Joseph Myers authored
      C2x adds support for enums with a fixed underlying type specified
      ("enum e : long long;" and similar).  Implement this in the C front
      end.  The same representation is used for these types as in C++, with
      two macros moved from cp-tree.h to c-common.h.
      
      Such enums can have bool as the underlying type, and various C
      front-end code checking for boolean types is adjusted to use a new
      C_BOOLEAN_TYPE_P to handle such enums the same way as bool.  (Note
      that for C++ we have bug 96496 that enums with underlying type bool
      don't work correctly there.)
      
      There are various issues with the wording for such enums in the
      current C2x working draft (including but not limited to wording in the
      accepted paper that failed to make it into the working draft), which I
      intend to raise in NB comments.  I think what I've implemented and
      added tests for matches the intent.
      
      Bootstrapped with no regressions for x86_64-pc-linux-gnu.
      
      	PR c/61469
      
      gcc/c-family/
      	* c-common.h (ENUM_UNDERLYING_TYPE, ENUM_FIXED_UNDERLYING_TYPE_P):
      	New.  Moved from cp/cp-tree.h.
      	* c-warn.cc (warnings_for_convert_and_check): Do not consider
      	conversions to enum with underlying type bool to overflow.
      
      gcc/c/
      	* c-convert.cc (c_convert): Handle enums with underlying boolean
      	type like bool.
      	* c-decl.cc (shadow_tag_warned): Allow shadowing declarations for
      	enums with enum type specifier, but give errors for storage class
      	specifiers, qualifiers or alignment specifiers in non-definition
      	declarations of such enums.
      	(grokdeclarator): Give error for non-definition use of type
      	specifier with an enum type specifier.
      	(parser_xref_tag): Add argument has_enum_type_specifier.  Pass it
      	to lookup_tag and use it to set ENUM_FIXED_UNDERLYING_TYPE_P.
      	(xref_tag): Update call to parser_xref_tag.
      	(start_enum): Add argument fixed_underlying_type.  Complete enum
      	type with a fixed underlying type given in the definition.  Give
      	error for defining without a fixed underlying type in the
      	definition if one was given in a prior declaration.  Do not mark
      	enums with fixed underlying type as packed for -fshort-enums.
      	Store the enum type in the_enum.
      	(finish_enum): Do not adjust types of values or check their range
      	for an enum with a fixed underlying type.  Set underlying type of
      	enum and variants.
      	(build_enumerator): Check enumeration constants for enum with
      	fixed underlying type against that type and convert to that type.
      	Increment in the underlying integer type, with handling for bool.
      	(c_simulate_enum_decl): Update call to start_enum.
      	(declspecs_add_type): Set specs->enum_type_specifier_ref_p.
      	* c-objc-common.cc (c_get_alias_set): Use ENUM_UNDERLYING_TYPE
      	rather than recomputing an underlying type based on size.
      	* c-parser.cc (c_parser_declspecs)
      	(c_parser_struct_or_union_specifier, c_parser_typeof_specifier):
      	Set has_enum_type_specifier for type specifiers.
      	(c_parser_enum_specifier): Handle enum type specifiers.
      	(c_parser_struct_or_union_specifier): Update call to
      	parser_xref_tag.
      	(c_parser_omp_atomic): Check for boolean increment or decrement
      	using C_BOOLEAN_TYPE_P.
      	* c-tree.h (C_BOOLEAN_TYPE_P): New.
      	(struct c_typespec): Add has_enum_type_specifier.
      	(struct c_declspecs): Add enum_type_specifier_ref_p.
      	(struct c_enum_contents): Add enum_type.
      	(start_enum, parser_xref_tag): Update prototypes.
      	* c-typeck.cc (composite_type): Allow for enumerated types
      	compatible with bool.
      	(common_type, comptypes_internal, perform_integral_promotions):
      	Use ENUM_UNDERLYING_TYPE.
      	(parser_build_binary_op, build_unary_op, convert_for_assignment)
      	(c_finish_return, c_start_switch, build_binary_op): Check for
      	boolean types using C_BOOLEAN_TYPE_P.
      
      gcc/cp/
      	* cp-tree.h (ENUM_FIXED_UNDERLYING_TYPE_P, ENUM_UNDERLYING_TYPE):
      	Remove.  Moved to c-common.h.
      
      gcc/testsuite/
      	* gcc.dg/c11-enum-4.c, gcc.dg/c11-enum-5.c, gcc.dg/c11-enum-6.c,
      	gcc.dg/c2x-enum-6.c, gcc.dg/c2x-enum-7.c, gcc.dg/c2x-enum-8.c,
      	gcc.dg/gnu2x-enum-1.c: New tests.
      e0997c14
    • GCC Administrator's avatar
      Daily bump. · 96069d84
      GCC Administrator authored
      96069d84
    • Ian Lance Taylor's avatar
      runtime: use _libgo_off_t_type when calling C mmap · 0a2984dd
      Ian Lance Taylor authored
      The last argument to the C mmap function is type off_t, not uintptr.
      On some 32-bit systems, off_t is larger than uintptr.
      
      Based on patch by Sören Tempel.
      
      Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/445735
      0a2984dd
  2. Oct 27, 2022
    • Eric Botcazou's avatar
      Aarch64: Do not define DONT_USE_BUILTIN_SETJMP · fc01cfa9
      Eric Botcazou authored
      The setting looks obsolete at this point.
      
      gcc/
      	* config/aarch64/aarch64.h (DONT_USE_BUILTIN_SETJMP): Delete.
      fc01cfa9
    • H.J. Lu's avatar
      x86: Replace ne:CCC/ne:CCO with UNSPEC_CC_NE in neg patterns · 0e36a9c6
      H.J. Lu authored
      In i386.md, neg patterns which set MODE_CC register like
      
      (set (reg:CCC FLAGS_REG)
           (ne:CCC (match_operand:SWI48 1 "general_reg_operand") (const_int 0)))
      
      can lead to errors when operand 1 is a constant value.  If FLAGS_REG in
      
      (set (reg:CCC FLAGS_REG)
           (ne:CCC (const_int 2) (const_int 0)))
      
      is set to 1, RTX simplifiers may simplify
      
      (set (reg:SI 93)
           (neg:SI (ltu:SI (reg:CCC 17 flags) (const_int 0 [0]))))
      
      as
      
      (set (reg:SI 93)
           (neg:SI (ltu:SI (const_int 1) (const_int 0 [0]))))
      
      which leads to incorrect results since LTU on MODE_CC register isn't the
      same as "unsigned less than" in x86 backend.  To prevent RTL optimizers
      from setting MODE_CC register to a constant, use UNSPEC_CC_NE to replace
      ne:CCC/ne:CCO when setting FLAGS_REG in neg patterns.
      
      gcc/
      
      	PR target/107172
      	* config/i386/i386.md (UNSPEC_CC_NE): New.
      	Replace ne:CCC/ne:CCO with UNSPEC_CC_NE in neg patterns.
      
      gcc/testsuite/
      
      	PR target/107172
      	* gcc.target/i386/pr107172.c: New test.
      0e36a9c6
    • Andrew Pinski's avatar
      Use simple_dce_from_worklist with match_simplify_replacement. · 1c2b53ce
      Andrew Pinski authored
      This is a simple patch to do some DCE after a successful
      match and simplify replacement in PHI-OPT. match and simplify
      likes to generate some extra statements which should be cleaned
      up.
      
      OK? Bootstrapped and tested on x86_64-linux with no regressions.
      
      Thanks,
      Andrew Pinski
      
      gcc/ChangeLog:
      
      	* tree-ssa-phiopt.cc: Include tree-ssa-dce.h
      	(replace_phi_edge_with_variable):
      	New argument, dce_ssa_names. Call simple_dce_from_worklist.
      	(match_simplify_replacement): If we inserted a sequence,
      	mark the lhs of the new sequence to be possible dce.
      	Always move the statement and mark the lhs (if it is a name)
      	as possible to remove.
      1c2b53ce
    • Jakub Jelinek's avatar
      c++: Fix ICE on g++.dg/modules/adl-3_c.C [PR107379] · a33d623d
      Jakub Jelinek authored
      As mentioned in the PR, apparently my r13-2887 P1467R9 changes
      regressed these tests on powerpc64le-linux with IEEE quad by default.
      
      I believe my changes just uncovered a latent bug.
      The problem is that push_namespace calls find_namespace_slot,
      which does:
        tree *slot = DECL_NAMESPACE_BINDINGS (ns)
          ->find_slot_with_hash (name, name ? IDENTIFIER_HASH_VALUE (name) : 0,
                                 create_p ? INSERT : NO_INSERT);
      In the <identifier_node 0x7fffe9f55ac0 details> ns case, slot is non-NULL
      above with a binding_vector in it.
      Then pushdecl is called and this does:
                        slot = find_namespace_slot (ns, name, ns == current_namespace);
      where ns == current_namespace (ns is :: and name is details) is true.
      So this again calls
                tree *slot = DECL_NAMESPACE_BINDINGS (ns)
                  ->find_slot_with_hash (name, name ? IDENTIFIER_HASH_VALUE (name) : 0,
                                         create_p ? INSERT : NO_INSERT);
      but this time with create_p and so INSERT.
      At this point we reach
                if (insert == INSERT && m_size * 3 <= m_n_elements * 4)
                  expand ();
      and when we are unlucky and the occupancy of the hash table just reached 3/4,
      expand () is called and the hash table is reallocated.  But when that happens,
      it means the slot pointer in the pushdecl caller (push_namespace) points to
      freed memory and so any accesses to it in make_namespace_finish will be UB.
      
      The following patch fixes it by calling find_namespace_slot again even if it
      was non-NULL, just doesn't assert it is *slot == ns in that case (because
      it often is not).
      
      2022-10-27  Jakub Jelinek  <jakub@redhat.com>
      
      	PR c++/107379
      	* name-lookup.cc (push_namespace): Call find_namespace_slot again
      	after pushdecl as the hash table might be expanded during pushdecl.
      a33d623d
    • Nathan Sidwell's avatar
      c++: Templated lambda mangling · f7d1d777
      Nathan Sidwell authored
      (Explicitly) Templated lambdas have a different signature to
      implicitly templated lambdas -- '[]<template T> (T) {}' is not the
      same as '[](auto) {}'.  This should be reflected in the mangling.  The
      ABI captures this as
      https://github.com/itanium-cxx-abi/cxx-abi/issues/31, and clang has
      implemented such additions.
      
      It's relatively straight forwards to write out the non-synthetic
      template parms, and note if we need to issue an ABI warning.
      
      	gcc/cp/
      	* mangle.cc (write_closure_template_head): New.
      	(write_closure_type_name): Call it.
      	gcc/testsuite/
      	* g++.dg/abi/lambda-ctx1-18.C: Adjust.
      	* g++.dg/abi/lambda-ctx1-18vs17.C: Adjust.
      	* g++.dg/abi/lambda-tpl1-17.C: New.
      	* g++.dg/abi/lambda-tpl1-18.C: New.
      	* g++.dg/abi/lambda-tpl1-18vs17.C: New.
      	* g++.dg/abi/lambda-tpl1.h: New.
      f7d1d777
    • Richard Sandiford's avatar
      aarch64: Reinstate some uses of CONSTEXPR · f95d3d5d
      Richard Sandiford authored
      In 9482a5e4 I'd replaced uses
      of CONSTEXPR with direct uses of constexpr.  However, it turns
      out that we still have CONSTEXPR for a reason: GCC 4.8 doesn't
      implement constexpr properly, and for example rejects things like:
      
        extern const int x;
        constexpr int x = 1;
      
      This patch partially reverts the previous one.  To make things
      more complicated, there are still some things that need to be
      constexpr rather than CONSTEXPR, since they are used to initialise
      scalar constants.  The patch therefore doesn't change anything
      in aarch64-feature-deps.h.
      
      gcc/
      	* config/aarch64/aarch64-protos.h: Replace constexpr with
      	CONSTEXPR.
      	* config/aarch64/aarch64-sve-builtins-base.cc: Likewise.
      	* config/aarch64/aarch64-sve-builtins-functions.h: Likewise.
      	* config/aarch64/aarch64-sve-builtins-shapes.cc: Likewise.
      	* config/aarch64/aarch64-sve-builtins-sve2.cc: Likewise.
      	* config/aarch64/aarch64-sve-builtins.cc: Likewise.
      	* config/aarch64/aarch64.cc: Likewise.
      	* config/aarch64/driver-aarch64.cc: Likewise
      f95d3d5d
    • Aldy Hernandez's avatar
      [PR tree-optimization/107394] Canonicalize global franges as they are read back. · 2b1fb720
      Aldy Hernandez authored
      The problem here is that we're inlining a global range with NANs into
      a function that has been tagged with __attribute__((optimize
      ("-ffinite-math-only"))).  As the global range is copied from
      SSA_NAME_RANGE_INFO, its NAN bits are copied, which then cause
      frange::verify_range() to fail a sanity check making sure no NANs
      creep in when !HONOR_NANS.
      
      I think what we should do is nuke the NAN bits as we're restoring the
      global range.  For that matter, if we use the frange constructor,
      everything except that NAN sign will be done automatically, including
      dropping INFs to the min/max representable range when appropriate.
      
      	PR tree-optimization/107394
      
      gcc/ChangeLog:
      
      	* value-range-storage.cc (frange_storage_slot::get_frange): Use
      	frange constructor.
      
      gcc/testsuite/ChangeLog:
      
      	* gcc.dg/tree-ssa/pr107394.c: New test.
      2b1fb720
    • Thomas Schwinge's avatar
      options: Clarify 'Init' option property usage for streaming optimization · 9119431b
      Thomas Schwinge authored
      This clarifies commit 95db7e9a
      "options, lto: Optimize streaming of optimization nodes".
      
      No functional change; no change in generated files.
      
      	gcc/
      	* optc-save-gen.awk: Clarify 'Init' option property usage for
      	streaming optimization.
      9119431b
    • Martin Liska's avatar
      lto: do not load LTO stream for aliases [PR107418] · be6c7554
      Martin Liska authored
      	PR lto/107418
      
      gcc/lto/ChangeLog:
      
      	* lto-dump.cc (lto_main): Do not load LTO stream for aliases.
      be6c7554
    • Jakub Jelinek's avatar
      c++: Fix excess precision related ICE on invalid binop [PR107382, PR107383] · bfb7994a
      Jakub Jelinek authored
      The following tests ICE in the gcc_assert (common); in cp_build_binary_op.
      I've missed that while for * common is set always, while for +, - and /
      it is in some cases not.
      If it is not, then
        if (!result_type
            && arithmetic_types_p
            && (shorten || common || short_compare))
      condition is false, then the following
        if (may_need_excess_precision
            && (orig_type0 != type0 || orig_type1 != type1)
            && build_type == NULL_TREE)
      would fail the assertion there and if there wouldn't be excess precision,
        if (code == SPACESHIP_EXPR)
      would be false (for SPACESHIP_EXPR we always have build_type set like for
      other comparisons) and then trigger
        if (!result_type)
          {
            if (complain & tf_error)
              {
                binary_op_rich_location richloc (location,
                                                 orig_op0, orig_op1, true);
                error_at (&richloc,
                          "invalid operands of types %qT and %qT to binary %qO",
                          TREE_TYPE (orig_op0), TREE_TYPE (orig_op1), code);
              }
            return error_mark_node;
          }
      So, if result_type is NULL, we don't really need to compute
      semantic_result_type because nothing will use it anyway and can get
      fall through into the error/return error_mark_node; case.
      
      2022-10-27  Jakub Jelinek  <jakub@redhat.com>
      
      	PR c++/107382
      	PR c++/107383
      	* typeck.cc (cp_build_binary_op): Don't compute semantic_result_type
      	if result_type is NULL.
      
      	* g++.dg/diagnostic/bad-binary-ops2.C: New test.
      bfb7994a
    • Torbjörn SVENSSON's avatar
      IRA: Make sure array is big enough · 4e1d7042
      Torbjörn SVENSSON authored
      
      In commit 081c9662, the call to resize_reg_info() was moved before
      the call to remove_scratches() and the latter one can increase the
      number of regs and that would cause an out of bounds usage on the
      reg_renumber global array.
      
      Without this patch, the following testcase randomly fails with:
      during RTL pass: ira
      In file included from /src/gcc/testsuite/gcc.dg/compat/struct-by-value-5b_y.c:13:
      /src/gcc/testsuite/gcc.dg/compat/struct-by-value-5b_y.c: In function 'checkgSf13':
      /src/gcc/testsuite/gcc.dg/compat/fp-struct-test-by-value-y.h:28:1: internal compiler error: Segmentation fault
      /src/gcc/testsuite/gcc.dg/compat/struct-by-value-5b_y.c:22:1: note: in expansion of macro 'TEST'
      
      gcc/ChangeLog:
      
      	* ira.cc: Resize array after reg number increased.
      
      Co-Authored-By: default avatarYvan ROUX <yvan.roux@foss.st.com>
      Signed-off-by: default avatarTorbjörn SVENSSON <torbjorn.svensson@foss.st.com>
      4e1d7042
    • Jiawei's avatar
      RISC-V: Add zhinx/zhinxmin testcases. · 27065374
      Jiawei authored
      Test zhinx/zhinxmin support, same like with zfh/zfhmin testcases
      but use gprs and don't use fmv instruction.
      
      gcc/testsuite/ChangeLog:
      
      	* gcc.target/riscv/_Float16-zhinx-1.c: New test.
      	* gcc.target/riscv/_Float16-zhinx-2.c: New test.
      	* gcc.target/riscv/_Float16-zhinx-3.c: New test.
      	* gcc.target/riscv/_Float16-zhinxmin-1.c: New test.
      	* gcc.target/riscv/_Float16-zhinxmin-2.c: New test.
      	* gcc.target/riscv/_Float16-zhinxmin-3.c: New test.
      27065374
    • Jiawei's avatar
      RISC-V: Limit regs use for z*inx extension. · 6b252dc9
      Jiawei authored
      
      Limit z*inx abi support with 'ilp32','ilp32e','lp64' only.
      Use GPR instead FPR when 'zfinx' enable, Only use even registers
      in RV32 when 'zdinx' enable.
      Enable FLOAT16 when Zhinx/Zhinxmin enabled.
      
      Co-Authored-By: default avatarSinan Lin <sinan@isrc.iscas.ac.cn>
      
      gcc/ChangeLog:
      
      	* config/riscv/constraints.md (TARGET_ZFINX ? GR_REGS): Set GPRS
      	use while Zfinx is enable.
      	* config/riscv/riscv.cc (riscv_hard_regno_mode_ok): Limit odd
      	registers use when Zdinx enable in RV32 cases.
      	(riscv_option_override): New target enable MASK_FDIV.
      	(riscv_libgcc_floating_mode_supported_p): New error info when
      	use incompatible arch&abi.
      	(riscv_excess_precision): New target enable FLOAT16.
      6b252dc9
    • Jiawei's avatar
      RISC-V: Target support for z*inx extension. · ac96e906
      Jiawei authored
      Support 'TARGET_ZFINX' with float instruction pattern and builtin function.
      Reuse 'TARGET_HADR_FLOAT',  'TARGET_DOUBLE_FLOAT' and 'TARGET_ZHINX' patterns.
      
      gcc/ChangeLog:
      
      	* config/riscv/iterators.md (TARGET_ZFINX):New target.
      	(TARGET_ZDINX): Ditto.
      	(TARGET_ZHINX): Ditto.
      	* config/riscv/riscv-builtins.cc (AVAIL): Ditto.
      	(riscv_atomic_assign_expand_fenv): Ditto.
      	* config/riscv/riscv-c.cc (riscv_cpu_cpp_builtins): Ditto.
      	* config/riscv/riscv.md: Ditto.
      ac96e906
    • Jiawei's avatar
      RISC-V: Minimal support of z*inx extension. · e0933572
      Jiawei authored
      
      Minimal support of z*inx extension, include 'zfinx', 'zdinx' and 'zhinx/zhinxmin'
      corresponding to 'f', 'd' and 'zfh/zfhmin', the 'zdinx' will imply 'zfinx'
      same as 'd' imply 'f', 'zhinx' will aslo imply 'zfinx', all zfinx extension imply 'zicsr'.
      
      Co-Authored-By: default avatarSinan Lin <sinan@isrc.iscas.ac.cn>
      
      gcc/ChangeLog:
      
      	* common/config/riscv/riscv-common.cc: New extensions.
      	* config/riscv/arch-canonicalize: New imply relations.
      	* config/riscv/riscv-opts.h (MASK_ZFINX): New mask.
      	(MASK_ZDINX): Ditto.
      	(MASK_ZHINX): Ditto.
      	(MASK_ZHINXMIN): Ditto.
      	(TARGET_ZFINX): New target.
      	(TARGET_ZDINX): Ditto.
      	(TARGET_ZHINX): Ditto.
      	(TARGET_ZHINXMIN): Ditto.
      	* config/riscv/riscv.opt: New target variable.
      e0933572
    • GCC Administrator's avatar
      Daily bump. · 486a5037
      GCC Administrator authored
      486a5037
  3. Oct 26, 2022
    • David Malcolm's avatar
      analyzer: fixes to file-descriptor handling · 57bbf3a4
      David Malcolm authored
      
      gcc/analyzer/ChangeLog:
      	* sm-fd.cc (fd_state_machine::on_open): Transition to "unchecked"
      	when the mode is symbolic, rather than just on integer constants.
      	(fd_state_machine::check_for_open_fd): Don't complain about
      	unchecked values in the start state.
      
      gcc/testsuite/ChangeLog:
      	* gcc.dg/analyzer/fd-3.c (test_5): Expect "opened here" message
      	even when flags are symbolic.
      	(test_read_from_symbolic_fd): New.
      	(test_write_to_symbolic_fd): New.
      
      Signed-off-by: default avatarDavid Malcolm <dmalcolm@redhat.com>
      57bbf3a4
    • David Malcolm's avatar
      analyzer: add sm-fd.dot · 593254ae
      David Malcolm authored
      
      Add a .dot file to document the file descriptor state machine.
      
      gcc/analyzer/ChangeLog:
      	* sm-fd.dot: New file.
      
      Signed-off-by: default avatarDavid Malcolm <dmalcolm@redhat.com>
      593254ae
    • Harald Anlauf's avatar
      Fortran: BOZ literal constants are not compatible to any type [PR103413] · f7d28818
      Harald Anlauf authored
      gcc/fortran/ChangeLog:
      
      	PR fortran/103413
      	* symbol.cc (gfc_type_compatible): A boz-literal-constant has no type
      	and thus is not considered compatible to any type.
      
      gcc/testsuite/ChangeLog:
      
      	PR fortran/103413
      	* gfortran.dg/illegal_boz_arg_4.f90: New test.
      f7d28818
    • David Faust's avatar
      bpf: add preserve_field_info builtin · 068baae1
      David Faust authored
      Add BPF __builtin_preserve_field_info. This builtin is used to extract
      information to facilitate struct and union relocations performed by the
      BPF loader, especially for bitfields.
      
      The builtin has the following signature:
      
        unsigned int __builtin_preserve_field_info (EXPR, unsigned int KIND);
      
      Where EXPR is an expression accessing a field of a struct or union.
      Depending on KIND, different information is returned to the program. The
      supported values for KIND are as follows:
      
        enum {
          FIELD_BYTE_OFFSET = 0,
          FIELD_BYTE_SIZE,
          FIELD_EXISTENCE,
          FIELD_SIGNEDNESS,
          FIELD_LSHIFT_U64,
          FIELD_RSHIFT_U64
        };
      
      If -mco-re is in effect (explicitly or implicitly specified), a CO-RE
      relocation is added for the access in EXPR recording the relevant
      information according to KIND.
      
      gcc/
      
      	* config/bpf/bpf.cc: Support __builtin_preserve_field_info.
      	(enum bpf_builtins): Add new builtin.
      	(bpf_init_builtins): Likewise.
      	(bpf_core_field_info): New function.
      	(bpf_expand_builtin): Accomodate new builtin. Refactor adding new
      	relocation to...
      	(maybe_make_core_relo): ... here. New function.
      	(bpf_resolve_overloaded_builtin): Accomodate new builtin.
      	(bpf_core_newdecl): Likewise.
      	(bpf_core_walk): Likewise.
      	(bpf_core_is_maybe_aggregate_access): Improve logic.
      	(struct core_walk_data): New.
      	* config/bpf/coreout.cc (bpf_core_reloc_add): Allow adding different
      	relocation kinds.
      	* config/bpf/coreout.h: Analogous change.
      	* doc/extend.texi: Document BPF __builtin_preserve_field_info.
      
      gcc/testsuite/
      
      	* gcc.target/bpf/core-builtin-fieldinfo-errors-1.c: New test.
      	* gcc.target/bpf/core-builtin-fieldinfo-errors-2.c: New test.
      	* gcc.target/bpf/core-builtin-fieldinfo-existence-1.c: New test.
      	* gcc.target/bpf/core-builtin-fieldinfo-lshift-1-be.c: New test.
      	* gcc.target/bpf/core-builtin-fieldinfo-lshift-1-le.c: New test.
      	* gcc.target/bpf/core-builtin-fieldinfo-lshift-2.c: New test.
      	* gcc.target/bpf/core-builtin-fieldinfo-offset-1.c: New test.
      	* gcc.target/bpf/core-builtin-fieldinfo-rshift-1.c: New test.
      	* gcc.target/bpf/core-builtin-fieldinfo-rshift-2.c: New test.
      	* gcc.target/bpf/core-builtin-fieldinfo-sign-1.c: New test.
      	* gcc.target/bpf/core-builtin-fieldinfo-sign-2.c: New test.
      	* gcc.target/bpf/core-builtin-fieldinfo-size-1.c: New test.
      068baae1
    • Marek Polacek's avatar
      c++: Implement -Wdangling-reference [PR106393] · d2249cd9
      Marek Polacek authored
      This patch implements a new experimental warning (enabled by -Wall) to
      detect references bound to temporaries whose lifetime has ended.  The
      primary motivation is the Note in
      <https://en.cppreference.com/w/cpp/algorithm/max>:
      
        Capturing the result of std::max by reference produces a dangling reference
        if one of the parameters is a temporary and that parameter is returned:
      
        int n = 1;
        const int& r = std::max(n-1, n+1); // r is dangling
      
      That's because both temporaries for n-1 and n+1 are destroyed at the end
      of the full expression.  With this warning enabled, you'll get:
      
      g.C:3:12: warning: possibly dangling reference to a temporary [-Wdangling-reference]
          3 | const int& r = std::max(n-1, n+1);
            |            ^
      g.C:3:24: note: the temporary was destroyed at the end of the full expression 'std::max<int>((n - 1), (n + 1))'
          3 | const int& r = std::max(n-1, n+1);
            |                ~~~~~~~~^~~~~~~~~~
      
      The warning works by checking if a reference is initialized with a function
      that returns a reference, and at least one parameter of the function is
      a reference that is bound to a temporary.  It assumes that such a function
      actually returns one of its arguments!  (I added code to check_return_expr
      to suppress the warning when we've seen the definition of the function
      and we can say that it can return a variable with static storage
      duration.)
      
      It warns when the function in question is a member function, but only if
      the function is invoked on a temporary object, otherwise the warning
      would emit loads of warnings for valid code like obj.emplace<T>({0}, 0).
      It does detect the dangling reference in:
      
        struct S {
          const S& self () { return *this; }
        };
        const S& s = S().self();
      
      It warns in member initializer lists as well:
      
        const int& f(const int& i) { return i; }
        struct S {
          const int &r;
          S() : r(f(10)) { }
        };
      
      I've run the testsuite/bootstrap with the warning enabled by default.
      There were just a few FAILs, all of which look like genuine bugs.
      A bootstrap with the warning enabled by default passed as well.
      
      When testing a previous version of the patch, there were many FAILs in
      libstdc++'s 22_locale/; all of them because the warning triggered on
      
        const test_type& obj = std::use_facet<test_type>(std::locale());
      
      but this code looks valid -- std::use_facet doesn't return a reference
      to its parameter.  Therefore I added a #pragma and code to suppress the
      warning.
      
      	PR c++/106393
      
      gcc/c-family/ChangeLog:
      
      	* c.opt (Wdangling-reference): New.
      
      gcc/cp/ChangeLog:
      
      	* call.cc (expr_represents_temporary_p): New, factored out of...
      	(conv_binds_ref_to_temporary): ...here.  Don't return false just
      	because a ck_base is missing.  Use expr_represents_temporary_p.
      	(do_warn_dangling_reference): New.
      	(maybe_warn_dangling_reference): New.
      	(extend_ref_init_temps): Call maybe_warn_dangling_reference.
      	* cp-tree.h: Adjust comment.
      	* typeck.cc (check_return_expr): Suppress -Wdangling-reference
      	warnings.
      
      gcc/ChangeLog:
      
      	* doc/invoke.texi: Document -Wdangling-reference.
      
      libstdc++-v3/ChangeLog:
      
      	* include/bits/locale_classes.tcc: Add #pragma to disable
      	-Wdangling-reference with std::use_facet.
      
      gcc/testsuite/ChangeLog:
      
      	* g++.dg/cpp23/elision4.C: Use -Wdangling-reference, add dg-warning.
      	* g++.dg/cpp23/elision7.C: Likewise.
      	* g++.dg/warn/Wdangling-pointer-2.C: Use -Wno-dangling-reference.
      	* g++.dg/warn/Wdangling-reference1.C: New test.
      	* g++.dg/warn/Wdangling-reference2.C: New test.
      	* g++.dg/warn/Wdangling-reference3.C: New test.
      d2249cd9
    • Takayuki 'January June' Suwa's avatar
      xtensa: Fix out-of-bounds array access in the movdi pattern · f896c134
      Takayuki 'January June' Suwa authored
      The following new warnings were introduced in the commit
      4f3f0296 ("xtensa: Prepare the transition from Reload to LRA"):
      
      gcc/config/xtensa/xtensa.md:945:26: error: array subscript 3 is above
      	array bounds of 'rtx_def* [2]' [-Werror=array-bounds]
        945 |           emit_move_insn (operands[2], operands[3]);
      gcc/config/xtensa/xtensa.md:945:26: error: array subscript 2 is above
      	array bounds of 'rtx_def* [2]' [-Werror=array-bounds]
        945 |           emit_move_insn (operands[2], operands[3]);
      
      From gcc/insn-emit.cc (generated by building):
      
      > /* ../../gcc/config/xtensa/xtensa.md:932 */
      > rtx
      > gen_movdi (rtx operand0,
      > 	rtx operand1)
      > {
      >   rtx_insn *_val = 0;
      >   start_sequence ();
      >   {
      >     rtx operands[2];					// only 2 elements
      >     operands[0] = operand0;
      >     operands[1] = operand1;
      > #define FAIL return (end_sequence (), _val)
      > #define DONE return (_val = get_insns (), end_sequence (), _val)
      > #line 936 "../../gcc/config/xtensa/xtensa.md"
      > {
      >   if (CONSTANT_P (operands[1]))
      >     {
      >       /* Split in halves if 64-bit Const-to-Reg moves
      > 	 because of offering further optimization opportunities.  */
      >       if (register_operand (operands[0], DImode))
      > 	{
      > 	  xtensa_split_DI_reg_imm (operands);		// out-of-bounds!
      > 	  emit_move_insn (operands[0], operands[1]);
      > 	  emit_move_insn (operands[2], operands[3]);	// out-of-bounds!
      > 	  DONE;
      > 	}
      
      gcc/ChangeLog:
      
      	* config/xtensa/xtensa.md (movdi):
      	Copy operands[0...1] to ops[0...3] and then use the latter before
      	calling xtensa_split_DI_reg_imm() and emitting insns.
      f896c134
    • Alexander Monakov's avatar
      ipa-visibility: remove assert in TLS optimization [PR107353] · 82e629c2
      Alexander Monakov authored
      When upgrading TLS access model based on optimized symbol visibility
      status, we attempted to assert that recomputing the model would not
      weaken it. It turns out that C, C++, and Fortran front-ends all can
      (unintentionally) assign a stronger model than what can be derived
      from the declaration.
      
      Let's act conservatively instead of asserting, at least as long as
      such pre-existing issues remain.
      
      gcc/ChangeLog:
      
      	PR other/107353
      	* ipa-visibility.cc (function_and_variable_visibility):
      	Conditionally upgrade TLS model instead of asserting.
      82e629c2
    • Andrew MacLeod's avatar
      Check if varying may also be non-negative. · a87819b8
      Andrew MacLeod authored
      When using strict enums, we can sometimes turn varying into a better
      range.
      
      	* gimple-range-fold.cc (fold_using_range::fold_stmt): Check if
      	stmt is non-negative and adjust the range.
      a87819b8
    • Martin Liska's avatar
      i386: add reset_cpu_feature · d80b7744
      Martin Liska authored
      gcc/ChangeLog:
      
      	* common/config/i386/cpuinfo.h (has_cpu_feature): Add comment.
      	(reset_cpu_feature): New.
      	(get_zhaoxin_cpu): Use reset_cpu_feature.
      d80b7744
    • Ju-Zhe Zhong's avatar
      RISC-V: Fix epilogue generation for barrier. · 4329d111
      Ju-Zhe Zhong authored
       I noticed that I have made a mistake in previous patch:
       https://patchwork.sourceware.org/project/gcc/patch/20220817071950.271762-1-juzhe.zhong@rivai.ai/
      
       The previous statement before this patch:
       bool need_barrier_p = (get_frame_size () + cfun->machine->frame.arg_pointer_offset) != 0;
      
       However, I changed it in the previous patch:
       bool need_barrier_p = known_ne (get_frame_size (), cfun->machine->frame.arg_pointer_offset);
       This is incorrect.
      
       Now, I correct this statement in this patch.
      
      gcc/ChangeLog:
      
      	* config/riscv/riscv.cc (riscv_expand_epilogue): Fix statement.
      4329d111
    • Ju-Zhe Zhong's avatar
      RISC-V: ADJUST_NUNITS according to -march. · 7e924ba3
      Ju-Zhe Zhong authored
      This patch fixed PR107357: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107357
      
      gcc/ChangeLog:
      
      	PR target/107357
      	* config/riscv/riscv-modes.def (VECTOR_BOOL_MODE): Set to minimum size.
      	(ADJUST_NUNITS): Adjust according to -march.
      	(ADJUST_BYTESIZE): Ditto.
      	* config/riscv/riscv-protos.h (riscv_v_ext_enabled_vector_mode_p):
      	Remove.
      	(riscv_v_ext_vector_mode_p): Change function implementation.
      	* config/riscv/riscv-vector-builtins.cc (rvv_switcher::rvv_switcher):
      	Change to riscv_v_ext_vector_mode_p.
      	(register_builtin_type): Ditto.
      	* config/riscv/riscv.cc (riscv_v_ext_vector_mode_p): Change to enabled
      	modes.
      	(ENTRY): Ditto.
      	(riscv_v_ext_enabled_vector_mode_p): Remove.
      	(riscv_v_adjust_nunits): New function.
      	(riscv_vector_mode_supported_p): Use riscv_v_ext_vector_mode_p instead.
      	* config/riscv/riscv.h (riscv_v_adjust_nunits): New function.
      7e924ba3
    • Ju-Zhe Zhong's avatar
      RISC-V: Support load/store in mov<mode> pattern for RVV modes. · f556cd8b
      Ju-Zhe Zhong authored
      gcc/ChangeLog:
      
      	* config.gcc (riscv*): Add riscv-v.o to extra_objs.
      	* config/riscv/constraints.md (vu): New constraint.
      	(vi): Ditto.
      	(Wc0): Ditto.
      	(Wc1): Ditto.
      	* config/riscv/predicates.md (vector_length_operand): New.
      	(reg_or_mem_operand): Ditto.
      	(vector_move_operand): Ditto.
      	(vector_mask_operand): Ditto.
      	(vector_merge_operand): Ditto.
      	* config/riscv/riscv-protos.h (riscv_regmode_natural_size) New.
      	(riscv_vector::const_vec_all_same_in_range_p): Ditto.
      	(riscv_vector::legitimize_move): Ditto.
      	(tail_policy): Ditto.
      	(mask_policy): Ditto.
      	* config/riscv/riscv-v.cc: New.
      	* config/riscv/riscv-vector-builtins-bases.cc
      	(vsetvl::expand): Refactor how LMUL encoding.
      	* config/riscv/riscv.cc (riscv_print_operand): Update how LMUL
      	print and mask operand print.
      	(riscv_regmode_natural_size): New.
      	* config/riscv/riscv.h (REGMODE_NATURAL_SIZE): New.
      	* config/riscv/riscv.md (mode): Add vector modes.
      	* config/riscv/t-riscv (riscv-v.o) New.
      	* config/riscv/vector-iterators.md: New.
      	* config/riscv/vector.md (vundefined<mode>): New.
      	(mov<mode>): New.
      	(*mov<mode>): New.
      	(@vsetvl<mode>_no_side_effects): New.
      	(@pred_mov<mode>): New.
      
      gcc/testsuite/ChangeLog:
      	* gcc.target/riscv/rvv/base/mov-1.c: New.
      	* gcc.target/riscv/rvv/base/mov-10.c: New.
      	* gcc.target/riscv/rvv/base/mov-11.c: New.
      	* gcc.target/riscv/rvv/base/mov-12.c: New.
      	* gcc.target/riscv/rvv/base/mov-13.c: New.
      	* gcc.target/riscv/rvv/base/mov-2.c: New.
      	* gcc.target/riscv/rvv/base/mov-3.c: New.
      	* gcc.target/riscv/rvv/base/mov-4.c: New.
      	* gcc.target/riscv/rvv/base/mov-5.c: New.
      	* gcc.target/riscv/rvv/base/mov-6.c: New.
      	* gcc.target/riscv/rvv/base/mov-7.c: New.
      	* gcc.target/riscv/rvv/base/mov-8.c: New.
      	* gcc.target/riscv/rvv/base/mov-9.c: New.
      f556cd8b
    • Monk Chiang's avatar
      RISC-V: Recognized Svinval and Svnapot extensions · 86654b2c
      Monk Chiang authored
      gcc/ChangeLog:
      
      	* common/config/riscv/riscv-common.cc (riscv_ext_version_table):
      	Add svinval and svnapot extension.
      	(riscv_ext_flag_table): Ditto.
      	* config/riscv/riscv-opts.h (MASK_SVINVAL): New.
      	(MASK_SVNAPOT): Ditto.
      	(TARGET_SVINVAL): Ditto.
      	(TARGET_SVNAPOT): Ditto.
      	* config/riscv/riscv.opt (riscv_sv_subext): New.
      
      gcc/testsuite/ChangeLog:
      	* gcc.target/riscv/predef-24.c:New.
      	* gcc.target/riscv/predef-25.c:New.
      86654b2c
    • Ju-Zhe Zhong's avatar
      RISC-V: Adjust table indentation in commnet for riscv-modes.def · 0ef04aa8
      Ju-Zhe Zhong authored
      gcc/ChangeLog:
      
      	* config/riscv/riscv-modes.def: Adjust table indentation in commnet.
      0ef04aa8
    • Martin Liska's avatar
      gcc/configure: regenerate · ba2030b0
      Martin Liska authored
      gcc/ChangeLog:
      
      	* configure: Regenerate.
      ba2030b0
    • Aldy Hernandez's avatar
      Convert flag_finite_math_only uses in frange to HONOR_*. · 82866f43
      Aldy Hernandez authored
      As mentioned earlier, we should be using HONOR_* on types rather than
      flag_finite_math_only.
      
      gcc/ChangeLog:
      
      	* value-range.cc (frange::set): Use HONOR_*.
      	(frange::verify_range): Same.
      	* value-range.h (frange_val_min): Same.
      	(frange_val_max): Same.
      82866f43
    • Jiufu Guo's avatar
      rs6000: cannot_force_const_mem for HIGH code rtx[PR106460] · 978ec482
      Jiufu Guo authored
      As the issue in PR106460, a rtx 'high:DI (symbol_ref:DI ("var_48")' is tried
      to store into constant pool and ICE occur.  But actually, this rtx represents
      partial incomplete address and can not be put into a .rodata section.
      
      This patch updates rs6000_cannot_force_const_mem to return true for rtx(s) with
      HIGH code, because these rtx(s) indicate part of address and are not ok for
      constant pool.
      
      Below are some examples:
      (high:DI (const:DI (plus:DI (symbol_ref:DI ("xx") (const_int 12 [0xc])))))
      (high:DI (symbol_ref:DI ("var_1")..)))
      
      	PR target/106460
      
      gcc/ChangeLog:
      
      	* config/rs6000/rs6000.cc (rs6000_cannot_force_const_mem): Return true
      	for HIGH code rtx.
      
      gcc/testsuite/ChangeLog:
      
      	* gcc.target/powerpc/pr106460.c: New test.
      978ec482
    • Kito Cheng's avatar
      RISC-V: Add h extension support · 0cd11d30
      Kito Cheng authored
      `h` was the prefix of multi-letter extension name, but it become a
      extension in later RISC-V isa spec.
      
      Fortunately we don't have any extension really defined is prefixed
      with `h`, so we can just change that.
      
      gcc/ChangeLog:
      
      	* common/config/riscv/riscv-common.cc (riscv_ext_version_table):
      	Add `h`.
      	(riscv_supported_std_ext): Ditto.
      	(multi_letter_subset_rank): Remove `h`.
      	(riscv_subset_list::parse_std_ext): Handle `h` as single letter
      	extension.
      	(riscv_subset_list::parse): Ditto.
      
      gcc/testsuite/ChangeLog:
      
      	* gcc.target/riscv/arch-18.c: New.
      	* gcc.target/riscv/arch-5.c: Remove test for prefixed
      	with `h`.
      	* gcc.target/riscv/predef-23.c: New.
      0cd11d30
    • Eugene Rozenfeld's avatar
      Don't force DWARF4 for AutoFDO tests · a9f339d8
      Eugene Rozenfeld authored
      Support for DWARF5 was added to create_gcov in
      https://github.com/google/autofdo so we no longer need
      to force DWARF4 for AutoFDO tests.
      
      Tested on x86_64-pc-linux-gnu.
      
      gcc/testsuite/ChangeLog:
      	* lib/profopt.exp: Don't force DWARF4 for AutoFDO tests
      a9f339d8
Loading